com.wallstop-studios.dxmessaging 1.0.4 → 1.0.6

package/README.md

@@ -11,10 +11,10 @@ Game engine agnostic robust, synchronous pub/sub C# messaging solution, mostly g
 4. Resolve the latest `DxMessaging`
 
 # Dependencies
-This project has a dependency on my [`Unity Helpers`](https://github.com/wallstop/unity-helpers) project, which contains the System.Runtime.CompilerServices.Unsafe.dll, which is used for some speed hacks in DxMessaging directly. Unity Helpers bundles a few (small) dependencies, including protobuf. If you don't want these dependencies, or if they conflict in some way, you can either include a copy of the System.Runtime.CompilerServices.Unsafe.dll yourself without relying on UnityHelpers, or manually download and include the Unity Helpers project and delete anything that conflicts with your project.
+This project has a dependency on my [`Unity Helpers`](https://github.com/wallstop/unity-helpers) project, which contains the `System.Runtime.CompilerServices.Unsafe.dll`, which is used for some speed hacks in DxMessaging directly. Unity Helpers bundles a few (small) dependencies, including protobuf. If you don't want these dependencies, or if they conflict in some way, you can either include a copy of the `System.Runtime.CompilerServices.Unsafe.dll` yourself without relying on UnityHelpers, or manually download and include the Unity Helpers project and delete anything that conflicts with your project. Or, manually download this project without UnityHelpers. The choice is yours.
 
 # Benchmarks
-DxMessaging is currently a bit slower (2-4x) than Unity's built in messaging solution (when running in Unity). [Source](./Tests/Runtime/Core/PerformanceTests.cs).
+DxMessaging is currently a bit slower (2-3x) than Unity's built in messaging solution (when running in Unity). [Source](./Tests/Runtime/Benchmarks/PerformanceTests.cs).
 | Message Tech | Operations / Second |
 | ------------ | ------------------- |
 | Unity | 1,908,539 |

package/Runtime/Unity/MessagingComponent.cs

@@ -4,12 +4,17 @@
     using System;
     using System.Collections.Generic;
     using UnityEngine;
-    
+
     [DisallowMultipleComponent]
     public sealed class MessagingComponent : MonoBehaviour
     {
+        [SerializeField]
+        private bool _emitMessagesWhenDisabled;
+
         private MessageHandler _messageHandler;
-        private readonly Dictionary<MonoBehaviour, MessageRegistrationToken> _registeredListeners = new Dictionary<MonoBehaviour, MessageRegistrationToken>();
+
+        private readonly Dictionary<MonoBehaviour, MessageRegistrationToken> _registeredListeners =
+            new Dictionary<MonoBehaviour, MessageRegistrationToken>();
 
         public MessageRegistrationToken Create(MonoBehaviour listener)
         {
@@ -20,9 +25,7 @@
 
             if (gameObject.GetInstanceID() != listener.gameObject.GetInstanceID())
             {
-                throw new ArgumentException(string.Format(
-                    "Cannot create a RegistrationToken without an valid owner. {0}.",
-                    listener.gameObject.GetInstanceID()));
+                throw new ArgumentException($"Cannot create a RegistrationToken without an valid owner. {listener.gameObject.GetInstanceID()}.");
             }
 
             if (_registeredListeners.TryGetValue(listener, out MessageRegistrationToken createdToken))
@@ -37,14 +40,17 @@
                 {
                     active = true
                 };
-                MessagingDebug.Log(LogLevel.Debug, "Creating MessageHandler for componentType {0}, GameObject name: {1}, InstanceId: {2}.",
-                    listener.GetType(), listener.gameObject.name, (InstanceId) gameObject);
+                MessagingDebug.Log(
+                    LogLevel.Debug,
+                    "Creating MessageHandler for componentType {0}, GameObject name: {1}, InstanceId: {2}.",
+                    listener.GetType(), listener.gameObject.name, (InstanceId)gameObject);
             }
             else
             {
-                MessagingDebug.Log(LogLevel.Debug,
+                MessagingDebug.Log(
+                    LogLevel.Debug,
                     "Using existing MessageHandler for componentType {0}, GameObject name: {1}, InstanceId: {2}.",
-                    listener.GetType(), listener.gameObject.name, (InstanceId) gameObject);
+                    listener.GetType(), listener.gameObject.name, (InstanceId)gameObject);
             }
 
             createdToken = MessageRegistrationToken.Create(_messageHandler);
@@ -64,10 +70,15 @@
 
         private void ToggleMessageHandler(bool newActive)
         {
+            if (!newActive && _emitMessagesWhenDisabled)
+            {
+                return;
+            }
+
             if (_messageHandler != null && _messageHandler.active != newActive)
             {
                 _messageHandler.active = newActive;
             }
         }
     }
-}
+}

package/package.json

@@ -1,11 +1,11 @@
 {
   "name": "com.wallstop-studios.dxmessaging",
-  "version": "1.0.4",
+  "version": "1.0.6",
   "displayName": "DxMessaging",
   "description": "Synchronous Event Bus for Unity",
   "unity": "2021.1",
   "dependencies": {
-    "com.wallstop-studios.unity-helpers" : "1.0.0-rc6"
+    "com.wallstop-studios.unity-helpers" : "1.0.1-rc13"
   },
   "keywords": [
     "messaging",

package/Tests/Editor/WallstopStudios.DxMessaging.Tests.Editor.asmdef

@@ -1,23 +0,0 @@
-{
-    "name": "WallstopStudios.DxMessaging.Tests.Editor",
-    "rootNamespace": "DxMessaging.Tests.Editor",
-    "references": [
-        "UnityEngine.TestRunner",
-        "UnityEditor.TestRunner"
-    ],
-    "includePlatforms": [
-        "Editor"
-    ],
-    "excludePlatforms": [],
-    "allowUnsafeCode": false,
-    "overrideReferences": true,
-    "precompiledReferences": [
-        "nunit.framework.dll"
-    ],
-    "autoReferenced": false,
-    "defineConstraints": [
-        "UNITY_INCLUDE_TESTS"
-    ],
-    "versionDefines": [],
-    "noEngineReferences": false
-}

package/Tests/Editor/WallstopStudios.DxMessaging.Tests.Editor.asmdef.meta

@@ -1,7 +0,0 @@
-fileFormatVersion: 2
-guid: c646054334573af4a95dfd389817700c
-AssemblyDefinitionImporter:
-  externalObjects: {}
-  userData: 
-  assetBundleName: 
-  assetBundleVariant: