com.elestrago.unity.package-tools 2.2.1 → 2.2.3

package/CAHNGELOG.md

@@ -2,6 +2,22 @@
 
 ---
 
+## [2.2.3](https://gitlab.com/elestrago-pkg/package-tool/-/tags/2.2.3)
+
+### Fixed
+
+- Fixed `unity-package-docs` scanner missing namespaces and types in C# files that start with a UTF-8 BOM.
+
+---
+
+## [2.2.2](https://gitlab.com/elestrago-pkg/package-tool/-/tags/2.2.2)
+
+### Changed
+
+- Simplified the `Claude Skills` post-import hook to rely on self-deletion for deduplication, removing the `SessionState` guards so a re-import within the same Unity session runs again instead of being silently skipped.
+
+---
+
 ## [2.2.1](https://gitlab.com/elestrago-pkg/package-tool/-/tags/2.2.1)
 
 ### Added

package/Samples~/ClaudeSkills/Editor/ClaudeSkillsPostImport.cs

@@ -7,10 +7,12 @@ using UnityEngine;
 namespace PackageTool.Samples.ClaudeSkills
 {
 	/// <summary>
-	/// Runs once after the "Claude Skills" sample is imported into a consumer project. Walks every
-	/// skill subfolder next to this script, copies it to <c>&lt;project&gt;/.claude/skills/&lt;name&gt;</c>,
-	/// prompting before overwriting an existing skill, and then deletes the imported sample folder so
-	/// the operation does not repeat on subsequent domain reloads.
+	/// Runs after the "Claude Skills" sample is imported into a consumer project. Walks every skill
+	/// subfolder next to this script, copies it to <c>&lt;project&gt;/.claude/skills/&lt;name&gt;</c>,
+	/// prompting before overwriting an existing skill, then deletes the imported sample folder
+	/// (including this script itself). Self-deletion is the only dedup mechanism: once gone the type
+	/// can't trigger again until the consumer re-imports the sample, which is exactly when a fresh
+	/// run is wanted.
 	/// </summary>
 	[InitializeOnLoad]
 	internal static class ClaudeSkillsPostImport
@@ -20,8 +22,6 @@ namespace PackageTool.Samples.ClaudeSkills
 		private const string EDITOR_FOLDER_NAME = "Editor";
 		private const string SCRIPT_FILE_NAME = "ClaudeSkillsPostImport.cs";
 		private const string DIALOG_TITLE = "Claude Skills";
-		private const string SESSION_GUARD_KEY_PREFIX = "PackageTool.ClaudeSkillsPostImport.Processed:";
-		private const string SESSION_RUNNING_KEY = "PackageTool.ClaudeSkillsPostImport.Running";
 
 		static ClaudeSkillsPostImport()
 		{
@@ -30,27 +30,15 @@ namespace PackageTool.Samples.ClaudeSkills
 
 		private static void Run()
 		{
-			// Re-entrancy guard. Multiple copies of this type (e.g. in side-by-side sample imports
-			// each shipping their own assembly) would each schedule a delayCall; without this guard
-			// they would race on the same sample folders and double-prompt the user.
-			if (SessionState.GetBool(SESSION_RUNNING_KEY, false))
-				return;
-			SessionState.SetBool(SESSION_RUNNING_KEY, true);
-
 			try
 			{
 				foreach (var sampleRootAssetPath in FindSampleRootAssetPaths())
 				{
-					// Only run from an imported sample location; never act on the source folder
-					// inside a package author's project.
+					// Only act on imported sample locations; never touch the source folder inside a
+					// package author's project.
 					if (!sampleRootAssetPath.StartsWith("Assets/Samples/", StringComparison.Ordinal))
 						continue;
 
-					var guardKey = SESSION_GUARD_KEY_PREFIX + sampleRootAssetPath;
-					if (SessionState.GetBool(guardKey, false))
-						continue;
-					SessionState.SetBool(guardKey, true);
-
 					ProcessSample(sampleRootAssetPath);
 				}
 			}
@@ -58,10 +46,6 @@ namespace PackageTool.Samples.ClaudeSkills
 			{
 				Debug.LogErrorFormat("{0} Post-import failed: {1}", LOG_PREFIX, e);
 			}
-			finally
-			{
-				SessionState.SetBool(SESSION_RUNNING_KEY, false);
-			}
 		}
 
 		private static IEnumerable<string> FindSampleRootAssetPaths()

package/Samples~/ClaudeSkills/unity-package-docs/scripts/scan_package.py

@@ -154,7 +154,7 @@ SUMMARY_LINE_RE = re.compile(r"^\s*///\s?(?P<text>.*)$")
 
 def parse_cs_file(path: Path, rel_path: str) -> dict:
     """Return {'types': [...], 'namespaces': set([...])} for one .cs file."""
-    raw = path.read_text(encoding="utf-8", errors="replace")
+    raw = path.read_text(encoding="utf-8-sig", errors="replace")
     norm = normalize(raw)
     norm_lines = norm.split("\n")
     raw_lines = raw.split("\n")
@@ -353,7 +353,7 @@ def scan_asmdefs(package_dir: Path, repo_root: Path) -> list[dict]:
     results: list[dict] = []
     for p in package_dir.rglob("*.asmdef"):
         try:
-            data = json.loads(p.read_text(encoding="utf-8"))
+            data = json.loads(p.read_text(encoding="utf-8-sig"))
         except json.JSONDecodeError:
             continue
         results.append(
@@ -383,7 +383,7 @@ def build_script_guid_map(repo_root: Path) -> dict[str, str]:
         return mapping
     for meta in assets.rglob("*.cs.meta"):
         try:
-            text = meta.read_text(encoding="utf-8", errors="replace")
+            text = meta.read_text(encoding="utf-8-sig", errors="replace")
         except OSError:
             continue
         m = META_GUID_RE.search(text)
@@ -409,7 +409,7 @@ def scan_sample_dir(sample_dir: Path, repo_root: Path, package_types: set[str],
         suf = p.suffix.lower()
         if suf == ".cs":
             try:
-                src = p.read_text(encoding="utf-8", errors="replace")
+                src = p.read_text(encoding="utf-8-sig", errors="replace")
             except OSError:
                 continue
             norm = normalize(src)
@@ -420,7 +420,7 @@ def scan_sample_dir(sample_dir: Path, repo_root: Path, package_types: set[str],
             results.append({"path": rel, "kind": "script", "namespace": ns, "packageTypesReferenced": refs})
         elif suf in (".unity", ".prefab"):
             try:
-                text = p.read_text(encoding="utf-8", errors="replace")
+                text = p.read_text(encoding="utf-8-sig", errors="replace")
             except OSError:
                 continue
             guids = sorted(set(SCRIPT_REF_RE.findall(text)))

package/package.json

@@ -1,14 +1,14 @@
 {
   "name": "com.elestrago.unity.package-tools",
-  "version": "2.2.1",
+  "version": "2.2.3",
   "displayName": "Package Tool",
   "description": "Tool for create unity packages",
   "category": "unity",
   "unity": "2021.3",
   "homepage": "https://gitlab.com/elestrago-pkg/package-tool",
-  "documentationUrl": "https://gitlab.com/elestrago-pkg/package-tool/-/blob/2.2.1/README.md",
-  "changelogUrl": "https://gitlab.com/elestrago-pkg/package-tool/-/blob/2.2.1/CHANGELOG.md",
-  "licensesUrl": "https://gitlab.com/elestrago-pkg/package-tool/-/blob/2.2.1/LICENSE",
+  "documentationUrl": "https://gitlab.com/elestrago-pkg/package-tool/-/blob/2.2.3/README.md",
+  "changelogUrl": "https://gitlab.com/elestrago-pkg/package-tool/-/blob/2.2.3/CHANGELOG.md",
+  "licensesUrl": "https://gitlab.com/elestrago-pkg/package-tool/-/blob/2.2.3/LICENSE",
   "license": "MIT",
   "keywords": [
     "unity",