collabmd 0.1.43 → 0.1.44

package/src/client/presentation/file-explorer-view.js

@@ -3,22 +3,9 @@ import {
   stripVaultFileExtension,
 } from '../../domain/file-kind.js';
 import { escapeHtml } from '../domain/vault-utils.js';
+import { getVaultPathLeaf, getVaultPathParent } from '../domain/vault-paths.js';
 import { buttonClassNames } from './components/ui/button.js';
 
-function getPathLeaf(path) {
-  return String(path ?? '')
-    .replace(/\/+$/u, '')
-    .split('/')
-    .filter(Boolean)
-    .pop() || '';
-}
-
-function getParentPath(pathValue) {
-  const normalized = String(pathValue ?? '').replace(/\/+$/u, '');
-  const separatorIndex = normalized.lastIndexOf('/');
-  return separatorIndex >= 0 ? normalized.slice(0, separatorIndex) : '';
-}
-
 function findNodeByPath(nodes = [], pathValue = '') {
   for (const node of nodes) {
     if (node.path === pathValue) {
@@ -174,7 +161,7 @@ export class FileExplorerView {
     }
 
     const affectedParentPaths = Array.from(new Set(
-      changedPaths.map((pathValue) => getParentPath(pathValue)),
+      changedPaths.map((pathValue) => getVaultPathParent(pathValue)),
     ))
       .sort((left, right) => left.split('/').length - right.split('/').length)
       .filter((pathValue, index, values) => (
@@ -232,7 +219,7 @@ export class FileExplorerView {
         depth: 0,
         filePath: match.path,
         fileType: match.type || (getVaultTreeNodeType(match.path) ?? 'file'),
-        name: match.name || getPathLeaf(match.path),
+        name: match.name || getVaultPathLeaf(match.path),
       }));
     }
     this.treeContainer.appendChild(fragment);
@@ -348,7 +335,7 @@ export class FileExplorerView {
     button.dataset.entryType = 'directory';
     button.innerHTML = `
       <svg class="file-tree-icon" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2"><path d="M22 19a2 2 0 0 1-2 2H4a2 2 0 0 1-2-2V5a2 2 0 0 1 2-2h5l2 3h9a2 2 0 0 1 2 2z"/></svg>
-      <span class="file-tree-name">${escapeHtml(node.name || getPathLeaf(node.path))}</span>
+      <span class="file-tree-name">${escapeHtml(node.name || getVaultPathLeaf(node.path))}</span>
     `;
 
     button.addEventListener('click', (event) => {

package/src/client/presentation/file-history-view-controller.js

@@ -1,21 +1,12 @@
 import { escapeHtml } from '../domain/vault-utils.js';
+import { getVaultPathLeaf, getVaultPathParent } from '../domain/vault-paths.js';
 import { buttonClassNames } from './components/ui/button.js';
 
 const HISTORY_PAGE_SIZE = 30;
 
-function getPathLeaf(pathValue) {
-  return String(pathValue ?? '').split('/').pop() || '';
-}
-
-function getPathDir(pathValue) {
-  const parts = String(pathValue ?? '').split('/');
-  parts.pop();
-  return parts.join('/');
-}
-
 function renderHistoryTitle(filePath = '') {
-  const fileName = getPathLeaf(filePath);
-  const dirPath = getPathDir(filePath);
+  const fileName = getVaultPathLeaf(filePath);
+  const dirPath = getVaultPathParent(filePath);
   if (!dirPath) {
     return `<span class="file-history-path">${escapeHtml(fileName)}</span>`;
   }

package/src/client/presentation/git-diff-view-controller.js

@@ -1,16 +1,7 @@
 import { escapeHtml } from '../domain/vault-utils.js';
+import { getVaultPathLeaf, getVaultPathParent } from '../domain/vault-paths.js';
 import { buttonClassNames } from './components/ui/button.js';
 
-function getPathLeaf(pathValue) {
-  return String(pathValue ?? '').split('/').pop() || '';
-}
-
-function getPathDir(pathValue) {
-  const parts = String(pathValue ?? '').split('/');
-  parts.pop();
-  return parts.join('/');
-}
-
 function createSectionId(pathValue) {
   return `diff-section-${encodeURIComponent(String(pathValue ?? '')).replace(/%/g, '_')}`;
 }
@@ -687,7 +678,7 @@ export class GitDiffViewController {
     const files = this.data?.files ?? [];
     const items = files.map((file, index) => {
       const isActive = this.activeFilePath === file.path;
-      const dirPath = getPathDir(file.path);
+      const dirPath = getVaultPathParent(file.path);
       return `
         <button
           class="ui-record-surface diff-index-item${isActive ? ' active' : ''}"
@@ -696,7 +687,7 @@ export class GitDiffViewController {
           aria-current="${isActive ? 'true' : 'false'}"
         >
           <span class="ui-record-header diff-index-item-top">
-            <span class="ui-record-title diff-index-item-name">${escapeHtml(getPathLeaf(file.path))}</span>
+            <span class="ui-record-title diff-index-item-name">${escapeHtml(getVaultPathLeaf(file.path))}</span>
             <span class="ui-status-badge ${badgeClass(file.status)}">${escapeHtml(file.status)}</span>
           </span>
           ${dirPath ? `<span class="ui-record-subtitle diff-index-item-path">${escapeHtml(dirPath)}</span>` : ''}
@@ -748,8 +739,8 @@ export class GitDiffViewController {
           <span class="diff-commit-section-main">
             ${chevronSvg(isCollapsed)}
             <span class="diff-commit-section-copy">
-              <span class="diff-commit-section-name">${escapeHtml(getPathLeaf(file.path))}</span>
-              ${getPathDir(file.path) ? `<span class="diff-commit-section-path">${escapeHtml(getPathDir(file.path))}</span>` : ''}
+              <span class="diff-commit-section-name">${escapeHtml(getVaultPathLeaf(file.path))}</span>
+              ${getVaultPathParent(file.path) ? `<span class="diff-commit-section-path">${escapeHtml(getVaultPathParent(file.path))}</span>` : ''}
             </span>
           </span>
           <span class="diff-commit-section-meta">
@@ -1237,10 +1228,10 @@ export class GitDiffViewController {
       }
 
       if (path) {
-        return getPathLeaf(path);
+        return getVaultPathLeaf(path);
       }
       if (this.activeFilePath) {
-        return getPathLeaf(this.activeFilePath);
+        return getVaultPathLeaf(this.activeFilePath);
       }
       if (this.commitMeta?.shortHash) {
         return `Commit ${this.commitMeta.shortHash}`;
@@ -1252,7 +1243,7 @@ export class GitDiffViewController {
     }
 
     if (filePath) {
-      return getPathLeaf(filePath);
+      return getVaultPathLeaf(filePath);
     }
 
     if (scope === 'staged') {

package/src/client/presentation/git-panel-controller.js

@@ -1,20 +1,11 @@
 import { escapeHtml } from '../domain/vault-utils.js';
+import { getVaultPathLeaf, getVaultPathParent } from '../domain/vault-paths.js';
 import { buttonClassNames } from './components/ui/button.js';
 import { segmentedButtonClassNames, segmentedControlClassNames } from './components/ui/segmented-control.js';
 
 const HISTORY_PAGE_SIZE = 30;
 const REFRESH_INTERVAL_MS = 10_000;
 
-function getPathDir(pathValue) {
-  const parts = String(pathValue ?? '').split('/');
-  parts.pop();
-  return parts.join('/');
-}
-
-function getPathLeaf(pathValue) {
-  return String(pathValue ?? '').split('/').pop() || '';
-}
-
 function fileIconSvg() {
   return '<svg class="git-file-icon" width="12" height="12" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" aria-hidden="true"><path d="M14 2H6a2 2 0 0 0-2 2v16a2 2 0 0 0 2 2h12a2 2 0 0 0 2-2V8z"/><polyline points="14 2 14 8 20 8"/></svg>';
 }
@@ -728,8 +719,8 @@ export class GitPanelController {
     const isActive = this.selection.source === 'workspace'
       && this.selection.path === file.path
       && this.selection.scope === file.scope;
-    const dirPath = getPathDir(file.path);
-    const displayName = getPathLeaf(file.path);
+    const dirPath = getVaultPathParent(file.path);
+    const displayName = getVaultPathLeaf(file.path);
     const fullPath = String(file.path || '');
     const statusClass = badgeClass(file.status);
     const stageAction = file.scope === 'staged'

package/src/client/presentation/quick-switcher-controller.js

@@ -9,12 +9,8 @@ import {
 
 const MAX_VISIBLE_RESULTS = 12;
 
-function stripDisplayExtension(filePath) {
-  return stripVaultFileExtension(filePath);
-}
-
 function createCorpusEntry(filePath) {
-  const displayName = stripDisplayExtension(filePath);
+  const displayName = stripVaultFileExtension(filePath);
   const fileName = displayName.split('/').pop() || displayName;
 
   return {
@@ -28,11 +24,12 @@ function createCorpusEntry(filePath) {
 }
 
 function getFileName(filePath) {
-  return stripDisplayExtension(filePath).split('/').pop() || stripDisplayExtension(filePath);
+  const displayName = stripVaultFileExtension(filePath);
+  return displayName.split('/').pop() || displayName;
 }
 
 function getDirPath(filePath) {
-  const displayName = stripDisplayExtension(filePath);
+  const displayName = stripVaultFileExtension(filePath);
   return displayName.includes('/') ? displayName.substring(0, displayName.lastIndexOf('/')) : '';
 }
 

package/src/client/presentation/scroll-sync-controller.js

@@ -1,4 +1,5 @@
 import { clamp } from '../domain/vault-utils.js';
+import { cancelIdleRender, requestIdleRender } from '../browser-utils.js';
 
 const VIEWPORT_FOCUS_RATIO = 0.35;
 const LARGE_DOCUMENT_EDITOR_IDLE_MS = 120;
@@ -31,32 +32,6 @@ function isLeafSourceBlock(element) {
   return !element.querySelector('[data-source-line]');
 }
 
-function requestIdleWork(callback) {
-  if (typeof window.requestIdleCallback === 'function') {
-    return window.requestIdleCallback(callback, { timeout: 500 });
-  }
-
-  return window.setTimeout(() => {
-    callback({
-      didTimeout: false,
-      timeRemaining: () => 0,
-    });
-  }, 1);
-}
-
-function cancelIdleWork(id) {
-  if (id === null) {
-    return;
-  }
-
-  if (typeof window.cancelIdleCallback === 'function') {
-    window.cancelIdleCallback(id);
-    return;
-  }
-
-  window.clearTimeout(id);
-}
-
 export class ScrollSyncController {
   constructor({
     getEditorLineNumber,
@@ -143,7 +118,7 @@ export class ScrollSyncController {
     this.editorScrollIdleTimer = null;
     this.pendingSync = null;
     this.previewBlocks = null;
-    cancelIdleWork(this.previewBlocksWarmId);
+    cancelIdleRender(this.previewBlocksWarmId);
     this.previewBlocksWarmId = null;
     this.previewBlocksReadyCallbacks = [];
     this.lockedElements.clear();
@@ -188,7 +163,7 @@ export class ScrollSyncController {
 
   invalidatePreviewBlocks() {
     this.previewBlocks = null;
-    cancelIdleWork(this.previewBlocksWarmId);
+    cancelIdleRender(this.previewBlocksWarmId);
     this.previewBlocksWarmId = null;
     this.previewBlocksReadyCallbacks = [];
   }
@@ -224,11 +199,11 @@ export class ScrollSyncController {
       return;
     }
 
-    this.previewBlocksWarmId = requestIdleWork(() => {
+    this.previewBlocksWarmId = requestIdleRender(() => {
       this.previewBlocksWarmId = null;
       this.previewBlocks = this.buildPreviewBlocks();
       this.flushPreviewBlocksReadyCallbacks();
-    });
+    }, 500);
   }
 
   realignAfterLayoutChange() {

package/src/client/styles/features/comment-card.css

@@ -48,6 +48,14 @@
   text-transform: uppercase;
 }
 
+.comment-card-anchor-note {
+  padding: var(--space-2) var(--space-3);
+  border-radius: var(--radius-md);
+  background: var(--surface-comment-offset-soft);
+  color: var(--color-text-muted);
+  font-size: var(--text-label);
+}
+
 .comment-card-close,
 .comment-thread-card-action {
   border: 1px solid transparent;

package/src/client/styles/features/comment-overlays.css

@@ -34,6 +34,21 @@
   position: absolute;
 }
 
+.comment-preview-selection-chip {
+  --ui-chip-color: var(--color-comment);
+  position: absolute;
+  z-index: 2;
+  box-shadow: var(--shadow-sm);
+  pointer-events: auto;
+}
+
+@media (pointer: coarse) {
+  .comment-preview-selection-chip {
+    min-height: 44px;
+    padding-inline: var(--space-3);
+  }
+}
+
 .comment-preview-highlight {
   position: absolute;
   border: 1px solid oklch(from var(--color-comment) l c h / 0.16);

package/src/client/styles/features/diagram-preview.css

@@ -49,6 +49,26 @@
   background: var(--color-surface-offset);
 }
 
+.diagram-preview-error-card {
+  align-items: flex-start;
+  border-top: 1px solid var(--color-divider);
+  background: var(--color-error-highlight);
+  color: var(--color-error);
+  font-size: var(--text-xs);
+}
+
+.diagram-preview-error-card .diagram-preview-placeholder-copy details {
+  color: var(--color-text-muted);
+}
+
+.diagram-preview-error-card .diagram-preview-placeholder-copy code {
+  display: block;
+  max-width: min(60ch, 100%);
+  margin-top: var(--space-2);
+  overflow-wrap: anywhere;
+  white-space: pre-wrap;
+}
+
 .diagram-preview-toolbar {
   display: flex;
   align-items: center;

package/src/client/styles/style.css

@@ -5,17 +5,35 @@
 @import './layout/sidebar.css';
 @import './layout/editor-page.css';
 @import './layout/shell.css';
+@import './primitives/controls.css';
+@import './components/actions.css';
+@import './components/navigation.css';
+@import './components/states.css';
 @import './components/surfaces.css';
 @import './components/scrollbars.css';
-@import './features/git.css';
-@import './features/diff.css';
-@import './features/collaboration-ui.css';
-@import './features/preview-content.css';
-@import './features/comments.css';
-@import './features/preview-sidebars.css';
+@import './features/git-branch.css';
+@import './features/git-files.css';
+@import './features/git-history.css';
+@import './features/diff-toolbar.css';
+@import './features/diff-commit.css';
+@import './features/diff-lines.css';
+@import './features/collaboration-presence.css';
+@import './features/collaboration-chat.css';
+@import './features/collaboration-dialogs.css';
+@import './features/preview-markdown.css';
+@import './features/media-lightbox.css';
+@import './features/embedded-preview.css';
+@import './features/comments-drawer.css';
+@import './features/comment-overview.css';
+@import './features/comment-overlays.css';
+@import './features/comment-card.css';
+@import './features/comment-markdown.css';
+@import './features/backlinks.css';
+@import './features/outline.css';
 @import './layout/view-modes.css';
 @import './components/feedback.css';
 @import './layout/responsive.css';
-@import './overrides/vendor.css';
+@import './overrides/highlightjs.css';
+@import './overrides/codemirror.css';
 @import './features/quick-switcher.css';
 @import './features/diagram-preview.css';

package/src/client/styles/surfaces/excalidraw-editor.css

@@ -6,6 +6,31 @@ body[data-surface='excalidraw-editor'][data-document-mode='preview'] .disable-vi
   display: none !important;
 }
 
+.excalidraw-editor-shell {
+  position: relative;
+  width: 100%;
+  height: 100vh;
+}
+
+.excalidraw-authority-banner {
+  position: absolute;
+  z-index: 20;
+  top: var(--space-3);
+  left: 50%;
+  max-width: min(36rem, calc(100vw - (2 * var(--space-4))));
+  padding: var(--space-2) var(--space-3);
+  border: 1px solid var(--color-border);
+  border-radius: var(--radius-md);
+  background: var(--color-surface-raised);
+  box-shadow: var(--shadow-md);
+  color: var(--color-text-muted);
+  font-size: var(--text-ui-sm);
+  line-height: 1.4;
+  text-align: center;
+  transform: translateX(-50%);
+  pointer-events: none;
+}
+
 .loading-state {
   display: flex;
   align-items: center;

package/src/domain/excalidraw-room-codec.js

@@ -221,15 +221,7 @@ export function isExcalidrawRoomDocStructured(ydoc) {
   }
 
   const meta = ydoc.getMap(EXCALIDRAW_META_KEY);
-  if (Number(meta.get(EXCALIDRAW_SCHEMA_VERSION_KEY)) === EXCALIDRAW_ROOM_SCHEMA_VERSION) {
-    return true;
-  }
-
-  return (
-    ydoc.getMap(EXCALIDRAW_ELEMENTS_KEY).size > 0
-    || ydoc.getMap(EXCALIDRAW_FILES_KEY).size > 0
-    || ydoc.getMap(EXCALIDRAW_APP_STATE_KEY).size > 0
-  );
+  return Number(meta.get(EXCALIDRAW_SCHEMA_VERSION_KEY)) === EXCALIDRAW_ROOM_SCHEMA_VERSION;
 }
 
 export function ensureExcalidrawRoomSchema(ydoc) {

package/src/domain/vault-paths.js

@@ -0,0 +1,41 @@
+export function resolveVaultRelativePath(fromFilePath = '', relativePath = '') {
+  const sourceSegments = String(fromFilePath ?? '')
+    .replace(/\\/g, '/')
+    .split('/')
+    .filter(Boolean);
+  const targetSegments = String(relativePath ?? '')
+    .split('/')
+    .map((segment) => {
+      try {
+        return decodeURIComponent(segment);
+      } catch {
+        return segment;
+      }
+    });
+
+  if (targetSegments.length === 0) {
+    return '';
+  }
+
+  sourceSegments.pop();
+  const resolvedSegments = [...sourceSegments];
+
+  for (const rawSegment of targetSegments) {
+    const segment = String(rawSegment ?? '').trim();
+    if (!segment || segment === '.') {
+      continue;
+    }
+
+    if (segment === '..') {
+      if (resolvedSegments.length === 0) {
+        return '';
+      }
+      resolvedSegments.pop();
+      continue;
+    }
+
+    resolvedSegments.push(segment);
+  }
+
+  return resolvedSegments.join('/');
+}

package/src/server/config/env.js

@@ -39,10 +39,6 @@ function parseOptionalPositiveInt(rawValue, {
   throw new Error(`${variableName} must be a positive integer.`);
 }
 
-function parsePort(rawPort, fallbackPort) {
-  return parsePositiveInt(rawPort, fallbackPort);
-}
-
 function normalizeOptionalString(value) {
   const normalized = String(value ?? '').trim();
   return normalized.length > 0 ? normalized : '';
@@ -401,7 +397,7 @@ export function loadConfig(overrides = {}) {
     maxDownloadFileBytes: parsePositiveInt(process.env.COLLABMD_MAX_DOWNLOAD_FILE_BYTES, 268_435_456),
     maxInitialSyncBytes: parsePositiveInt(process.env.COLLABMD_MAX_INITIAL_SYNC_BYTES, 16_777_216),
     perfLoggingEnabled: overrides.perfLoggingEnabled ?? isPerfLoggingEnabled(process.env.COLLABMD_PERF_LOGGING),
-    port: parsePort(process.env.PORT, 1234),
+    port: parsePositiveInt(process.env.PORT, 1234),
     nodeEnv,
     plantumlServerUrl: process.env.PLANTUML_SERVER_URL || 'https://www.plantuml.com/plantuml',
     publicDir,

package/src/server/domain/bases/base-expression-runtime.js

@@ -1,55 +1,10 @@
 import { isImageAttachmentFilePath } from '../../../domain/file-kind.js';
+import { resolveVaultRelativePath } from '../../../domain/vault-paths.js';
 
 function isPlainObject(value) {
   return Object.prototype.toString.call(value) === '[object Object]';
 }
 
-function normalizeVaultPathSegments(pathValue = '') {
-  return String(pathValue ?? '')
-    .replace(/\\/g, '/')
-    .split('/')
-    .filter(Boolean);
-}
-
-function resolveVaultRelativePath(fromFilePath, relativePath) {
-  const sourceSegments = normalizeVaultPathSegments(fromFilePath);
-  const targetSegments = String(relativePath ?? '')
-    .split('/')
-    .map((segment) => {
-      try {
-        return decodeURIComponent(segment);
-      } catch {
-        return segment;
-      }
-    });
-
-  if (targetSegments.length === 0) {
-    return '';
-  }
-
-  sourceSegments.pop();
-  const resolvedSegments = [...sourceSegments];
-
-  for (const rawSegment of targetSegments) {
-    const segment = String(rawSegment ?? '').trim();
-    if (!segment || segment === '.') {
-      continue;
-    }
-
-    if (segment === '..') {
-      if (resolvedSegments.length === 0) {
-        return '';
-      }
-      resolvedSegments.pop();
-      continue;
-    }
-
-    resolvedSegments.push(segment);
-  }
-
-  return resolvedSegments.join('/');
-}
-
 export function createLinkValue(target, {
   display = '',
   exists = false,