coles-solid-library 0.3.9 → 0.3.10

package/dist/index.esm.js

@@ -599,8 +599,15 @@ const Carousel = ({
   const [internalIndex, setInternalIndex] = createSignal(startingIndex);
   const [propIndex, other] = splitProps(props, ["currentIndex"]);
   const [, setCarouselBodyRef] = createSignal(null);
+  // Unified read/write for controlled vs uncontrolled usage
   const getPropIndex = () => propIndex.currentIndex ? propIndex.currentIndex[0]() : internalIndex();
-  const setPropIndex = index => propIndex.currentIndex ? propIndex.currentIndex[1](index) : setInternalIndex(index);
+  const setPropIndex = index => {
+    if (propIndex.currentIndex) {
+      propIndex.currentIndex[1](index);
+    } else {
+      setInternalIndex(index);
+    }
+  };
   const [currSlideName] = useContext(carouselTitleContext);
   // ----- Memoized Values -----
   const getElementsLength = createMemo(() => {
@@ -625,12 +632,8 @@ const Carousel = ({
       return [theProps.children];
     }
   });
-  const currentIndex = createMemo(() => {
-    if (getElementsLength() === 2) {
-      return getPropIndex();
-    }
-    return internalIndex();
-  });
+  // The active index should always come from external control if provided
+  const currentIndex = createMemo(() => getPropIndex());
   const slideName = createMemo(() => {
     if (Object.keys(props).includes('elements') && getElementsLength() > 0) {
       return getElementsArray()[currentIndex()]?.name;
@@ -659,23 +662,20 @@ const Carousel = ({
   });
   // ----- Functions -----
   const nextSlide = () => {
-    if (currentIndex() !== getElementsLength() - 1) {
-      setInternalIndex(old => old + 1);
-    } else {
-      setInternalIndex(0);
-    }
+    const next = currentIndex() !== getElementsLength() - 1 ? currentIndex() + 1 : 0;
+    setPropIndex(next);
   };
   const prevSlide = () => {
-    if (currentIndex() !== 0) {
-      setInternalIndex(old => old - 1);
-    } else {
-      setInternalIndex(getElementsLength() - 1);
-    }
+    const prev = currentIndex() !== 0 ? currentIndex() - 1 : getElementsLength() - 1;
+    setPropIndex(prev);
   };
   // ----- Effects -----
+  // Keep internal signal in sync when switching from uncontrolled to controlled or external changes
   createRenderEffect(() => {
-    if (props.currentIndex) {
-      setPropIndex(currentIndex());
+    if (!propIndex.currentIndex) return; // controlled only
+    // Mirror external index into internal for consistency (e.g., if component logic elsewhere reads internalIndex)
+    if (internalIndex() !== propIndex.currentIndex[0]()) {
+      setInternalIndex(propIndex.currentIndex[0]());
     }
   });
   // ----- TSX -----

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "coles-solid-library",
-  "version": "0.3.9",
+  "version": "0.3.10",
   "description": "A SolidJS mostly UI library",
   "module": "dist/index.esm.js",
   "types": "dist/index.d.ts",