cokit-cli 1.2.3 → 1.2.6
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +6 -7
- package/agents/brainstormer.agent.md +9 -2
- package/agents/code-reviewer.agent.md +59 -84
- package/agents/code-simplifier.agent.md +9 -6
- package/agents/debugger.agent.md +17 -8
- package/agents/docs-manager.agent.md +104 -8
- package/agents/fullstack-developer.agent.md +57 -13
- package/agents/git-manager.agent.md +2 -382
- package/agents/planner.agent.md +36 -8
- package/agents/researcher.agent.md +18 -3
- package/agents/tester.agent.md +13 -14
- package/agents/ui-ux-designer.agent.md +209 -33
- package/docs/README.md +4 -3
- package/docs/claudekit-porting-rules.md +182 -0
- package/docs/codebase-summary.md +11 -10
- package/docs/cokit-comprehensive-mapping-guide.md +4 -4
- package/docs/cokit-slides.md +1 -1
- package/docs/cokit-sync-and-maintenance-guide.md +8 -3
- package/docs/cokit-team-presentation.md +5 -5
- package/docs/guide-next-steps-speckit-cokit-implementation.md +1 -1
- package/docs/project-overview-pdr.md +1 -1
- package/docs/project-roadmap.md +6 -7
- package/package.json +1 -1
- package/prompts/ck-ask.prompt.md +1 -1
- package/prompts/ck-bootstrap.prompt.md +1 -1
- package/prompts/ck-cook.prompt.md +12 -12
- package/prompts/ck-plan-fast.prompt.md +1 -0
- package/prompts/ck-plan-hard.prompt.md +2 -1
- package/prompts/ck-plan-red-team.prompt.md +227 -0
- package/prompts/ck-plan.prompt.md +1 -0
- package/prompts/ck-simplify.prompt.md +1 -1
- package/skills/code-review/SKILL.md +78 -28
- package/skills/cook/SKILL.md +45 -11
- package/skills/debug/SKILL.md +112 -17
- package/skills/fix/SKILL.md +20 -8
- package/skills/frontend-design/SKILL.md +6 -3
- package/skills/planning/SKILL.md +47 -15
- package/skills/research/SKILL.md +1 -1
- package/skills/scout/SKILL.md +24 -11
- package/skills/web-testing/SKILL.md +60 -6
- package/skills/web-testing/references/report-format.md +57 -0
- package/skills/web-testing/references/test-execution-workflow.md +118 -0
- package/skills/web-testing/references/ui-testing-workflow.md +97 -0
- package/templates/repo/.github/agents/brainstormer.agent.md +9 -2
- package/templates/repo/.github/agents/code-reviewer.agent.md +59 -84
- package/templates/repo/.github/agents/code-simplifier.agent.md +9 -6
- package/templates/repo/.github/agents/debugger.agent.md +17 -8
- package/templates/repo/.github/agents/docs-manager.agent.md +104 -8
- package/templates/repo/.github/agents/fullstack-developer.agent.md +57 -13
- package/templates/repo/.github/agents/git-manager.agent.md +2 -382
- package/templates/repo/.github/agents/planner.agent.md +36 -8
- package/templates/repo/.github/agents/researcher.agent.md +18 -3
- package/templates/repo/.github/agents/tester.agent.md +13 -14
- package/templates/repo/.github/agents/ui-ux-designer.agent.md +209 -33
- package/templates/repo/.github/prompts/ck-ask.prompt.md +1 -1
- package/templates/repo/.github/prompts/ck-bootstrap.prompt.md +1 -1
- package/templates/repo/.github/prompts/ck-cook.prompt.md +12 -12
- package/templates/repo/.github/prompts/ck-plan-fast.prompt.md +1 -0
- package/templates/repo/.github/prompts/ck-plan-hard.prompt.md +2 -1
- package/templates/repo/.github/prompts/ck-plan-red-team.prompt.md +227 -0
- package/templates/repo/.github/prompts/ck-plan.prompt.md +1 -0
- package/templates/repo/.github/prompts/ck-simplify.prompt.md +1 -1
- package/templates/repo/.github/prompts/ck-spec-specify.prompt.md +1 -0
- package/templates/repo/.github/skills/code-review/SKILL.md +78 -28
- package/templates/repo/.github/skills/cook/SKILL.md +45 -11
- package/templates/repo/.github/skills/debug/SKILL.md +112 -17
- package/templates/repo/.github/skills/fix/SKILL.md +20 -8
- package/templates/repo/.github/skills/frontend-design/SKILL.md +6 -3
- package/templates/repo/.github/skills/planning/SKILL.md +47 -15
- package/templates/repo/.github/skills/research/SKILL.md +1 -1
- package/templates/repo/.github/skills/scout/SKILL.md +24 -11
- package/templates/repo/.github/skills/web-testing/SKILL.md +60 -6
- package/templates/repo/.github/skills/web-testing/references/report-format.md +57 -0
- package/templates/repo/.github/skills/web-testing/references/test-execution-workflow.md +118 -0
- package/templates/repo/.github/skills/web-testing/references/ui-testing-workflow.md +97 -0
- package/prompts/ck-journal.prompt.md +0 -19
- package/prompts/ck-preview.prompt.md +0 -77
- package/templates/repo/.github/prompts/ck-journal.prompt.md +0 -19
- package/templates/repo/.github/prompts/ck-preview.prompt.md +0 -77
|
@@ -0,0 +1,227 @@
|
|
|
1
|
+
---
|
|
2
|
+
agent: 'agent'
|
|
3
|
+
description: 'Adversarial plan review — spawn hostile reviewers to find flaws, security holes, false assumptions, failure modes'
|
|
4
|
+
argument-hint: 'Path to plan directory'
|
|
5
|
+
---
|
|
6
|
+
|
|
7
|
+
## Variant Notice
|
|
8
|
+
**IMPORTANT — Read before proceeding.**
|
|
9
|
+
`ck-plan-red-team` is an internal mode for adversarial plan review — it is meant to be selected automatically by AI when you run `/ck-plan`.
|
|
10
|
+
You don't need to call this directly. Just use `/ck-plan` and AI will pick the right mode for you.
|
|
11
|
+
Before executing, you MUST output the following message **exactly as written** and wait for user response:
|
|
12
|
+
|
|
13
|
+
---
|
|
14
|
+
**Variant Notice**
|
|
15
|
+
|
|
16
|
+
`ck-plan-red-team` is an internal mode for adversarial plan review — it is meant to be selected automatically by AI when you run `/ck-plan`.
|
|
17
|
+
You don't need to call this directly. Just use `/ck-plan` and AI will pick the right mode for you.
|
|
18
|
+
|
|
19
|
+
Do you want to continue anyway, or switch to `/ck-plan`? **[Continue / Switch to /ck-plan]**
|
|
20
|
+
|
|
21
|
+
---
|
|
22
|
+
|
|
23
|
+
Only proceed if user explicitly confirms Continue.
|
|
24
|
+
If user chooses "Switch to /ck-plan", run `/ck-plan` immediately — do NOT ask user to re-enter their input.
|
|
25
|
+
|
|
26
|
+
## Your Mission
|
|
27
|
+
|
|
28
|
+
Adversarially review an implementation plan by spawning parallel reviewer agents that try to tear it apart. Each reviewer adopts a different hostile lens. You then adjudicate findings, and the user decides which to apply.
|
|
29
|
+
|
|
30
|
+
**Mindset:** Like hiring someone who hates the implementer to destroy their work.
|
|
31
|
+
|
|
32
|
+
## Plan Resolution
|
|
33
|
+
|
|
34
|
+
1. If `${input}` provided → Use that path
|
|
35
|
+
2. Else check `## Plan Context` section → Use active plan path
|
|
36
|
+
3. If no plan found → Ask user to specify path or run `/ck-plan` first
|
|
37
|
+
|
|
38
|
+
## Workflow
|
|
39
|
+
|
|
40
|
+
### Step 1: Read Plan Files
|
|
41
|
+
|
|
42
|
+
Read the plan directory:
|
|
43
|
+
- `plan.md` — Overview, phases, dependencies
|
|
44
|
+
- `phase-*.md` — All phase files (full content)
|
|
45
|
+
- Note: architecture decisions, assumptions, scope, risks, implementation steps
|
|
46
|
+
|
|
47
|
+
Collect all plan file paths for reviewers to read directly.
|
|
48
|
+
|
|
49
|
+
### Step 2: Scale Reviewer Count
|
|
50
|
+
|
|
51
|
+
Scale reviewers based on plan complexity:
|
|
52
|
+
|
|
53
|
+
| Phase Count | Reviewers | Lenses Selected |
|
|
54
|
+
|-------------|-----------|-----------------|
|
|
55
|
+
| 1-2 phases | 2 | Security Adversary + Assumption Destroyer |
|
|
56
|
+
| 3-5 phases | 3 | + Failure Mode Analyst |
|
|
57
|
+
| 6+ phases | 4 | + Scope & Complexity Critic (all lenses) |
|
|
58
|
+
|
|
59
|
+
### Step 3: Define Adversarial Lenses
|
|
60
|
+
|
|
61
|
+
Available lenses (select per Step 2):
|
|
62
|
+
|
|
63
|
+
| Reviewer | Lens | Focus |
|
|
64
|
+
|----------|------|-------|
|
|
65
|
+
| **Security Adversary** | Attacker mindset | Auth bypass, injection, data exposure, privilege escalation, supply chain, OWASP top 10 |
|
|
66
|
+
| **Failure Mode Analyst** | Murphy's Law | Race conditions, data loss, cascading failures, recovery gaps, deployment risks, rollback holes |
|
|
67
|
+
| **Assumption Destroyer** | Skeptic | Unstated dependencies, false "will work" claims, missing error paths, scale assumptions, integration assumptions |
|
|
68
|
+
| **Scope & Complexity Critic** | YAGNI enforcer | Over-engineering, premature abstraction, unnecessary complexity, missing MVP cuts, scope creep, gold plating |
|
|
69
|
+
|
|
70
|
+
### Step 4: Spawn Reviewers
|
|
71
|
+
|
|
72
|
+
Launch reviewers simultaneously using `code-reviewer` agents in parallel.
|
|
73
|
+
|
|
74
|
+
**Each reviewer prompt MUST include:**
|
|
75
|
+
1. This override: `"IGNORE your default code-review instructions. You are reviewing a PLAN DOCUMENT, not code. There is no code to lint, build, or test. Focus exclusively on plan quality."`
|
|
76
|
+
2. Their specific adversarial lens and persona
|
|
77
|
+
3. The plan file paths so they can read original files directly
|
|
78
|
+
4. These instructions:
|
|
79
|
+
|
|
80
|
+
```
|
|
81
|
+
You are a hostile reviewer. Your job is to DESTROY this plan.
|
|
82
|
+
Adopt the {LENS_NAME} perspective. Find every flaw you can.
|
|
83
|
+
|
|
84
|
+
Rules:
|
|
85
|
+
- Be specific: cite exact phase/section where the flaw lives
|
|
86
|
+
- Be concrete: describe the failure scenario, not just "could be a problem"
|
|
87
|
+
- Rate severity: Critical (blocks success) | High (significant risk) | Medium (notable concern)
|
|
88
|
+
- Skip trivial observations (style, naming, formatting) — not worth reporting.
|
|
89
|
+
- No praise. No "overall looks good". Only findings.
|
|
90
|
+
- 5-10 findings per reviewer. Quality over quantity.
|
|
91
|
+
|
|
92
|
+
Output format per finding:
|
|
93
|
+
## Finding {N}: {title}
|
|
94
|
+
- **Severity:** Critical | High | Medium
|
|
95
|
+
- **Location:** Phase {X}, section "{name}"
|
|
96
|
+
- **Flaw:** {what's wrong}
|
|
97
|
+
- **Failure scenario:** {concrete description of how this fails}
|
|
98
|
+
- **Evidence:** {quote from plan or missing element}
|
|
99
|
+
- **Suggested fix:** {brief recommendation}
|
|
100
|
+
```
|
|
101
|
+
|
|
102
|
+
### Step 5: Collect, Deduplicate & Cap
|
|
103
|
+
|
|
104
|
+
After all reviewers complete:
|
|
105
|
+
1. Collect all findings
|
|
106
|
+
2. Deduplicate overlapping findings (merge if same root issue)
|
|
107
|
+
3. Sort by severity: Critical → High → Medium
|
|
108
|
+
4. **Cap at 15 findings:** Keep all Critical, top High by specificity, note dropped Medium count
|
|
109
|
+
|
|
110
|
+
### Step 6: Adjudicate
|
|
111
|
+
|
|
112
|
+
For each finding, evaluate and propose a disposition:
|
|
113
|
+
|
|
114
|
+
| Disposition | Meaning |
|
|
115
|
+
|-------------|---------|
|
|
116
|
+
| **Accept** | Valid flaw — plan should be updated |
|
|
117
|
+
| **Reject** | False positive, acceptable risk, or already handled |
|
|
118
|
+
|
|
119
|
+
**Adjudication format:**
|
|
120
|
+
|
|
121
|
+
```markdown
|
|
122
|
+
## Red Team Findings
|
|
123
|
+
|
|
124
|
+
### Finding 1: {title} — {SEVERITY}
|
|
125
|
+
**Reviewer:** {lens name}
|
|
126
|
+
**Location:** {phase/section}
|
|
127
|
+
**Flaw:** {description}
|
|
128
|
+
**Failure scenario:** {concrete scenario}
|
|
129
|
+
**Disposition:** Accept | Reject
|
|
130
|
+
**Rationale:** {why accept/reject — be specific}
|
|
131
|
+
```
|
|
132
|
+
|
|
133
|
+
### Step 7: User Review
|
|
134
|
+
|
|
135
|
+
Present the adjudicated findings to the user directly in your response. List all findings with their dispositions, then ask:
|
|
136
|
+
|
|
137
|
+
> **Review red-team findings.** Which dispositions do you want to change?
|
|
138
|
+
>
|
|
139
|
+
> 1. **Looks good, apply accepted findings** — proceed with current Accept/Reject
|
|
140
|
+
> 2. **Let me review each one** — walk through findings individually
|
|
141
|
+
> 3. **Reject all, plan is fine** — discard all findings
|
|
142
|
+
|
|
143
|
+
Wait for user response before proceeding.
|
|
144
|
+
|
|
145
|
+
**If "Let me review each one":**
|
|
146
|
+
For each finding marked Accept, present it and ask:
|
|
147
|
+
- "Apply this fix to the plan?" with options: **Yes, apply** | **No, reject** | **Modify suggestion**
|
|
148
|
+
|
|
149
|
+
**If "Modify suggestion":**
|
|
150
|
+
Ask user: "Describe your modification to this finding's suggested fix:"
|
|
151
|
+
Record the modified suggestion in the finding's "Suggested fix" field.
|
|
152
|
+
Set disposition to "Accept (modified)" in the Red Team Review table.
|
|
153
|
+
|
|
154
|
+
### Step 8: Apply to Plan
|
|
155
|
+
|
|
156
|
+
For each accepted finding:
|
|
157
|
+
1. Locate the target phase file and section
|
|
158
|
+
2. Add the fix/note inline with a marker:
|
|
159
|
+
```markdown
|
|
160
|
+
<!-- Red Team: {finding title} — {date} -->
|
|
161
|
+
```
|
|
162
|
+
3. If finding requires new content, add to the most relevant section
|
|
163
|
+
4. If finding requires removing/changing content, edit in place
|
|
164
|
+
|
|
165
|
+
After applying, add a `## Red Team Review` section to `plan.md`.
|
|
166
|
+
If section already exists (repeat run), **append** a new session block — never overwrite history.
|
|
167
|
+
|
|
168
|
+
**Placement order in plan.md** (bottom of file):
|
|
169
|
+
1. `## Red Team Review` (before validation)
|
|
170
|
+
2. `## Validation Log` (after red-team)
|
|
171
|
+
|
|
172
|
+
This ordering matches the execution sequence: red-team → validate.
|
|
173
|
+
|
|
174
|
+
```markdown
|
|
175
|
+
## Red Team Review
|
|
176
|
+
|
|
177
|
+
### Session — {YYYY-MM-DD}
|
|
178
|
+
**Findings:** {total} ({accepted} accepted, {rejected} rejected)
|
|
179
|
+
**Severity breakdown:** {N} Critical, {N} High, {N} Medium
|
|
180
|
+
|
|
181
|
+
| # | Finding | Severity | Disposition | Applied To |
|
|
182
|
+
|---|---------|----------|-------------|------------|
|
|
183
|
+
| 1 | {title} | Critical | Accept | Phase 2 |
|
|
184
|
+
| 2 | {title} | High | Reject | — |
|
|
185
|
+
```
|
|
186
|
+
|
|
187
|
+
## Output
|
|
188
|
+
|
|
189
|
+
After completion, provide summary:
|
|
190
|
+
- Total findings by severity
|
|
191
|
+
- Accepted vs rejected count
|
|
192
|
+
- Files modified
|
|
193
|
+
- Key risks addressed
|
|
194
|
+
- Remaining concerns (if any rejected findings were borderline)
|
|
195
|
+
|
|
196
|
+
## Next Steps (MANDATORY)
|
|
197
|
+
|
|
198
|
+
After providing the summary, remind the user:
|
|
199
|
+
|
|
200
|
+
> **Plan updated with red-team findings.** Consider running:
|
|
201
|
+
> ```
|
|
202
|
+
> /ck-plan-validate {ABSOLUTE_PATH_TO_PLAN_DIR}/plan.md
|
|
203
|
+
> ```
|
|
204
|
+
> to re-validate decisions after changes, then:
|
|
205
|
+
> ```
|
|
206
|
+
> /ck-cook --auto {ABSOLUTE_PATH_TO_PLAN_DIR}/plan.md
|
|
207
|
+
> ```
|
|
208
|
+
> to implement.
|
|
209
|
+
|
|
210
|
+
## Important Notes
|
|
211
|
+
|
|
212
|
+
**IMPORTANT:** Reviewers must be HOSTILE, not helpful. No softening language.
|
|
213
|
+
**IMPORTANT:** Deduplicate aggressively — reviewers will find overlapping issues.
|
|
214
|
+
**IMPORTANT:** Adjudication must be evidence-based. Don't reject valid findings to be nice.
|
|
215
|
+
**IMPORTANT:** If plan has a Validation Log from `/ck-plan-validate`, reviewers should check if validation answers introduced new assumptions.
|
|
216
|
+
**IMPORTANT:** Sacrifice grammar for concision in reports.
|
|
217
|
+
**IMPORTANT:** Reviewers read plan files directly — do NOT duplicate content in a summary.
|
|
218
|
+
|
|
219
|
+
---
|
|
220
|
+
|
|
221
|
+
## Suggested Next Steps
|
|
222
|
+
|
|
223
|
+
| Command | Description |
|
|
224
|
+
|---------|-------------|
|
|
225
|
+
| `/ck-plan-validate` | Validate plan with critical questions |
|
|
226
|
+
| `/ck-cook` | Implement the plan |
|
|
227
|
+
| `/ck-plan` | Create or modify plan |
|
|
@@ -69,6 +69,7 @@ If user chooses validation or mode is `auto`: Execute `/ck-plan-validate {plan-p
|
|
|
69
69
|
| Command | Description |
|
|
70
70
|
|---------|-------------|
|
|
71
71
|
| `/ck-plan-validate` | Validate plan with critical questions |
|
|
72
|
+
| `/ck-spec-tasks` | Break plan into actionable tasks |
|
|
72
73
|
| `/ck-cook` | Implement plan |
|
|
73
74
|
| `/ck-test` | Run tests and analyze results |
|
|
74
75
|
| `/ck-fix` | Analyze and fix issues |
|
|
@@ -257,4 +257,5 @@ Success criteria must be:
|
|
|
257
257
|
| `/ck-spec-clarify` | Ask clarification questions | Spec has [NEEDS CLARIFICATION] markers or vague requirements |
|
|
258
258
|
| `/ck-spec-plan` | Generate implementation plan | Spec is complete and ready for technical planning |
|
|
259
259
|
| `/ck-spec-constitution` | Create project principles | Need to establish non-negotiable rules before planning |
|
|
260
|
+
| `/ck-plan` | Create implementation plan | Spec is finalized, ready to plan and implement |
|
|
260
261
|
| `/ck-brainstorm` | Brainstorm ideas first | Not sure what to build yet |
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: code-review
|
|
3
|
-
description: Review code quality, receive feedback with technical rigor, verify completion claims. Use before PRs, after implementing features, when claiming task completion, for agent reviews.
|
|
3
|
+
description: Review code quality, receive feedback with technical rigor, verify completion claims. Includes edge case scouting for multi-file features. Use before PRs, after implementing features, when claiming task completion, for agent reviews.
|
|
4
4
|
---
|
|
5
5
|
|
|
6
6
|
# Code Review
|
|
@@ -9,13 +9,12 @@ Guide proper code review practices emphasizing technical rigor, evidence-based c
|
|
|
9
9
|
|
|
10
10
|
## Overview
|
|
11
11
|
|
|
12
|
-
|
|
13
|
-
|
|
14
|
-
|
|
15
|
-
|
|
16
|
-
|
|
17
|
-
|
|
18
|
-
Each practice has specific triggers and protocols detailed in reference files.
|
|
12
|
+
| Practice | When | Protocol |
|
|
13
|
+
|----------|------|----------|
|
|
14
|
+
| **Edge Case Scouting** | Before any review on 3+ file features | `/ck-scout` for hidden paths and untested scenarios |
|
|
15
|
+
| **Receiving Feedback** | Feedback from human or agent | READ → UNDERSTAND → VERIFY → EVALUATE → RESPOND → IMPLEMENT |
|
|
16
|
+
| **Requesting Reviews** | After each task, before merge, after major features | Delegate to `code-reviewer` agent |
|
|
17
|
+
| **Verification Gates** | Before any completion claim | Run command, read output, then claim |
|
|
19
18
|
|
|
20
19
|
## Core Principle
|
|
21
20
|
|
|
@@ -26,6 +25,15 @@ Always honoring **YAGNI**, **KISS**, and **DRY** principles.
|
|
|
26
25
|
|
|
27
26
|
## When to Use This Skill
|
|
28
27
|
|
|
28
|
+
### Edge Case Scouting
|
|
29
|
+
Trigger when:
|
|
30
|
+
- Feature touches 3+ files
|
|
31
|
+
- Implementing complex business logic
|
|
32
|
+
- Before requesting formal code review
|
|
33
|
+
- After implementation, before testing
|
|
34
|
+
|
|
35
|
+
**Reference:** `references/requesting-code-review.md`
|
|
36
|
+
|
|
29
37
|
### Receiving Feedback
|
|
30
38
|
Trigger when:
|
|
31
39
|
- Receiving code review comments from any source
|
|
@@ -61,35 +69,74 @@ Trigger when:
|
|
|
61
69
|
```
|
|
62
70
|
SITUATION?
|
|
63
71
|
│
|
|
72
|
+
├─ Multi-file feature (3+ files)?
|
|
73
|
+
│ └─ Run edge case scouting first → /ck-scout then request review
|
|
74
|
+
│
|
|
64
75
|
├─ Received feedback
|
|
65
76
|
│ ├─ Unclear items? → STOP, ask for clarification first
|
|
66
77
|
│ ├─ From human partner? → Understand, then implement
|
|
67
78
|
│ └─ From external reviewer? → Verify technically before implementing
|
|
68
79
|
│
|
|
69
80
|
├─ Completed work
|
|
70
|
-
│ ├─ Major feature/task? → Request code-reviewer agent review
|
|
71
|
-
│ └─ Before merge? → Request code-reviewer agent review
|
|
81
|
+
│ ├─ Major feature/task? → Request `code-reviewer` agent review
|
|
82
|
+
│ └─ Before merge? → Request `code-reviewer` agent review
|
|
72
83
|
│
|
|
73
84
|
└─ About to claim status
|
|
74
85
|
├─ Have fresh verification? → State claim WITH evidence
|
|
75
86
|
└─ No fresh verification? → RUN verification command first
|
|
76
87
|
```
|
|
77
88
|
|
|
89
|
+
## Edge Case Scouting
|
|
90
|
+
|
|
91
|
+
### When to Scout
|
|
92
|
+
Before formal review of any multi-file feature (3+ files changed).
|
|
93
|
+
|
|
94
|
+
### Process
|
|
95
|
+
1. Use `/ck-scout` to search for hidden code paths, edge inputs, error branches
|
|
96
|
+
2. Document untested scenarios found
|
|
97
|
+
3. Add tests or guards for critical edge cases
|
|
98
|
+
4. Then proceed to formal `code-reviewer` review
|
|
99
|
+
|
|
100
|
+
### What to Look For
|
|
101
|
+
- Null/undefined paths not covered by tests
|
|
102
|
+
- Error branches lacking handlers
|
|
103
|
+
- Boundary conditions (empty arrays, max values, concurrent calls)
|
|
104
|
+
- Async race conditions
|
|
105
|
+
- Permission/auth edge cases
|
|
106
|
+
|
|
107
|
+
## Task-Managed Review Pipeline (Multi-File Features)
|
|
108
|
+
|
|
109
|
+
For features spanning 3+ files, use a structured pipeline:
|
|
110
|
+
|
|
111
|
+
```
|
|
112
|
+
scout → review → fix → verify
|
|
113
|
+
```
|
|
114
|
+
|
|
115
|
+
**Steps:**
|
|
116
|
+
1. **Scout** - Use `/ck-scout` or `/ck-scout ext` to identify edge cases and gaps
|
|
117
|
+
2. **Review** - Delegate to `code-reviewer` agent with full context
|
|
118
|
+
3. **Fix** - Implement critical and important feedback
|
|
119
|
+
4. **Verify** - Run tests, confirm fixes, then claim completion
|
|
120
|
+
|
|
121
|
+
Track progress using a checklist in your plan or task notes:
|
|
122
|
+
```
|
|
123
|
+
- [ ] Edge case scouting complete
|
|
124
|
+
- [ ] `code-reviewer` review complete
|
|
125
|
+
- [ ] Critical issues fixed
|
|
126
|
+
- [ ] Verification passed
|
|
127
|
+
```
|
|
128
|
+
|
|
78
129
|
## Receiving Feedback Protocol
|
|
79
130
|
|
|
80
131
|
### Response Pattern
|
|
81
132
|
READ → UNDERSTAND → VERIFY → EVALUATE → RESPOND → IMPLEMENT
|
|
82
133
|
|
|
83
134
|
### Key Rules
|
|
84
|
-
-
|
|
85
|
-
-
|
|
86
|
-
-
|
|
87
|
-
-
|
|
88
|
-
-
|
|
89
|
-
|
|
90
|
-
### Source Handling
|
|
91
|
-
- **Human partner:** Trusted - implement after understanding, no performative agreement
|
|
92
|
-
- **External reviewers:** Verify technically correct, check for breakage, push back if wrong
|
|
135
|
+
- No performative agreement: "You're absolutely right!", "Great point!", "Thanks for [anything]"
|
|
136
|
+
- No implementation before verification
|
|
137
|
+
- Restate requirement, ask questions, push back with technical reasoning, or just start working
|
|
138
|
+
- If unclear: STOP and ask for clarification on ALL unclear items first
|
|
139
|
+
- YAGNI check: search for usage before implementing suggested "proper" features
|
|
93
140
|
|
|
94
141
|
**Full protocol:** `references/code-review-reception.md`
|
|
95
142
|
|
|
@@ -101,9 +148,10 @@ READ → UNDERSTAND → VERIFY → EVALUATE → RESPOND → IMPLEMENT
|
|
|
101
148
|
- Before merge to main
|
|
102
149
|
|
|
103
150
|
### Process
|
|
104
|
-
1.
|
|
105
|
-
2.
|
|
106
|
-
3.
|
|
151
|
+
1. Scout edge cases (3+ file features): use `/ck-scout` first
|
|
152
|
+
2. Get git SHAs: `BASE_SHA=$(git rev-parse HEAD~1)` and `HEAD_SHA=$(git rev-parse HEAD)`
|
|
153
|
+
3. Delegate to `code-reviewer` agent with: WHAT_WAS_IMPLEMENTED, PLAN_OR_REQUIREMENTS, BASE_SHA, HEAD_SHA, DESCRIPTION
|
|
154
|
+
4. Act on feedback: Fix Critical immediately, Important before proceeding, note Minor for later
|
|
107
155
|
|
|
108
156
|
**Full protocol:** `references/requesting-code-review.md`
|
|
109
157
|
|
|
@@ -130,14 +178,16 @@ Using "should"/"probably"/"seems to", expressing satisfaction before verificatio
|
|
|
130
178
|
|
|
131
179
|
## Integration with Workflows
|
|
132
180
|
|
|
133
|
-
- **Agent-Driven:**
|
|
134
|
-
- **Pull Requests:**
|
|
181
|
+
- **Agent-Driven:** Scout edge cases first (3+ files), review after EACH task, verify before moving to next
|
|
182
|
+
- **Pull Requests:** Scout → verify tests pass → request `code-reviewer` review before merge
|
|
135
183
|
- **General:** Apply verification gates before any status claims, push back on invalid feedback
|
|
184
|
+
- **Pipeline:** For complex features use the full `scout → review → fix → verify` pipeline
|
|
136
185
|
|
|
137
186
|
## Bottom Line
|
|
138
187
|
|
|
139
|
-
1.
|
|
140
|
-
2.
|
|
141
|
-
3.
|
|
188
|
+
1. **Scout first** - Edge cases found before review save rework cycles
|
|
189
|
+
2. Technical rigor over social performance - No performative agreement
|
|
190
|
+
3. Systematic review processes - Use `code-reviewer` agent via pipeline
|
|
191
|
+
4. Evidence before claims - Verification gates always
|
|
142
192
|
|
|
143
|
-
Verify. Question. Then implement. Evidence. Then claim.
|
|
193
|
+
Scout. Verify. Question. Then implement. Evidence. Then claim.
|
|
@@ -15,12 +15,13 @@ End-to-end implementation with automatic workflow detection.
|
|
|
15
15
|
/cook <natural language task OR plan path>
|
|
16
16
|
```
|
|
17
17
|
|
|
18
|
-
**Optional flags:** `--fast`, `--parallel`, `--no-test`, `--auto`
|
|
18
|
+
**Optional flags:** `--fast`, `--parallel`, `--no-test`, `--auto`, `--interactive`
|
|
19
19
|
|
|
20
20
|
Example:
|
|
21
21
|
```
|
|
22
22
|
/cook "Add user authentication to the app" --fast
|
|
23
23
|
/cook path/to/plan.md --auto
|
|
24
|
+
/cook "Fix login bug" --interactive
|
|
24
25
|
```
|
|
25
26
|
|
|
26
27
|
## Smart Intent Detection
|
|
@@ -32,6 +33,7 @@ Example:
|
|
|
32
33
|
| Contains "trust me", "auto" | auto | Auto-approve all steps |
|
|
33
34
|
| Lists 3+ features OR "parallel" | parallel | Multi-agent execution |
|
|
34
35
|
| Contains "no test", "skip test" | no-test | Skip testing step |
|
|
36
|
+
| `--interactive` flag (explicit) | interactive | Full workflow with user input |
|
|
35
37
|
| Default | interactive | Full workflow with user input |
|
|
36
38
|
|
|
37
39
|
See `references/intent-detection.md` for detection logic.
|
|
@@ -71,19 +73,51 @@ Human review required at these checkpoints (skipped with `--auto`):
|
|
|
71
73
|
**Always enforced (all modes):**
|
|
72
74
|
- **Testing:** 100% pass required (unless no-test mode)
|
|
73
75
|
- **Code Review:** User approval OR auto-approve (score≥9.5, 0 critical)
|
|
74
|
-
- **Finalize:**
|
|
76
|
+
- **Finalize:** docs-manager MUST complete
|
|
75
77
|
|
|
76
78
|
## Required Agents
|
|
77
79
|
|
|
78
|
-
| Phase | Agent |
|
|
79
|
-
|
|
80
|
-
| Research | `researcher` (parallel, optional in fast) |
|
|
81
|
-
| Scout | `scout` |
|
|
82
|
-
| Plan | `planner` |
|
|
83
|
-
| UI Work | `ui-ux-designer` |
|
|
84
|
-
| Testing | `tester`, `debugger` |
|
|
85
|
-
| Review | `code-reviewer` |
|
|
86
|
-
| Finalize | `
|
|
80
|
+
| Phase | Agent | Requirement |
|
|
81
|
+
|-------|-------|-------------|
|
|
82
|
+
| Research | `researcher` agent (parallel, optional in fast) | Spawn as needed |
|
|
83
|
+
| Scout | `scout` agent | Spawn for codebase search |
|
|
84
|
+
| Plan | `planner` agent | MUST spawn |
|
|
85
|
+
| UI Work | `ui-ux-designer` agent | Spawn when frontend work exists |
|
|
86
|
+
| Testing | `tester`, `debugger` agents | MUST spawn |
|
|
87
|
+
| Review | `code-reviewer` agent | MUST spawn |
|
|
88
|
+
| Finalize | `docs-manager`, `git-manager` agents | MUST spawn |
|
|
89
|
+
|
|
90
|
+
## Implementation Progress Tracking
|
|
91
|
+
|
|
92
|
+
During Step 3 (Implementation), track progress using a todo list/checklist in the active plan or phase file:
|
|
93
|
+
|
|
94
|
+
```
|
|
95
|
+
- [ ] Phase 1: Setup environment
|
|
96
|
+
- [ ] Phase 2: Database models
|
|
97
|
+
- [ ] Phase 3: API endpoints
|
|
98
|
+
- [ ] Phase 4: UI components
|
|
99
|
+
```
|
|
100
|
+
|
|
101
|
+
Update each item as completed. This replaces task management tooling with simple markdown tracking visible in the plan.
|
|
102
|
+
|
|
103
|
+
## CRITICAL ENFORCEMENT
|
|
104
|
+
|
|
105
|
+
**Steps 4 (Testing), 5 (Code Review), and 6 (Finalize) MUST delegate to agents. DO NOT implement testing, review, or finalization yourself.**
|
|
106
|
+
|
|
107
|
+
- Step 4: Always delegate to `tester` agent. If failures, delegate to `debugger` agent, then re-delegate to `tester`.
|
|
108
|
+
- Step 5: Always delegate to `code-reviewer` agent. Never self-review.
|
|
109
|
+
- Step 6: Always delegate to `docs-manager` agent for doc updates.
|
|
110
|
+
|
|
111
|
+
## Finalize Step (MANDATORY)
|
|
112
|
+
|
|
113
|
+
Step 6 is not optional. All four actions MUST complete:
|
|
114
|
+
|
|
115
|
+
1. Update plan/phase status to completed in plan files
|
|
116
|
+
2. Delegate to `docs-manager` agent → review and update `./docs` if implementation changed APIs, architecture, or behavior
|
|
117
|
+
3. Mark all todo checklist items complete in the active plan
|
|
118
|
+
4. Ask the user: "Would you like to commit these changes via `git-manager` agent?"
|
|
119
|
+
|
|
120
|
+
**Never skip finalize**, even in fast or auto mode.
|
|
87
121
|
|
|
88
122
|
## References
|
|
89
123
|
|