coh-content-db 2.0.0-rc.6 → 2.0.0-rc.7

package/src/test/db/badge.test.ts

@@ -1,4 +1,4 @@
-import { Badge } from '../../main'
+import { Badge, compareByDefaultName, compareByZoneKey } from '../../main'
 import { badgeDataFixture } from '../api/badge-data.fixture'
 import { badgeRequirementDataFixture } from '../api/badge-requirement-data.fixture'
 
@@ -18,8 +18,8 @@ describe(Badge.name, () => {
 
   describe('type', () => {
     test('should be set from the data', () => {
-      const badge = new Badge(badgeDataFixture.create({ type: 'ACHIEVEMENT' }))
-      expect(badge.type).toEqual('ACHIEVEMENT')
+      const badge = new Badge(badgeDataFixture.create({ type: 'achievement' }))
+      expect(badge.type).toEqual('achievement')
     })
   })
 
@@ -30,12 +30,22 @@ describe(Badge.name, () => {
     })
   })
 
-  describe('alignment', () => {
+  describe('morality', () => {
     test('should be set from the data', () => {
-      const badge = new Badge(badgeDataFixture.create({ alignment: ['H', 'V'] }))
-      expect(badge.alignment.hero).toBeTruthy()
-      expect(badge.alignment.villain).toBeTruthy()
-      expect(badge.alignment.praetorian).toBeFalsy()
+      const badge = new Badge(badgeDataFixture.create({ morality: ['hero', 'villain'] }))
+      expect(badge.morality.hero).toBeTruthy()
+      expect(badge.morality.villain).toBeTruthy()
+    })
+
+    test('should accept a single string', () => {
+      const badge = new Badge(badgeDataFixture.create({ morality: 'hero' }))
+      expect(badge.morality.hero).toBeTruthy()
+      expect(badge.morality.villain).toBeFalsy()
+    })
+
+    test('should be optional, defaulting to all', () => {
+      const badge = new Badge(badgeDataFixture.omit('morality').create())
+      expect(badge.morality.all).toBeTruthy()
     })
   })
 
@@ -99,30 +109,6 @@ describe(Badge.name, () => {
     })
   })
 
-  describe('zoneKey', () => {
-    test('should be set from the data', () => {
-      const badge = new Badge(badgeDataFixture.create({ zoneKey: 'foo' }))
-      expect(badge.zoneKey).toEqual('foo')
-    })
-
-    test('should be optional', () => {
-      const badge = new Badge(badgeDataFixture.omit('zoneKey').create())
-      expect(badge.zoneKey).toBeUndefined()
-    })
-  })
-
-  describe('loc', () => {
-    test('should be set from the data', () => {
-      const badge = new Badge(badgeDataFixture.create({ loc: [1, 2, 3] }))
-      expect(badge.loc).toStrictEqual([1, 2, 3])
-    })
-
-    test('should be optional', () => {
-      const badge = new Badge(badgeDataFixture.omit('loc').create())
-      expect(badge.loc).toBeUndefined()
-    })
-  })
-
   describe('effect', () => {
     test('should be set from the data', () => {
       const badge = new Badge(badgeDataFixture.create({ effect: 'foo' }))
@@ -135,27 +121,20 @@ describe(Badge.name, () => {
     })
   })
 
-  describe('vidiotMapKey', () => {
+  describe('setTitle', () => {
     test('should be set from the data', () => {
-      const badge = new Badge(badgeDataFixture.create({ vidiotMapKey: 'foo' }))
-      expect(badge.vidiotMapKey).toEqual('foo')
+      const badge = new Badge(badgeDataFixture.create({ setTitleId: [123, 456] }))
+      expect(badge.setTitleId).toStrictEqual([123, 456])
     })
 
-    test('should be optional', () => {
-      const badge = new Badge(badgeDataFixture.omit('vidiotMapKey').create())
-      expect(badge.vidiotMapKey).toBeUndefined()
-    })
-  })
-
-  describe('setTitle', () => {
-    test('should be set from the data', () => {
-      const badge = new Badge(badgeDataFixture.create({ setTitle: { id: 123, praetorianId: 456 } }))
-      expect(badge.setTitle).toStrictEqual({ id: 123, praetorianId: 456 })
+    test('should treat the praetorian id as optional', () => {
+      const badge = new Badge(badgeDataFixture.create({ setTitleId: [123] }))
+      expect(badge.setTitleId).toStrictEqual([123])
     })
 
     test('should be optional', () => {
-      const badge = new Badge(badgeDataFixture.omit('setTitle').create())
-      expect(badge.setTitle).toBeUndefined()
+      const badge = new Badge(badgeDataFixture.omit('setTitleId').create())
+      expect(badge.setTitleId).toBeUndefined()
     })
   })
 
@@ -172,34 +151,22 @@ describe(Badge.name, () => {
   })
 
   describe('requirements', () => {
-    test(`should throw an error on duplicate key in same group`, () => {
+    test(`should throw an error on duplicate key`, () => {
       const data = badgeDataFixture.create({
         key: 'badge',
-        requirements: [[
+        requirements: [
           badgeRequirementDataFixture.create({ key: 'foo' }),
           badgeRequirementDataFixture.create({ key: 'foo' }),
-        ]],
+        ],
       })
-      expect(() => new Badge(data)).toThrow('Duplicate badge requirement key [badge:foo] in group [1]')
-    })
-
-    test(`should not throw an error on duplicate key in different group`, () => {
-      const data = badgeDataFixture.create({
-        key: 'badge',
-        requirements: [[
-          badgeRequirementDataFixture.create({ key: 'foo' }),
-        ], [
-          badgeRequirementDataFixture.create({ key: 'foo' }),
-        ]],
-      })
-      new Badge(data)
+      expect(() => new Badge(data)).toThrow('Duplicate badge requirement key [badge:foo]')
     })
   })
 
   describe('getRequirement', () => {
     test(`should retrieve requirement from the index`, () => {
       const data = badgeDataFixture.create({
-        requirements: [[badgeRequirementDataFixture.create({ key: 'foo' })]],
+        requirements: [badgeRequirementDataFixture.create({ key: 'foo' })],
       })
 
       expect(new Badge(data).getRequirement('foo')).not.toBeUndefined()
@@ -213,4 +180,158 @@ describe(Badge.name, () => {
       expect(() => new Badge(data).getRequirement('foo')).toThrow('Unknown badge requirement key [foo]')
     })
   })
+
+  describe('zoneKeys', () => {
+    test(`should return the list of keys`, () => {
+      const badge = new Badge(badgeDataFixture.create({
+        requirements: [
+          badgeRequirementDataFixture.create({ location: { zoneKey: 'a' } }),
+          badgeRequirementDataFixture.create({ location: { zoneKey: 'c' } }),
+          badgeRequirementDataFixture.create({ location: { zoneKey: 'b' } }),
+          badgeRequirementDataFixture.create({ location: { zoneKey: 'c' } }),
+        ],
+      }))
+      expect(badge.zoneKeys).toStrictEqual(['a', 'c', 'b'])
+    })
+
+    test(`should return undefined if there no zones`, () => {
+      const badge = new Badge(badgeDataFixture.create({
+        requirements: [
+          badgeRequirementDataFixture.omit('location').create(),
+        ],
+      }))
+      expect(badge.zoneKey).toBeUndefined()
+    })
+
+    test(`should ignore requirements with no location`, () => {
+      const badge = new Badge(badgeDataFixture.create({
+        requirements: [
+          badgeRequirementDataFixture.create({ location: { zoneKey: 'a' } }),
+          badgeRequirementDataFixture.create({ location: { zoneKey: 'c' } }),
+          badgeRequirementDataFixture.omit('location').create(),
+          badgeRequirementDataFixture.create({ location: { zoneKey: 'c' } }),
+        ],
+      }))
+      expect(badge.zoneKeys).toStrictEqual(['a', 'c'])
+    })
+  })
+
+  describe('zoneKey', () => {
+    test(`should return the key for a single zone`, () => {
+      const badge = new Badge(badgeDataFixture.create({
+        requirements: [
+          badgeRequirementDataFixture.create({ location: { zoneKey: 'a' } }),
+        ],
+      }))
+      expect(badge.zoneKey).toBe('a')
+    })
+
+    test(`should return undefined if there no zones`, () => {
+      const badge = new Badge(badgeDataFixture.create({
+        requirements: [
+          badgeRequirementDataFixture.omit('location').create(),
+        ],
+      }))
+      expect(badge.zoneKey).toBeUndefined()
+    })
+
+    test(`should return undefined if there are multiple zones`, () => {
+      const badge = new Badge(badgeDataFixture.create({
+        requirements: [
+          badgeRequirementDataFixture.create({ location: { zoneKey: 'a' } }),
+          badgeRequirementDataFixture.create({ location: { zoneKey: 'c' } }),
+        ],
+      }))
+      expect(badge.zoneKey).toBeUndefined()
+    })
+  })
+
+  describe(compareByDefaultName.name, () => {
+    test(`should compare two badges by name`, () => {
+      const badgeA = new Badge(badgeDataFixture.create({ name: 'A' }))
+      const badgeB = new Badge(badgeDataFixture.create({ name: 'B' }))
+      expect(compareByDefaultName(badgeA, badgeB)).toBeLessThan(0)
+      expect([badgeB, badgeA].sort(compareByDefaultName)).toStrictEqual([badgeA, badgeB])
+    })
+
+    test(`should return 0 for equal names`, () => {
+      const badgeA = new Badge(badgeDataFixture.create({ name: 'A' }))
+      const badgeB = new Badge(badgeDataFixture.create({ name: 'A' }))
+      expect(compareByDefaultName(badgeA, badgeB)).toEqual(0)
+    })
+
+    test(`should compare two undefined values`, () => {
+      const badgeA = new Badge(badgeDataFixture.create({ name: [] }))
+      const badgeB = new Badge(badgeDataFixture.create({ name: [] }))
+      expect(compareByDefaultName(badgeA, badgeB)).toEqual(0)
+    })
+
+    test(`should sort undefined values last`, () => {
+      const badgeA = new Badge(badgeDataFixture.create({ name: 'A' }))
+      const badgeB = new Badge(badgeDataFixture.create({ name: [] }))
+      expect([badgeA, badgeB].sort(compareByDefaultName)).toStrictEqual([badgeA, badgeB])
+      expect([badgeB, badgeA].sort(compareByDefaultName)).toStrictEqual([badgeA, badgeB])
+    })
+  })
+
+  describe(compareByZoneKey.name, () => {
+    test(`should compare two badges by zoneKey`, () => {
+      const badgeA = new Badge(badgeDataFixture.create({
+        requirements: [
+          badgeRequirementDataFixture.create({ location: { zoneKey: 'a' } }),
+        ],
+      }))
+      const badgeB = new Badge(badgeDataFixture.create({
+        requirements: [
+          badgeRequirementDataFixture.create({ location: { zoneKey: 'b' } }),
+        ],
+      }))
+      expect(compareByZoneKey(badgeA, badgeB)).toBeLessThan(0)
+      expect([badgeB, badgeA].sort(compareByZoneKey)).toStrictEqual([badgeA, badgeB])
+    })
+
+    test(`should return 0 for equal zoneKeys`, () => {
+      const badgeA = new Badge(badgeDataFixture.create({
+        requirements: [
+          badgeRequirementDataFixture.create({ location: { zoneKey: 'a' } }),
+        ],
+      }))
+      const badgeB = new Badge(badgeDataFixture.create({
+        requirements: [
+          badgeRequirementDataFixture.create({ location: { zoneKey: 'a' } }),
+        ],
+      }))
+      expect(compareByZoneKey(badgeA, badgeB)).toEqual(0)
+    })
+
+    test(`should equate two undefined values`, () => {
+      const badgeA = new Badge(badgeDataFixture.create({
+        requirements: [
+          badgeRequirementDataFixture.omit('location').create(),
+        ],
+      }))
+      const badgeB = new Badge(badgeDataFixture.create({
+        requirements: [
+          badgeRequirementDataFixture.omit('location').create(),
+        ],
+      }))
+      expect(compareByZoneKey(badgeA, badgeB)).toEqual(0)
+    })
+
+    test(`should sort badges with multiple values last`, () => {
+      const badgeA = new Badge(badgeDataFixture.create({
+        requirements: [
+          badgeRequirementDataFixture.create({ location: { zoneKey: 'a' } }),
+        ],
+      }))
+      const badgeB = new Badge(badgeDataFixture.create({
+        requirements: [
+          badgeRequirementDataFixture.create({ location: { zoneKey: 'b' } }),
+          badgeRequirementDataFixture.create({ location: { zoneKey: 'c' } }),
+        ],
+      }))
+      expect([badgeA, badgeB].sort(compareByZoneKey)).toStrictEqual([badgeA, badgeB])
+      expect([badgeB, badgeA].sort(compareByZoneKey)).toStrictEqual([badgeA, badgeB])
+    })
+  })
 })

package/src/test/db/coh-content-database.test.ts

@@ -4,6 +4,7 @@ import { archetypeDataFixture } from '../api/archetype-data.fixture'
 import { badgeDataFixture } from '../api/badge-data.fixture'
 import { zoneDataFixture } from '../api/zone-data.fixture'
 import { contactDataFixture } from '../api/contact-data.fixture'
+import { missionDataFixture } from '../api/mission-data.fixture'
 
 describe(CohContentDatabase.name, () => {
   test('should load a basic bundle', () => {
@@ -15,7 +16,7 @@ describe(CohContentDatabase.name, () => {
       const data = contentBundleFixture
         .omit('servers')
         .create()
-      expect(() => new CohContentDatabase(data).archetypes).toHaveLength(0)
+      expect(new CohContentDatabase(data).servers).toHaveLength(0)
     })
 
     test(`should load values from bundle`, () => {
@@ -40,13 +41,13 @@ describe(CohContentDatabase.name, () => {
       const data = contentBundleFixture
         .omit('archetypes')
         .create()
-      expect(() => new CohContentDatabase(data).archetypes).toHaveLength(0)
+      expect(new CohContentDatabase(data).archetypes).toHaveLength(0)
     })
 
     test(`should load data from bundle`, () => {
       const data = contentBundleFixture
         .create({ archetypes: [archetypeDataFixture.create({ key: 'foo' })] })
-      expect(() => new CohContentDatabase(data).getArchetype('foo')).not.toBeUndefined()
+      expect(new CohContentDatabase(data).getArchetype('foo')).not.toBeUndefined()
     })
   })
 
@@ -65,7 +66,7 @@ describe(CohContentDatabase.name, () => {
       const data = contentBundleFixture
         .omit('badges')
         .create()
-      expect(() => new CohContentDatabase(data).badges).toHaveLength(0)
+      expect(new CohContentDatabase(data).badges).toHaveLength(0)
     })
   })
 
@@ -84,7 +85,7 @@ describe(CohContentDatabase.name, () => {
       const data = contentBundleFixture
         .omit('zones')
         .create()
-      expect(() => new CohContentDatabase(data).zones).toHaveLength(0)
+      expect(new CohContentDatabase(data).zones).toHaveLength(0)
     })
   })
 
@@ -103,7 +104,26 @@ describe(CohContentDatabase.name, () => {
       const data = contentBundleFixture
         .omit('contacts')
         .create()
-      expect(() => new CohContentDatabase(data).contacts).toHaveLength(0)
+      expect(new CohContentDatabase(data).contacts).toHaveLength(0)
+    })
+  })
+
+  describe('missions', () => {
+    test(`should throw an error on duplicate mission`, () => {
+      const data = contentBundleFixture.create({
+        missions: [
+          missionDataFixture.create({ key: 'foo' }),
+          missionDataFixture.create({ key: 'foo' }),
+        ],
+      })
+      expect(() => new CohContentDatabase(data)).toThrow(`Duplicate mission key 'foo'`)
+    })
+
+    test(`should accept an undefined field`, () => {
+      const data = contentBundleFixture
+        .omit('missions')
+        .create()
+      expect(new CohContentDatabase(data).missions).toHaveLength(0)
     })
   })
 
@@ -116,12 +136,13 @@ describe(CohContentDatabase.name, () => {
       expect(new CohContentDatabase(data).getArchetype('foo')).not.toBeUndefined()
     })
 
-    test(`should throw error for unknown archetype`, () => {
-      const data = contentBundleFixture.create({
-        archetypes: [],
-      })
+    test(`should return undefined for unknown archetype`, () => {
+      const data = contentBundleFixture.create({ archetypes: [] })
+      expect(new CohContentDatabase(data).getArchetype('foo')).toBeUndefined()
+    })
 
-      expect(() => new CohContentDatabase(data).getArchetype('foo')).toThrow(`Unknown archetype key 'foo'`)
+    test(`should return undefined for undefined key`, () => {
+      expect(new CohContentDatabase(contentBundleFixture.create({ archetypes: [] })).getArchetype()).toBeUndefined()
     })
   })
 
@@ -134,30 +155,13 @@ describe(CohContentDatabase.name, () => {
       expect(new CohContentDatabase(data).getZone('foo')).not.toBeUndefined()
     })
 
-    test(`should throw error for unknown zone`, () => {
-      const data = contentBundleFixture.create({
-        zones: [],
-      })
-
-      expect(() => new CohContentDatabase(data).getZone('foo')).toThrow(`Unknown zone key 'foo'`)
-    })
-  })
-
-  describe('zoneExists', () => {
-    test(`should return true for a zone that exists`, () => {
-      const data = contentBundleFixture.create({
-        zones: [zoneDataFixture.create({ key: 'foo' })],
-      })
-
-      expect(new CohContentDatabase(data).zoneExists('foo')).toBeTruthy()
+    test(`should return undefined for unknown zone`, () => {
+      const data = contentBundleFixture.create({ zones: [] })
+      expect(new CohContentDatabase(data).getZone('foo')).toBeUndefined()
     })
 
-    test(`should return false for a zone that does not exist`, () => {
-      const data = contentBundleFixture.create({
-        zones: [],
-      })
-
-      expect(new CohContentDatabase(data).zoneExists('foo')).toBeFalsy()
+    test(`should return undefined for undefined key`, () => {
+      expect(new CohContentDatabase(contentBundleFixture.create({ zones: [] })).getZone()).toBeUndefined()
     })
   })
 
@@ -170,30 +174,32 @@ describe(CohContentDatabase.name, () => {
       expect(new CohContentDatabase(data).getContact('foo')).not.toBeUndefined()
     })
 
-    test(`should throw error for unknown contact`, () => {
-      const data = contentBundleFixture.create({
-        contacts: [],
-      })
+    test(`should return undefined for unknown contact`, () => {
+      const data = contentBundleFixture.create({ contacts: [] })
+      expect(new CohContentDatabase(data).getContact('foo')).toBeUndefined()
+    })
 
-      expect(() => new CohContentDatabase(data).getContact('foo')).toThrow(`Unknown contact key 'foo'`)
+    test(`should return undefined for undefined key`, () => {
+      expect(new CohContentDatabase(contentBundleFixture.create({ contacts: [] })).getContact()).toBeUndefined()
     })
   })
 
-  describe('contactExists', () => {
-    test(`should return true for a contact that exists`, () => {
+  describe('getMission', () => {
+    test(`should retrieve mission from the index`, () => {
       const data = contentBundleFixture.create({
-        contacts: [contactDataFixture.create({ key: 'foo' })],
+        missions: [missionDataFixture.create({ key: 'foo' })],
       })
 
-      expect(new CohContentDatabase(data).contactExists('foo')).toBeTruthy()
+      expect(new CohContentDatabase(data).getMission('foo')).not.toBeUndefined()
     })
 
-    test(`should return false for a contact that does not exist`, () => {
-      const data = contentBundleFixture.create({
-        contacts: [],
-      })
+    test(`should return undefined for unknown mission`, () => {
+      const data = contentBundleFixture.create({ missions: [] })
+      expect(new CohContentDatabase(data).getMission('foo')).toBeUndefined()
+    })
 
-      expect(new CohContentDatabase(data).contactExists('foo')).toBeFalsy()
+    test(`should return undefined for undefined key`, () => {
+      expect(new CohContentDatabase(contentBundleFixture.create({ missions: [] })).getMission()).toBeUndefined()
     })
   })
 
@@ -206,30 +212,13 @@ describe(CohContentDatabase.name, () => {
       expect(new CohContentDatabase(data).getBadge('foo')).not.toBeUndefined()
     })
 
-    test(`should throw error for unknown badge`, () => {
-      const data = contentBundleFixture.create({
-        badges: [],
-      })
-
-      expect(() => new CohContentDatabase(data).getBadge('foo')).toThrow('Unknown badge key [foo]')
-    })
-  })
-
-  describe('badgeExists', () => {
-    test(`should return true for a badge that exists`, () => {
-      const data = contentBundleFixture.create({
-        badges: [badgeDataFixture.create({ key: 'foo' })],
-      })
-
-      expect(new CohContentDatabase(data).badgeExists('foo')).toBeTruthy()
+    test(`should return undefined for unknown badge`, () => {
+      const data = contentBundleFixture.create({ badges: [] })
+      expect(new CohContentDatabase(data).getBadge('foo')).toBeUndefined()
     })
 
-    test(`should return false for a badge that does not exist`, () => {
-      const data = contentBundleFixture.create({
-        badges: [],
-      })
-
-      expect(new CohContentDatabase(data).badgeExists('foo')).toBeFalsy()
+    test(`should return undefined for undefined key`, () => {
+      expect(new CohContentDatabase(contentBundleFixture.create({ badges: [] })).getBadge()).toBeUndefined()
     })
   })
 

package/src/test/db/contact.test.ts

@@ -9,86 +9,87 @@ describe(Contact.name, () => {
   })
 
   describe('key', () => {
-    test(`should should be set from the data`, () => {
+    test(`should be set from the data`, () => {
       const contact = new Contact(contactDataFixture.create({ key: 'foo' }))
       expect(contact.key).toEqual('foo')
     })
   })
 
   describe('name', () => {
-    test(`should should be set from the data`, () => {
+    test(`should be set from the data`, () => {
       const contact = new Contact(contactDataFixture.create({ name: 'foo' }))
       expect(contact.name).toEqual('foo')
     })
   })
 
   describe('title', () => {
-    test(`should should be set from the data`, () => {
+    test(`should be set from the data`, () => {
       const contact = new Contact(contactDataFixture.create({ title: 'foo' }))
       expect(contact.title).toEqual('foo')
     })
 
-    test(`should should be optional`, () => {
+    test(`should be optional`, () => {
       const contact = new Contact(contactDataFixture.omit('title').create())
       expect(contact.title).toBeUndefined()
     })
   })
 
-  describe('zoneKey', () => {
-    test(`should should be set from the data`, () => {
-      const contact = new Contact(contactDataFixture.create({ zoneKey: 'foo' }))
-      expect(contact.zoneKey).toEqual('foo')
+  describe('morality', () => {
+    test(`should be set from the data`, () => {
+      const contact = new Contact(contactDataFixture.create({ morality: ['hero'] }))
+      expect(contact.morality?.hero).toBeTruthy()
+      expect(contact.morality?.vigilante).toBeFalsy()
     })
 
-    test(`should should be optional`, () => {
-      const contact = new Contact(contactDataFixture.omit('zoneKey').create())
-      expect(contact.zoneKey).toBeUndefined()
+    test(`should be optional`, () => {
+      const contact = new Contact(contactDataFixture.omit('morality').create())
+      expect(contact.morality?.all).toBeTruthy()
     })
   })
 
-  describe('loc', () => {
-    test(`should should be set from the data`, () => {
-      const contact = new Contact(contactDataFixture.create({ loc: [1, 2, 3] }))
-      expect(contact.loc).toStrictEqual([1, 2, 3])
+  describe('zoneKey', () => {
+    test(`should be set from the data`, () => {
+      const contact = new Contact(contactDataFixture.create({ location: { zoneKey: 'atlas-park', coords: [1, -2, 3.5] } }))
+      expect(contact.location).toEqual({ zoneKey: 'atlas-park', coords: [1, -2, 3.5] })
     })
 
-    test(`should should be optional`, () => {
-      const contact = new Contact(contactDataFixture.omit('loc').create())
-      expect(contact.loc).toBeUndefined()
+    test(`should be optional`, () => {
+      const contact = new Contact(contactDataFixture.omit('location').create())
+      expect(contact.location).toBeUndefined()
     })
   })
 
   describe('levelRange', () => {
-    test(`should should be set from the data`, () => {
+    test(`should be set from the data`, () => {
       const contact = new Contact(contactDataFixture.create({ levelRange: [1, 2] }))
       expect(contact.levelRange).toStrictEqual([1, 2])
     })
 
-    test(`should should be optional`, () => {
+    test(`should be optional`, () => {
       const contact = new Contact(contactDataFixture.omit('levelRange').create())
       expect(contact.levelRange).toBeUndefined()
     })
   })
 
   describe('notes', () => {
-    test(`should should be set from the data`, () => {
+    test(`should be set from the data`, () => {
       const contact = new Contact(contactDataFixture.create({ notes: 'foo' }))
       expect(contact.notes).toEqual('foo')
     })
 
-    test(`should should be optional`, () => {
+    test(`should be optional`, () => {
       const contact = new Contact(contactDataFixture.omit('notes').create())
       expect(contact.notes).toBeUndefined()
     })
   })
 
   describe('links', () => {
-    test(`should should be set from the data`, () => {
+    test(`should be set from the data`, () => {
       const contact = new Contact(contactDataFixture.create({ links: [{ title: 'foo', href: 'bar' }] }))
       expect(contact.links).toStrictEqual([{ title: 'foo', href: 'bar' }])
     })
 
-    test(`should should be optional`, () => {
+    test(`should be optional`, () => {
       const contact = new Contact(contactDataFixture.omit('links').create())
       expect(contact.links).toHaveLength(0)
     })