cognitive-core 0.2.3 → 0.2.5

package/tests/surfacing/skill-publisher.test.ts

@@ -77,10 +77,73 @@ describe('SkillPublisher', () => {
       const playbook = createSamplePlaybook();
       const skill = convertPlaybookToSkill(playbook);
 
-      expect(skill.description).toBe('TypeScript import fails with TS2307');
+      expect(skill.description).toContain('TypeScript import fails with TS2307');
       expect(skill.instructions).toContain('TypeScript import fails with TS2307');
     });
 
+    it('should surface trigger phrases inline in description for lightweight matching', () => {
+      const playbook = createSamplePlaybook();
+      const skill = convertPlaybookToSkill(playbook);
+
+      // Lead situation still present.
+      expect(skill.description).toContain('TypeScript import fails with TS2307');
+      // Explicit "Use when" clause listing each trigger phrase, quoted.
+      expect(skill.description).toContain('Use when');
+      expect(skill.description).toContain('"TS2307"');
+      expect(skill.description).toContain('"Cannot find module"');
+    });
+
+    it('should omit trigger clause when no triggers are declared', () => {
+      const playbook = createSamplePlaybook({
+        applicability: {
+          situations: ['Some situation'],
+          triggers: [],
+          antiPatterns: [],
+          domains: [],
+        },
+      });
+      const skill = convertPlaybookToSkill(playbook);
+
+      expect(skill.description).toBe('Some situation.');
+      expect(skill.description).not.toContain('Use when');
+    });
+
+    it('should cap description at 1024 chars', () => {
+      const playbook = createSamplePlaybook({
+        applicability: {
+          situations: ['X'.repeat(500)],
+          // Many long triggers would push past 1024 chars combined.
+          triggers: Array.from({ length: 20 }, (_, i) => 'trigger-phrase-' + 'y'.repeat(50) + `-${i}`),
+          antiPatterns: [],
+          domains: [],
+        },
+      });
+      const skill = convertPlaybookToSkill(playbook);
+
+      expect(skill.description.length).toBeLessThanOrEqual(1024);
+      expect(skill.description).toMatch(/\.\.\.$/);
+    });
+
+    it('should use provenance.curatedBy as author when set', () => {
+      const playbook = createSamplePlaybook({
+        provenance: {
+          origin: 'curated',
+          curatedBy: 'swarmkit-skills',
+          recordedAt: new Date(),
+        },
+      });
+      const skill = convertPlaybookToSkill(playbook);
+
+      expect(skill.author).toBe('swarmkit-skills');
+    });
+
+    it('should fall back to cognitive-core as author when provenance.curatedBy is absent', () => {
+      const playbook = createSamplePlaybook();
+      const skill = convertPlaybookToSkill(playbook);
+
+      expect(skill.author).toBe('cognitive-core');
+    });
+
     it('should build instructions from strategy, tactics, and steps', () => {
       const playbook = createSamplePlaybook();
       const skill = convertPlaybookToSkill(playbook);
@@ -92,27 +155,31 @@ describe('SkillPublisher', () => {
       expect(skill.instructions).toContain('Verify with tsc --noEmit');
     });
 
-    it('should include verification and notes in instructions', () => {
+    it('should include structured verification, when-to-use, and when-not-to-use sections', () => {
       const playbook = createSamplePlaybook();
       const skill = convertPlaybookToSkill(playbook);
 
-      expect(skill.instructions).toContain('Build passes');
-      expect(skill.instructions).toContain('Do NOT use when:');
-      expect(skill.instructions).toContain('Watch for:');
-      expect(skill.instructions).toContain('Refinements:');
+      // Verification indicators rendered as bulleted lists
+      expect(skill.instructions).toContain('Success:\n- Build passes');
+      expect(skill.instructions).toContain('Failure:\n- Same error persists');
       expect(skill.instructions).toContain('Rollback:');
-    });
 
-    it('should compute metrics from evolution data', () => {
-      const playbook = createSamplePlaybook();
-      const skill = convertPlaybookToSkill(playbook);
+      // Anti-patterns now live in their own section, not in Notes
+      expect(skill.instructions).toContain('## When not to use');
+      expect(skill.instructions).toContain('- Module genuinely does not exist');
+
+      // Situations get their own section
+      expect(skill.instructions).toContain('## When to use');
+      expect(skill.instructions).toContain('- TypeScript import fails with TS2307');
 
-      expect(skill.metrics.usageCount).toBe(10); // 8 + 2
-      expect(skill.metrics.successRate).toBe(0.8); // 8/10
-      expect(skill.metrics.averageConfidence).toBe(0.85);
-      expect(skill.metrics.lastUsed).toBeDefined();
+      // Refinements remain in Notes
+      expect(skill.instructions).toContain('Refinements:');
     });
 
+    // skill-tree >= 0.2 dropped Skill.metrics — usage data lives on
+    // playbook.evolution.* in cognitive-core. The publisher no longer
+    // emits a metrics snapshot. See SKILL_TREE_METRICS_DEPRECATION plan.
+
     it('should include code example in instructions', () => {
       const playbook = createSamplePlaybook();
       const skill = convertPlaybookToSkill(playbook);
@@ -277,12 +344,12 @@ describe('SkillPublisher', () => {
       expect(result.error).toContain('not found');
     });
 
-    it('should preserve existing notes when deprecating', async () => {
+    it('should preserve existing content when deprecating', async () => {
       const publisher = new SkillPublisher(storage);
       await publisher.publishPlaybook(createSamplePlaybook({ id: 'notes-1' }));
 
       const before = await storage.getSkill('notes-1');
-      expect(before!.instructions).toContain('Do NOT use when:');
+      expect(before!.instructions).toContain('## When not to use');
 
       await publisher.deprecateSkill('notes-1', 'Superseded');
 
@@ -357,8 +424,9 @@ describe('SkillPublisher', () => {
 
       skill = await storage.getSkill('evolve-1');
       expect(skill!.version).toBe('2.0.0');
-      expect(skill!.metrics.usageCount).toBe(22);
-      expect(skill!.metrics.averageConfidence).toBe(0.95);
+      // Live evolution data (usageCount, confidence) stays on the
+      // playbook in cognitive-core; the published Skill no longer
+      // carries metrics snapshots.
     });
   });
 });

package/tests/surfacing/sqlite-storage-adapter.test.ts

@@ -16,13 +16,6 @@ function createSampleSkill(overrides?: Partial<Skill>): Skill {
     author: 'cognitive-core',
     status: 'active',
     tags: ['typescript', 'nodejs'],
-    metrics: {
-      usageCount: 8,
-      successRate: 0.9,
-      lastUsed: now,
-      feedbackScores: [],
-      averageConfidence: 0.85,
-    },
     source: {
       type: 'extracted',
       sessionId: 'session-abc',
@@ -126,8 +119,6 @@ describe('SqliteStorageAdapter', () => {
 
     const retrieved = await adapter.getSkill('skill-json');
     expect(retrieved!.tags).toEqual(['typescript', 'nodejs']);
-    expect(retrieved!.metrics.usageCount).toBe(8);
-    expect(retrieved!.metrics.successRate).toBe(0.9);
     expect(retrieved!.source!.type).toBe('extracted');
     expect(retrieved!.serving!.tokenEstimate).toBe(150);
   });