codingpixel-expo-app 0.1.3 → 0.1.5

package/dist/index.js

@@ -22,6 +22,7 @@ import { buildLayoutReplacements } from "./fonts.js";
 import { ensureLockfile, installNativeDeps } from "./install.js";
 import { log } from "./util.js";
 import { readSDKNotes } from "./sdkNotes.js";
+import { SDK_PROBE_RESULTS } from "./sdkProbeResults.js";
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = path.dirname(__filename);
 /**
@@ -33,7 +34,9 @@ function resolveTemplatesRoot() {
     return path.resolve(__dirname, "..", "templates");
 }
 /**
- * Locate `docs/SDK_NOTES.md`. Same layout assumption as `resolveTemplatesRoot`.
+ * Locate `docs/SDK_NOTES.md` for OPTIONAL out-of-tree dev runs (when the CLI
+ * is invoked from its own source tree with fresh probe results). Production
+ * runs from a published tarball read from `SDK_PROBE_RESULTS` instead.
  */
 function resolveSdkNotesPath() {
     return path.resolve(__dirname, "..", "docs", "SDK_NOTES.md");
@@ -69,15 +72,21 @@ async function main() {
     log.step("Splicing constants + layout sentinels …");
     patchConstants(target.dir, templatesRoot, answers);
     patchLayout(target.dir, buildLayoutReplacements(answers));
-    // ---- Read SDK_NOTES.md probe outcomes ----
+    // ---- Resolve probe outcomes ----
+    // Primary: baked-in `SDK_PROBE_RESULTS` (always available; ships in dist/).
+    // Override: `docs/SDK_NOTES.md` if present in the CLI source tree (out-of-tree
+    // development scenarios where probe was just re-run against a newer SDK).
     const sdk = readSDKNotes(resolveSdkNotesPath());
-    const flagsOk = sdk.get("FLAGS_OK") === "1";
-    const probePass = sdk.get("PROBE_PASS") === "1";
-    const workletsAutoIncluded = sdk.get("BABEL_PRESET_AUTO_INCLUDES_WORKLETS") === "1";
-    const workletsPkg = sdk.get("WORKLETS_PKG") === "react-native-worklets-core"
+    const get = (key, fallback) => sdk.get(key) ?? fallback;
+    const flagsOk = get("FLAGS_OK", SDK_PROBE_RESULTS.FLAGS_OK ? "1" : "0") === "1";
+    const probePass = get("PROBE_PASS", SDK_PROBE_RESULTS.PROBE_PASS ? "1" : "0") === "1";
+    const workletsAutoIncluded = get("BABEL_PRESET_AUTO_INCLUDES_WORKLETS", SDK_PROBE_RESULTS.BABEL_PRESET_AUTO_INCLUDES_WORKLETS ? "1" : "0") === "1";
+    const workletsPkg = get("WORKLETS_PKG", SDK_PROBE_RESULTS.WORKLETS_PKG) ===
+        "react-native-worklets-core"
         ? "react-native-worklets-core"
         : "react-native-worklets";
-    const expoBaseUrlInherited = sdk.get("EXPO_TSCONFIG_BASEURL") !== "null";
+    const baseUrlNoteRaw = get("EXPO_TSCONFIG_BASEURL", SDK_PROBE_RESULTS.EXPO_TSCONFIG_BASEURL_INHERITED ? "." : "null");
+    const expoBaseUrlInherited = baseUrlNoteRaw !== "null";
     log.step("Patching package.json scripts + tsconfig + babel.config.js …");
     patchPackageJsonScripts(target.dir);
     patchTsconfig(target.dir, { expoBaseUrlInherited });

package/dist/install.js

@@ -43,6 +43,16 @@ export function buildAlwaysInstalledList(workletsPkg) {
         // resolve 'expo-linking' from .../expo-router/build/views/Unmatched.js").
         "expo-linking",
         "expo-constants",
+        // Deviation #18 — react-native-mmkv 3.x+ peer deps + system-ui.
+        // mmkv was rewritten on Nitro Modules; without `react-native-nitro-modules`,
+        // gradle fails with "Project with path ':react-native-nitro-modules' could
+        // not be found in project ':react-native-mmkv'" and CocoaPods fails with
+        // "Unable to find a specification for `NitroModules` depended upon by `NitroMmkv`".
+        "react-native-nitro-modules",
+        // expo-system-ui is required by `expo prebuild` for `userInterfaceStyle`
+        // in app.json (default value "light"). Without it, prebuild warns:
+        // "Install expo-system-ui in your project to enable this feature."
+        "expo-system-ui",
     ];
 }
 export function buildConditionalDeps(answers) {

package/dist/sdkProbeResults.js

@@ -0,0 +1,28 @@
+// Probe values captured during template authoring (run `scripts/run-probes.sh`
+// to regenerate when bumping target SDK; then update this file by hand).
+//
+// These values are compiled into `dist/` so the CLI has them at runtime without
+// depending on `docs/SDK_NOTES.md` being shipped in the npm tarball. Shipping
+// the docs file was tried earlier and left two real bugs:
+//   1. `BABEL_PRESET_AUTO_INCLUDES_WORKLETS` defaulted false → patchBabel
+//      added `react-native-worklets/plugin` even though babel-preset-expo
+//      already auto-includes it (double-load risk + duplicate-plugin warnings).
+//   2. `EXPO_TSCONFIG_BASEURL` defaulted "inherited" → `baseUrl` never set
+//      → TS path resolution fragile.
+//
+// Constants here override `readSDKNotes` (which is now a fallback for
+// out-of-tree development scenarios).
+export const SDK_PROBE_RESULTS = {
+    /** Pinned by template-authoring date — bump alongside Expo SDK upgrades. */
+    EXPO_SDK_VERSION: "~54.0.33",
+    /** SDK 54+ `babel-preset-expo` auto-includes worklets/reanimated plugin. */
+    BABEL_PRESET_AUTO_INCLUDES_WORKLETS: true,
+    /** Canonical name per SDK 54 (vs the legacy `-core` variant). */
+    WORKLETS_PKG: "react-native-worklets",
+    /** SDK 54 `expo/tsconfig.base` does NOT provide `baseUrl` → patcher sets ".". */
+    EXPO_TSCONFIG_BASEURL_INHERITED: false,
+    /** SDK 54 `npx expo install --yarn`/`--npm` flags supported (Branch A). */
+    FLAGS_OK: true,
+    /** SDK 54 `expo install` materializes lockfile → no explicit PM install needed. */
+    PROBE_PASS: true,
+};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "codingpixel-expo-app",
-  "version": "0.1.3",
+  "version": "0.1.5",
   "description": "Opinionated Expo app scaffolder mirroring MyRoster conventions.",
   "type": "module",
   "bin": {