codify-plugin-lib 1.0.172 → 1.0.174

package/dist/messages/sender.js

@@ -18,23 +18,29 @@ class CodifyCliSenderImpl {
         });
     }
     async sendAndWaitForResponse(message) {
-        return new Promise((resolve, reject) => {
+        return new Promise((resolve) => {
             const requestId = nanoid(8);
             const listener = (data) => {
                 if (data.requestId === requestId) {
                     process.removeListener('message', listener);
-                    if (!this.validateIpcMessageV2(data.data)) {
-                        throw new Error(`Invalid response for request:
-
-${message}
-       
+                    if (!this.validateIpcMessageV2(data)) {
+                        throw new Error(`Invalid response for request.
+Request:                        
+${JSON.stringify(message, null, 2)}
+Response:
+${JSON.stringify(data, null, 2)}
+Error:
 ${JSON.stringify(this.validateIpcMessageV2.errors, null, 2)}`);
                     }
                     resolve(data);
                 }
             };
             process.on('message', listener);
-            process.send(message);
+            const ipcMessage = {
+                ...message,
+                requestId,
+            };
+            process.send(ipcMessage);
         });
     }
 }

package/dist/plan/change-set.d.ts

@@ -29,6 +29,7 @@ export declare class ChangeSet<T extends StringIndexedObject> {
     get currentParameters(): T;
     static empty<T extends StringIndexedObject>(): ChangeSet<T>;
     static create<T extends StringIndexedObject>(desired: Partial<T>): ChangeSet<T>;
+    static noop<T extends StringIndexedObject>(parameters: Partial<T>): ChangeSet<T>;
     static destroy<T extends StringIndexedObject>(current: Partial<T>): ChangeSet<T>;
     static calculateModification<T extends StringIndexedObject>(desired: Partial<T>, current: Partial<T>, parameterSettings?: Partial<Record<keyof T, ParsedParameterSetting>>): ChangeSet<T>;
     /**

package/dist/plan/change-set.js

@@ -34,6 +34,16 @@ export class ChangeSet {
         }));
         return new ChangeSet(ResourceOperation.CREATE, parameterChanges);
     }
+    static noop(parameters) {
+        const parameterChanges = Object.entries(parameters)
+            .map(([k, v]) => ({
+            name: k,
+            operation: ParameterOperation.NOOP,
+            previousValue: v ?? null,
+            newValue: v ?? null,
+        }));
+        return new ChangeSet(ResourceOperation.NOOP, parameterChanges);
+    }
     static destroy(current) {
         const parameterChanges = Object.entries(current)
             .map(([k, v]) => ({

package/dist/plan/plan.js

@@ -72,6 +72,10 @@ export class Plan {
         }
         // DESTROY
         if (filteredCurrentParameters && !desired) {
+            // We can manually override destroys. If a resource cannot be destroyed (for instance the npm resource relies on NodeJS being created and destroyed)
+            if (!settings.canDestroy) {
+                return new Plan(uuidV4(), ChangeSet.noop(filteredCurrentParameters), core, isStateful);
+            }
             return new Plan(uuidV4(), ChangeSet.destroy(filteredCurrentParameters), core, isStateful);
         }
         // NO-OP, MODIFY or RE-CREATE

package/dist/resource/parsed-resource-settings.d.ts

@@ -29,6 +29,7 @@ export declare class ParsedResourceSettings<T extends StringIndexedObject> imple
     private settings;
     constructor(settings: ResourceSettings<T>);
     get typeId(): string;
+    get canDestroy(): boolean;
     get statefulParameters(): Map<keyof T, StatefulParameterController<T, T[keyof T]>>;
     get parameterSettings(): Record<keyof T, ParsedParameterSetting>;
     get defaultValues(): Partial<Record<keyof T, unknown>>;

package/dist/resource/parsed-resource-settings.js

@@ -22,6 +22,9 @@ export class ParsedResourceSettings {
     get typeId() {
         return this.id;
     }
+    get canDestroy() {
+        return !this.settings.importAndDestroy?.preventDestroy;
+    }
     get statefulParameters() {
         return this.getFromCacheOrCreate('statefulParameters', () => {
             const statefulParameters = Object.entries(this.settings.parameterSettings ?? {})

package/dist/resource/resource-settings.d.ts

@@ -96,11 +96,16 @@ export interface ResourceSettings<T extends StringIndexedObject> {
     importAndDestroy?: {
         /**
          * Can this resources be imported? If set to false then the codifyCLI will skip over/not consider this
-         * resource valid for imports. Defaults to true.
+         * resource valid for imports. Defaults to false.
          *
          * Resources that can't be imported in the core library for example are: action resources
          */
         preventImport?: boolean;
+        /**
+         * Can this resources be destroyed? If set to false then the codifyCLI will skip over/not consider this
+         * resource valid for destroys. Defaults to false.
+         */
+        preventDestroy?: boolean;
         /**
          * Customize the required parameters needed to import this resource. By default, the `requiredParameters` are taken
          * from the identifyingParameters for allowMultiple. The `requiredParameters` parameter must be declared if a complex required is declared in

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "codify-plugin-lib",
-  "version": "1.0.172",
+  "version": "1.0.174",
   "description": "Library plugin library",
   "main": "dist/index.js",
   "typings": "dist/index.d.ts",

package/src/messages/sender.ts

@@ -1,9 +1,5 @@
 import { Ajv } from 'ajv';
-import {
-  IpcMessageV2,
-  IpcMessageV2Schema,
-  MessageCmd, PressKeyToContinueRequestData
-} from 'codify-schemas';
+import { IpcMessageV2, IpcMessageV2Schema, MessageCmd, PressKeyToContinueRequestData } from 'codify-schemas';
 import { nanoid } from 'nanoid';
 
 const ajv = new Ajv({
@@ -26,18 +22,19 @@ class CodifyCliSenderImpl {
   }
 
   private async sendAndWaitForResponse(message: IpcMessageV2): Promise<IpcMessageV2> {
-    return new Promise((resolve, reject) => {
+    return new Promise((resolve) => {
       const requestId = nanoid(8);
-      const listener = (data: IpcMessageV2)=> {
+      const listener = (data: IpcMessageV2) => {
         if (data.requestId === requestId) {
           process.removeListener('message', listener);
 
-          if (!this.validateIpcMessageV2(data.data)) {
-            throw new Error(
-`Invalid response for request:
-
-${message}
-       
+          if (!this.validateIpcMessageV2(data)) {
+            throw new Error(`Invalid response for request.
+Request:                        
+${JSON.stringify(message, null, 2)}
+Response:
+${JSON.stringify(data, null, 2)}
+Error:
 ${JSON.stringify(this.validateIpcMessageV2.errors, null, 2)}`);
           }
 
@@ -46,7 +43,12 @@ ${JSON.stringify(this.validateIpcMessageV2.errors, null, 2)}`);
       }
 
       process.on('message', listener);
-      process.send!(message)
+
+      const ipcMessage = {
+        ...message,
+        requestId,
+      }
+      process.send!(ipcMessage)
     })
   }
 }

package/src/plan/change-set.ts

@@ -72,6 +72,18 @@ export class ChangeSet<T extends StringIndexedObject> {
     return new ChangeSet(ResourceOperation.CREATE, parameterChanges);
   }
 
+  static noop<T extends StringIndexedObject>(parameters: Partial<T>): ChangeSet<T> {
+    const parameterChanges = Object.entries(parameters)
+      .map(([k, v]) => ({
+        name: k,
+        operation: ParameterOperation.NOOP,
+        previousValue: v ?? null,
+        newValue: v ?? null,
+      }))
+
+    return new ChangeSet(ResourceOperation.NOOP, parameterChanges);
+  }
+
   static destroy<T extends StringIndexedObject>(current: Partial<T>): ChangeSet<T> {
     const parameterChanges = Object.entries(current)
       .map(([k, v]) => ({

package/src/plan/plan.ts

@@ -126,6 +126,16 @@ export class Plan<T extends StringIndexedObject> {
 
     // DESTROY
     if (filteredCurrentParameters && !desired) {
+      // We can manually override destroys. If a resource cannot be destroyed (for instance the npm resource relies on NodeJS being created and destroyed)
+      if (!settings.canDestroy) {
+        return new Plan(
+          uuidV4(),
+          ChangeSet.noop(filteredCurrentParameters),
+          core,
+          isStateful,
+        )
+      }
+
       return new Plan(
         uuidV4(),
         ChangeSet.destroy(filteredCurrentParameters),

package/src/resource/parsed-resource-settings.ts

@@ -64,6 +64,10 @@ export class ParsedResourceSettings<T extends StringIndexedObject> implements Re
     return this.id;
   }
 
+  get canDestroy(): boolean {
+    return !this.settings.importAndDestroy?.preventDestroy;
+  }
+
   get statefulParameters(): Map<keyof T, StatefulParameterController<T, T[keyof T]>> {
     return this.getFromCacheOrCreate('statefulParameters', () => {
 

package/src/resource/resource-settings.ts

@@ -113,12 +113,18 @@ export interface ResourceSettings<T extends StringIndexedObject> {
   importAndDestroy?: {
     /**
      * Can this resources be imported? If set to false then the codifyCLI will skip over/not consider this
-     * resource valid for imports. Defaults to true.
+     * resource valid for imports. Defaults to false.
      *
      * Resources that can't be imported in the core library for example are: action resources
      */
     preventImport?: boolean;
 
+    /**
+     * Can this resources be destroyed? If set to false then the codifyCLI will skip over/not consider this
+     * resource valid for destroys. Defaults to false.
+     */
+    preventDestroy?: boolean;
+
     /**
      * Customize the required parameters needed to import this resource. By default, the `requiredParameters` are taken
      * from the identifyingParameters for allowMultiple. The `requiredParameters` parameter must be declared if a complex required is declared in