codex-workflow-v2 2.0.0-beta.1 → 2.0.0-beta.11

package/dist/src/lifecycle/types.js

@@ -0,0 +1,4 @@
+export const LIFECYCLE_EPOCH = 2;
+export const TRANSITION_DEFINITION_FORMAT_VERSION = 4;
+export const TRANSITION_CATALOG_FORMAT_VERSION = 4;
+//# sourceMappingURL=types.js.map

package/dist/src/lifecycle/types.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"types.js","sourceRoot":"","sources":["../../../src/lifecycle/types.ts"],"names":[],"mappings":"AAEA,MAAM,CAAC,MAAM,eAAe,GAAG,CAAU,CAAC;AAC1C,MAAM,CAAC,MAAM,oCAAoC,GAAG,CAAU,CAAC;AAC/D,MAAM,CAAC,MAAM,iCAAiC,GAAG,CAAU,CAAC"}

package/dist/src/observation.d.ts

@@ -0,0 +1,20 @@
+import type { AdoptionPostureEvent, ProjectRecord, WorkflowObservation, WriterLease } from './contracts.js';
+import type { RepositoryIdentity } from './repository.js';
+import type { FileStateStore } from './state/store.js';
+export interface WorkflowObservationBoundary {
+    identity: RepositoryIdentity;
+    project: ProjectRecord | null;
+    currentAdoptionPosture: AdoptionPostureEvent | null;
+    leases: WriterLease[];
+    observation: WorkflowObservation;
+}
+/**
+ * Reads only the persistence boundary needed to decide whether a coherent lifecycle snapshot can
+ * be loaded. It deliberately does not register a project, recover a journal, initialize adoption,
+ * or construct a WriterLockManager.
+ */
+export declare function inspectWorkflowObservationBoundary(options: {
+    store: FileStateStore;
+    identity: RepositoryIdentity;
+    now: Date;
+}): WorkflowObservationBoundary;

package/dist/src/observation.js

@@ -0,0 +1,171 @@
+import { existsSync, readdirSync, realpathSync } from 'node:fs';
+import path from 'node:path';
+import { readCurrentAdoptionPosture } from './alpha6/adoption.js';
+import { listMilestoneTransactionJournals } from './alpha6/journal.js';
+import { assertNoSymlinkPathComponents } from './alpha6/store-sidecars.js';
+import { listProjectTransactions } from './beta1/project-transaction.js';
+import { listCoreTaskOperationMutexes, listWriterLeases, toPublicCoreTaskOperation, toPublicWriterLease, } from './state/lock.js';
+import { inspectCorrectiveReplanTaskTransactions } from './state/corrective-replan-transaction.js';
+import { inspectCorrectiveYieldTaskTransactions } from './state/corrective-yield-transaction.js';
+/**
+ * Reads only the persistence boundary needed to decide whether a coherent lifecycle snapshot can
+ * be loaded. It deliberately does not register a project, recover a journal, initialize adoption,
+ * or construct a WriterLockManager.
+ */
+export function inspectWorkflowObservationBoundary(options) {
+    const { store, identity, now } = options;
+    const projectRoot = store.projectRoot(identity.projectId);
+    const projectFile = path.join(projectRoot, 'project.json');
+    const lockRoot = store.lockRoot(identity.projectId);
+    const stateRootPresent = existsSync(store.root);
+    const projectRootPresent = existsSync(projectRoot);
+    const lockRootPresent = existsSync(lockRoot);
+    const missingRegistration = !existsSync(projectFile);
+    const pendingProjectTransactions = observeProjectTransactions(projectRoot, identity.projectId);
+    const pendingMilestoneTransactions = observeMilestoneTransactions(store, identity.projectId);
+    const replanTransactions = inspectCorrectiveReplanTaskTransactions(projectRoot, store.root);
+    const yieldTransactions = inspectCorrectiveYieldTaskTransactions(projectRoot, store.root);
+    const taskTransactions = {
+        pending: [...replanTransactions.pending, ...yieldTransactions.pending]
+            .sort((left, right) => left.taskId.localeCompare(right.taskId) || left.transactionId.localeCompare(right.transactionId)),
+        corrupt: [...replanTransactions.corrupt, ...yieldTransactions.corrupt]
+            .sort((left, right) => left.taskId.localeCompare(right.taskId) || left.transactionId.localeCompare(right.transactionId)),
+    };
+    const pendingTaskTransitionIds = [...new Set(taskTransactions.pending.map((transaction) => transaction.transitionId))];
+    const mixedPendingTaskTransitions = pendingTaskTransitionIds.length > 1;
+    const leases = listWriterLeases(lockRoot);
+    const coreTaskOperations = listCoreTaskOperationMutexes(lockRoot, store.root)
+        .map((mutex) => toPublicCoreTaskOperation(mutex, now));
+    const orphanCoreTaskOperations = coreTaskOperations.filter((operation) => !taskTransactions.pending.some((transaction) => transaction.taskId === operation.entityId && transaction.transactionId === operation.operationId));
+    const project = !missingRegistration && pendingProjectTransactions.length === 0
+        ? store.readProject(identity.projectId)
+        : null;
+    const repositoryRootBound = project?.repositoryRoots.includes(identity.repositoryRoot) ?? false;
+    const adoptionAssessed = pendingProjectTransactions.length === 0
+        && pendingMilestoneTransactions.length === 0
+        && taskTransactions.pending.length === 0
+        && taskTransactions.corrupt.length === 0
+        && orphanCoreTaskOperations.length === 0;
+    const currentAdoptionPosture = adoptionAssessed && stateRootPresent
+        ? readCurrentAdoptionPosture(store, identity.projectId)
+        : null;
+    const missingAdoption = adoptionAssessed && currentAdoptionPosture === null;
+    const observedLeases = leases.map((lease) => toPublicWriterLease(lease, now));
+    const activeLeases = observedLeases.filter((lease) => !lease.stale);
+    const staleLeases = observedLeases.filter((lease) => lease.stale);
+    const reasonCodes = [];
+    if (missingRegistration)
+        reasonCodes.push('PROJECT_REGISTRATION_MISSING');
+    if (project && !repositoryRootBound)
+        reasonCodes.push('PROJECT_REPOSITORY_ROOT_UNBOUND');
+    if (pendingProjectTransactions.length > 0)
+        reasonCodes.push('PROJECT_RECOVERY_REQUIRED');
+    if (pendingMilestoneTransactions.length > 0)
+        reasonCodes.push('MILESTONE_RECOVERY_REQUIRED');
+    if (taskTransactions.pending.length > 0)
+        reasonCodes.push('TASK_RECOVERY_REQUIRED');
+    if (taskTransactions.corrupt.length > 0)
+        reasonCodes.push('TASK_TRANSACTION_INTEGRITY_FAILED');
+    if (orphanCoreTaskOperations.some((operation) => !operation.stale))
+        reasonCodes.push('TASK_OPERATION_IN_PROGRESS');
+    if (orphanCoreTaskOperations.some((operation) => operation.stale))
+        reasonCodes.push('STALE_TASK_OPERATION');
+    if (activeLeases.length > 0)
+        reasonCodes.push('ACTIVE_WRITER_LEASE');
+    if (staleLeases.length > 0)
+        reasonCodes.push('STALE_WRITER_LEASE');
+    if (missingAdoption)
+        reasonCodes.push('ADOPTION_MISSING');
+    const blocked = missingRegistration
+        || (project !== null && !repositoryRootBound)
+        || pendingProjectTransactions.length > 0
+        || taskTransactions.corrupt.length > 0
+        || mixedPendingTaskTransitions
+        || orphanCoreTaskOperations.length > 0;
+    const repairable = taskTransactions.pending.length > 0
+        || pendingMilestoneTransactions.length > 0
+        || staleLeases.length > 0;
+    const kind = blocked ? 'blocked' : repairable ? 'repair' : 'assessment';
+    const repair = kind !== 'repair'
+        ? null
+        : taskTransactions.pending.length > 0
+            ? {
+                command: pendingTaskTransitionIds[0] === 'task.coordination.corrective-yield'
+                    ? 'task corrective-yield-recover'
+                    : 'task corrective-replan-recover',
+                cataloged: false,
+                available: true,
+                projectId: identity.projectId,
+                taskIds: [...new Set(taskTransactions.pending.map((transaction) => transaction.taskId))].sort(),
+                transactionIds: taskTransactions.pending.map((transaction) => transaction.transactionId).sort(),
+            }
+            : pendingMilestoneTransactions.length > 0
+                ? {
+                    command: 'milestone recover',
+                    cataloged: false,
+                    projectId: identity.projectId,
+                    milestoneIds: [...new Set(pendingMilestoneTransactions.map((transaction) => transaction.milestoneId))].sort(),
+                    transactionIds: pendingMilestoneTransactions.map((transaction) => transaction.transactionId).sort(),
+                }
+                : {
+                    command: 'locks repair',
+                    cataloged: false,
+                    projectId: identity.projectId,
+                    entityIds: staleLeases.map((lease) => lease.entityId).sort(),
+                };
+    return {
+        identity,
+        project,
+        currentAdoptionPosture,
+        leases,
+        observation: {
+            kind,
+            reasonCodes,
+            stateRootPresent,
+            projectRootPresent,
+            lockRootPresent,
+            missingRegistration,
+            repositoryRootBound,
+            adoptionAssessed,
+            missingAdoption,
+            pendingProjectTransactions,
+            pendingMilestoneTransactions,
+            pendingTaskTransactions: taskTransactions.pending,
+            corruptTaskTransactions: taskTransactions.corrupt,
+            coreTaskOperations,
+            leases: observedLeases,
+            availableRepairTransitionId: null,
+            repair,
+        },
+    };
+}
+function observeProjectTransactions(projectRoot, projectId) {
+    return listProjectTransactions(projectRoot, projectId)
+        .map((transaction) => ({ ...transaction }))
+        .sort((left, right) => left.preparedAt.localeCompare(right.preparedAt)
+        || left.transactionId.localeCompare(right.transactionId));
+}
+function observeMilestoneTransactions(store, projectId) {
+    const milestonesRoot = path.join(store.projectRoot(projectId), 'milestones');
+    if (!existsSync(milestonesRoot))
+        return [];
+    assertNoSymlinkPathComponents(milestonesRoot, {
+        label: 'Milestones observation root',
+        requireLeaf: true,
+        trustedRoot: store.root,
+    });
+    return readdirSync(milestonesRoot, { withFileTypes: true })
+        .filter((entry) => entry.isDirectory())
+        .flatMap((entry) => listMilestoneTransactionJournals(realpathSync(path.join(milestonesRoot, entry.name)), {
+        expectedMilestoneId: entry.name,
+    }).map((journal) => ({
+        milestoneId: journal.milestoneId,
+        transactionId: journal.transactionId,
+        phase: journal.phase,
+        preparedAt: journal.preparedAt,
+        updatedAt: journal.updatedAt,
+    })))
+        .sort((left, right) => left.preparedAt.localeCompare(right.preparedAt)
+        || left.transactionId.localeCompare(right.transactionId));
+}
+//# sourceMappingURL=observation.js.map

package/dist/src/observation.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"observation.js","sourceRoot":"","sources":["../../src/observation.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,WAAW,EAAE,YAAY,EAAE,MAAM,SAAS,CAAC;AAChE,OAAO,IAAI,MAAM,WAAW,CAAC;AAW7B,OAAO,EAAE,0BAA0B,EAAE,MAAM,sBAAsB,CAAC;AAClE,OAAO,EAAE,gCAAgC,EAAE,MAAM,qBAAqB,CAAC;AACvE,OAAO,EAAE,6BAA6B,EAAE,MAAM,4BAA4B,CAAC;AAC3E,OAAO,EAAE,uBAAuB,EAAE,MAAM,gCAAgC,CAAC;AAEzE,OAAO,EACL,4BAA4B,EAC5B,gBAAgB,EAChB,yBAAyB,EACzB,mBAAmB,GACpB,MAAM,iBAAiB,CAAC;AACzB,OAAO,EAAE,uCAAuC,EAAE,MAAM,0CAA0C,CAAC;AACnG,OAAO,EAAE,sCAAsC,EAAE,MAAM,yCAAyC,CAAC;AAWjG;;;;GAIG;AACH,MAAM,UAAU,kCAAkC,CAAC,OAIlD;IACC,MAAM,EAAE,KAAK,EAAE,QAAQ,EAAE,GAAG,EAAE,GAAG,OAAO,CAAC;IACzC,MAAM,WAAW,GAAG,KAAK,CAAC,WAAW,CAAC,QAAQ,CAAC,SAAS,CAAC,CAAC;IAC1D,MAAM,WAAW,GAAG,IAAI,CAAC,IAAI,CAAC,WAAW,EAAE,cAAc,CAAC,CAAC;IAC3D,MAAM,QAAQ,GAAG,KAAK,CAAC,QAAQ,CAAC,QAAQ,CAAC,SAAS,CAAC,CAAC;IACpD,MAAM,gBAAgB,GAAG,UAAU,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IAChD,MAAM,kBAAkB,GAAG,UAAU,CAAC,WAAW,CAAC,CAAC;IACnD,MAAM,eAAe,GAAG,UAAU,CAAC,QAAQ,CAAC,CAAC;IAC7C,MAAM,mBAAmB,GAAG,CAAC,UAAU,CAAC,WAAW,CAAC,CAAC;IACrD,MAAM,0BAA0B,GAAG,0BAA0B,CAAC,WAAW,EAAE,QAAQ,CAAC,SAAS,CAAC,CAAC;IAC/F,MAAM,4BAA4B,GAAG,4BAA4B,CAAC,KAAK,EAAE,QAAQ,CAAC,SAAS,CAAC,CAAC;IAC7F,MAAM,kBAAkB,GAAG,uCAAuC,CAAC,WAAW,EAAE,KAAK,CAAC,IAAI,CAAC,CAAC;IAC5F,MAAM,iBAAiB,GAAG,sCAAsC,CAAC,WAAW,EAAE,KAAK,CAAC,IAAI,CAAC,CAAC;IAC1F,MAAM,gBAAgB,GAAG;QACvB,OAAO,EAAE,CAAC,GAAG,kBAAkB,CAAC,OAAO,EAAE,GAAG,iBAAiB,CAAC,OAAO,CAAC;aACnE,IAAI,CAAC,CAAC,IAAI,EAAE,KAAK,EAAE,EAAE,CAAC,IAAI,CAAC,MAAM,CAAC,aAAa,CAAC,KAAK,CAAC,MAAM,CAAC,IAAI,IAAI,CAAC,aAAa,CAAC,aAAa,CAAC,KAAK,CAAC,aAAa,CAAC,CAAC;QAC1H,OAAO,EAAE,CAAC,GAAG,kBAAkB,CAAC,OAAO,EAAE,GAAG,iBAAiB,CAAC,OAAO,CAAC;aACnE,IAAI,CAAC,CAAC,IAAI,EAAE,KAAK,EAAE,EAAE,CAAC,IAAI,CAAC,MAAM,CAAC,aAAa,CAAC,KAAK,CAAC,MAAM,CAAC,IAAI,IAAI,CAAC,aAAa,CAAC,aAAa,CAAC,KAAK,CAAC,aAAa,CAAC,CAAC;KAC3H,CAAC;IACF,MAAM,wBAAwB,GAAG,CAAC,GAAG,IAAI,GAAG,CAAC,gBAAgB,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,WAAW,EAAE,EAAE,CAAC,WAAW,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;IACvH,MAAM,2BAA2B,GAAG,wBAAwB,CAAC,MAAM,GAAG,CAAC,CAAC;IACxE,MAAM,MAAM,GAAG,gBAAgB,CAAC,QAAQ,CAAC,CAAC;IAC1C,MAAM,kBAAkB,GAAG,4BAA4B,CAAC,QAAQ,EAAE,KAAK,CAAC,IAAI,CAAC;SAC1E,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,yBAAyB,CAAC,KAAK,EAAE,GAAG,CAAC,CAAC,CAAC;IACzD,MAAM,wBAAwB,GAAG,kBAAkB,CAAC,MAAM,CAAC,CAAC,SAAS,EAAE,EAAE,CAAC,CAAC,gBAAgB,CAAC,OAAO,CAAC,IAAI,CACtG,CAAC,WAAW,EAAE,EAAE,CAAC,WAAW,CAAC,MAAM,KAAK,SAAS,CAAC,QAAQ,IAAI,WAAW,CAAC,aAAa,KAAK,SAAS,CAAC,WAAW,CAClH,CAAC,CAAC;IAEH,MAAM,OAAO,GAAG,CAAC,mBAAmB,IAAI,0BAA0B,CAAC,MAAM,KAAK,CAAC;QAC7E,CAAC,CAAC,KAAK,CAAC,WAAW,CAAC,QAAQ,CAAC,SAAS,CAAC;QACvC,CAAC,CAAC,IAAI,CAAC;IACT,MAAM,mBAAmB,GAAG,OAAO,EAAE,eAAe,CAAC,QAAQ,CAAC,QAAQ,CAAC,cAAc,CAAC,IAAI,KAAK,CAAC;IAChG,MAAM,gBAAgB,GAAG,0BAA0B,CAAC,MAAM,KAAK,CAAC;WAC3D,4BAA4B,CAAC,MAAM,KAAK,CAAC;WACzC,gBAAgB,CAAC,OAAO,CAAC,MAAM,KAAK,CAAC;WACrC,gBAAgB,CAAC,OAAO,CAAC,MAAM,KAAK,CAAC;WACrC,wBAAwB,CAAC,MAAM,KAAK,CAAC,CAAC;IAC3C,MAAM,sBAAsB,GAAG,gBAAgB,IAAI,gBAAgB;QACjE,CAAC,CAAC,0BAA0B,CAAC,KAAK,EAAE,QAAQ,CAAC,SAAS,CAAC;QACvD,CAAC,CAAC,IAAI,CAAC;IACT,MAAM,eAAe,GAAG,gBAAgB,IAAI,sBAAsB,KAAK,IAAI,CAAC;IAC5E,MAAM,cAAc,GAAG,MAAM,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,mBAAmB,CAAC,KAAK,EAAE,GAAG,CAAC,CAAC,CAAC;IAC9E,MAAM,YAAY,GAAG,cAAc,CAAC,MAAM,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;IACpE,MAAM,WAAW,GAAG,cAAc,CAAC,MAAM,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;IAElE,MAAM,WAAW,GAA4B,EAAE,CAAC;IAChD,IAAI,mBAAmB;QAAE,WAAW,CAAC,IAAI,CAAC,8BAA8B,CAAC,CAAC;IAC1E,IAAI,OAAO,IAAI,CAAC,mBAAmB;QAAE,WAAW,CAAC,IAAI,CAAC,iCAAiC,CAAC,CAAC;IACzF,IAAI,0BAA0B,CAAC,MAAM,GAAG,CAAC;QAAE,WAAW,CAAC,IAAI,CAAC,2BAA2B,CAAC,CAAC;IACzF,IAAI,4BAA4B,CAAC,MAAM,GAAG,CAAC;QAAE,WAAW,CAAC,IAAI,CAAC,6BAA6B,CAAC,CAAC;IAC7F,IAAI,gBAAgB,CAAC,OAAO,CAAC,MAAM,GAAG,CAAC;QAAE,WAAW,CAAC,IAAI,CAAC,wBAAwB,CAAC,CAAC;IACpF,IAAI,gBAAgB,CAAC,OAAO,CAAC,MAAM,GAAG,CAAC;QAAE,WAAW,CAAC,IAAI,CAAC,mCAAmC,CAAC,CAAC;IAC/F,IAAI,wBAAwB,CAAC,IAAI,CAAC,CAAC,SAAS,EAAE,EAAE,CAAC,CAAC,SAAS,CAAC,KAAK,CAAC;QAAE,WAAW,CAAC,IAAI,CAAC,4BAA4B,CAAC,CAAC;IACnH,IAAI,wBAAwB,CAAC,IAAI,CAAC,CAAC,SAAS,EAAE,EAAE,CAAC,SAAS,CAAC,KAAK,CAAC;QAAE,WAAW,CAAC,IAAI,CAAC,sBAAsB,CAAC,CAAC;IAC5G,IAAI,YAAY,CAAC,MAAM,GAAG,CAAC;QAAE,WAAW,CAAC,IAAI,CAAC,qBAAqB,CAAC,CAAC;IACrE,IAAI,WAAW,CAAC,MAAM,GAAG,CAAC;QAAE,WAAW,CAAC,IAAI,CAAC,oBAAoB,CAAC,CAAC;IACnE,IAAI,eAAe;QAAE,WAAW,CAAC,IAAI,CAAC,kBAAkB,CAAC,CAAC;IAE1D,MAAM,OAAO,GAAG,mBAAmB;WAC9B,CAAC,OAAO,KAAK,IAAI,IAAI,CAAC,mBAAmB,CAAC;WAC1C,0BAA0B,CAAC,MAAM,GAAG,CAAC;WACrC,gBAAgB,CAAC,OAAO,CAAC,MAAM,GAAG,CAAC;WACnC,2BAA2B;WAC3B,wBAAwB,CAAC,MAAM,GAAG,CAAC,CAAC;IACzC,MAAM,UAAU,GAAG,gBAAgB,CAAC,OAAO,CAAC,MAAM,GAAG,CAAC;WACjD,4BAA4B,CAAC,MAAM,GAAG,CAAC;WACvC,WAAW,CAAC,MAAM,GAAG,CAAC,CAAC;IAC5B,MAAM,IAAI,GAAgC,OAAO,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,YAAY,CAAC;IACrG,MAAM,MAAM,GAAG,IAAI,KAAK,QAAQ;QAC9B,CAAC,CAAC,IAAI;QACN,CAAC,CAAC,gBAAgB,CAAC,OAAO,CAAC,MAAM,GAAG,CAAC;YACnC,CAAC,CAAC;gBACE,OAAO,EAAE,wBAAwB,CAAC,CAAC,CAAC,KAAK,oCAAoC;oBAC3E,CAAC,CAAC,+BAAwC;oBAC1C,CAAC,CAAC,gCAAyC;gBAC7C,SAAS,EAAE,KAAc;gBACzB,SAAS,EAAE,IAAa;gBACxB,SAAS,EAAE,QAAQ,CAAC,SAAS;gBAC7B,OAAO,EAAE,CAAC,GAAG,IAAI,GAAG,CAAC,gBAAgB,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,WAAW,EAAE,EAAE,CAAC,WAAW,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE;gBAC/F,cAAc,EAAE,gBAAgB,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,WAAW,EAAE,EAAE,CAAC,WAAW,CAAC,aAAa,CAAC,CAAC,IAAI,EAAE;aAChG;YACH,CAAC,CAAC,4BAA4B,CAAC,MAAM,GAAG,CAAC;gBACzC,CAAC,CAAC;oBACE,OAAO,EAAE,mBAA4B;oBACrC,SAAS,EAAE,KAAc;oBACzB,SAAS,EAAE,QAAQ,CAAC,SAAS;oBAC7B,YAAY,EAAE,CAAC,GAAG,IAAI,GAAG,CAAC,4BAA4B,CAAC,GAAG,CAAC,CAAC,WAAW,EAAE,EAAE,CAAC,WAAW,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE;oBAC7G,cAAc,EAAE,4BAA4B,CAAC,GAAG,CAAC,CAAC,WAAW,EAAE,EAAE,CAAC,WAAW,CAAC,aAAa,CAAC,CAAC,IAAI,EAAE;iBACpG;gBACH,CAAC,CAAC;oBACE,OAAO,EAAE,cAAuB;oBAChC,SAAS,EAAE,KAAc;oBACzB,SAAS,EAAE,QAAQ,CAAC,SAAS;oBAC7B,SAAS,EAAE,WAAW,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC,IAAI,EAAE;iBAC7D,CAAC;IAER,OAAO;QACL,QAAQ;QACR,OAAO;QACP,sBAAsB;QACtB,MAAM;QACN,WAAW,EAAE;YACX,IAAI;YACJ,WAAW;YACX,gBAAgB;YAChB,kBAAkB;YAClB,eAAe;YACf,mBAAmB;YACnB,mBAAmB;YACnB,gBAAgB;YAChB,eAAe;YACf,0BAA0B;YAC1B,4BAA4B;YAC5B,uBAAuB,EAAE,gBAAgB,CAAC,OAAO;YACjD,uBAAuB,EAAE,gBAAgB,CAAC,OAAO;YACjD,kBAAkB;YAClB,MAAM,EAAE,cAAc;YACtB,2BAA2B,EAAE,IAAI;YACjC,MAAM;SACP;KACF,CAAC;AACJ,CAAC;AAED,SAAS,0BAA0B,CAAC,WAAmB,EAAE,SAAiB;IACxE,OAAO,uBAAuB,CAAC,WAAW,EAAE,SAAS,CAAC;SACnD,GAAG,CAAC,CAAC,WAAW,EAAE,EAAE,CAAC,CAAC,EAAE,GAAG,WAAW,EAAE,CAAC,CAAC;SAC1C,IAAI,CAAC,CAAC,IAAI,EAAE,KAAK,EAAE,EAAE,CAAC,IAAI,CAAC,UAAU,CAAC,aAAa,CAAC,KAAK,CAAC,UAAU,CAAC;WACjE,IAAI,CAAC,aAAa,CAAC,aAAa,CAAC,KAAK,CAAC,aAAa,CAAC,CAAC,CAAC;AAChE,CAAC;AAED,SAAS,4BAA4B,CACnC,KAAqB,EACrB,SAAiB;IAEjB,MAAM,cAAc,GAAG,IAAI,CAAC,IAAI,CAAC,KAAK,CAAC,WAAW,CAAC,SAAS,CAAC,EAAE,YAAY,CAAC,CAAC;IAC7E,IAAI,CAAC,UAAU,CAAC,cAAc,CAAC;QAAE,OAAO,EAAE,CAAC;IAC3C,6BAA6B,CAAC,cAAc,EAAE;QAC5C,KAAK,EAAE,6BAA6B;QACpC,WAAW,EAAE,IAAI;QACjB,WAAW,EAAE,KAAK,CAAC,IAAI;KACxB,CAAC,CAAC;IACH,OAAO,WAAW,CAAC,cAAc,EAAE,EAAE,aAAa,EAAE,IAAI,EAAE,CAAC;SACxD,MAAM,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,WAAW,EAAE,CAAC;SACtC,OAAO,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,gCAAgC,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC,cAAc,EAAE,KAAK,CAAC,IAAI,CAAC,CAAC,EAAE;QACxG,mBAAmB,EAAE,KAAK,CAAC,IAAI;KAChC,CAAC,CAAC,GAAG,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC;QACnB,WAAW,EAAE,OAAO,CAAC,WAAW;QAChC,aAAa,EAAE,OAAO,CAAC,aAAa;QACpC,KAAK,EAAE,OAAO,CAAC,KAAK;QACpB,UAAU,EAAE,OAAO,CAAC,UAAU;QAC9B,SAAS,EAAE,OAAO,CAAC,SAAS;KAC7B,CAAC,CAAC,CAAC;SACH,IAAI,CAAC,CAAC,IAAI,EAAE,KAAK,EAAE,EAAE,CAAC,IAAI,CAAC,UAAU,CAAC,aAAa,CAAC,KAAK,CAAC,UAAU,CAAC;WACjE,IAAI,CAAC,aAAa,CAAC,aAAa,CAAC,KAAK,CAAC,aAAa,CAAC,CAAC,CAAC;AAChE,CAAC"}

package/dist/src/reviewer.d.ts

@@ -3,10 +3,12 @@ export interface ReviewerProcessResult {
     status: number | null;
     stdout: string;
     stderr: string;
+    timedOut?: boolean;
 }
 export type ReviewerCommandRunner = (command: string, args: string[], options: {
     cwd: string;
     input: string;
+    timeoutMs: number;
 }) => ReviewerProcessResult;
 export interface StrictReviewOutput extends ReviewInput {
     isolationProbe: 'denied' | 'written' | 'not-attempted';
@@ -16,6 +18,7 @@ export interface StrictReviewerLaunchResult {
     verifiedIsolation: boolean;
     command: string[];
     processStatus: number | null;
+    timedOut: boolean;
     stderr: string;
     before: RepositorySeal;
     after: RepositorySeal;
@@ -24,11 +27,45 @@ export interface StrictStepReviewerLaunchResult extends StrictReviewerLaunchResu
     reviewedCommit: string;
     reviewerOutputHash: string;
 }
-interface RepositorySeal {
+export interface RepositorySeal {
     headCommit: string;
     changedFiles: string[];
     contentHash: string;
 }
+export interface ExternalStrictStepReviewPacket {
+    protocol: 'codex-workflow-external-strict-step-review-v1';
+    taskId: string;
+    stepId: string;
+    reviewedCommit: string;
+    packet: Record<string, unknown>;
+    packetHash: string;
+    repositorySeal: RepositorySeal;
+    repositorySealHash: string;
+}
+export interface ExternalStrictStepReviewInput {
+    protocol: 'codex-workflow-external-strict-step-review-v1';
+    packetHash: string;
+    repositorySealHash: string;
+    reviewerThreadId: string;
+    review: ReviewInput;
+}
+export interface ExternalStrictTaskReviewPacket {
+    protocol: 'codex-workflow-external-strict-task-review-v1';
+    taskId: string;
+    reviewedCommit: string;
+    packet: Record<string, unknown>;
+    packetHash: string;
+    repositorySeal: RepositorySeal;
+    repositorySealHash: string;
+}
+export interface ExternalStrictTaskReviewInput {
+    protocol: 'codex-workflow-external-strict-task-review-v1';
+    packetHash: string;
+    repositorySealHash: string;
+    reviewerThreadId: string;
+    review: ReviewInput;
+}
+export declare const STRICT_REVIEWER_TIMEOUT_MS = 180000;
 declare const REVIEW_SCHEMA: {
     readonly type: "object";
     readonly additionalProperties: false;
@@ -84,4 +121,9 @@ declare const REVIEW_SCHEMA: {
 };
 export declare function launchStrictReviewer(repositoryRoot: string, task: TaskState, taskRoot: string, envelope: ContextEnvelope, runner?: ReviewerCommandRunner): StrictReviewerLaunchResult;
 export declare function launchStrictStepReviewer(repositoryRoot: string, task: TaskState, taskRoot: string, envelope: ContextEnvelope, stepId: string, currentEvidence: StepEvidence, runner?: ReviewerCommandRunner): StrictStepReviewerLaunchResult;
+export declare function prepareExternalStrictStepReviewPacket(repositoryRoot: string, task: TaskState, taskRoot: string, envelope: ContextEnvelope, stepId: string, currentEvidence: StepEvidence): ExternalStrictStepReviewPacket;
+export declare function prepareExternalStrictTaskReviewPacket(repositoryRoot: string, task: TaskState, taskRoot: string, envelope: ContextEnvelope): ExternalStrictTaskReviewPacket;
+export declare function validateExternalStrictStepReviewInput(value: unknown, expected: ExternalStrictStepReviewPacket): ReviewInput;
+export declare function validateExternalStrictTaskReviewInput(value: unknown, expected: ExternalStrictTaskReviewPacket): ReviewInput;
+export declare function strictReviewInputHash(review: ReviewInput): string;
 export { REVIEW_SCHEMA };

package/dist/src/reviewer.js

@@ -1,11 +1,12 @@
 import { createHash } from 'node:crypto';
-import { existsSync, lstatSync, mkdtempSync, readFileSync, readdirSync, readlinkSync, rmSync, writeFileSync } from 'node:fs';
+import { existsSync, lstatSync, mkdtempSync, readFileSync, readlinkSync, rmSync, writeFileSync } from 'node:fs';
 import os from 'node:os';
 import path from 'node:path';
 import { spawnSync } from 'node:child_process';
 import { canonicalJsonStringify } from './alpha6/store-sidecars.js';
 import { changedFiles, headCommit, runGit } from './repository.js';
 const FULL_GIT_SHA_PATTERN = /^[a-f0-9]{40}$/;
+export const STRICT_REVIEWER_TIMEOUT_MS = 180_000;
 const REVIEW_SCHEMA = {
     type: 'object',
     additionalProperties: false,
@@ -65,6 +66,7 @@ export function launchStrictReviewer(repositoryRoot, task, taskRoot, envelope, r
         verifiedIsolation: launch.verifiedIsolation,
         command: launch.command,
         processStatus: launch.processStatus,
+        timedOut: launch.timedOut,
         stderr: launch.stderr,
         before: launch.before,
         after: launch.after,
@@ -89,51 +91,21 @@ export function launchStrictStepReviewer(repositoryRoot, task, taskRoot, envelop
     if (reviewedCommit !== currentHead) {
         return failedStepLaunch(repositoryRoot, [], null, `Strict step reviewer requires the canonical Step evidence commit to match repository HEAD for ${stepId} on task ${task.id}.`, reviewedCommit);
     }
+    const packet = strictStepReviewPayload(repositoryRoot, task, taskRoot, envelope, step, reviewedCommit, currentEvidence);
     const launch = runStrictReviewerLaunch(repositoryRoot, {
         protocol: 'codex-workflow-strict-step-review-v1',
         task,
         taskRoot,
         envelope,
         commandSummary: 'Strict step reviewer did not return valid output proving the denied write probe.',
-        packet: {
-            protocol: 'codex-workflow-strict-step-review-v1',
-            instruction: [
-                'Act only as the independent reviewer described by the context envelope.',
-                'Before reviewing, attempt to create .codex-reviewer-write-probe in the repository.',
-                'The attempt must be denied by the sandbox. Report isolationProbe="denied" only when it was denied.',
-                'Review only the supplied Task Step and bind your findings to the supplied reviewedCommit.',
-                'Do not modify any repository file. Return only the requested JSON result.',
-            ],
-            envelope,
-            task: {
-                id: task.id,
-                baseCommit: task.baseCommit,
-                headCommit: headCommit(repositoryRoot),
-                brief: readFileSync(path.join(taskRoot, 'brief.md'), 'utf8'),
-                plan: readFileSync(path.join(taskRoot, 'plan.md'), 'utf8'),
-                diff: task.baseCommit ? runGit(repositoryRoot, ['diff', '--no-ext-diff', `${task.baseCommit}..HEAD`]) : '',
-            },
-            step: {
-                id: step.id,
-                title: step.title,
-                objective: step.objective,
-                requirements: step.requirements,
-                dependencies: step.dependencies,
-                expectedOutputs: step.expectedOutputs,
-                allowedWrites: step.allowedWrites,
-                forbiddenScope: step.forbiddenScope,
-                checks: step.checks,
-                status: step.status,
-                reviewedCommit,
-                evidence: currentEvidence,
-            },
-        },
+        packet,
     }, runner);
     return {
         review: launch.review,
         verifiedIsolation: launch.verifiedIsolation,
         command: launch.command,
         processStatus: launch.processStatus,
+        timedOut: launch.timedOut,
         stderr: launch.stderr,
         before: launch.before,
         after: launch.after,
@@ -141,14 +113,184 @@ export function launchStrictStepReviewer(repositoryRoot, task, taskRoot, envelop
         reviewerOutputHash: launch.reviewerOutputHash,
     };
 }
+export function prepareExternalStrictStepReviewPacket(repositoryRoot, task, taskRoot, envelope, stepId, currentEvidence) {
+    const step = task.steps.find((candidate) => candidate.id === stepId);
+    if (!step || !step.evidence || canonicalJsonStringify(step.evidence) !== canonicalJsonStringify(currentEvidence)) {
+        throw new Error(`Strict Step Review packet requires exact canonical evidence for ${stepId}.`);
+    }
+    const reviewedCommit = currentEvidence.commitSha;
+    if (!FULL_GIT_SHA_PATTERN.test(reviewedCommit) || reviewedCommit !== headCommit(repositoryRoot)) {
+        throw new Error(`Strict Step Review packet requires ${stepId} evidence to match repository HEAD.`);
+    }
+    const packet = strictStepReviewPayload(repositoryRoot, task, taskRoot, envelope, step, reviewedCommit, currentEvidence);
+    const repositorySeal = sealRepository(repositoryRoot);
+    return {
+        protocol: 'codex-workflow-external-strict-step-review-v1',
+        taskId: task.id,
+        stepId,
+        reviewedCommit,
+        packet,
+        packetHash: canonicalHash(packet),
+        repositorySeal,
+        repositorySealHash: canonicalHash(repositorySeal),
+    };
+}
+export function prepareExternalStrictTaskReviewPacket(repositoryRoot, task, taskRoot, envelope) {
+    const reviewedCommit = headCommit(repositoryRoot);
+    if (!FULL_GIT_SHA_PATTERN.test(reviewedCommit)) {
+        throw new Error(`Strict Task Review packet requires a full lowercase Git SHA for ${task.id}.`);
+    }
+    const packet = {
+        protocol: 'codex-workflow-strict-review-v1',
+        instruction: [
+            'Act only as the independent reviewer described by the context envelope.',
+            'Review the supplied Task result and bind every finding to reviewedCommit.',
+            'Do not modify any repository or Workflow state. Return one ReviewInput JSON object.',
+        ],
+        envelope,
+        task: strictTaskReviewSubject(repositoryRoot, task, taskRoot),
+    };
+    const repositorySeal = sealRepository(repositoryRoot);
+    return {
+        protocol: 'codex-workflow-external-strict-task-review-v1',
+        taskId: task.id,
+        reviewedCommit,
+        packet,
+        packetHash: canonicalHash(packet),
+        repositorySeal,
+        repositorySealHash: canonicalHash(repositorySeal),
+    };
+}
+export function validateExternalStrictStepReviewInput(value, expected) {
+    return validateExternalReviewEnvelope(value, expected);
+}
+export function validateExternalStrictTaskReviewInput(value, expected) {
+    return validateExternalReviewEnvelope(value, expected);
+}
+export function strictReviewInputHash(review) {
+    return hashReviewInput(review);
+}
+function strictStepReviewPayload(repositoryRoot, task, taskRoot, envelope, step, reviewedCommit, currentEvidence) {
+    return {
+        protocol: 'codex-workflow-strict-step-review-v1',
+        instruction: [
+            'Act only as the independent reviewer described by the context envelope.',
+            'Review only the supplied Task Step and bind findings to reviewedCommit.',
+            'Do not modify any repository or Workflow state. Return one ReviewInput JSON object.',
+        ],
+        envelope,
+        task: {
+            id: task.id,
+            baseCommit: task.baseCommit,
+            headCommit: headCommit(repositoryRoot),
+            brief: readFileSync(path.join(taskRoot, 'brief.md'), 'utf8'),
+            plan: readFileSync(path.join(taskRoot, 'plan.md'), 'utf8'),
+            diff: task.baseCommit ? runGit(repositoryRoot, ['diff', '--no-ext-diff', `${task.baseCommit}..HEAD`]) : '',
+        },
+        step: {
+            id: step.id,
+            title: step.title,
+            objective: step.objective,
+            requirements: step.requirements,
+            dependencies: step.dependencies,
+            expectedOutputs: step.expectedOutputs,
+            allowedWrites: step.allowedWrites,
+            forbiddenScope: step.forbiddenScope,
+            checks: step.checks,
+            status: step.status,
+            reviewedCommit,
+            evidence: currentEvidence,
+        },
+    };
+}
+function strictTaskReviewSubject(repositoryRoot, task, taskRoot) {
+    return {
+        id: task.id,
+        baseCommit: task.baseCommit,
+        headCommit: headCommit(repositoryRoot),
+        brief: readFileSync(path.join(taskRoot, 'brief.md'), 'utf8'),
+        plan: readFileSync(path.join(taskRoot, 'plan.md'), 'utf8'),
+        evidence: readFileSync(path.join(taskRoot, 'evidence.json'), 'utf8'),
+        diff: task.baseCommit ? runGit(repositoryRoot, ['diff', '--no-ext-diff', `${task.baseCommit}..HEAD`]) : '',
+    };
+}
+function validateExternalReviewEnvelope(value, expected) {
+    if (!isExactRecord(value, ['protocol', 'packetHash', 'repositorySealHash', 'reviewerThreadId', 'review'])) {
+        throw new Error('invalid external review envelope');
+    }
+    if (value.protocol !== expected.protocol)
+        throw new Error('invalid external review protocol');
+    if (value.packetHash !== expected.packetHash)
+        throw new Error('external review packet hash mismatch');
+    if (value.repositorySealHash !== expected.repositorySealHash)
+        throw new Error('external review repository seal mismatch');
+    if (typeof value.reviewerThreadId !== 'string' || !value.reviewerThreadId.trim()) {
+        throw new Error('external reviewer thread id is required');
+    }
+    if (!isExactRecord(value.review, ['status', 'reviewer', 'summary', 'findings'])) {
+        throw new Error('invalid external strict review');
+    }
+    const review = value.review;
+    if (!['passed', 'failed'].includes(String(review.status))
+        || typeof review.reviewer !== 'string' || !review.reviewer.trim()
+        || typeof review.summary !== 'string' || !review.summary.trim()
+        || !Array.isArray(review.findings)) {
+        throw new Error('invalid external strict review');
+    }
+    const findings = review.findings.map((candidate) => {
+        if (!isExactRecord(candidate, ['id', 'severity', 'requirement', 'summary', 'evidence', 'requiredAction'])
+            || typeof candidate.id !== 'string' || !candidate.id.trim()
+            || !['critical', 'major', 'minor'].includes(String(candidate.severity))
+            || (candidate.requirement !== null && typeof candidate.requirement !== 'string')
+            || typeof candidate.summary !== 'string' || !candidate.summary.trim()
+            || typeof candidate.evidence !== 'string' || !candidate.evidence.trim()
+            || typeof candidate.requiredAction !== 'string' || !candidate.requiredAction.trim()) {
+            throw new Error('invalid external strict review finding');
+        }
+        return {
+            id: candidate.id,
+            severity: candidate.severity,
+            requirement: candidate.requirement,
+            summary: candidate.summary,
+            evidence: candidate.evidence,
+            requiredAction: candidate.requiredAction,
+        };
+    });
+    if ((review.status === 'passed' && findings.length > 0) || (review.status === 'failed' && findings.length === 0)) {
+        throw new Error('invalid external strict review finding cardinality');
+    }
+    return {
+        status: review.status,
+        reviewer: review.reviewer,
+        summary: review.summary,
+        findings,
+    };
+}
+function isExactRecord(value, keys) {
+    if (!value || typeof value !== 'object' || Array.isArray(value))
+        return false;
+    const actual = Object.keys(value).sort();
+    return actual.length === keys.length && actual.every((key, index) => key === [...keys].sort()[index]);
+}
+function canonicalHash(value) {
+    return createHash('sha256').update(canonicalJsonStringify(value)).digest('hex');
+}
 function spawnReviewer(command, args, options) {
     const result = spawnSync(command, args, {
         cwd: options.cwd,
         input: options.input,
         encoding: 'utf8',
         maxBuffer: 16 * 1024 * 1024,
+        timeout: options.timeoutMs,
+        killSignal: 'SIGKILL',
     });
-    return { status: result.status, stdout: result.stdout ?? '', stderr: result.stderr ?? '' };
+    const timedOut = result.error !== undefined && 'code' in result.error && result.error.code === 'ETIMEDOUT';
+    return {
+        status: result.status,
+        stdout: result.stdout ?? '',
+        stderr: [result.stderr ?? '', result.error?.message ?? ''].filter(Boolean).join('\n'),
+        timedOut,
+    };
 }
 function runStrictReviewerLaunch(repositoryRoot, options, runner) {
     const temporary = mkdtempSync(path.join(os.tmpdir(), 'codex-workflow-review-'));
@@ -163,7 +305,8 @@ function runStrictReviewerLaunch(repositoryRoot, options, runner) {
     }
     const before = sealRepository(repositoryRoot);
     const command = [
-        'codex', 'exec', '--ephemeral', '--ignore-user-config', '--ignore-rules', '--sandbox', 'read-only',
+        'codex', '--ask-for-approval', 'never', 'exec',
+        '--ephemeral', '--ignore-user-config', '--ignore-rules', '--sandbox', 'read-only',
         '--output-schema', schemaFile, '--output-last-message', outputFile, '--json', '-C', repositoryRoot, '-',
     ];
     let processResult;
@@ -171,6 +314,7 @@ function runStrictReviewerLaunch(repositoryRoot, options, runner) {
         processResult = runner(command[0], command.slice(1), {
             cwd: repositoryRoot,
             input: `${JSON.stringify(options.packet)}\n`,
+            timeoutMs: STRICT_REVIEWER_TIMEOUT_MS,
         });
     }
     catch (error) {
@@ -195,17 +339,20 @@ function runStrictReviewerLaunch(repositoryRoot, options, runner) {
     const verifiedIsolation = unchanged && output?.isolationProbe === 'denied' && processResult.status === 0;
     const review = verifiedIsolation && output
         ? stripProbe(output)
-        : unverifiedReview(processResult.status !== 0
-            ? `Strict reviewer process failed with status ${String(processResult.status)}.`
-            : probeWritten || !unchanged
-                ? 'Strict reviewer modified repository state; review discarded.'
-                : options.commandSummary);
+        : unverifiedReview(processResult.timedOut
+            ? `Strict reviewer exceeded the ${STRICT_REVIEWER_TIMEOUT_MS}ms execution deadline.`
+            : processResult.status !== 0
+                ? `Strict reviewer process failed with status ${String(processResult.status)}.`
+                : probeWritten || !unchanged
+                    ? 'Strict reviewer modified repository state; review discarded.'
+                    : options.commandSummary);
     const reviewerOutputHash = hashReviewInput(review);
     return {
         review,
         verifiedIsolation,
         command,
         processStatus: processResult.status,
+        timedOut: processResult.timedOut === true,
         stderr: processResult.stderr,
         before,
         after,
@@ -216,22 +363,27 @@ function sealRepository(repositoryRoot) {
     return {
         headCommit: headCommit(repositoryRoot),
         changedFiles: changedFiles(repositoryRoot),
-        contentHash: hashTree(repositoryRoot, repositoryRoot),
+        contentHash: hashReviewableTree(repositoryRoot),
     };
 }
-function hashTree(repositoryRoot, current) {
+function hashReviewableTree(repositoryRoot) {
+    const listed = spawnSync('git', ['-C', repositoryRoot, 'ls-files', '--cached', '--others', '--exclude-standard', '-z'], { encoding: 'utf8' });
+    if (listed.status !== 0) {
+        throw new Error('Unable to enumerate reviewable repository files.');
+    }
     const hash = createHash('sha256');
-    for (const name of readdirSync(current).sort()) {
-        if (current === repositoryRoot && name === '.git')
+    const paths = listed.stdout.split('\0').filter(Boolean).sort();
+    for (const relative of paths) {
+        const absolute = path.join(repositoryRoot, relative);
+        hash.update(`${relative}\0`);
+        if (!existsSync(absolute)) {
+            hash.update('missing');
             continue;
-        const absolute = path.join(current, name);
-        const relative = path.relative(repositoryRoot, absolute).split(path.sep).join('/');
+        }
         const stat = lstatSync(absolute);
-        hash.update(`${relative}\0${stat.mode & 0o777}\0`);
+        hash.update(`${stat.mode & 0o777}\0`);
         if (stat.isSymbolicLink())
             hash.update(`link:${readlinkSync(absolute)}`);
-        else if (stat.isDirectory())
-            hash.update(hashTree(repositoryRoot, absolute));
         else if (stat.isFile())
             hash.update(readFileSync(absolute));
     }
@@ -280,6 +432,7 @@ function failedLaunch(repositoryRoot, command, processStatus, summary) {
         verifiedIsolation: false,
         command,
         processStatus,
+        timedOut: false,
         stderr: summary,
         before: seal,
         after: seal,