codex-review-mcp 2.6.0 → 2.8.0

package/dist/review/buildPrompt.js

@@ -7,8 +7,22 @@ export function buildPrompt({ diffText, context, focus, version, isStaticReview
         '',
         'You are an expert TypeScript, React 18, Material UI, and Emotion UI code reviewer. Be concise, specific, and actionable.',
         '',
-        '⚠️  CRITICAL CONSTRAINT: Review ONLY the files and changes shown in the diff below.',
-        'Do NOT reference, suggest, or mention files that are not in this diff.',
+        '⚠️  CRITICAL CONSTRAINTS:',
+        '1. Review ONLY the files and changes shown in the diff below.',
+        '2. Do NOT reference, suggest, or mention files that are not in this diff.',
+        '3. EVERY finding MUST include:',
+        '   - Exact file path and line number(s) that exist in the diff',
+        '   - A short quoted code snippet from that exact location as evidence',
+        '   - If you cannot quote the code, the finding is invalid',
+        '',
+        '💡 WHEN IN DOUBT, ASK - DON\'T GUESS:',
+        'If you need more information to give accurate feedback, ask clarifying questions instead of making assumptions.',
+        'Good questions help the coding agent provide better context. Examples:',
+        '  • "I see a new `useUserData` hook but don\'t see its tests - are they in a separate PR?"',
+        '  • "This component uses `CustomModal` - is this a new pattern or existing abstraction I should reference?"',
+        '  • "The error handling here is minimal - is there a global error boundary handling this?"',
+        '  • "I need to see the full `UserService` interface to verify this usage is type-safe"',
+        'Asking questions is ALWAYS better than asserting something you cannot verify from the diff.',
         '',
         'PRIORITY HIERARCHY:',
         '1. Project documentation (.cursor/rules/*, CODE_REVIEW.md, CONTRIBUTING.md) - HIGHEST PRIORITY',
@@ -30,11 +44,30 @@ export function buildPrompt({ diffText, context, focus, version, isStaticReview
         '- setTimeout/setInterval without clear cleanup or justification',
         '- Direct DOM manipulation (document.querySelector, etc.) instead of React refs',
         '- Inline styles with hardcoded colors/sizes instead of theme values',
+        '- ⚠️ Z-INDEX CHANGES (HIGH RISK): Treat all z-index modifications with extreme caution. MUST analyze the entire z-index hierarchy, verify no breaking changes in stacking context, and check for existing z-index patterns in codebase before recommending changes.',
         '',
         `\n---\n${reviewType}${isStaticReview ? ' - Code Files' : ' (unified=0)'}:\n`,
         diffText,
         context ? '\n---\nProject context and guidelines (FOLLOW THESE STRICTLY):\n' + context : '',
-        '\n---\nOutput strictly as Markdown with the following sections:\n',
-        '1) Title + scope summary\n2) Quick Summary (3–6 bullets)\n3) Issues table: severity | file:lines | category | explanation | suggested fix\n4) Inline suggested edits for top issues\n5) Positive notes (mention when code follows project guidelines well)\n6) Next steps',
+        '',
+        '---',
+        'BEFORE YOU RESPOND - VALIDATE EACH FINDING:',
+        '- [ ] File path exists in the diff above',
+        '- [ ] Line number(s) exist in that file',
+        '- [ ] Code snippet is quoted verbatim from that location',
+        '- [ ] Issue ties to project rules/patterns (not just generic advice)',
+        '- [ ] If you cannot verify all above → ASK a specific question instead of asserting',
+        '',
+        'Remember: A good clarifying question is more valuable than a questionable assertion.',
+        '',
+        '---',
+        'Output strictly as Markdown with the following sections:',
+        '1) Title + scope summary',
+        '2) Quick Summary (3–6 bullets)',
+        '3) Issues table: severity | file:lines | category | explanation | suggested fix',
+        '4) Inline suggested edits for top issues',
+        '5) Clarifying Questions (if any) - list specific questions that would help provide better feedback',
+        '6) Positive notes (mention when code follows project guidelines well)',
+        '7) Next steps',
     ].join('\n');
 }

package/dist/review/buildPrompt.test.js

@@ -62,10 +62,12 @@ describe('buildPrompt', () => {
         });
         // Verify key sections are present
         expect(prompt).toContain('You are an expert TypeScript, React 18, Material UI, and Emotion UI code reviewer');
-        expect(prompt).toContain('CRITICAL CONSTRAINT: Review ONLY the files');
+        expect(prompt).toContain('CRITICAL CONSTRAINTS');
+        expect(prompt).toContain('Review ONLY the files');
+        expect(prompt).toContain('EVERY finding MUST include');
+        expect(prompt).toContain('BEFORE YOU RESPOND - VALIDATE EACH FINDING');
         expect(prompt).toContain('PRIORITY HIERARCHY');
         expect(prompt).toContain('CORE PRINCIPLES');
-        // Severity is determined by GPT-5 based on context, not pre-defined
         expect(prompt).toContain('Output strictly as Markdown with the following sections');
     });
     it('should include the diff text', () => {
@@ -92,8 +94,11 @@ describe('buildPrompt', () => {
         const prompt = buildPrompt({
             diffText: mockDiff,
         });
-        expect(prompt).toContain('CRITICAL CONSTRAINT: Review ONLY the files');
+        expect(prompt).toContain('CRITICAL CONSTRAINTS');
+        expect(prompt).toContain('Review ONLY the files');
         expect(prompt).toContain('Do NOT reference, suggest, or mention files that are not in this diff');
+        expect(prompt).toContain('EVERY finding MUST include');
+        expect(prompt).toContain('quoted code snippet from that exact location as evidence');
     });
     it('should include guidance hierarchy with proper priorities', () => {
         const prompt = buildPrompt({

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "codex-review-mcp",
-  "version": "2.6.0",
+  "version": "2.8.0",
   "main": "index.js",
   "scripts": {
     "build": "tsc",