codex-review-mcp 2.3.5 → 2.3.6

package/dist/mcp-server.test.js

@@ -171,6 +171,34 @@ describe('MCP Server Integration Tests', () => {
             }), expect.any(Function) // onProgress callback
             );
         });
+        it('should pass workspaceDir parameter for context gathering', async () => {
+            // CRITICAL TEST: Verifies workspaceDir flows from MCP layer to performCodeReview
+            const testWorkspaceDir = '/Users/test/Projects/learn-webapp';
+            await client.callTool({
+                name: 'perform_code_review',
+                arguments: {
+                    content: 'console.log("test");',
+                    workspaceDir: testWorkspaceDir
+                }
+            });
+            // Verify workspaceDir is passed to performCodeReview
+            expect(performCodeReview).toHaveBeenCalledWith(expect.objectContaining({
+                workspaceDir: testWorkspaceDir
+            }), expect.any(Function));
+        });
+        it('should handle missing workspaceDir (falls back to cwd)', async () => {
+            await client.callTool({
+                name: 'perform_code_review',
+                arguments: {
+                    content: 'console.log("test");'
+                    // workspaceDir NOT provided
+                }
+            });
+            // workspaceDir should be undefined, causing gatherContext to use process.cwd()
+            expect(performCodeReview).toHaveBeenCalledWith(expect.objectContaining({
+                workspaceDir: undefined
+            }), expect.any(Function));
+        });
         it('should return markdown content', async () => {
             const result = await client.callTool({
                 name: 'perform_code_review',

package/dist/tools/performCodeReview.js

@@ -37,6 +37,16 @@ export async function performCodeReview(input, onProgress) {
         : shouldSkip
             ? ''
             : await gatherContext(input.workspaceDir);
+    // Debug: Log what context was gathered (to stderr for MCP logs)
+    console.error(`[codex-review-mcp] Context gathered: ${context.length} chars`);
+    const hasCursorRules = context.includes('.cursor/rules');
+    console.error(`[codex-review-mcp] Contains .cursor/rules: ${hasCursorRules}`);
+    if (hasCursorRules) {
+        const cursorFiles = (context.match(/<!-- \.cursor\/rules\/[^>]+ -->/g) || []);
+        console.error(`[codex-review-mcp] Cursor rules files: ${cursorFiles.join(', ')}`);
+    }
+    // Also use debugLog for persistent logging
+    await debugLog(`Context gathered: ${context.length} chars, .cursor/rules: ${hasCursorRules}`);
     // Build expert prompt
     await onProgress?.('Building expert prompt…', 50, 100);
     const isStaticReview = input.contentType === 'code';

package/dist/tools/performCodeReview.test.js

@@ -112,6 +112,34 @@ describe('performCodeReview', () => {
             });
             expect(gatherContextModule.gatherContext).toHaveBeenCalledWith(workspaceDir);
         });
+        it('should use process.cwd() when workspaceDir is not provided', async () => {
+            const gatherSpy = vi.spyOn(gatherContextModule, 'gatherContext').mockResolvedValue('');
+            vi.spyOn(invokeAgentModule, 'invokeAgent').mockResolvedValue('# Review');
+            await performCodeReview({
+                content: mockDiff
+                // workspaceDir NOT provided
+            });
+            // Should be called with undefined, which makes gatherContext use process.cwd()
+            expect(gatherSpy).toHaveBeenCalledWith(undefined);
+        });
+        it('should find .cursor/rules when workspaceDir points to correct directory', async () => {
+            // This tests the critical path: workspaceDir -> gatherContext -> .cursor/rules
+            const workspaceDir = '/project/with/cursor/rules';
+            const gatherSpy = vi.spyOn(gatherContextModule, 'gatherContext')
+                .mockResolvedValue('<!-- .cursor/rules/project.mdc -->\n# Cursor Rules\nUse strict mode');
+            vi.spyOn(invokeAgentModule, 'invokeAgent').mockResolvedValue('# Review');
+            const buildPromptSpy = vi.spyOn(buildPromptModule, 'buildPrompt').mockReturnValue('prompt');
+            await performCodeReview({
+                content: mockDiff,
+                workspaceDir
+            });
+            // Verify gatherContext was called with the workspace dir
+            expect(gatherSpy).toHaveBeenCalledWith(workspaceDir);
+            // Verify the gathered context (with .cursor/rules) is passed to buildPrompt
+            expect(buildPromptSpy).toHaveBeenCalledWith(expect.objectContaining({
+                context: expect.stringContaining('.cursor/rules/project.mdc')
+            }));
+        });
     });
     describe('Content Types', () => {
         it('should handle diff content type', async () => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "codex-review-mcp",
-  "version": "2.3.5",
+  "version": "2.3.6",
   "main": "index.js",
   "scripts": {
     "build": "tsc",