codex-plugin-doctor 1.37.0 → 1.38.0

package/README.md

@@ -402,9 +402,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v5
-      - uses: Esquetta/CodexPluginDoctor@v1.37.0
+      - uses: Esquetta/CodexPluginDoctor@v1.38.0
         with:
-          version: "1.37.0"
+          version: "1.38.0"
           path: .
           runtime: "true"
           policy: codex-publish

package/dist/core/dep-audit.js

@@ -15,9 +15,13 @@ async function fileExists(filePath) {
 }
 async function runNpmAudit(cwd) {
     return new Promise((resolve, reject) => {
-        const command = process.platform === "win32" ? process.env.ComSpec ?? "cmd.exe" : "npm";
+        const npmCliPath = process.env.npm_execpath ??
+            path.join(path.dirname(process.execPath), "node_modules", "npm", "bin", "npm-cli.js");
+        const command = process.platform === "win32"
+            ? process.execPath
+            : "npm";
         const args = process.platform === "win32"
-            ? ["/d", "/s", "/c", "npm", "audit", "--json"]
+            ? [npmCliPath, "audit", "--json"]
             : ["audit", "--json"];
         execFile(command, args, { cwd, timeout: 120_000 }, (error, stdout, stderr) => {
             const parsed = (() => {

package/dist/core/npm-package-doctor.js

@@ -9,9 +9,11 @@ const execFileAsync = promisify(execFile);
 const gunzipAsync = promisify(gunzip);
 function npmCommand(args) {
     if (process.platform === "win32") {
+        const npmCliPath = process.env.npm_execpath ??
+            path.join(path.dirname(process.execPath), "node_modules", "npm", "bin", "npm-cli.js");
         return {
-            command: process.env.ComSpec ?? "cmd.exe",
-            args: ["/d", "/s", "/c", "npm", ...args]
+            command: process.execPath,
+            args: [npmCliPath, ...args]
         };
     }
     return { command: "npm", args };

package/dist/security/security-audit.d.ts

@@ -13,6 +13,7 @@ export interface SecurityAudit {
 export declare function auditMcpServerConfig(rootPath: string, parsedConfig: unknown, options?: {
     configPath?: string;
 }): Finding[];
+export declare function auditChildProcessSourceSurface(rootPath: string): Promise<Finding[]>;
 export declare function buildSecurityAuditFromFindings(targetPath: string, findings: Finding[]): SecurityAudit;
 export declare function buildSecurityAudit(targetPath: string): Promise<SecurityAudit>;
 export declare function renderSecurityAuditJson(audit: SecurityAudit): string;

package/dist/security/security-audit.js

@@ -157,13 +157,34 @@ const poisonScanSkippedDirectories = new Set([
     ".git",
     "coverage",
     "dist",
-    "node_modules"
+    "node_modules",
+    "release-candidate",
+    "tests"
 ]);
 const promptInjectionPatterns = [
     /\bignore\s+(?:all\s+)?(?:previous|prior|system|developer)\s+instructions?\b/i,
     /\b(?:exfiltrate|steal|leak|upload|send)\b.{0,120}\b(?:secret|secrets|token|tokens|api\s*key|api\s*keys|credential|credentials|environment\s+variables?|env)\b/i,
     /\bdo\s+not\s+(?:reveal|tell|mention|disclose)\b.{0,120}\b(?:instruction|instructions|prompt|prompts|system|developer)\b/i
 ];
+const childProcessScanExtensions = new Set([
+    ".cjs",
+    ".js",
+    ".mjs",
+    ".ts",
+    ".tsx"
+]);
+function importsChildProcess(content) {
+    return (/\bfrom\s+["']node:child_process["']/.test(content) ||
+        /\bfrom\s+["']child_process["']/.test(content) ||
+        /\brequire\(\s*["'](?:node:)?child_process["']\s*\)/.test(content));
+}
+function sourceUsesShellOption(content) {
+    return /\bshell\s*:\s*(?:true|process\.platform\s*===\s*["']win32["'])/.test(content);
+}
+function sourceUsesShellCommand(content) {
+    return (/["']cmd(?:\.exe)?["'][\s\S]{0,200}["']\/c["']/i.test(content) ||
+        /["'](?:powershell|pwsh)(?:\.exe)?["'][\s\S]{0,200}["']-(?:command|encodedcommand|enc)["']/i.test(content));
+}
 export function auditMcpServerConfig(rootPath, parsedConfig, options = {}) {
     const configPath = options.configPath
         ? relativePackagePath(rootPath, options.configPath)
@@ -270,6 +291,45 @@ async function auditPromptPoisoningSurface(rootPath) {
     }
     return findings;
 }
+async function collectChildProcessScanFiles(rootPath, currentPath = rootPath) {
+    const entries = await readdir(currentPath, { withFileTypes: true });
+    const filePaths = [];
+    for (const entry of entries) {
+        const entryPath = path.join(currentPath, entry.name);
+        if (entry.isDirectory()) {
+            if (poisonScanSkippedDirectories.has(entry.name)) {
+                continue;
+            }
+            filePaths.push(...(await collectChildProcessScanFiles(rootPath, entryPath)));
+            continue;
+        }
+        if (!entry.isFile() || !childProcessScanExtensions.has(path.extname(entry.name).toLowerCase())) {
+            continue;
+        }
+        const details = await stat(entryPath);
+        if (details.size <= 512 * 1024) {
+            filePaths.push(entryPath);
+        }
+    }
+    return filePaths;
+}
+export async function auditChildProcessSourceSurface(rootPath) {
+    const findings = [];
+    for (const filePath of await collectChildProcessScanFiles(rootPath)) {
+        const content = await readFile(filePath, "utf8");
+        if (!importsChildProcess(content)) {
+            continue;
+        }
+        const relativeFilePath = relativePackagePath(rootPath, filePath);
+        if (sourceUsesShellOption(content)) {
+            findings.push(buildFinding("fail", "plugin.security.child_process_shell", `The source file \`${relativeFilePath}\` enables child_process shell execution.`, "Shell execution expands command strings through a platform shell, which can turn quoting bugs or user-controlled args into command injection.", "Use `spawn` or `execFile` with an explicit executable and argument array instead of enabling `shell`.", { filePath: relativeFilePath }));
+        }
+        if (sourceUsesShellCommand(content)) {
+            findings.push(buildFinding("fail", "plugin.security.child_process_shell_command", `The source file \`${relativeFilePath}\` appears to launch a shell command wrapper.`, "Explicit shell wrappers such as `cmd /c` or `powershell -Command` make command execution harder to audit and increase injection risk.", "Launch the concrete executable directly, or use platform-specific executable names such as `npm.cmd` on Windows.", { filePath: relativeFilePath }));
+        }
+    }
+    return findings;
+}
 async function auditMcpCommandSurface(discoveredPackage) {
     const { manifest, rootPath } = discoveredPackage;
     if (!manifest.mcpServers) {
@@ -343,6 +403,7 @@ export async function buildSecurityAudit(targetPath) {
     const findings = [
         ...validationSecurityFindings,
         ...(await auditMcpCommandSurface(discoveredPackage)),
+        ...(await auditChildProcessSourceSurface(discoveredPackage.rootPath)),
         ...(await auditPromptPoisoningSurface(discoveredPackage.rootPath))
     ];
     return buildSecurityAuditFromFindings(discoveredPackage.rootPath, findings);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "codex-plugin-doctor",
-  "version": "1.37.0",
+  "version": "1.38.0",
   "description": "CLI-first validator for Codex plugins, skills, and MCP package surfaces with runtime MCP protocol validation.",
   "type": "module",
   "main": "./dist/index.js",