codex-plugin-doctor 1.34.0 → 1.35.0

package/README.md

@@ -402,9 +402,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v5
-      - uses: Esquetta/CodexPluginDoctor@v1.34.0
-        with:
-          version: "1.34.0"
+      - uses: Esquetta/CodexPluginDoctor@v1.35.0
+        with:
+          version: "1.35.0"
           path: .
           runtime: "true"
           policy: codex-publish

package/dist/compatibility/compatibility-matrix.js

@@ -30,6 +30,11 @@ function statusFromCheckResult(result) {
     }
     return "pass";
 }
+function isPathWithinRoot(rootPath, candidatePath) {
+    const relativePath = path.relative(rootPath, candidatePath);
+    return (relativePath === "" ||
+        (!relativePath.startsWith("..") && !path.isAbsolute(relativePath)));
+}
 export async function readMcpConfigPath(targetPath) {
     const rootPath = path.resolve(targetPath);
     const directMcpPath = path.join(rootPath, ".mcp.json");
@@ -40,21 +45,38 @@ export async function readMcpConfigPath(targetPath) {
     if (!(await fileExists(manifestPath))) {
         return null;
     }
+    let manifest;
     try {
-        const manifest = await readJsonFile(manifestPath);
-        return typeof manifest.mcpServers === "string"
-            ? path.resolve(rootPath, manifest.mcpServers)
-            : null;
+        manifest = await readJsonFile(manifestPath);
     }
     catch {
         return null;
     }
+    if (typeof manifest.mcpServers !== "string") {
+        return null;
+    }
+    const mcpConfigPath = path.resolve(rootPath, manifest.mcpServers);
+    if (!isPathWithinRoot(rootPath, mcpConfigPath)) {
+        throw new Error("Manifest MCP config path resolves outside the package root.");
+    }
+    return mcpConfigPath;
 }
 async function hasCodexManifest(targetPath) {
     return fileExists(path.join(path.resolve(targetPath), ".codex-plugin", "plugin.json"));
 }
 async function checkGenericMcp(targetPath) {
-    const mcpConfigPath = await readMcpConfigPath(targetPath);
+    let mcpConfigPath;
+    try {
+        mcpConfigPath = await readMcpConfigPath(targetPath);
+    }
+    catch (error) {
+        return {
+            client: "Generic MCP",
+            status: "fail",
+            summary: error instanceof Error ? error.message : "MCP config path is unsafe.",
+            details: ["Keep `.mcp.json` or manifest `mcpServers` references inside the package root."]
+        };
+    }
     if (!mcpConfigPath || !(await fileExists(mcpConfigPath))) {
         return {
             client: "Generic MCP",

package/dist/core/runtime-probe.js

@@ -193,12 +193,20 @@ async function fileExists(targetPath) {
         return false;
     }
 }
+function isPathWithinRoot(rootPath, candidatePath) {
+    const relativePath = path.relative(rootPath, candidatePath);
+    return (relativePath === "" ||
+        (!relativePath.startsWith("..") && !path.isAbsolute(relativePath)));
+}
 async function loadMcpServers(discoveredPackage) {
     const { manifest, rootPath } = discoveredPackage;
     if (!manifest.mcpServers) {
         return null;
     }
     const mcpConfigPath = path.resolve(rootPath, manifest.mcpServers);
+    if (!isPathWithinRoot(rootPath, mcpConfigPath)) {
+        return null;
+    }
     const exists = await fileExists(mcpConfigPath);
     if (!exists) {
         return null;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "codex-plugin-doctor",
-  "version": "1.34.0",
+  "version": "1.35.0",
   "description": "CLI-first validator for Codex plugins, skills, and MCP package surfaces with runtime MCP protocol validation.",
   "type": "module",
   "main": "./dist/index.js",