codex-plugin-doctor 1.11.0 → 1.13.0

package/README.md

@@ -358,9 +358,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v5
-      - uses: Esquetta/CodexPluginDoctor@v1.11.0
+      - uses: Esquetta/CodexPluginDoctor@v1.13.0
         with:
-          version: "1.11.0"
+          version: "1.13.0"
           path: .
           runtime: "true"
           policy: codex-publish

package/dist/core/review-bundle.js

@@ -1,5 +1,5 @@
 import { createHash } from "node:crypto";
-import { mkdir, readFile, stat, writeFile } from "node:fs/promises";
+import { mkdir, readFile, realpath, stat, writeFile } from "node:fs/promises";
 import path from "node:path";
 import { buildDoctorAttestation, renderDoctorAttestationJson, verifyDoctorAttestation } from "./attestation.js";
 import { buildDoctorReleaseEvidenceReport, renderDoctorReleaseEvidenceJson, verifyDoctorReleaseEvidence } from "./release-evidence.js";
@@ -10,14 +10,60 @@ import { readJsonFile } from "./read-json-file.js";
 function isPlainObject(value) {
     return typeof value === "object" && value !== null && !Array.isArray(value);
 }
+function hasExactKeys(value, keys) {
+    const actualKeys = Object.keys(value);
+    return actualKeys.length === keys.length && keys.every((key) => actualKeys.includes(key));
+}
+function isStatus(value) {
+    return value === "pass" || value === "warn" || value === "fail";
+}
+function isRuntimePolicyDecision(value) {
+    return value === "allow" ||
+        value === "review" ||
+        value === "sandbox_recommended" ||
+        value === "deny";
+}
+function isBundleFileMap(value) {
+    const expectedKeys = Object.keys(relativeBundleFiles());
+    return isPlainObject(value) &&
+        hasExactKeys(value, expectedKeys) &&
+        expectedKeys.every((key) => typeof value[key] === "string");
+}
+function isIntegrityEntry(value) {
+    if (!isPlainObject(value)) {
+        return false;
+    }
+    const bytes = value.bytes;
+    return typeof value.path === "string" &&
+        typeof value.digest === "string" &&
+        /^sha256:[a-f0-9]{64}$/.test(value.digest) &&
+        typeof bytes === "number" &&
+        Number.isSafeInteger(bytes) &&
+        bytes >= 0;
+}
+function isManifestIntegrity(value) {
+    return isPlainObject(value) &&
+        value.algorithm === "sha256" &&
+        isPlainObject(value.files) &&
+        Object.values(value.files).every(isIntegrityEntry);
+}
 function isDoctorReviewBundleManifest(value) {
     return isPlainObject(value) &&
         value.schemaVersion === "1.0.0" &&
         value.kind === "doctor.review.bundle" &&
+        typeof value.generatedAt === "string" &&
+        typeof value.version === "string" &&
         typeof value.targetPath === "string" &&
         typeof value.outputDirectory === "string" &&
+        isStatus(value.status) &&
+        (value.exitCode === 0 || value.exitCode === 1) &&
         isPlainObject(value.summary) &&
-        isPlainObject(value.files);
+        isRuntimePolicyDecision(value.summary.runtimePolicy) &&
+        typeof value.summary.releaseReady === "boolean" &&
+        isStatus(value.summary.attestation) &&
+        (value.summary.releaseEvidence === "pass" || value.summary.releaseEvidence === "fail") &&
+        isBundleFileMap(value.files) &&
+        (value.integrity === undefined || isManifestIntegrity(value.integrity));
 }
 function statusRank(status) {
     return status === "fail" ? 2 : status === "warn" ? 1 : 0;
@@ -50,6 +96,21 @@ function isPathInsideDirectory(candidatePath, directoryPath) {
     const relativePath = path.relative(directoryPath, candidatePath);
     return relativePath === "" || (!relativePath.startsWith("..") && !path.isAbsolute(relativePath));
 }
+async function resolveBundleArtifactPath(bundleDirectory, relativePath) {
+    const resolvedBundleDirectory = path.resolve(bundleDirectory);
+    const artifactPath = path.resolve(resolvedBundleDirectory, relativePath);
+    if (!isPathInsideDirectory(artifactPath, resolvedBundleDirectory)) {
+        throw new Error("Bundle artifact path resolves outside the bundle directory.");
+    }
+    const [canonicalBundleDirectory, canonicalArtifactPath] = await Promise.all([
+        realpath(resolvedBundleDirectory),
+        realpath(artifactPath)
+    ]);
+    if (!isPathInsideDirectory(canonicalArtifactPath, canonicalBundleDirectory)) {
+        throw new Error("Bundle artifact canonical path resolves outside the bundle directory.");
+    }
+    return canonicalArtifactPath;
+}
 function bundleStatus(runtimePolicy, releaseEvidence) {
     if (runtimePolicy.status === "fail" || releaseEvidence.status === "fail") {
         return "fail";
@@ -171,7 +232,7 @@ export function renderDoctorReviewBundleJson(bundle) {
     return JSON.stringify(bundle.manifest, null, 2);
 }
 async function readBundleJsonFile(bundleDirectory, relativePath) {
-    return readJsonFile(path.join(bundleDirectory, relativePath));
+    return readJsonFile(await resolveBundleArtifactPath(bundleDirectory, relativePath));
 }
 async function readBundleDiffSnapshot(bundleDirectory) {
     const manifestArtifact = await readBundleJsonFile(bundleDirectory, "manifest.json");
@@ -348,15 +409,7 @@ export async function verifyDoctorReviewBundle(bundleDirectory, options) {
     const files = manifest?.files ?? relativeBundleFiles();
     for (const [fileKey, relativePath] of Object.entries(files)) {
         try {
-            const artifactPath = path.resolve(resolvedBundleDirectory, relativePath);
-            if (!isPathInsideDirectory(artifactPath, resolvedBundleDirectory)) {
-                checks.push({
-                    id: `review_bundle.file.${fileKey}`,
-                    status: "fail",
-                    message: `${relativePath} resolves outside the review bundle directory.`
-                });
-                continue;
-            }
+            const artifactPath = await resolveBundleArtifactPath(resolvedBundleDirectory, relativePath);
             const fileStat = await stat(artifactPath);
             checks.push({
                 id: `review_bundle.file.${fileKey}`,
@@ -427,8 +480,8 @@ export async function verifyDoctorReviewBundle(bundleDirectory, options) {
                     });
                     continue;
                 }
-                const integrityPath = path.resolve(resolvedBundleDirectory, expected.path);
-                if (!isPathInsideDirectory(integrityPath, resolvedBundleDirectory)) {
+                const resolvedIntegrityPath = path.resolve(resolvedBundleDirectory, expected.path);
+                if (!isPathInsideDirectory(resolvedIntegrityPath, resolvedBundleDirectory)) {
                     integrityStatus = "fail";
                     checks.push({
                         id: `review_bundle.integrity.${fileKey}.path`,
@@ -437,6 +490,7 @@ export async function verifyDoctorReviewBundle(bundleDirectory, options) {
                     });
                     continue;
                 }
+                const integrityPath = await resolveBundleArtifactPath(resolvedBundleDirectory, expected.path);
                 const content = await readFile(integrityPath);
                 const digest = sha256(content);
                 const matches = digest === expected.digest && content.byteLength === expected.bytes;
@@ -505,7 +559,8 @@ export async function verifyDoctorReviewBundle(bundleDirectory, options) {
         });
     }
     try {
-        attestation = await verifyDoctorAttestation(path.join(resolvedBundleDirectory, files.attestationJson), targetPath, { signingKey: options.signingKey });
+        const attestationPath = await resolveBundleArtifactPath(resolvedBundleDirectory, files.attestationJson);
+        attestation = await verifyDoctorAttestation(attestationPath, targetPath, { signingKey: options.signingKey });
         checks.push({
             id: "review_bundle.attestation",
             status: attestation.status,
@@ -522,7 +577,8 @@ export async function verifyDoctorReviewBundle(bundleDirectory, options) {
         });
     }
     try {
-        releaseEvidence = await verifyDoctorReleaseEvidence(path.join(resolvedBundleDirectory, files.releaseEvidenceJson), {
+        const releaseEvidencePath = await resolveBundleArtifactPath(resolvedBundleDirectory, files.releaseEvidenceJson);
+        releaseEvidence = await verifyDoctorReleaseEvidence(releaseEvidencePath, {
             signingKey: options.signingKey,
             targetPath
         });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "codex-plugin-doctor",
-  "version": "1.11.0",
+  "version": "1.13.0",
   "description": "CLI-first validator for Codex plugins, skills, and MCP package surfaces with runtime MCP protocol validation.",
   "type": "module",
   "main": "./dist/index.js",