codeninja 3.2.0 → 4.0.0

package/ide/antigravity/.agents/workflows/codeninja-refactor.md

@@ -1,68 +1,76 @@
+This workflow runs when user invokes /codeninja:refactor
+
 ---
-slash_command: /codeninja:refactor
-personas: [global-orchestrator, nodejs-backend, database-architect]
-skills: [mcp-and-context, api-builder, database, code-intelligence]
-description: Rename or restructure code with full context tracking.
+type: workflow
+name: refactor
+description: >
+  Rename, restructure, or improve existing code. Always records changes in
+  context.change_log so all agents remain aware of the history.
 ---
 
-# /codeninja:refactor
+# Workflow: @refactor
+
+## Goal
+Make a controlled change to existing code with full traceability in context.
 
-## Before Running
-1. Call `context_read`
-2. Call `context_check_stale`
+## Rules
+- Every rename is recorded in `context.change_log`
+- DB column renames generate a migration file
+- Never delete the old name from change_log
 
-## Execution — Full Step-by-Step
+---
 
-**Step 1.** Ask: "What type of refactor?"
-1. Rename a DB column
-2. Rename a service
-3. Rename a table
-4. Rename a module
-5. Restructure files
-- Store: `context.current_refactor.type`
+## Step-by-Step Execution
 
-**Step 2.** Ask: "Which service?" (if applicable — skip for DB-only refactors)
+1. Run task: `ask-refactor-type`
+   - Options: rename DB column, rename service, rename module, restructure files
+   - Stores: `context.current_refactor.type`
 
----
+2. Run task: `ask-target-service` (if applicable)
 
-### If "Rename DB column":
-- Ask: "Which table?" (list from context)
-- Ask: "Which column to rename?" (list current columns)
-- Ask: "New column name?" (snake_case)
-- Delegate to database-agent:
-  - Generate ALTER TABLE migration file
+3. Based on refactor type:
+
+### rename DB column
+- Run task: `ask-table-name`
+- Run task: `ask-old-column-name`
+- Run task: `ask-new-column-name`
+- Delegate to `database-agent`:
+  - Generate ALTER TABLE migration
   - Update `context.db.schema.tables[<table>].columns`
   - Append to `context.db.schema.change_log`
-- Delegate to nodejs-agent:
+- Delegate to `nodejs-agent`:
   - Find all references to old column name in service files
   - Update model queries
   - Update swagger_doc.json
 
-### If "Rename service":
-- Ask: "Current service name?" (list from context)
-- Ask: "New service name?"
+### rename service
+- Run task: `ask-old-service-name`
+- Run task: `ask-new-service-name`
 - Update `context.services` key
 - Append to `context.change_log`
 
-### If "Rename table":
-- Ask: "Which table?" (list from context)
-- Ask: "New table name?" (must start with tbl_, snake_case)
-- Delegate to database-agent:
+### rename table
+- Run task: `ask-table-name`
+- Run task: `ask-new-table-name`
+- Delegate to `database-agent`:
   - Generate ALTER migration: `RENAME TABLE <old> TO <new>`
   - Update `context.db.schema.tables` key
-  - Append to `context.db.schema.change_log`: `{ type: "table_renamed", from: "<old>", to: "<new>" }`
-- Delegate to nodejs-agent:
+  - Append to `context.db.schema.change_log`:
+    `{ type: "table_renamed", from: "<old>", to: "<new>", migration_file: "..." }`
+- Delegate to `nodejs-agent`:
   - Find all references to old table name in model files
   - Update queries in all affected services
 - Append to top-level `context.change_log`
 
-### If "Rename module":
-- Ask: "Current module name?"
-- Ask: "New module name?"
-- Delegate to nodejs-agent → rename files and update route_manager
+### rename module
+- Run task: `ask-old-module-name`
+- Run task: `ask-new-module-name`
+- Delegate to `nodejs-agent` → rename files and update route_manager
 
----
+4. Confirm: "Apply refactor? (yes/no)"
+
+> **Multi-agent:** Delegate to `database-architect` (DB refactors) or `nodejs-backend` (service/module refactors) via Task invocation for parallel execution.
+> Read `.codeninja/tasks/` before applying each change.
 
-**Confirm:** "Apply refactor? (yes/no)"
-If yes → make all changes → call `context_write` → call `context_clear_scratchpad` ["current_refactor"]
-Show final summary.
+5. If yes → make changes → run task: `write-context`
+6. Run task: `show-final-summary`

package/ide/antigravity/.agents/workflows/codeninja-review.md

@@ -1,29 +1,42 @@
+This workflow runs when user invokes /codeninja:review
+
 ---
-slash_command: /codeninja:review
-personas: [global-orchestrator, nodejs-backend]
-skills: [mcp-and-context, api-builder, code-intelligence]
-description: Deep code review with severity-ranked findings and concrete fixes.
+type: workflow
+name: review
+description: >
+  Deep code review of any file or module — security, architecture, naming
+  conventions, and alignment with project patterns. Outputs severity-ranked
+  findings with exact fixes.
 ---
 
-# /codeninja:review
+# Workflow: @review / /codeninja:review
 
-## Before Running
-1. Call `context_read`
-2. Call `context_check_stale`
+## Goal
+Produce a structured code review that finds real issues using actual project
+context — not generic best practices. Every finding references the real file
+and line, and every fix is concrete code, not advice.
+
+## Rules
+- Read the actual file before reviewing it
+- Cross-reference `context.db.schema` for table/column accuracy
+- Compare against 1–2 existing modules to check pattern consistency
+- Never flag something as an issue if it's the established pattern in this project
+
+---
 
-## Execution — Full Step-by-Step
+## Step-by-Step Execution
 
 ### Step 1 — Identify Target
-If not specified, ask: "Which file or module would you like reviewed?"
+If not specified, ask: "Which file or module would you like me to review?"
 
 ### Step 2 — Load Context
-1. Call `fs_read` on the target file
-2. Read 1–2 similar modules from `context.services[<service>].modules` for pattern comparison
-3. Cross-reference `context.db.schema` for table/column accuracy
+1. Call `context_read`
+2. Call `fs_read` on the target file
+3. Read 1–2 similar modules from `context.services[<service>].modules` for comparison
 
 ### Step 3 — Run Review Checklist
 
-#### Security (CRITICAL if failing)
+#### Security (flag as CRITICAL if failing)
 - [ ] All POST/PUT/PATCH routes have validatorjs input validation
 - [ ] API key middleware applied before any route logic
 - [ ] JWT auth middleware present on protected routes
@@ -31,20 +44,20 @@ If not specified, ask: "Which file or module would you like reviewed?"
 - [ ] Parameterized queries only — no string concatenation in SQL
 - [ ] Error responses don't leak stack traces or internal details
 
-#### Architecture (WARNING if failing)
+#### Architecture (flag as WARNING if failing)
 - [ ] 2-layer rule: no SQL in route.js, no res.json() in model.js
 - [ ] route_manager.js registration matches route file
 - [ ] swagger_doc.json has entry for this endpoint
 - [ ] All user-facing strings in languages/en.js — none hardcoded in route.js
 
-#### Code Quality (SUGGESTION if failing)
+#### Code Quality (flag as SUGGESTION if failing)
 - [ ] JSDoc on every exported function
 - [ ] No unused variables or dead imports
 - [ ] No console.log — project logger used instead
 - [ ] Async functions have try/catch blocks
 - [ ] SELECT * not used — explicit column list
 
-#### Database (WARNING if failing)
+#### Database (flag as WARNING if failing)
 - [ ] Column names match context.db.schema exactly (snake_case)
 - [ ] Foreign key columns indexed
 - [ ] Transactions used where multiple writes occur together
@@ -62,9 +75,13 @@ After:  the corrected code
 Why:    one sentence explanation
 ```
 
-End with: `Review complete: X critical · Y warnings · Z suggestions`
+End with summary line:
+```
+Review complete: X critical · Y warnings · Z suggestions
+```
 
 ### Step 5 — Offer Auto-Fix
-"Would you like me to apply any of these fixes?
-- SUGGESTION-level: apply all at once
-- WARNING/CRITICAL: one at a time, confirm each"
+"Would you like me to apply any of these fixes? I'll confirm each change before writing."
+
+For SUGGESTION-level items: offer to apply all at once.
+For WARNING/CRITICAL items: apply one at a time, confirm each.