codeimpact 0.3.1 → 0.3.2

package/dist/index.js

@@ -8300,7 +8300,7 @@ function buildFeatureAgentDefinition(feature) {
       created_by: "code-impact"
     },
     scope: {
-      includedPaths: [...feature.paths, ...feature.testFiles],
+      includedPaths: [...feature.paths, ...deriveTestGlobs(feature)],
       excludedPaths: feature.paths.map((p) => p.replace("/**", "/__mocks__/**"))
     },
     allowedTools: [
@@ -8473,6 +8473,25 @@ function renderAgentsShim(agents, config2) {
   }
   return lines.join("\n");
 }
+function deriveTestGlobs(feature) {
+  if (feature.testFiles.length === 0) return [];
+  const dirCounts = /* @__PURE__ */ new Map();
+  for (const tf of feature.testFiles) {
+    const parts = tf.split("/");
+    const dir = parts.slice(0, -1).join("/");
+    dirCounts.set(dir, (dirCounts.get(dir) || 0) + 1);
+  }
+  const globs = [];
+  for (const [dir, count] of dirCounts) {
+    if (count >= 2) {
+      globs.push(`${dir}/**`);
+    } else {
+      const file2 = feature.testFiles.find((f) => f.startsWith(dir + "/"));
+      if (file2) globs.push(file2);
+    }
+  }
+  return globs;
+}
 function parseAgentMd(content) {
   try {
     const frontmatterMatch = content.match(/^---\n([\s\S]*?)\n---/);
@@ -10464,7 +10483,9 @@ function findSubPackageJsons(projectPath) {
       const entries = readdirSync10(dir, { withFileTypes: true });
       for (const entry of entries) {
         if (!entry.isDirectory()) continue;
-        if (entry.name === "node_modules" || entry.name === ".git" || entry.name === "dist") continue;
+        const lower = entry.name.toLowerCase();
+        if (lower === "node_modules" || lower === ".git" || lower === "dist") continue;
+        if (EXCLUDED_FEATURE_DIRS.has(lower)) continue;
         const subDir = join30(dir, entry.name);
         const pkgJson = join30(subDir, "package.json");
         if (existsSync29(pkgJson) && subDir !== projectPath) {
@@ -10571,6 +10592,9 @@ function groupByDirectory(files, projectPath) {
     if (srcIdx >= 0 && parts.length > srcIdx + 2) {
       dirKey = parts.slice(0, srcIdx + 2).join("/");
     } else if (parts.length >= 2 && parts[0]) {
+      const topDir = parts[0].toLowerCase();
+      if (EXCLUDED_FEATURE_DIRS.has(topDir)) continue;
+      if (!SOURCE_TOP_DIRS.has(topDir)) continue;
       dirKey = parts[0];
     } else {
       continue;
@@ -10672,15 +10696,33 @@ function findTestFiles(featurePaths, allFiles) {
   return testFiles;
 }
 function isUtilityDir(dirName) {
-  return UTILITY_DIRS.has(dirName.toLowerCase());
+  const lower = dirName.toLowerCase();
+  return UTILITY_DIRS.has(lower) || EXCLUDED_FEATURE_DIRS.has(lower);
 }
 function slugify6(name) {
   return name.toLowerCase().replace(/[^a-z0-9]+/g, "-").replace(/^-+|-+$/g, "").slice(0, 40);
 }
-var UTILITY_DIRS;
+var SOURCE_TOP_DIRS, UTILITY_DIRS, EXCLUDED_FEATURE_DIRS;
 var init_feature_detector = __esm({
   "src/core/agents/feature-detector.ts"() {
     "use strict";
+    SOURCE_TOP_DIRS = /* @__PURE__ */ new Set([
+      "src",
+      "app",
+      "apps",
+      "packages",
+      "services",
+      "modules",
+      "test",
+      "tests",
+      "spec",
+      "e2e",
+      "api",
+      "lib",
+      "cmd",
+      "internal",
+      "pkg"
+    ]);
     UTILITY_DIRS = /* @__PURE__ */ new Set([
       "lib",
       "libs",
@@ -10699,6 +10741,47 @@ var init_feature_detector = __esm({
       "vendor",
       "third-party"
     ]);
+    EXCLUDED_FEATURE_DIRS = /* @__PURE__ */ new Set([
+      // Runtime-generated / workspace
+      "knowledge",
+      ".code-impact",
+      ".codeimpact",
+      ".claude",
+      ".cursor",
+      // Documentation
+      "doc",
+      "docs",
+      "documentation",
+      // Build / output
+      "dist",
+      "build",
+      "out",
+      ".next",
+      ".nuxt",
+      ".output",
+      // Dependencies
+      "node_modules",
+      ".yarn",
+      ".pnpm-store",
+      // CI / config
+      ".github",
+      ".gitlab",
+      ".circleci",
+      "scripts",
+      ".husky",
+      // Test fixtures (not features themselves)
+      "fixtures",
+      "base",
+      "__fixtures__",
+      "__snapshots__",
+      // Data / migrations
+      "migrations",
+      "seeds",
+      "data",
+      // IDE / editor
+      ".vscode",
+      ".idea"
+    ]);
   }
 });
 
@@ -11315,8 +11398,9 @@ function renderFeatureSkill(feature, technologies, config2) {
     lines.push(`- ${p}`);
   }
   if (feature.testFiles.length > 0) {
-    for (const tf of feature.testFiles) {
-      lines.push(`- ${tf}`);
+    const testGlobs = summarizeTestFiles(feature.testFiles);
+    for (const tg of testGlobs) {
+      lines.push(`- ${tg}`);
     }
   }
   lines.push("");
@@ -11399,6 +11483,25 @@ function parseAutoContentSections(autoContent) {
   }
   return sections;
 }
+function summarizeTestFiles(testFiles) {
+  if (testFiles.length === 0) return [];
+  const dirCounts = /* @__PURE__ */ new Map();
+  for (const tf of testFiles) {
+    const parts = tf.split("/");
+    const dir = parts.slice(0, -1).join("/");
+    dirCounts.set(dir, (dirCounts.get(dir) || 0) + 1);
+  }
+  const globs = [];
+  for (const [dir, count] of dirCounts) {
+    if (count >= 2) {
+      globs.push(`${dir}/**`);
+    } else {
+      const file2 = testFiles.find((f) => f.startsWith(dir + "/"));
+      if (file2) globs.push(file2);
+    }
+  }
+  return globs;
+}
 function inferDirPurpose(dirName) {
   const purposes = {
     core: "Core business logic and domain modules",
@@ -11420,15 +11523,26 @@ function inferDirPurpose(dirName) {
 }
 function deriveRules(feature, technologies) {
   const rules = [];
-  for (const tech of technologies) {
-    const knowledge = TECH_KNOWLEDGE[tech.name];
-    if (knowledge) {
-      rules.push(...knowledge.rules);
+  if (WELL_KNOWN_FEATURES.has(feature.name)) {
+    rules.push(...getFeatureNameRules(feature.name));
+    const techRules = [];
+    for (const tech of technologies) {
+      const knowledge = TECH_KNOWLEDGE[tech.name];
+      if (knowledge) techRules.push(...knowledge.rules);
+    }
+    for (const tr of techRules.slice(0, 2)) {
+      if (!rules.some((r) => r.includes(tr.split(" ")[0] || ""))) {
+        rules.push(tr);
+      }
+    }
+  } else {
+    for (const tech of technologies) {
+      const knowledge = TECH_KNOWLEDGE[tech.name];
+      if (knowledge) rules.push(...knowledge.rules);
+    }
+    if (rules.length === 0) {
+      rules.push(...getFeatureNameRules(feature.name));
     }
-  }
-  if (rules.length === 0) {
-    const featureRules = getFeatureNameRules(feature.name);
-    rules.push(...featureRules);
   }
   if (feature.paths.length > 0) {
     const scope = feature.paths[0]?.replace("/**", "") || "";
@@ -11438,15 +11552,24 @@ function deriveRules(feature, technologies) {
 }
 function derivePitfalls(feature, technologies) {
   const pitfalls = [];
-  for (const tech of technologies) {
-    const knowledge = TECH_KNOWLEDGE[tech.name];
-    if (knowledge) {
-      pitfalls.push(...knowledge.pitfalls);
+  if (WELL_KNOWN_FEATURES.has(feature.name)) {
+    pitfalls.push(...getFeatureNamePitfalls(feature.name));
+    for (const tech of technologies) {
+      const knowledge = TECH_KNOWLEDGE[tech.name];
+      if (knowledge) {
+        for (const p of knowledge.pitfalls.slice(0, 1)) {
+          if (!pitfalls.includes(p)) pitfalls.push(p);
+        }
+      }
+    }
+  } else {
+    for (const tech of technologies) {
+      const knowledge = TECH_KNOWLEDGE[tech.name];
+      if (knowledge) pitfalls.push(...knowledge.pitfalls);
+    }
+    if (pitfalls.length === 0) {
+      pitfalls.push(...getFeatureNamePitfalls(feature.name));
     }
-  }
-  if (pitfalls.length === 0) {
-    const featurePitfalls = getFeatureNamePitfalls(feature.name);
-    pitfalls.push(...featurePitfalls);
   }
   return pitfalls;
 }
@@ -11562,7 +11685,7 @@ function filterDirectDependencies(technologies, projectPath) {
   }
   return technologies.filter((t) => !skipPatterns.some((p) => p.test(t.name))).slice(0, 20);
 }
-var TECH_KNOWLEDGE;
+var TECH_KNOWLEDGE, WELL_KNOWN_FEATURES;
 var init_generator = __esm({
   "src/core/agents/generator.ts"() {
     "use strict";
@@ -11689,6 +11812,19 @@ var init_generator = __esm({
         ]
       }
     };
+    WELL_KNOWN_FEATURES = /* @__PURE__ */ new Set([
+      "server",
+      "storage",
+      "indexing",
+      "core",
+      "test",
+      "knowledge",
+      "doc",
+      "auth",
+      "api",
+      "billing",
+      "cli"
+    ]);
   }
 });
 
@@ -12398,6 +12534,8 @@ function createMinimalIntelligence(projectPath, technologies, features) {
       layers,
       dataFlow: inferDataFlow(features),
       keyComponents: [],
+      patternCategories: {},
+      topPatterns: [],
       functionStats: { total: 0, exported: 0 }
     },
     dependencyHotspots: [],
@@ -43124,22 +43262,32 @@ ${END_MARKER}`;
     return { content: `${block}
 `, changed: true };
   }
-  const start = existing.indexOf(START_MARKER);
-  const end = existing.indexOf(END_MARKER);
-  if (start >= 0 && end > start) {
-    const before = existing.slice(0, start).trimEnd();
-    const after = existing.slice(end + END_MARKER.length).trimStart();
-    const content2 = `${before}
-
-${block}
-
-${after}`.trim() + "\n";
-    return { content: content2, changed: content2 !== existing };
+  let cleaned = existing;
+  let hadMarkers = false;
+  while (true) {
+    const start = cleaned.indexOf(START_MARKER);
+    const end = cleaned.indexOf(END_MARKER, start >= 0 ? start : 0);
+    if (start >= 0 && end > start) {
+      hadMarkers = true;
+      cleaned = cleaned.slice(0, start) + cleaned.slice(end + END_MARKER.length);
+    } else if (end >= 0 && start < 0) {
+      hadMarkers = true;
+      cleaned = cleaned.slice(0, end) + cleaned.slice(end + END_MARKER.length);
+    } else {
+      break;
+    }
   }
-  const content = `${existing.trimEnd()}
+  cleaned = cleaned.replace(/\n{3,}/g, "\n\n").trim();
+  let content;
+  if (!cleaned) {
+    content = `${block}
+`;
+  } else {
+    content = `${cleaned}
 
 ${block}
 `;
+  }
   return { content, changed: content !== existing };
 }
 function writeManagedFile(targetPath, section, options) {
@@ -43172,93 +43320,61 @@ function renderPlatformSection(platform, paths, skillIndex, evolutionGuidance) {
   let attentionSection = "";
   if (evolutionGuidance && evolutionGuidance.length > 0) {
     attentionSection = `
-
 ### Skills Needing Attention
 ${evolutionGuidance.map((g) => `- ${g}`).join("\n")}`;
   }
-  return `# CodeImpact Knowledge System
+  return `# CodeImpact \u2014 AI-Powered Codebase Intelligence
+
+You have access to **CodeImpact**, a persistent knowledge system that understands this codebase. It provides project skills, architecture knowledge, and self-learning agents.
+
+## IMPORTANT: Session Start
+
+1. **Read project knowledge** before making changes:
+   - \`.code-impact/project/SKILL.md\` \u2014 Tech stack, architecture, key directories
+   - \`.code-impact/project/CONVENTIONS.md\` \u2014 Coding standards and patterns
+   - \`.code-impact/project/ARCHITECTURE.md\` \u2014 System layers and data flow
+2. **Read feature knowledge** for the files you're modifying:
+   - \`.code-impact/features/{feature}/SKILL.md\` \u2014 Feature-specific rules, pitfalls, and research refs
+   - Features: check \`.code-impact/features/\` for available feature directories
+3. Run \`${tool("memory_status")}\` for project overview and recent changes
 
-You are part of a **self-improving knowledge system**. Skills you create persist across sessions. Future AI sessions benefit from the knowledge you build now.
+## MCP Tools (Use FIRST before built-in tools)
 
-## Tools
 | Task | Tool |
 |------|------|
-| Find code | \`${tool("memory_query")}\` |
-| Check code | \`${tool("memory_review")}\` |
-| Verify code | \`${tool("memory_verify")}\` |
+| Search code semantically | \`${tool("memory_query")}\` |
+| Review code before changes | \`${tool("memory_review")}\` |
+| Verify before committing | \`${tool("memory_verify")}\` |
 | Project status | \`${tool("memory_status")}\` |
 | Impact analysis | \`${tool("memory_blast_radius")}\` |
+| Agent system | \`${tool("memory_agents")}\` |
 | Build knowledge | \`${tool("memory_evolve")}\` |
 
-## Session Start
-1. Run \`${tool("memory_status")}\` \u2014 check \`knowledge_gaps\` for uncovered technologies and high-risk files.
-2. Read relevant skills from \`knowledge/skills/\` for the current task.
+## Agent System
 
-## Skill Creation Protocol
+This project has feature-level agents in \`.code-impact/features/\`. Each agent has:
+- **SKILL.md** \u2014 Rules, pitfalls, and technology-specific guidance
+- **AGENT.md** \u2014 Scope, allowed tools, and lessons learned from past mistakes
 
-**After completing any task involving 3+ files**, create or improve a skill.
+Before modifying files, check the relevant feature's SKILL.md for rules and pitfalls.
+After completing a task, record the outcome via \`${tool("memory_agents")}\` with action="record_outcome".
 
-### To create a new skill:
-\`${tool("memory_evolve")}\` with:
-- action="create_skill"
-- name="technology-or-area-name" (slug format)
-- description="One line: when to use this skill"
-- scope="technology|feature|risk|core"
-- content="Full markdown body (see format below)"
+## Skill Management
 
-### To improve an existing skill:
-\`${tool("memory_evolve")}\` with:
-- action="improve_skill", skill_id="skill-name"
-- Patch mode: old_text="exact text to replace", new_text="replacement"
-- Append mode: section="pitfalls", content="New pitfall to add"
+After completing any task involving 3+ files, create or improve a skill:
 
-### To discover gaps:
-\`${tool("memory_evolve")}\` with action="list_signals"
-
-### Skill Format (agentskills.io SKILL.md)
-
-\`\`\`markdown
----
-name: better-sqlite3-patterns
-description: Synchronous database patterns. Use when working with database queries or schema changes.
-version: 1.0
-metadata:
-  scope: technology
-  created_by: ai
----
-
-# better-sqlite3 Patterns
-
-## When to Use
-When modifying database queries, adding tables, or working with files that import from src/storage/database.ts.
-
-## Key Facts
-- Database: .codeimpact/codeimpact.db (SQLite, WAL mode)
-- API: better-sqlite3 (synchronous, NOT async)
-
-## Rules
-- ALL database access goes through database.ts \u2014 never import better-sqlite3 directly.
-- Use db.prepare().all() for SELECT, db.prepare().run() for INSERT/UPDATE/DELETE.
-
-## Pitfalls
-- db.exec() returns nothing. If you use it for SELECT, you get undefined.
-- better-sqlite3 is synchronous. Do NOT wrap in async/await.
-
-## Verification
-- npx tsc --noEmit passes with no type errors on database code.
-\`\`\`
+\`${tool("memory_evolve")}\` with action="create_skill" (new) or action="improve_skill" (update)
 
 ### Quality Rules
-- **Under 5000 tokens** per skill
-- **Be specific**: "Use db.prepare().all() for SELECT" not "follow project patterns"
-- **Pitfalls with symptoms**: "you'll get undefined" not "don't misuse"
-- **Every line earns its tokens** \u2014 no filler, no generic advice the AI already knows
+- Under 5000 tokens per skill
+- Be specific: "Use db.prepare().all() for SELECT" not "follow project patterns"
+- Include pitfalls with symptoms: "you'll get undefined" not "don't misuse"
 
 ## Existing Skills
 ${skillList}
 ${attentionSection}
 
-## Workspace
+## Knowledge Workspace
 \`${paths.root.replace(/\\/g, "/")}\``;
 }
 var PlatformRuleSync = class {