codehere 0.3.0-rc.8 → 0.3.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +11 -11
- package/dist/domain/services/codebase-detector.js +1 -1
- package/dist/index.js +42 -5
- package/dist/infrastructure/hooks/session-analyzer.js +14 -5
- package/dist/infrastructure/orchestration/conductor-adapter.js +16 -5
- package/dist/infrastructure/orchestration/generic-cli-adapter.js +0 -3
- package/dist/infrastructure/protocols/mcp-server-impl.js +33 -3
- package/dist/infrastructure/security/file-collection.js +3 -0
- package/dist/presentation/cli/commands/report-command.js +56 -11
- package/dist/presentation/cli/commands/status-command.js +32 -10
- package/dist/presentation/cli/repl.js +651 -198
- package/dist/ui.js +0 -3
- package/dist/utils/typo-guard.js +73 -0
- package/dist/utils/version.js +1 -1
- package/package.json +1 -1
package/README.md
CHANGED
|
@@ -4,12 +4,12 @@
|
|
|
4
4
|
|
|
5
5
|
[](https://www.npmjs.com/package/codehere)
|
|
6
6
|
[](../LICENSE)
|
|
7
|
-
[]()
|
|
8
8
|
[]()
|
|
9
9
|
|
|
10
|
-
codehere is **a PM for your AI coding agents.** Delegate a task. codehere picks the right specialist (Claude Code, Codex, Aider, or OpenCode),
|
|
10
|
+
codehere is **a PM for your AI coding agents.** Delegate a task. codehere picks the right specialist (Claude Code, Codex, Aider, or OpenCode), spawns it, streams its work back to you, and hands you a plain-English Final Report with a **trust score on every file changed**. Today, Claude Code gets full pre-execution safety-hook enforcement on every tool call; other adapters are session-traced and reported, with per-tool hook parity planned for v0.4.
|
|
11
11
|
|
|
12
|
-
One manager, many specialists,
|
|
12
|
+
One manager, many specialists, every action recorded.
|
|
13
13
|
|
|
14
14
|
## Install
|
|
15
15
|
|
|
@@ -49,10 +49,10 @@ Pick an agent, type a task, hit **Assign**. codehere:
|
|
|
49
49
|
|
|
50
50
|
1. Spawns the agent with the right headless flags
|
|
51
51
|
2. Streams the steps back as readable progress · *"Read src/auth.ts · Edit src/auth.ts · Run npm test"*
|
|
52
|
-
3.
|
|
52
|
+
3. For Claude Code tasks: routes every tool call through the codehere safety hook — you see *"🛡 5 safe · 0 blocked"* grow live. For Codex / Aider / OpenCode tasks: emits the agent's native event stream (no per-tool blocking yet)
|
|
53
53
|
4. On completion, hands you a **Final report**: files changed with `+/-` lines, trust score per file, test pass/fail, token usage
|
|
54
54
|
|
|
55
|
-
|
|
55
|
+
Claude Code tool calls are logged to `~/.codehere/audit/hook-events.jsonl`; spawned-task lifecycle (any adapter) is logged to `~/.codehere/sessions.jsonl`.
|
|
56
56
|
|
|
57
57
|
### Just the safety hook (no agents required)
|
|
58
58
|
|
|
@@ -65,7 +65,7 @@ codehere report # generates a shareable markdown audit report
|
|
|
65
65
|
codehere status # quick dashboard · sessions, blocks, trust trends
|
|
66
66
|
```
|
|
67
67
|
|
|
68
|
-
The hook intercepts every `Bash`, `Edit`, `Write`, `MultiEdit`, and `NotebookEdit` call from any Claude Code session running on your machine, runs it through the trust-scorer pattern bank in under 5 ms, blocks anything matching the destructive / credential / injection patterns, and appends every decision to
|
|
68
|
+
The hook intercepts every `Bash`, `Edit`, `Write`, `MultiEdit`, and `NotebookEdit` call from any Claude Code session running on your machine, runs it through the trust-scorer pattern bank in under 5 ms, blocks anything matching the destructive / credential / injection patterns, and appends every decision to an append-only JSONL audit log at `~/.codehere/audit/`. (Hook coverage today is Claude Code-only — Codex / Aider / OpenCode adapters spawn through their native CLIs and emit to `~/.codehere/sessions.jsonl`; full hook parity across all adapters is v0.4 work.)
|
|
69
69
|
|
|
70
70
|
## Commands
|
|
71
71
|
|
|
@@ -90,14 +90,14 @@ codehere scan-tool · internal · used by the hook system, not by users
|
|
|
90
90
|
|
|
91
91
|
## What it catches
|
|
92
92
|
|
|
93
|
-
The trust scorer + safety hook detect
|
|
93
|
+
The trust scorer + safety hook detect ~36 patterns across:
|
|
94
94
|
|
|
95
|
-
- SQL injection · XSS · command injection · path traversal
|
|
96
|
-
- Hardcoded secrets · weak crypto · JWT bypass
|
|
95
|
+
- SQL injection · XSS · command injection · path traversal
|
|
96
|
+
- Hardcoded secrets · API keys · weak crypto · JWT bypass
|
|
97
97
|
- Eval injection · prompt injection · credential theft
|
|
98
|
-
- Destructive operations · supply-chain patterns
|
|
98
|
+
- Destructive shell operations · supply-chain patterns
|
|
99
99
|
|
|
100
|
-
Every blocked call is logged with the reason; every allowed call is logged with the trust score.
|
|
100
|
+
Every blocked call is logged with the reason; every allowed call is logged with the trust score. Pattern bank lives in `agent/src/infrastructure/security/trust-scorer.ts`.
|
|
101
101
|
|
|
102
102
|
## MCP server
|
|
103
103
|
|
|
@@ -9,7 +9,7 @@ import { join, dirname, resolve } from 'path';
|
|
|
9
9
|
*/
|
|
10
10
|
export function findCodebaseRoot(startPath = process.cwd()) {
|
|
11
11
|
const resolvedStart = resolve(startPath);
|
|
12
|
-
|
|
12
|
+
const currentDir = resolvedStart;
|
|
13
13
|
// Try to find git root first
|
|
14
14
|
const gitRoot = findGitRoot(currentDir);
|
|
15
15
|
if (gitRoot) {
|
package/dist/index.js
CHANGED
|
@@ -37,12 +37,19 @@ catch {
|
|
|
37
37
|
}
|
|
38
38
|
config();
|
|
39
39
|
import { getVersion } from './utils/version.js';
|
|
40
|
+
import { checkTypo } from './utils/typo-guard.js';
|
|
40
41
|
const program = new Command();
|
|
41
42
|
program
|
|
42
43
|
.name('codehere')
|
|
43
44
|
.description('A PM for your AI coding agents. Delegate a task, watch it run, get a plain-English report with a trust score on every file.')
|
|
44
45
|
.version(getVersion())
|
|
45
|
-
.configureHelp({ helpWidth: 80, sortSubcommands: true })
|
|
46
|
+
.configureHelp({ helpWidth: 80, sortSubcommands: true })
|
|
47
|
+
// rc.18: many users hit `codehere --help` first and get Commander's flat
|
|
48
|
+
// list. The grouped `codehere help` is more useful for discovery. Surface
|
|
49
|
+
// it inline so muscle-memory `--help` users find the better page.
|
|
50
|
+
// (Pin: no raw ANSI in --help output — existing commands.test.ts asserts
|
|
51
|
+
// this, see test/cli/commands.test.ts "no raw ANSI escape codes in --help".)
|
|
52
|
+
.addHelpText('after', '\nTip: `codehere help` shows commands grouped by use case (Delegate · Safety & Trust · Configuration).');
|
|
46
53
|
// Default action · show welcome, then drop into the interactive REPL on TTY.
|
|
47
54
|
// codehere offers TWO surfaces, both first-class: the CLI REPL (here) and the
|
|
48
55
|
// web UI (`codehere start`). Users pick whichever fits their workflow.
|
|
@@ -52,8 +59,23 @@ program
|
|
|
52
59
|
// One-shot delegate: `codehere "review src/auth.ts"` runs that task and exits.
|
|
53
60
|
// Useful for scripting or quick one-offs without entering the REPL.
|
|
54
61
|
if (query && query.trim()) {
|
|
62
|
+
const trimmed = query.trim();
|
|
63
|
+
// Typo guard — see src/utils/typo-guard.ts for heuristics.
|
|
64
|
+
// Returns suggestions when input looks like a typo; null falls through.
|
|
65
|
+
const known = program.commands.map((c) => c.name());
|
|
66
|
+
const suggestions = checkTypo(trimmed, known);
|
|
67
|
+
if (suggestions) {
|
|
68
|
+
console.error(`codehere: unknown command '${trimmed}'.`);
|
|
69
|
+
console.error('');
|
|
70
|
+
console.error(' Did you mean:');
|
|
71
|
+
for (const s of suggestions)
|
|
72
|
+
console.error(` codehere ${s}`);
|
|
73
|
+
console.error('');
|
|
74
|
+
console.error(` If you meant to ask a question, quote it: codehere "${trimmed}"`);
|
|
75
|
+
process.exit(1);
|
|
76
|
+
}
|
|
55
77
|
const { runOneShot } = await import('./presentation/cli/repl.js');
|
|
56
|
-
await runOneShot(
|
|
78
|
+
await runOneShot(trimmed);
|
|
57
79
|
return;
|
|
58
80
|
}
|
|
59
81
|
if (!process.stdin.isTTY) {
|
|
@@ -103,8 +125,23 @@ program
|
|
|
103
125
|
.command('health')
|
|
104
126
|
.description('Check system health and metrics')
|
|
105
127
|
.option('-m, --metrics', 'Show detailed metrics')
|
|
128
|
+
.option('--json', 'Machine-readable JSON (for monitoring/CI)')
|
|
106
129
|
.action((options) => {
|
|
107
130
|
const health = performHealthCheck();
|
|
131
|
+
if (options.json) {
|
|
132
|
+
// Machine-readable: status + checks (+ metrics when --metrics).
|
|
133
|
+
// Stdout is the contract — never mix with the human banner.
|
|
134
|
+
// Use process.exitCode (not process.exit) so a piped consumer sees the
|
|
135
|
+
// full JSON before the process tears down (rc.16: Codex flagged the old
|
|
136
|
+
// process.exit call as a truncation hazard under stdout redirection).
|
|
137
|
+
const payload = { status: health.status, checks: health.checks };
|
|
138
|
+
if (options.metrics)
|
|
139
|
+
payload.metrics = getMetrics();
|
|
140
|
+
console.log(JSON.stringify(payload, null, 2));
|
|
141
|
+
if (health.status === 'unhealthy')
|
|
142
|
+
process.exitCode = 1;
|
|
143
|
+
return;
|
|
144
|
+
}
|
|
108
145
|
if (isMinimalStyle()) {
|
|
109
146
|
printMinimalHeader('health', '');
|
|
110
147
|
}
|
|
@@ -202,9 +239,9 @@ program
|
|
|
202
239
|
.command('report')
|
|
203
240
|
.description('Generate a shareable security audit report — narrative, not just a score')
|
|
204
241
|
.argument('[target]', 'File or directory to audit (default: current directory)')
|
|
205
|
-
.option('--out <file>', 'Write report to a specific file (default: codehere-audit.md)')
|
|
206
|
-
.option('--stdout', 'Print the report to stdout
|
|
207
|
-
.option('--json', 'Output machine-readable JSON
|
|
242
|
+
.option('--out <file>', 'Write report to a specific file (default: codehere-audit.md for markdown)')
|
|
243
|
+
.option('--stdout', 'Print the report to stdout (already the default for --json)')
|
|
244
|
+
.option('--json', 'Output machine-readable JSON to stdout (pipe to jq, etc.)')
|
|
208
245
|
.option('--simple', 'Plain English output — no jargon, for non-technical stakeholders')
|
|
209
246
|
.addHelpText('after', `
|
|
210
247
|
Examples:
|
|
@@ -76,17 +76,26 @@ export function detectAmplificationAlerts(sessions) {
|
|
|
76
76
|
continue;
|
|
77
77
|
let message = '';
|
|
78
78
|
const risk = session.amplificationRisk;
|
|
79
|
-
|
|
80
|
-
|
|
79
|
+
// rc.17 framing: don't accuse "injection" by default — that wording scares
|
|
80
|
+
// users on perfectly normal long attended sessions. Reserve the strong
|
|
81
|
+
// language for cases where the *blocked-call ratio* is high (real signal
|
|
82
|
+
// of prompts trying things they shouldn't), not just call volume.
|
|
83
|
+
// UX_OBSERVATIONS.md P1.
|
|
84
|
+
const blockRatio = session.totalCalls > 0 ? session.blockedCalls / session.totalCalls : 0;
|
|
85
|
+
if (session.blockedCalls > 0 && session.totalCalls > 20 && blockRatio > 0.05) {
|
|
86
|
+
message = `${session.totalCalls} tool calls, ${session.blockedCalls} blocked (${(blockRatio * 100).toFixed(0)}%) — high block ratio, review for injection`;
|
|
87
|
+
}
|
|
88
|
+
else if (session.blockedCalls > 0 && session.totalCalls > 20) {
|
|
89
|
+
message = `${session.totalCalls} tool calls, ${session.blockedCalls} blocked — long session, review if unattended`;
|
|
81
90
|
}
|
|
82
91
|
else if (session.totalCalls > 50) {
|
|
83
|
-
message = `${session.totalCalls} tool calls in one session —
|
|
92
|
+
message = `${session.totalCalls} tool calls in one session — high density, review if unattended`;
|
|
84
93
|
}
|
|
85
94
|
else if ((session.toolMix['Bash'] ?? 0) > 10) {
|
|
86
|
-
message = `${session.toolMix['Bash']} Bash calls in one session — elevated
|
|
95
|
+
message = `${session.toolMix['Bash']} Bash calls in one session — elevated tool-mix`;
|
|
87
96
|
}
|
|
88
97
|
else {
|
|
89
|
-
message = `${session.totalCalls} calls, ${session.blockedCalls} blocked — worth
|
|
98
|
+
message = `${session.totalCalls} calls, ${session.blockedCalls} blocked — worth a glance`;
|
|
90
99
|
}
|
|
91
100
|
alerts.push({
|
|
92
101
|
sessionId: session.sessionId,
|
|
@@ -91,7 +91,12 @@ function tokenize(prompt) {
|
|
|
91
91
|
// "add tests" "add-tests" "add_tests" "add/tests" "add:tests" "add.tests"
|
|
92
92
|
// Note: must NOT collapse the leading/trailing spaces — they're load-bearing
|
|
93
93
|
// for the boundary check below (`.includes(' ' + t + ' ')`).
|
|
94
|
-
const normalized = ' ' +
|
|
94
|
+
const normalized = ' ' +
|
|
95
|
+
prompt
|
|
96
|
+
.toLowerCase()
|
|
97
|
+
.replace(/[^a-z0-9]+/g, ' ')
|
|
98
|
+
.trim() +
|
|
99
|
+
' ';
|
|
95
100
|
return { tokens, normalized };
|
|
96
101
|
}
|
|
97
102
|
/**
|
|
@@ -240,7 +245,6 @@ function spawnConductor(prompt, options, lookup) {
|
|
|
240
245
|
},
|
|
241
246
|
};
|
|
242
247
|
buffer.push(errEvent);
|
|
243
|
-
queueMicrotask(() => emitter.emit('event', errEvent));
|
|
244
248
|
return synthesizeSession({ sessionId, startedAt, prompt, statusValue, emitter, buffer });
|
|
245
249
|
}
|
|
246
250
|
// Emit the routing-decision event FIRST so the audit log records WHY this
|
|
@@ -255,8 +259,11 @@ function spawnConductor(prompt, options, lookup) {
|
|
|
255
259
|
promptExcerpt: prompt.slice(0, 200),
|
|
256
260
|
},
|
|
257
261
|
};
|
|
262
|
+
// Buffer replay on subscribe() handles delivery to the first subscriber. Do
|
|
263
|
+
// NOT also queueMicrotask(emit) — the microtask fires AFTER subscribe attaches
|
|
264
|
+
// its handler, so the handler would receive routingEvent twice (rc.13 bug:
|
|
265
|
+
// duplicate "routing → ..." line in the REPL).
|
|
258
266
|
buffer.push(routingEvent);
|
|
259
|
-
queueMicrotask(() => emitter.emit('event', routingEvent));
|
|
260
267
|
// Find the chosen specialist adapter and spawn against it.
|
|
261
268
|
const specialist = lookup().find((a) => a.id === decision.agentId);
|
|
262
269
|
if (!specialist) {
|
|
@@ -269,7 +276,6 @@ function spawnConductor(prompt, options, lookup) {
|
|
|
269
276
|
data: { message: `Conductor picked '${decision.agentId}' but no adapter with that ID is registered.` },
|
|
270
277
|
};
|
|
271
278
|
buffer.push(errEvent);
|
|
272
|
-
queueMicrotask(() => emitter.emit('event', errEvent));
|
|
273
279
|
return synthesizeSession({ sessionId, startedAt, prompt, statusValue, emitter, buffer });
|
|
274
280
|
}
|
|
275
281
|
// Spawn the specialist session and proxy every event through.
|
|
@@ -284,7 +290,12 @@ function spawnConductor(prompt, options, lookup) {
|
|
|
284
290
|
stepsSnapshot = specialistSession.steps;
|
|
285
291
|
if (specialistSession.artifacts)
|
|
286
292
|
artifactsSnapshot = specialistSession.artifacts;
|
|
287
|
-
|
|
293
|
+
// Specialist adapters terminate with an 'exit' event — never emit
|
|
294
|
+
// 'codehere:complete' / 'codehere:error'. Without mirroring on 'exit',
|
|
295
|
+
// session.status stayed 'running' forever and the REPL printed
|
|
296
|
+
// "✗ └─ running" (rc.13 bug). Also keep the legacy types for safety in
|
|
297
|
+
// case a future adapter emits them.
|
|
298
|
+
if (evt.type === 'exit' || evt.type === 'codehere:complete' || evt.type === 'codehere:error') {
|
|
288
299
|
statusValue = specialistSession.status;
|
|
289
300
|
}
|
|
290
301
|
});
|
|
@@ -478,7 +478,6 @@ export function compileSafePattern(source, fallback, agentId) {
|
|
|
478
478
|
// Layer 1 · static shape check — this is the only fully reliable defense.
|
|
479
479
|
const danger = detectRedosShape(source);
|
|
480
480
|
if (danger) {
|
|
481
|
-
// eslint-disable-next-line no-console
|
|
482
481
|
console.warn(`[codehere] Regex for "${agentId}" rejected (${danger}) — using fallback`);
|
|
483
482
|
return fallback;
|
|
484
483
|
}
|
|
@@ -487,7 +486,6 @@ export function compileSafePattern(source, fallback, agentId) {
|
|
|
487
486
|
candidate = new RegExp(source);
|
|
488
487
|
}
|
|
489
488
|
catch {
|
|
490
|
-
// eslint-disable-next-line no-console
|
|
491
489
|
console.warn(`[codehere] Invalid regex in agents.yaml for "${agentId}" — using fallback`);
|
|
492
490
|
return fallback;
|
|
493
491
|
}
|
|
@@ -496,7 +494,6 @@ export function compileSafePattern(source, fallback, agentId) {
|
|
|
496
494
|
const start = Date.now();
|
|
497
495
|
candidate.test('a'.repeat(1000));
|
|
498
496
|
if (Date.now() - start > 100) {
|
|
499
|
-
// eslint-disable-next-line no-console
|
|
500
497
|
console.warn(`[codehere] Regex for "${agentId}" too slow (likely ReDoS) — using fallback`);
|
|
501
498
|
return fallback;
|
|
502
499
|
}
|
|
@@ -20,7 +20,8 @@
|
|
|
20
20
|
*/
|
|
21
21
|
import http from 'http';
|
|
22
22
|
import { readFileSync, existsSync, statSync, watchFile, unwatchFile } from 'fs';
|
|
23
|
-
import { join, relative } from 'path';
|
|
23
|
+
import { join, relative, dirname } from 'path';
|
|
24
|
+
import { fileURLToPath } from 'url';
|
|
24
25
|
import { collectFilesForMCP, scoreFileForMCP } from './mcp-helpers.js';
|
|
25
26
|
import { scanPayload, calculateRiskScore, AUDIT_FILE } from '../hooks/claude-sdk-hook.js';
|
|
26
27
|
import { getVersion } from '../../utils/version.js';
|
|
@@ -589,8 +590,14 @@ export function startMCPServer(options = {}) {
|
|
|
589
590
|
res.end(JSON.stringify({ error: 'Method not allowed for this path' }));
|
|
590
591
|
return;
|
|
591
592
|
}
|
|
592
|
-
// MCP endpoint
|
|
593
|
-
|
|
593
|
+
// MCP endpoint — POST jsonrpc; reject other verbs with 405 + Allow header
|
|
594
|
+
// (rc.17: was 404, which is wrong HTTP semantic — UX_OBSERVATIONS P3).
|
|
595
|
+
if (req.url === '/mcp') {
|
|
596
|
+
if (req.method !== 'POST') {
|
|
597
|
+
res.writeHead(405, { 'Content-Type': 'application/json', Allow: 'POST' });
|
|
598
|
+
res.end(JSON.stringify({ error: 'MCP endpoint accepts POST only', method: req.method }));
|
|
599
|
+
return;
|
|
600
|
+
}
|
|
594
601
|
let body = '';
|
|
595
602
|
req.on('data', (chunk) => {
|
|
596
603
|
body += chunk;
|
|
@@ -612,6 +619,29 @@ export function startMCPServer(options = {}) {
|
|
|
612
619
|
});
|
|
613
620
|
return;
|
|
614
621
|
}
|
|
622
|
+
// /api/version — small completeness item for ops monitoring (rc.17).
|
|
623
|
+
// ESM-friendly: resolve package.json relative to the compiled module's
|
|
624
|
+
// own URL via fileURLToPath. Works in both src/ (during dev) and dist/
|
|
625
|
+
// because the relative path up to package.json is the same in both.
|
|
626
|
+
if (req.url === '/api/version' && req.method === 'GET') {
|
|
627
|
+
try {
|
|
628
|
+
const moduleDir = dirname(fileURLToPath(import.meta.url));
|
|
629
|
+
const pkgPath = join(moduleDir, '..', '..', '..', 'package.json');
|
|
630
|
+
const pkg = JSON.parse(readFileSync(pkgPath, 'utf-8'));
|
|
631
|
+
res.writeHead(200, { 'Content-Type': 'application/json' });
|
|
632
|
+
res.end(JSON.stringify({ version: pkg.version, name: pkg.name }));
|
|
633
|
+
}
|
|
634
|
+
catch (e) {
|
|
635
|
+
// rc.19: don't leak fs paths to the public HTTP surface.
|
|
636
|
+
// rc.20: but DO log the actual error context for the operator (Codex
|
|
637
|
+
// rc.19 review caught: previous version dropped `e` and logged only a
|
|
638
|
+
// static string, costing diagnosability).
|
|
639
|
+
console.error('[/api/version] failed to read package metadata:', e);
|
|
640
|
+
res.writeHead(500, { 'Content-Type': 'application/json' });
|
|
641
|
+
res.end(JSON.stringify({ error: 'Failed to read package metadata' }));
|
|
642
|
+
}
|
|
643
|
+
return;
|
|
644
|
+
}
|
|
615
645
|
// 404
|
|
616
646
|
res.writeHead(404);
|
|
617
647
|
res.end();
|
|
@@ -62,6 +62,9 @@ export const IGNORE_DIRS = new Set([
|
|
|
62
62
|
'.cache',
|
|
63
63
|
'.codehere',
|
|
64
64
|
'.codehere-cache',
|
|
65
|
+
// Cloned reference repos used for dogfooding / comparison — not the user's code.
|
|
66
|
+
// Codehere convention; mirrors how `.git` is hidden tooling-data, not source.
|
|
67
|
+
'.oss-repos',
|
|
65
68
|
// Test fixtures / mocks (intentionally-vulnerable code used as scanner inputs)
|
|
66
69
|
'fixtures',
|
|
67
70
|
'test-fixtures',
|
|
@@ -237,14 +237,61 @@ function generateSimpleReport(report, target) {
|
|
|
237
237
|
lines.push('Generated by codehere — know what your AI agent did before your tech lead asks.');
|
|
238
238
|
return lines.join('\n');
|
|
239
239
|
}
|
|
240
|
+
/**
|
|
241
|
+
* Write report to the requested path. If the path is unwritable (EROFS,
|
|
242
|
+
* EACCES, EPERM, ENOENT on a parent dir we can't create), fall back to
|
|
243
|
+
* stdout so the user still gets the report instead of a stack trace.
|
|
244
|
+
*
|
|
245
|
+
* Returns true if the file was written, false if we fell back to stdout.
|
|
246
|
+
*
|
|
247
|
+
* Provoked by rc.25 UAT: `codehere report --simple` from `/` crashed with
|
|
248
|
+
* `EROFS: read-only file system, open 'codehere-audit.md'`. A user running
|
|
249
|
+
* the command from any unwritable cwd should still get their report.
|
|
250
|
+
*/
|
|
251
|
+
function writeReportWithFallback(targetPath, content, label) {
|
|
252
|
+
try {
|
|
253
|
+
writeFileSync(targetPath, content);
|
|
254
|
+
console.log(success(`${label} written to ${targetPath}`));
|
|
255
|
+
return true;
|
|
256
|
+
}
|
|
257
|
+
catch (e) {
|
|
258
|
+
const code = e.code ?? '';
|
|
259
|
+
if (['EROFS', 'EACCES', 'EPERM', 'ENOENT'].includes(code)) {
|
|
260
|
+
console.error(error(`Could not write to ${targetPath} (${code}). Printing to stdout instead — pass --out <path> to a writable location.`));
|
|
261
|
+
process.stdout.write(content + '\n');
|
|
262
|
+
return false;
|
|
263
|
+
}
|
|
264
|
+
throw e;
|
|
265
|
+
}
|
|
266
|
+
}
|
|
240
267
|
export async function executeReportCommand(target, options = {}) {
|
|
241
268
|
const cwd = process.cwd();
|
|
242
269
|
const resolved = target ? (isAbsolute(target) ? target : join(cwd, target)) : cwd;
|
|
243
|
-
//
|
|
244
|
-
//
|
|
245
|
-
//
|
|
246
|
-
|
|
247
|
-
|
|
270
|
+
// rc.18: explicit mutex on combinations Codex flagged as silently
|
|
271
|
+
// ambiguous. Two pairs:
|
|
272
|
+
// format {--json, --simple} — pick at most one output format
|
|
273
|
+
// dest {--stdout, --out} — pick at most one destination
|
|
274
|
+
// Previously the second flag silently lost; now we error so users know.
|
|
275
|
+
if (options.json && options.simple) {
|
|
276
|
+
console.error(error('--json and --simple cannot be used together. Pick one output format.'));
|
|
277
|
+
process.exit(2);
|
|
278
|
+
}
|
|
279
|
+
if (options.stdout && options.out) {
|
|
280
|
+
console.error(error('--stdout and --out cannot be used together. Pick one destination.'));
|
|
281
|
+
process.exit(2);
|
|
282
|
+
}
|
|
283
|
+
// Default routing rules (after mutex check):
|
|
284
|
+
// --json → stdout (pipeable to jq, every CLI convention).
|
|
285
|
+
// --simple / md → file (user expects a shareable artifact, not a wall of markdown).
|
|
286
|
+
// --out <path> → wins over the default (explicit beats default).
|
|
287
|
+
// --stdout → forces stdout for non-json formats.
|
|
288
|
+
// Rationale: rc.15 — `report --json` writing to disk silently broke pipelines
|
|
289
|
+
// (`codehere report --json | jq` produced empty stdout). Stdout for machine-
|
|
290
|
+
// readable formats matches `kubectl get -o json`, `docker inspect`, etc.
|
|
291
|
+
const defaultOut = options.json
|
|
292
|
+
? undefined // stdout
|
|
293
|
+
: 'codehere-audit.md';
|
|
294
|
+
const effectiveOut = options.stdout ? undefined : (options.out ?? defaultOut);
|
|
248
295
|
if (!existsSync(resolved)) {
|
|
249
296
|
console.error(error(`Not found: ${resolved}`));
|
|
250
297
|
process.exit(1);
|
|
@@ -297,8 +344,7 @@ export async function executeReportCommand(target, options = {}) {
|
|
|
297
344
|
if (options.json) {
|
|
298
345
|
const output = JSON.stringify(report, null, 2);
|
|
299
346
|
if (effectiveOut) {
|
|
300
|
-
|
|
301
|
-
console.log(success(`Report written to ${effectiveOut}`));
|
|
347
|
+
writeReportWithFallback(effectiveOut, output, 'Report');
|
|
302
348
|
}
|
|
303
349
|
else {
|
|
304
350
|
console.log(output);
|
|
@@ -309,8 +355,7 @@ export async function executeReportCommand(target, options = {}) {
|
|
|
309
355
|
if (options.simple) {
|
|
310
356
|
const simple = generateSimpleReport(report, resolved);
|
|
311
357
|
if (effectiveOut) {
|
|
312
|
-
|
|
313
|
-
console.log(success(`Plain-English report written to ${effectiveOut}`));
|
|
358
|
+
writeReportWithFallback(effectiveOut, simple, 'Plain-English report');
|
|
314
359
|
}
|
|
315
360
|
else {
|
|
316
361
|
process.stdout.write(simple + '\n');
|
|
@@ -320,9 +365,9 @@ export async function executeReportCommand(target, options = {}) {
|
|
|
320
365
|
// Markdown output
|
|
321
366
|
const markdown = generateMarkdown(report, resolved, cwd);
|
|
322
367
|
if (effectiveOut) {
|
|
323
|
-
|
|
368
|
+
if (!writeReportWithFallback(effectiveOut, markdown, 'Report'))
|
|
369
|
+
return;
|
|
324
370
|
newline();
|
|
325
|
-
console.log(success(`Report written to ${effectiveOut}`));
|
|
326
371
|
console.log(colors.dim(` ${paths.length} files · score ${overallScore}/100 · grade ${grade}`));
|
|
327
372
|
if (criticalCount > 0) {
|
|
328
373
|
console.log(colors.red(` ${criticalCount} critical issue${criticalCount !== 1 ? 's' : ''} — check the report`));
|
|
@@ -148,9 +148,14 @@ function renderSessionDrillDown(sessionId, entries) {
|
|
|
148
148
|
console.log(` ${icon} ${time} ${tool} ${colors.dim(reason)}`);
|
|
149
149
|
}
|
|
150
150
|
newline();
|
|
151
|
-
// Verdict
|
|
152
|
-
|
|
153
|
-
|
|
151
|
+
// Verdict — rc.17: tighten "injection" claim to actual high block ratio
|
|
152
|
+
// (UX_OBSERVATIONS.md P1; long attended sessions shouldn't get accused).
|
|
153
|
+
if (blocked.length > 2 && sorted.length > 20 && blocked.length / sorted.length > 0.05) {
|
|
154
|
+
const pct = ((blocked.length / sorted.length) * 100).toFixed(0);
|
|
155
|
+
console.log(colors.red(` ⚠ ${pct}% block rate (${blocked.length}/${sorted.length}) — review for injection patterns.`));
|
|
156
|
+
}
|
|
157
|
+
else if (blocked.length > 0 && sorted.length > 20) {
|
|
158
|
+
console.log(colors.yellow(` ${blocked.length} blocked / ${sorted.length} total — long session, review if unattended.`));
|
|
154
159
|
}
|
|
155
160
|
else if (blocked.length > 0) {
|
|
156
161
|
console.log(colors.yellow(` ${blocked.length} blocked call${blocked.length !== 1 ? 's' : ''} — review the blocked entries above.`));
|
|
@@ -413,6 +418,13 @@ export async function executeStatusCommand(options = {}) {
|
|
|
413
418
|
const cwd = process.cwd();
|
|
414
419
|
const version = getVersion();
|
|
415
420
|
const entries = readAuditLog();
|
|
421
|
+
// Validate --since up front — applies to ALL modes, not just --export.
|
|
422
|
+
// (rc.15 fix: previously the validation ran only inside the --export branch,
|
|
423
|
+
// so `codehere status --since bogus` silently succeeded with exit 0.)
|
|
424
|
+
if (options.since && parseDurationToHours(options.since) == null) {
|
|
425
|
+
console.error(`Invalid --since value: "${options.since}". Use e.g. 24h, 7d, 4w.`);
|
|
426
|
+
process.exit(1);
|
|
427
|
+
}
|
|
416
428
|
// Session drill-down mode
|
|
417
429
|
if (options.session) {
|
|
418
430
|
renderSessionDrillDown(options.session, entries);
|
|
@@ -421,10 +433,6 @@ export async function executeStatusCommand(options = {}) {
|
|
|
421
433
|
// Audit export mode — dump raw events for archival/compliance/sharing
|
|
422
434
|
if (options.export) {
|
|
423
435
|
const sinceHours = options.since ? parseDurationToHours(options.since) : null;
|
|
424
|
-
if (options.since && sinceHours == null) {
|
|
425
|
-
console.error(`Invalid --since value: "${options.since}". Use e.g. 24h, 7d, 4w.`);
|
|
426
|
-
process.exit(1);
|
|
427
|
-
}
|
|
428
436
|
try {
|
|
429
437
|
exportAudit(entries, options.export, sinceHours);
|
|
430
438
|
}
|
|
@@ -480,9 +488,17 @@ export async function executeStatusCommand(options = {}) {
|
|
|
480
488
|
}));
|
|
481
489
|
result.taskCount = tasks.length;
|
|
482
490
|
}
|
|
483
|
-
catch {
|
|
491
|
+
catch (e) {
|
|
492
|
+
// rc.25: JSON consumers reading only stdout were still being fed a
|
|
493
|
+
// lie ([] tasks, 0 count) on real failure (Codex final review:
|
|
494
|
+
// "degraded behavior being presented as success"). Now we surface a
|
|
495
|
+
// structured taskLoadError + status:'degraded' so automation can
|
|
496
|
+
// distinguish "no tasks" from "load failed."
|
|
497
|
+
console.error('[status --tasks --json] task repository failed to load:', e);
|
|
484
498
|
result.tasks = [];
|
|
485
499
|
result.taskCount = 0;
|
|
500
|
+
result.taskLoadError = e instanceof Error ? e.message : String(e);
|
|
501
|
+
result.status = 'degraded';
|
|
486
502
|
}
|
|
487
503
|
}
|
|
488
504
|
console.log(JSON.stringify(result, null, 2));
|
|
@@ -630,8 +646,14 @@ export async function executeStatusCommand(options = {}) {
|
|
|
630
646
|
}
|
|
631
647
|
}
|
|
632
648
|
}
|
|
633
|
-
catch {
|
|
634
|
-
|
|
649
|
+
catch (e) {
|
|
650
|
+
// rc.25: don't print "No tasks found" — that's a lie when load failed
|
|
651
|
+
// (Codex final review: "degraded behavior presented as success"). Show
|
|
652
|
+
// a clear error line; stderr already has the cause for the operator.
|
|
653
|
+
console.error('[status] task repository failed to load:', e);
|
|
654
|
+
const msg = e instanceof Error ? e.message : String(e);
|
|
655
|
+
console.log(colors.red(` ✗ Could not load task repository: ${msg}`));
|
|
656
|
+
console.log(colors.dim(' See logs above for details. Try `codehere start` to (re)init the task intake.'));
|
|
635
657
|
}
|
|
636
658
|
}
|
|
637
659
|
// Quick trust scan (opt-in)
|