codehere 0.1.1 → 0.2.2

package/dist/presentation/cli/commands/smart-command.js

@@ -3,7 +3,7 @@
  * Intelligent routing - user just types what they want
  */
 import { IntelligentRouter } from '../../../application/services/intelligent-router.js';
-import { colors, sectionHeader, formatNumber, formatPath, createTable, success, error, warning, newline, createSpinner, separator, symbols, } from '../../../ui.js';
+import { colors, sectionHeader, formatNumber, formatPath, createTable, success, error, warning, newline, symbols, } from '../../../ui.js';
 import { executionTracer } from '../../../infrastructure/observability/execution-tracer.js';
 import { displayError } from '../error-display.js';
 import { trackCommand, shouldShowFeatureDiscovery, markFeatureDiscoveryShown, } from '../../../infrastructure/ux/feature-discovery.js';
@@ -27,47 +27,8 @@ export async function executeSmartCommand(query, options = {}) {
     const { container } = await import('../../../application/services/dependency-container.js');
     const router = new IntelligentRouter(undefined, // Use default QueryIntentClassifier
     container.aiService, container.memoryStreamService);
-    // Professional banner with query
-    console.log('\n' + separator('═', 80));
-    console.log(colors.bold('Codehere - AI Coding Assistant'));
-    if (options.quick) {
-        console.log(colors.dim('  Quick Mode - Reading files directly (no indexing required)'));
-    }
-    if (options.continue) {
-        console.log(colors.dim('  Continuing from previous session'));
-    }
-    if (options.model) {
-        console.log(colors.dim(`  Model: ${options.model}`));
-    }
-    // Load project context from CODEHERE.md if present
-    let projectContext = null;
-    try {
-        const { loadProjectContext, getContextSummary } = await import('../../../infrastructure/context/project-context-loader.js');
-        projectContext = loadProjectContext(process.cwd());
-        if (projectContext) {
-            const summary = getContextSummary(projectContext);
-            console.log(colors.dim(`  Project: ${summary}`));
-        }
-    }
-    catch {
-        // Project context loading failed - continue without it
-    }
-    // Show git context summary
-    let gitContext = null;
-    try {
-        const { getGitContext, getGitSummary } = await import('../../../infrastructure/context/git-context-provider.js');
-        const gitSummary = getGitSummary(process.cwd());
-        if (gitSummary) {
-            console.log(colors.dim(`  Git: ${gitSummary}`));
-            gitContext = getGitContext(process.cwd(), 3); // Get top 3 changed files
-        }
-    }
-    catch {
-        // Git context loading failed - continue without it
-    }
-    console.log(separator('═', 80));
-    newline();
-    console.log(colors.bold('Query:') + ' ' + colors.cyan(`"${query}"`));
+    // Compact header
+    console.log(colors.cyan('codehere') + colors.dim(' ▸ ') + query);
     newline();
     // Start execution tracing and track start time for summary statistics
     const startTime = Date.now();
@@ -75,63 +36,13 @@ export async function executeSmartCommand(query, options = {}) {
         query,
         codebaseId: process.cwd(),
     });
-    // Progress spinner for user feedback
-    const spinner = createSpinner(options.quick ? 'Reading codebase...' : 'Processing query...');
-    spinner.start();
+    // No verbose spinner - atomic interaction
     try {
         // Get conversation context for this session
         const { conversationContextManager } = await import('../../../infrastructure/context/conversation-context.js');
         const { sessionManager } = await import('../../../infrastructure/context/session-manager.js');
-        let sessionId;
-        let history = [];
-        // Session continuity: load previous session if -c flag is used
-        if (options.continue) {
-            const previousSession = conversationContextManager.loadPreviousSession(process.cwd());
-            if (previousSession) {
-                sessionId = previousSession.sessionId;
-                history = conversationContextManager.getHistory(sessionId, 5);
-                // Show previous context
-                if (history.length > 0) {
-                    console.log(colors.dim(`Previous conversation (${history.length} turns):`));
-                    const lastQuery = history[history.length - 1].query;
-                    console.log(colors.dim(`  Last query: "${lastQuery.substring(0, 50)}${lastQuery.length > 50 ? '...' : ''}"`));
-                    newline();
-                }
-            }
-            else {
-                console.log(colors.dim('No previous session found. Starting fresh.'));
-                newline();
-                sessionId = sessionManager.getSessionId(process.cwd());
-            }
-        }
-        else {
-            sessionId = sessionManager.getSessionId(process.cwd());
-            history = conversationContextManager.getHistory(sessionId, 5);
-        }
-        // Update spinner text during processing
-        spinner.text = 'Analyzing intent...';
-        // Format project context for AI if available
-        let projectContextForAI;
-        if (projectContext) {
-            try {
-                const { formatContextForPrompt } = await import('../../../infrastructure/context/project-context-loader.js');
-                projectContextForAI = formatContextForPrompt(projectContext);
-            }
-            catch {
-                // Continue without formatted context
-            }
-        }
-        // Format git context for AI if available
-        let gitContextForAI;
-        if (gitContext && gitContext.changedFilesContent.length > 0) {
-            try {
-                const { formatGitContextForPrompt } = await import('../../../infrastructure/context/git-context-provider.js');
-                gitContextForAI = formatGitContextForPrompt(gitContext);
-            }
-            catch {
-                // Continue without git context
-            }
-        }
+        const sessionId = sessionManager.getSessionId(process.cwd());
+        const history = conversationContextManager.getHistory(sessionId, 5);
         const result = await router.route({
             query,
             context: {
@@ -142,14 +53,8 @@ export async function executeSmartCommand(query, options = {}) {
                     timestamp: typeof turn.timestamp === 'string' ? Date.parse(turn.timestamp) : turn.timestamp,
                 })),
                 sessionId,
-                quickMode: options.quick || false, // Quick mode - bypass embeddings
-                projectContext: projectContextForAI, // CODEHERE.md context
-                gitContext: gitContextForAI, // Recent git changes
             },
         });
-        // Stop spinner - processing complete
-        spinner.stop();
-        newline();
         // Calculate execution time for summary
         const executionTime = ((Date.now() - startTime) / 1000).toFixed(2);
         // Handle review if --review flag is set (only for destructive actions)
@@ -170,64 +75,36 @@ export async function executeSmartCommand(query, options = {}) {
                 newline();
             }
         }
-        // Display result based on action type - enhanced with better formatting
-        // Import formatter once for all cases
+        // Display result based on action type
+        const { formatMarkdownForTerminal } = await import('../../../infrastructure/ux/stream-markdown.js');
         const { formatContent } = await import('../../../infrastructure/ux/comprehensive-formatter.js');
         switch (result.action) {
             case 'ask':
-                // Enhanced: Show answer with better formatting and summary
-                sectionHeader('Answer');
-                const formattedAnswer = formatContent(result.message || 'No answer generated', { indent: 0, maxWidth: 76 });
-                console.log(formattedAnswer);
+                console.log(formatMarkdownForTerminal(result.message || 'No answer generated'));
+                console.log(colors.dim(`  ${executionTime}s`));
                 newline();
-                // Show summary statistics
-                const summaryRows = [];
-                summaryRows.push(['Execution Time', `${executionTime}s`]);
-                if (result.memoriesUsed) {
-                    summaryRows.push(['Memories Used', formatNumber(result.memoriesUsed)]);
-                }
-                // Add summary if we have metrics
-                if (summaryRows.length > 1) {
-                    console.log(separator('─', 80));
-                    sectionHeader('Summary');
-                    const summaryTable = createTable(['Metric', 'Value'], summaryRows);
-                    console.log(summaryTable.toString());
-                    newline();
-                }
                 break;
             case 'explain':
-                // Enhanced: Use CLI style guide for consistent output
-                const { printSection, printExecutionTime } = await import('../../../infrastructure/ux/cli-style-guide.js');
+                // Atomic: Just show the explanation
                 if (result.result) {
                     const explainResult = result.result;
-                    printSection('Explanation');
-                    const formattedExplanation = formatContent(explainResult.explanation || '', { indent: 0, maxWidth: 76 });
-                    console.log(formattedExplanation);
-                    newline();
-                    // Show execution metrics
-                    console.log(separator('─', 40));
-                    printExecutionTime(startTime);
-                    if (result.memoriesUsed) {
-                        console.log(colors.dim(`Memories used: ${result.memoriesUsed}`));
-                    }
+                    console.log(formatMarkdownForTerminal(explainResult.explanation || ''));
                 }
                 newline();
                 break;
             case 'edit':
-                // Enhanced: Use CLI style guide for edit operations
-                const { printSection: printEditSection, printSuccess, printWarning, printSummary } = await import('../../../infrastructure/ux/cli-style-guide.js');
-                console.log(separator('═', 80));
+                console.log('');
                 sectionHeader('Edit Result');
-                console.log(separator('═', 80));
+                console.log('');
                 newline();
                 if (result.success) {
                     const editResult = result.result;
                     // Display license warnings if present (Enhanced Security - License Scanning)
                     if (editResult?.licenseFindings && editResult.licenseFindings.length > 0) {
-                        printEditSection('License Scan');
+                        sectionHeader('License Scan');
                         const criticalFindings = editResult.licenseFindings.filter((f) => f.severity === 'critical' || f.severity === 'high');
                         if (criticalFindings.length > 0) {
-                            printWarning(`${criticalFindings.length} license conflict(s) detected`);
+                            console.log(warning(`⚠️  ${criticalFindings.length} license issue${criticalFindings.length !== 1 ? 's' : ''} found:`));
                             criticalFindings.slice(0, 3).forEach((finding) => {
                                 console.log(colors.yellow(`   • ${finding.license} license detected in ${finding.filepath || 'code'}`));
                                 if (finding.message) {
@@ -242,10 +119,10 @@ export async function executeSmartCommand(query, options = {}) {
                     }
                     // Display provider bias warnings if present (Enhanced Security - Provider Bias Detection)
                     if (editResult?.providerBiasFindings && editResult.providerBiasFindings.length > 0) {
-                        printEditSection('Provider Bias Detection');
+                        sectionHeader('Provider Bias Detection');
                         const criticalFindings = editResult.providerBiasFindings.filter((f) => f.severity === 'critical' || f.severity === 'high');
                         if (criticalFindings.length > 0) {
-                            printWarning(`${criticalFindings.length} vendor lock-in risk(s) detected`);
+                            console.log(warning(`⚠️  ${criticalFindings.length} vendor lock-in risk${criticalFindings.length !== 1 ? 's' : ''} detected:`));
                             criticalFindings.slice(0, 3).forEach((finding) => {
                                 console.log(colors.yellow(`   • ${finding.provider} provider detected`));
                                 if (finding.message) {
@@ -258,16 +135,19 @@ export async function executeSmartCommand(query, options = {}) {
                             newline();
                         }
                     }
-                    printSuccess('Edit applied successfully', editResult?.edit?.filepath ? `File: ${formatPath(editResult.edit.filepath)}` : undefined);
+                    console.log(success('Edit applied'));
+                    if (editResult?.edit?.filepath) {
+                        console.log(colors.dim(`File: ${formatPath(editResult.edit.filepath)}`));
+                    }
                     if (editResult?.edit?.linesAdded || editResult?.edit?.linesRemoved) {
+                        const changesTable = createTable(['Metric', 'Value'], [
+                            ['Lines Added', formatNumber(editResult.edit.linesAdded || 0)],
+                            ['Lines Removed', formatNumber(editResult.edit.linesRemoved || 0)],
+                            ['Execution Time', `${executionTime}s`],
+                        ]);
+                        console.log(changesTable.toString());
                         newline();
-                        printSummary({
-                            'Lines Added': editResult.edit.linesAdded || 0,
-                            'Lines Removed': editResult.edit.linesRemoved || 0,
-                            'Execution Time': `${executionTime}s`,
-                        });
                     }
-                    newline();
                 }
                 else {
                     // Use centralized error display
@@ -306,7 +186,7 @@ export async function executeSmartCommand(query, options = {}) {
                     newline();
                     console.log(colors.dim(`Execution Time: ${executionTime}s`));
                 }
-                console.log(separator('═', 80));
+                console.log('');
                 newline();
                 break;
             case 'react':
@@ -324,9 +204,9 @@ export async function executeSmartCommand(query, options = {}) {
                     const planResult = result.result;
                     // Check if it's from orchestrator (has execution/validation) or just planning
                     if (planResult.plan) {
-                        console.log(separator('═', 80));
+                        console.log('');
                         console.log(colors.bold('Plan'));
-                        console.log(separator('═', 80));
+                        console.log('');
                         newline();
                         console.log(colors.bold('Goal:') + ' ' + colors.cyan(planResult.plan.goal || query));
                         if (planResult.plan.metadata?.complexity) {
@@ -359,12 +239,12 @@ export async function executeSmartCommand(query, options = {}) {
                     }
                     // Show execution results if from orchestrator
                     if (planResult.execution) {
-                        console.log(separator('═', 80));
+                        console.log('');
                         console.log(colors.bold('Execution Results'));
-                        console.log(separator('═', 80));
+                        console.log('');
                         newline();
                         console.log(colors.bold(`Completed: ${planResult.execution.completedSubPlans || 0}/${planResult.execution.totalSubPlans || 0} sub-plans`));
-                        console.log(colors.bold(`Overall Success: ${planResult.execution.overallSuccess ? '[SUCCESS]' : '[FAILED]'}`));
+                        console.log(colors.bold(`Result: ${planResult.execution.overallSuccess ? 'Succeeded' : 'Failed'}`));
                         newline();
                         if (planResult.execution.results && planResult.execution.results.length > 0) {
                             planResult.execution.results.forEach((execResult) => {
@@ -380,9 +260,9 @@ export async function executeSmartCommand(query, options = {}) {
                     }
                     // Show validation results if available
                     if (planResult.validation) {
-                        console.log(separator('═', 80));
+                        console.log('');
                         console.log(colors.bold('Validation Results'));
-                        console.log(separator('═', 80));
+                        console.log('');
                         newline();
                         if (planResult.validation.qualityScore !== undefined) {
                             console.log(colors.bold(`Quality Score: ${planResult.validation.qualityScore}/100`));
@@ -401,9 +281,9 @@ export async function executeSmartCommand(query, options = {}) {
                     }
                     // Show final message
                     if (result.success) {
-                        console.log(separator('═', 80));
-                        console.log(success(result.message || 'Plan completed successfully'));
-                        console.log(separator('═', 80));
+                        console.log('');
+                        console.log(success(result.message || 'Plan finished'));
+                        console.log('');
                     }
                     else {
                         // Use centralized error display
@@ -417,9 +297,9 @@ export async function executeSmartCommand(query, options = {}) {
                     newline();
                 }
                 else {
-                    console.log(separator('═', 80));
+                    console.log('');
                     console.log(colors.bold('Plan'));
-                    console.log(separator('═', 80));
+                    console.log('');
                     newline();
                     console.log(result.message || 'Planning in progress...');
                     newline();
@@ -440,11 +320,11 @@ export async function executeSmartCommand(query, options = {}) {
         const contextualSuggestion = shouldShowContextualSuggestion(query, 'smart');
         if (contextualSuggestion) {
             newline();
-            console.log(separator('─', 80));
+            console.log('');
             console.log(colors.bold(`💡 ${contextualSuggestion.reason}`));
             console.log(colors.dim(`   Try: ${colors.cyan(contextualSuggestion.command)}`));
             console.log(colors.dim(`   ${contextualSuggestion.description}`));
-            console.log(separator('─', 80));
+            console.log('');
             newline();
         }
         else {
@@ -452,26 +332,27 @@ export async function executeSmartCommand(query, options = {}) {
             const discovery = shouldShowFeatureDiscovery('smart');
             if (discovery) {
                 newline();
-                console.log(separator('─', 80));
+                console.log('');
                 console.log(colors.bold(`💡 ${discovery.message}`));
                 discovery.features.forEach(feature => {
                     console.log(colors.dim(`  • ${colors.cyan(feature.name)}: ${feature.description}`));
                     console.log(colors.dim(`    ${colors.cyan(feature.command)}`));
                 });
-                console.log(separator('─', 80));
+                console.log('');
                 newline();
                 markFeatureDiscoveryShown(discovery.id);
             }
         }
-        // Store conversation turn for future reference resolution and session continuity
+        // Store conversation turn for future reference resolution
         try {
+            const { conversationContextManager } = await import('../../../infrastructure/context/conversation-context.js');
+            const { sessionManager } = await import('../../../infrastructure/context/session-manager.js');
+            const sessionId = sessionManager.getSessionId(process.cwd());
             const response = result.message || result.error || 'Processing complete';
             const entities = conversationContextManager.extractEntities(query);
             conversationContextManager.addTurn(sessionId, query, response, entities, result.intent);
-            // Save session to disk for continuity across CLI invocations
-            conversationContextManager.saveSession(sessionId, process.cwd());
         }
-        catch (convError) {
+        catch (error) {
             // Don't fail if conversation tracking fails
         }
         // Task 6.1: Explicit Feedback Mechanisms - Prompt for feedback after operation
@@ -499,9 +380,6 @@ export async function executeSmartCommand(query, options = {}) {
         newline();
     }
     catch (err) {
-        // Stop spinner on error
-        spinner.stop();
-        newline();
         const { displayError } = await import('../error-display.js');
         displayError(err, {
             operation: 'smart-route',