codecritique 1.2.0 → 1.2.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "codecritique",
-  "version": "1.2.0",
+  "version": "1.2.2",
   "description": "AI-powered code review tool for any programming language",
   "type": "module",
   "main": "src/index.js",

package/src/custom-documents.js

@@ -350,7 +350,7 @@ export class CustomDocumentProcessor {
       }
 
       // Try cache manager
-      const cachedChunks = await this.cacheManager.getCustomDocuments(resolvedProjectPath);
+      const cachedChunks = this.cacheManager.getCustomDocumentChunks(resolvedProjectPath);
       if (cachedChunks && cachedChunks.length > 0) {
         // Restore to memory
         this.customDocumentChunks.set(resolvedProjectPath, cachedChunks);
@@ -520,7 +520,7 @@ export class CustomDocumentProcessor {
     try {
       const resolvedProjectPath = path.resolve(projectPath);
       this.customDocumentChunks.delete(resolvedProjectPath);
-      await this.cacheManager.clearCustomDocuments(resolvedProjectPath);
+      this.cacheManager.customDocumentChunks.delete(resolvedProjectPath);
       console.log(chalk.green(`Cleared custom document chunks for project: ${resolvedProjectPath}`));
     } catch (error) {
       console.error(chalk.red(`Error clearing project chunks: ${error.message}`));

package/src/custom-documents.test.js

@@ -11,8 +11,7 @@ vi.mock('./embeddings/model-manager.js', () => ({
 vi.mock('./embeddings/cache-manager.js', () => ({
   CacheManager: class {
     storeCustomDocuments = vi.fn().mockResolvedValue(undefined);
-    getCustomDocuments = vi.fn().mockResolvedValue([]);
-    clearCustomDocuments = vi.fn().mockResolvedValue(undefined);
+    getCustomDocumentChunks = vi.fn().mockReturnValue([]);
   },
 }));
 
@@ -32,8 +31,7 @@ describe('CustomDocumentProcessor', () => {
 
     mockCacheManager = {
       storeCustomDocuments: vi.fn().mockResolvedValue(undefined),
-      getCustomDocuments: vi.fn().mockResolvedValue([]),
-      clearCustomDocuments: vi.fn().mockResolvedValue(undefined),
+      getCustomDocumentChunks: vi.fn().mockReturnValue([]),
     };
 
     processor = new CustomDocumentProcessor({
@@ -319,7 +317,7 @@ describe('CustomDocumentProcessor', () => {
 
     it('should return chunks from cache if not in memory', async () => {
       const cachedChunks = [{ id: 'cached', content: 'from cache' }];
-      mockCacheManager.getCustomDocuments.mockResolvedValue(cachedChunks);
+      mockCacheManager.getCustomDocumentChunks.mockReturnValue(cachedChunks);
 
       const result = await processor.getExistingChunks('/project');
 
@@ -328,7 +326,7 @@ describe('CustomDocumentProcessor', () => {
 
     it('should restore cached chunks to memory', async () => {
       const cachedChunks = [{ id: 'cached', content: 'from cache' }];
-      mockCacheManager.getCustomDocuments.mockResolvedValue(cachedChunks);
+      mockCacheManager.getCustomDocumentChunks.mockReturnValue(cachedChunks);
 
       await processor.getExistingChunks('/project');
 
@@ -336,7 +334,7 @@ describe('CustomDocumentProcessor', () => {
     });
 
     it('should return empty array when no chunks exist', async () => {
-      mockCacheManager.getCustomDocuments.mockResolvedValue([]);
+      mockCacheManager.getCustomDocumentChunks.mockReturnValue([]);
 
       const result = await processor.getExistingChunks('/project');
 
@@ -353,10 +351,14 @@ describe('CustomDocumentProcessor', () => {
       expect(processor.customDocumentChunks.has('/project')).toBe(false);
     });
 
-    it('should clear chunks from cache', async () => {
+    it('should clear chunks for only the selected project', async () => {
+      processor.customDocumentChunks.set('/project', [{ id: 'chunk-a' }]);
+      processor.customDocumentChunks.set('/other', [{ id: 'chunk-b' }]);
+
       await processor.clearProjectChunks('/project');
 
-      expect(mockCacheManager.clearCustomDocuments).toHaveBeenCalled();
+      expect(processor.customDocumentChunks.has('/project')).toBe(false);
+      expect(processor.customDocumentChunks.has('/other')).toBe(true);
     });
   });
 

package/src/index.js

@@ -420,19 +420,18 @@ async function runCodeReview(options) {
         outputFn(reviewResult.results, options);
         console.log(chalk.bold.green(`\nAnalysis complete for ${operationDescription}! (${duration}s)`));
       } else {
-        console.log(chalk.yellow('No results to display. Review result structure:'));
-        console.log(chalk.yellow('reviewResult.results exists?'), reviewResult.results ? 'Yes' : 'No');
-        if (reviewResult.results) {
-          console.log(chalk.yellow('reviewResult.results type:'), typeof reviewResult.results);
-          console.log(chalk.yellow('reviewResult.results is array?'), Array.isArray(reviewResult.results));
-          if (!Array.isArray(reviewResult.results)) {
-            console.log(
-              chalk.yellow('reviewResult.results content:'),
-              JSON.stringify(reviewResult.results, null, 2).substring(0, 500) + '...'
-            );
-          }
+        // No results to display (e.g., all files were excluded/skipped)
+        const message = reviewResult.message || 'All files were excluded from review (e.g., config files, lock files).';
+        console.log(chalk.yellow(message));
+
+        // Still output empty results if outputFile is specified (for CI/CD pipelines)
+        if (options.outputFile) {
+          const outputFn = options.output === 'json' ? outputJson : options.output === 'markdown' ? outputMarkdown : outputText;
+          outputFn([], options);
+          console.log(chalk.yellow(`Empty results written to: ${options.outputFile}`));
         }
-        console.log(chalk.yellow(reviewResult.message || 'Review completed, but no results to display.'));
+
+        console.log(chalk.bold.yellow(`\nReview complete for ${operationDescription} - no reviewable files found (${duration}s)`));
       }
     } else {
       console.error(chalk.red('\nCode review process failed.'));
@@ -577,35 +576,37 @@ async function generateEmbeddings(options) {
 
     // Start the progress update interval
     const progressInterval = setInterval(updateSpinner, 100);
+    let results;
+    try {
+      results = await embeddingsSystem.processBatchEmbeddings(filesToProcess, {
+        concurrency,
+        verbose: options.verbose,
+        excludePatterns,
+        respectGitignore: options.gitignore !== false,
+        baseDir: baseDir,
+        batchSize: 100, // Set a reasonable batch size
+        maxLines: parseInt(options.maxLines || '1000', 10),
+        onProgress: (status) => {
+          // Update counters based on status
+          if (status === 'processed') {
+            processedCount++;
+          } else if (status === 'skipped') {
+            skippedCount++;
+          } else if (status === 'failed') {
+            failedCount++;
+          } else if (status === 'excluded') {
+            excludedCount++;
+          }
 
-    const results = await embeddingsSystem.processBatchEmbeddings(filesToProcess, {
-      concurrency,
-      verbose: options.verbose,
-      excludePatterns,
-      respectGitignore: options.gitignore !== false,
-      baseDir: baseDir,
-      batchSize: 100, // Set a reasonable batch size
-      maxLines: parseInt(options.maxLines || '1000', 10),
-      onProgress: (status) => {
-        // Update counters based on status
-        if (status === 'processed') {
-          processedCount++;
-        } else if (status === 'skipped') {
-          skippedCount++;
-        } else if (status === 'failed') {
-          failedCount++;
-        } else if (status === 'excluded') {
-          excludedCount++;
-        }
-
-        // Update the spinner with new progress information
-        updateSpinner();
-      },
-    });
-
-    // Clean up the progress display
-    clearInterval(progressInterval);
-    spinner.stop(true);
+          // Update the spinner with new progress information
+          updateSpinner();
+        },
+      });
+    } finally {
+      // Clean up the progress display even if embedding generation fails.
+      clearInterval(progressInterval);
+      spinner.stop(true);
+    }
 
     console.log(chalk.green(`\nEmbedding generation complete!`));
     console.log(chalk.cyan(`Processed: ${results.processed} files`));

package/src/prompt-cache.js

@@ -195,6 +195,7 @@ Code suggestions enable reviewers to apply fixes directly as GitHub suggestions.
  */
 const LINE_NUMBERS_RULE = `**CRITICAL 'lineNumbers' RULE - MANDATORY COMPLIANCE**:
 - **ALWAYS provide line numbers** - this field is REQUIRED for every issue
+- **Line numbers are shown in the file content** as a prefix on each line (e.g., "  42 | const x = 1;"). Use THESE line numbers directly - do NOT try to count lines yourself.
 - If you can identify specific lines, provide them (max 3-5 for repeated issues)
 - If the issue affects the entire file or cannot be pinpointed, provide [1] or relevant section line numbers
 - For ANY issue that occurs multiple times in a file, list ONLY the first 3-5 occurrences maximum

package/src/rag-analyzer.js

@@ -27,6 +27,7 @@ import { isGenericDocument, getGenericDocumentContext } from './utils/document-d
 import { isTestFile, shouldProcessFile } from './utils/file-validation.js';
 import { detectFileType, detectLanguageFromExtension } from './utils/language-detection.js';
 import { debug } from './utils/logging.js';
+import { addLineNumbers } from './utils/string-utils.js';
 
 // Constants for content processing
 const MAX_QUERY_CONTEXT_LENGTH = 1500;
@@ -774,7 +775,7 @@ async function callLLMForAnalysis(context, options = {}) {
       return {
         summary: analysisResponse.summary || 'Analysis completed with parsing issues',
         issues: Array.isArray(analysisResponse.issues) ? analysisResponse.issues : [],
-        rawResponse: analysisResponse.rawResponse || llmResponse.substring(0, 500),
+        rawResponse: analysisResponse.rawResponse || JSON.stringify(llmResponse).substring(0, 500),
         parseWarning: 'Response structure was reconstructed due to parsing issues',
       };
     }
@@ -1047,10 +1048,10 @@ You have access to TWO pieces of information:
 - Do NOT flag functions/variables as missing if they exist elsewhere in the full file
 - The unchanged code is part of the file - check it before making assumptions
 
-**FULL FILE CONTENT (for context - DO NOT review unchanged code):**
+**FULL FILE CONTENT (for context - DO NOT review unchanged code, line numbers shown for reference):**
 
 \`\`\`${file.language}
-${file.fullFileContent || file.content}
+${addLineNumbers(file.fullFileContent || file.content)}
 \`\`\`
 
 **GIT DIFF TO REVIEW (critique ONLY these changes):**
@@ -1063,7 +1064,7 @@ Path: ${file.path}
 Language: ${file.language}
 
 \`\`\`${file.language}
-${file.content}
+${addLineNumbers(file.content)}
 \`\`\``;
 
   // Add project architecture context if available
@@ -1166,10 +1167,10 @@ You have access to TWO pieces of information:
 - Check the full file for existing test cases before making assumptions
 - The unchanged test code is part of the file - review it before suggesting additions
 
-**FULL TEST FILE CONTENT (for context - check for existing tests):**
+**FULL TEST FILE CONTENT (for context - check for existing tests, line numbers shown for reference):**
 
 \`\`\`${file.language}
-${file.fullFileContent || file.content}
+${addLineNumbers(file.fullFileContent || file.content)}
 \`\`\`
 
 **GIT DIFF TO REVIEW (critique ONLY these changes):**
@@ -1182,7 +1183,7 @@ Path: ${file.path}
 Language: ${file.language}
 
 \`\`\`${file.language}
-${file.content}
+${addLineNumbers(file.content)}
 \`\`\``;
 
   // Use shared helpers for custom docs and role definition
@@ -1317,9 +1318,9 @@ ${g.content}
 ${prFile.diff}
 \`\`\`
 
-### Full File Content (For Context):
+### Full File Content (For Context - line numbers shown for reference):
 \`\`\`${prFile.language}
-${prFile.fullContent}
+${addLineNumbers(prFile.fullContent)}
 \`\`\`
 `;
     })

package/src/rag-analyzer.test.js

@@ -385,6 +385,17 @@ describe('rag-analyzer', () => {
       expect(result.results).toBeDefined();
     });
 
+    it('should reconstruct malformed responses without crashing', async () => {
+      llm.sendPromptToClaude.mockResolvedValue({
+        content: 'non-json fallback text',
+        json: { foo: 'bar' },
+      });
+      const result = await runAnalysis('/test/file.js');
+      expect(result.success).toBe(true);
+      expect(result.results.summary).toBeDefined();
+      expect(Array.isArray(result.results.issues)).toBe(true);
+    });
+
     it('should handle LLM response with null json', async () => {
       llm.sendPromptToClaude.mockResolvedValue({ json: null });
       const result = await runAnalysis('/test/file.js');