codecharta-visualization 1.117.0 → 1.118.0

package/package.json

@@ -10,7 +10,7 @@
 		"url": "https://github.com/MaibornWolff/codecharta.git"
 	},
 	"name": "codecharta-visualization",
-	"version": "1.117.0",
+	"version": "1.118.0",
 	"engines": {
 		"node": ">=16"
 	},
@@ -119,7 +119,7 @@
 		"bestzip": "^2.2.0",
 		"eslint": "^8.28.0",
 		"eslint-config-prettier": "^8.5.0",
-		"eslint-plugin-unicorn": "^46.0.0",
+		"eslint-plugin-unicorn": "^47.0.0",
 		"eslint-plugin-unused-imports": "^2.0.0",
 		"html-loader": "^4.0.0",
 		"jest": "^29.4.3",
@@ -128,7 +128,7 @@
 		"jest-puppeteer": "^6.1.1",
 		"lint-staged": "^13.0.0",
 		"marked": "^4.3.0",
-		"nw-builder": "^3.7.4",
+		"nw-builder": "3.7.4",
 		"puppeteer": "^17.0.0",
 		"ts-jest": "^29.0.5",
 		"typescript": "~4.9.4",

package/app/codeCharta/ui/attributeSideBar/util/metricDescriptors.ts

@@ -1,30 +0,0 @@
-import { AttributeDescriptors } from "../../../codeCharta.model"
-import { metricTitles } from "../../../util/metric/metricTitles"
-
-export type MetricDescriptors = {
-	key: string
-	title: string
-	description: string
-	hintLowValue: string
-	hintHighValue: string
-	link: string
-}
-
-export function getMetricDescriptors(metricKey: string, attributeDescriptors?: AttributeDescriptors): MetricDescriptors {
-	return {
-		key: metricKey,
-		title: getMetricTitle(metricKey, attributeDescriptors),
-		description: attributeDescriptors?.[metricKey]?.description,
-		hintLowValue: attributeDescriptors?.[metricKey]?.hintLowValue,
-		hintHighValue: attributeDescriptors?.[metricKey]?.hintHighValue,
-		link: attributeDescriptors?.[metricKey]?.link
-	}
-}
-
-function getMetricTitle(metric: string, attributeDescriptors: AttributeDescriptors) {
-	if (attributeDescriptors?.[metric]?.title !== undefined && attributeDescriptors[metric].title !== "") {
-		return attributeDescriptors[metric].title
-	}
-	//Fallback Description can still return undefined
-	return metricTitles.get(metric)
-}

package/app/codeCharta/ui/legendPanel/selectors/legendAreaMetric.selector.ts

@@ -1,10 +0,0 @@
-import { createSelector } from "@ngrx/store"
-import { areaMetricSelector } from "../../../state/store/dynamicSettings/areaMetric/areaMetric.selector"
-import { attributeDescriptorsSelector } from "../../../state/store/fileSettings/attributeDescriptors/attributeDescriptors.selector"
-import { getMetricDescriptors } from "../../attributeSideBar/util/metricDescriptors"
-
-export const legendAreaMetricSelector = createSelector(
-	areaMetricSelector,
-	attributeDescriptorsSelector,
-	(areaMetric, attributeDescriptors) => getMetricDescriptors(areaMetric, attributeDescriptors)
-)

package/app/codeCharta/ui/legendPanel/selectors/legendColorMetric.selector.ts

@@ -1,10 +0,0 @@
-import { colorMetricSelector } from "../../../state/store/dynamicSettings/colorMetric/colorMetric.selector"
-import { getMetricDescriptors } from "../../attributeSideBar/util/metricDescriptors"
-import { attributeDescriptorsSelector } from "../../../state/store/fileSettings/attributeDescriptors/attributeDescriptors.selector"
-import { createSelector } from "@ngrx/store"
-
-export const legendColorMetricSelector = createSelector(
-	colorMetricSelector,
-	attributeDescriptorsSelector,
-	(colorMetric, attributeDescriptors) => getMetricDescriptors(colorMetric, attributeDescriptors)
-)

package/app/codeCharta/ui/legendPanel/selectors/legendEdgeMetric.selector.spec.ts

@@ -1,76 +0,0 @@
-import { _getLegendEdgeMetric } from "./legendEdgeMetric.selector"
-import { TEST_ATTRIBUTE_DESCRIPTORS_HALF_FILLED } from "../../../util/dataMocks"
-
-describe("_getLegendEdgeMetric", () => {
-	it("should return nothing if there are no edgeMetricData", () => {
-		expect(_getLegendEdgeMetric("rloc", [], undefined)).toBe(undefined)
-	})
-
-	it("should return nothing if edgeMetricData maxValue' is smaller than 0", () => {
-		expect(
-			_getLegendEdgeMetric(
-				"rloc",
-				[
-					{
-						name: "rloc",
-						maxValue: undefined,
-						minValue: undefined
-					}
-				],
-				undefined
-			)
-		).toBe(undefined)
-	})
-
-	it("should get existing legendEdgeMetric", () => {
-		expect(_getLegendEdgeMetric("rloc", [{ name: "rloc", maxValue: 10, minValue: 0 }], undefined)).toEqual({
-			key: "rloc",
-			title: "Real Lines of Code",
-			description: undefined
-		})
-	})
-
-	it("should get existing legendEdgeMetric with given attribute descriptors", () => {
-		expect(
-			_getLegendEdgeMetric(
-				"mcc",
-				[
-					{
-						name: "mcc",
-						maxValue: 10,
-						minValue: 0
-					}
-				],
-				TEST_ATTRIBUTE_DESCRIPTORS_HALF_FILLED
-			)
-		).toEqual({
-			description: "Maximum cyclic complexity",
-			hintHighValue: "",
-			hintLowValue: "",
-			key: "mcc",
-			link: "https://www.npmjs.com/package/metric-gardener",
-			title: "Maximum Cyclic Complexity"
-		})
-
-		expect(
-			_getLegendEdgeMetric(
-				"rloc",
-				[
-					{
-						name: "rloc",
-						maxValue: 10,
-						minValue: 0
-					}
-				],
-				TEST_ATTRIBUTE_DESCRIPTORS_HALF_FILLED
-			)
-		).toEqual({
-			description: "",
-			hintHighValue: "",
-			hintLowValue: "",
-			key: "rloc",
-			link: "https://www.npmjs.com/package/metric-gardener",
-			title: "Real Lines of Code"
-		})
-	})
-})

package/app/codeCharta/ui/legendPanel/selectors/legendEdgeMetric.selector.ts

@@ -1,25 +0,0 @@
-import { EdgeMetricData } from "../../../codeCharta.model"
-import { edgeMetricSelector } from "../../../state/store/dynamicSettings/edgeMetric/edgeMetric.selector"
-import { getMetricDescriptors } from "../../attributeSideBar/util/metricDescriptors"
-import { attributeDescriptorsSelector } from "../../../state/store/fileSettings/attributeDescriptors/attributeDescriptors.selector"
-import { metricDataSelector } from "../../../state/selectors/accumulatedData/metricData/metricData.selector"
-import { createSelector } from "@ngrx/store"
-
-export const _getLegendEdgeMetric = (edgeMetric: string, edgeMetricDatas: EdgeMetricData[], attributeDescriptors) => {
-	const edgeMetricData = edgeMetricDatas.find(someEdgeMetricData => {
-		return someEdgeMetricData.name === edgeMetric
-	})
-	const hasEdgeMetricEdge = edgeMetricData && edgeMetricData.maxValue > 0
-	if (!hasEdgeMetricEdge) {
-		return
-	}
-
-	return getMetricDescriptors(edgeMetric, attributeDescriptors)
-}
-
-export const legendEdgeMetricSelector = createSelector(
-	edgeMetricSelector,
-	metricDataSelector,
-	attributeDescriptorsSelector,
-	(edgeMetric, metricData, attributeDescriptors) => _getLegendEdgeMetric(edgeMetric, metricData.edgeMetricData, attributeDescriptors)
-)

package/app/codeCharta/ui/legendPanel/selectors/legendHeightMetric.selector.ts

@@ -1,10 +0,0 @@
-import { heightMetricSelector } from "../../../state/store/dynamicSettings/heightMetric/heightMetric.selector"
-import { getMetricDescriptors } from "../../attributeSideBar/util/metricDescriptors"
-import { attributeDescriptorsSelector } from "../../../state/store/fileSettings/attributeDescriptors/attributeDescriptors.selector"
-import { createSelector } from "@ngrx/store"
-
-export const legendHeightMetricSelector = createSelector(
-	heightMetricSelector,
-	attributeDescriptorsSelector,
-	(heightMetric, attributeDescriptors) => getMetricDescriptors(heightMetric, attributeDescriptors)
-)

package/app/codeCharta/util/simplePipes/SimplePipesModule.ts

@@ -1,9 +0,0 @@
-import { NgModule } from "@angular/core"
-import { RemoveExtensionPipe } from "./removeExtension.pipe"
-import { MetricDescriptorTitlePipe } from "./metricDescriptorTitle.pipe"
-
-@NgModule({
-	declarations: [RemoveExtensionPipe, MetricDescriptorTitlePipe],
-	exports: [RemoveExtensionPipe, MetricDescriptorTitlePipe]
-})
-export class SimplePipesModule {}

package/app/codeCharta/util/simplePipes/metricDescriptorTitle.pipe.spec.ts

@@ -1,62 +0,0 @@
-import { MetricDescriptors } from "app/codeCharta/ui/attributeSideBar/util/metricDescriptors"
-import { MetricDescriptorTitlePipe } from "./metricDescriptorTitle.pipe"
-
-const testKey = "testKey"
-const testTitle = "testTitle"
-const testHighValue = "testHighValue"
-const testLowValue = "testLowValue"
-const testDescription = "testDescription"
-const testLink = "testLink"
-let pipe: MetricDescriptorTitlePipe
-let md: MetricDescriptors
-
-describe("metricDescriptorTitlePipe", () => {
-	beforeEach(() => {
-		md = {
-			key: testKey,
-			title: null,
-			description: null,
-			hintLowValue: null,
-			hintHighValue: null,
-			link: null
-		}
-		pipe = new MetricDescriptorTitlePipe()
-	})
-
-	it("should return empty string for null", () => {
-		expect(pipe.transform(null)).toBe("")
-	})
-
-	it("should return empty string for undefined", () => {
-		expect(pipe.transform(undefined)).toBe("")
-	})
-
-	it("should be key if only key is present", () => {
-		expect(pipe.transform(md)).toBe(testKey)
-	})
-
-	it('should be "title (key)" if present', () => {
-		md.title = testTitle
-		expect(pipe.transform(md)).toBe(`${testTitle} (${testKey})`)
-	})
-
-	it("should contain : if more information available", () => {
-		md.hintLowValue = testLowValue
-		expect(pipe.transform(md)).toContain(":")
-	})
-
-	it("should include full information", () => {
-		md.title = testTitle
-		md.description = testDescription
-		md.hintHighValue = testHighValue
-		md.hintLowValue = testLowValue
-		const result = `${testTitle} (${testKey}):\n${testDescription}\nHigh Values: ${testHighValue}\nLow Values: ${testLowValue}`
-		expect(pipe.transform(md)).toBe(result)
-	})
-
-	it("should not include link", () => {
-		md.description = testDescription
-		md.link = testLink
-		expect(pipe.transform(md)).toBe(`${testKey}:\n${testDescription}`)
-	})
-})

package/app/codeCharta/util/simplePipes/metricDescriptorTitle.pipe.ts

@@ -1,18 +0,0 @@
-import { Pipe, PipeTransform } from "@angular/core"
-import { MetricDescriptors } from "../../ui/attributeSideBar/util/metricDescriptors"
-
-@Pipe({ name: "metricDescriptorTitle" })
-export class MetricDescriptorTitlePipe implements PipeTransform {
-	transform(metricDescriptor: MetricDescriptors): string {
-		if (metricDescriptor == null) {
-			return ""
-		}
-		const title: string = metricDescriptor.title ? `${metricDescriptor.title} (${metricDescriptor.key})` : metricDescriptor.key
-
-		let subtitle: string = metricDescriptor.description ? `\n${metricDescriptor.description}` : ""
-		subtitle += metricDescriptor.hintHighValue ? `\nHigh Values: ${metricDescriptor.hintHighValue}` : ""
-		subtitle += metricDescriptor.hintLowValue ? `\nLow Values: ${metricDescriptor.hintLowValue}` : ""
-
-		return subtitle.length > 0 ? `${title}:${subtitle}` : title
-	}
-}