codeceptjs 4.1.0-beta.1-esm-mocha → 4.2.0-beta.1

package/lib/globals.js

@@ -30,10 +30,8 @@ export async function initCodeceptGlobals(dir, config, container) {
   // pause/inject/share stay global even under noGlobals — they're the everyday
   // debugging/wiring entry points and have no useful import alternative for
   // page-object code that runs before the container is available.
-  global.pause = async (...args) => {
-    const pauseModule = await import('./pause.js')
-    return (pauseModule.default || pauseModule)(...args)
-  }
+  const pauseModule = await import('./pause.js')
+  global.pause = pauseModule.default || pauseModule
   global.inject = () => container.support()
   global.share = container.share
 

package/lib/helper/Appium.js

@@ -832,12 +832,12 @@ class Appium extends Webdriver {
    */
   async grabNetworkConnection() {
     onlyForApps.call(this, supportedPlatform.android)
-    const res = await this.browser.getNetworkConnection()
+    const res = await this.browser.execute('mobile: getConnectivity')
     return {
-      value: res,
-      inAirplaneMode: res.inAirplaneMode,
-      hasWifi: res.hasWifi,
-      hasData: res.hasData,
+      value: (res.airplaneMode ? 1 : 0) | (res.wifi ? 2 : 0) | (res.data ? 4 : 0),
+      inAirplaneMode: res.airplaneMode,
+      hasWifi: res.wifi,
+      hasData: res.data,
     }
   }
 
@@ -978,7 +978,23 @@ class Appium extends Webdriver {
    */
   async setNetworkConnection(value) {
     onlyForApps.call(this, supportedPlatform.android)
-    return this.browser.setNetworkConnection(value)
+    const connectivity = {
+      airplaneMode: !!(value & 1),
+      wifi: !!(value & 2),
+      data: !!(value & 4),
+    }
+    // `mobile: setConnectivity` runs `adb shell svc data <state>` for every field it receives,
+    // which fails with "Can't find service: phone" on images without telephony (e.g. tablets).
+    // Only a positive result is cached: a freshly booted device may not have registered a carrier
+    // yet, and caching that would strip `data` for the whole session.
+    if (!this._hasTelephony) {
+      const deviceInfo = await this.browser.execute('mobile: deviceInfo')
+      this._hasTelephony = !!deviceInfo?.carrierName
+    }
+    // Keep `data` on telephony-capable devices, otherwise the device stays online over cellular
+    // and going offline silently does nothing.
+    if (!this._hasTelephony) delete connectivity.data
+    return this.browser.execute('mobile: setConnectivity', connectivity)
   }
 
   /**