codeceptjs 4.0.8 → 4.0.9

package/docs/playwright.md

@@ -63,6 +63,25 @@ Make sure `Playwright` helper is enabled in `codecept.conf.js` config:
 > Turn off the `show` option if you want to run test in headless mode.
 > If you don't specify the browser here, `chromium` will be used. Possible browsers are: `chromium`, `firefox` and `webkit`
 
+To point `firefox` at a custom build instead of the bundled one, pass `executablePath` under the
+`firefox` key:
+
+```js
+  helpers: {
+    Playwright: {
+      url: "http://localhost",
+      browser: 'firefox',
+      firefox: {
+        executablePath: '/path/to/firefox'
+      }
+    }
+  }
+```
+
+Useful with a build like [invisible_playwright](https://github.com/feder-cr/invisible_playwright),
+patched at the source level for a realistic fingerprint, for sites that detect the default Chromium
+path.
+
 Playwright uses different strategies to detect if a page is loaded. In configuration use `waitForNavigation` option for that:
 
 When to consider navigation succeeded, defaults to `load`. Given an array of event strings, navigation is considered to be successful after all events have been fired. Events can be either:

package/lib/data/context.js

@@ -82,8 +82,13 @@ function isTableDataRow(row) {
   return has.call(row, 'data') && has.call(row, 'skip')
 }
 
+function isDataTable(dataTable) {
+  if (dataTable instanceof DataTable) return true
+  return Boolean(dataTable) && Array.isArray(dataTable.array) && Array.isArray(dataTable.rows) && typeof dataTable.add === 'function'
+}
+
 function detectDataType(dataTable) {
-  if (dataTable instanceof DataTable) {
+  if (isDataTable(dataTable)) {
     return dataTable.rows
   }
 

package/lib/globals.js

@@ -30,10 +30,8 @@ export async function initCodeceptGlobals(dir, config, container) {
   // pause/inject/share stay global even under noGlobals — they're the everyday
   // debugging/wiring entry points and have no useful import alternative for
   // page-object code that runs before the container is available.
-  global.pause = async (...args) => {
-    const pauseModule = await import('./pause.js')
-    return (pauseModule.default || pauseModule)(...args)
-  }
+  const pauseModule = await import('./pause.js')
+  global.pause = pauseModule.default || pauseModule
   global.inject = () => container.support()
   global.share = container.share
 

package/lib/helper/GraphQL.js

@@ -53,14 +53,6 @@ class GraphQL extends Helper {
     this.axios.defaults.headers = this.options.defaultHeaders
   }
 
-  static _checkRequirements() {
-    try {
-      require('axios')
-    } catch (e) {
-      return ['axios']
-    }
-  }
-
   static _config() {
     return [
       {

package/lib/helper/GraphQLDataFactory.js

@@ -174,15 +174,6 @@ class GraphQLDataFactory extends Helper {
     Object.keys(this.factories).forEach(f => (this.created[f] = []))
   }
 
-  static _checkRequirements() {
-    try {
-      require('axios')
-      require('rosie')
-    } catch (e) {
-      return ['axios', 'rosie']
-    }
-  }
-
   _after() {
     if (!this.config.cleanup) {
       return Promise.resolve()

package/lib/plugin/junitReporter.js

@@ -66,6 +66,26 @@ export default function (config = {}) {
   config = Object.assign({}, defaultConfig, config)
 
   let written = false
+  const hookFailures = []
+
+  event.dispatcher.on(event.hook.failed, hook => {
+    if (!hook || !['BeforeSuite', 'AfterSuite'].includes(hook.hookName)) return
+    const err = hook.err || hook.error
+    if (!err) return
+    const runnable = hook.ctx && hook.ctx.test
+    const suite = runnable && runnable.parent
+    hookFailures.push({
+      title: hook.title || `${hook.hookName} hook failed`,
+      state: 'failed',
+      err,
+      parent: suite,
+      file: (runnable && runnable.file) || (suite && suite.file),
+      tags: (suite && suite.tags) || [],
+      meta: {},
+      steps: [],
+      duration: (runnable && runnable.duration) || 0,
+    })
+  })
 
   const writeReport = result => {
     if (written) return
@@ -76,7 +96,7 @@ export default function (config = {}) {
     mkdirp.sync(dir)
     const file = path.join(dir, config.outputName)
 
-    fs.writeFileSync(file, buildXml(result, config))
+    fs.writeFileSync(file, buildXml(result, config, hookFailures))
     output.plugin('junitReporter', `JUnit report saved to ${file}`)
   }
 
@@ -84,17 +104,18 @@ export default function (config = {}) {
   event.dispatcher.on(event.workers.result, writeReport)
 }
 
-function buildXml(result, config) {
+function buildXml(result, config, hookFailures = []) {
   const doc = new DOMImplementation().createDocument(null, null, null)
-  const suites = groupBySuite(result.tests)
+  const allTests = result.tests.concat(hookFailures)
+  const suites = groupBySuite(allTests)
 
   const root = doc.createElement('testsuites')
   setAttr(root, 'name', config.testGroupName)
-  setAttr(root, 'tests', result.tests.length)
-  setAttr(root, 'failures', countState(result.tests, 'failed'))
-  setAttr(root, 'skipped', countSkipped(result.tests))
+  setAttr(root, 'tests', allTests.length)
+  setAttr(root, 'failures', countState(allTests, 'failed'))
+  setAttr(root, 'skipped', countSkipped(allTests))
   setAttr(root, 'errors', 0)
-  setAttr(root, 'time', toSeconds(sumDuration(result.tests)))
+  setAttr(root, 'time', toSeconds(sumDuration(allTests)))
   setAttr(root, 'timestamp', toIso(result.stats && result.stats.start))
   doc.appendChild(root)
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "codeceptjs",
-  "version": "4.0.8",
+  "version": "4.0.9",
   "type": "module",
   "description": "Supercharged End 2 End Testing Framework for NodeJS",
   "keywords": [