codeceptjs 4.0.2-beta.9 → 4.0.3

package/lib/helper/Appium.js

@@ -179,13 +179,13 @@ class Appium extends Webdriver {
     super(config)
 
     this.isRunning = false
-    this.appiumV2 = config.appiumV2 || true
+    this.appiumV2 = config.appiumV2 !== false
     this.axios = axios.create()
 
-    if (!config.appiumV2) {
-      console.log('The Appium core team does not maintain Appium 1.x anymore since the 1st of January 2022. Appium 2.x is used by default.')
+    if (this.appiumV2 === false) {
+      console.log('Appium 1.x is no longer maintained by the Appium team (since 2022-01-01).')
       console.log('More info: https://bit.ly/appium-v2-migration')
-      console.log('This Appium 1.x support will be removed in next major release.')
+      console.log('Appium 1.x support will be removed in the next major CodeceptJS release.')
     }
   }
 
@@ -220,6 +220,9 @@ class Appium extends Webdriver {
       deprecationWarnings: false,
       restart: true,
       manualStart: false,
+      // Mobile emulator/device cold starts (esp. on cloud grids like Sauce Labs)
+      // routinely exceed webdriverio's 2-minute default. Bump to 5 min.
+      connectionRetryTimeout: 300000, // ms
       timeouts: {
         script: 0, // ms
       },
@@ -331,6 +334,24 @@ class Appium extends Webdriver {
     }
     this.$$ = this.browser.$$.bind(this.browser)
 
+    // wdio v9 implements `element.isDisplayed()` for non-mobile contexts by
+    // injecting a JS visibility check via POST /execute/sync. Appium's native
+    // context cannot execute JS, so each call logs an ugly
+    // "Method is not implemented" ERROR before the existing catch swallows it.
+    // Short-circuit isDisplayed to `true` while in native context so the
+    // request is never issued (matches existing _isDisplayedSafe semantics).
+    const helper = this
+    if (typeof this.browser.overwriteCommand === 'function') {
+      this.browser.overwriteCommand(
+        'isDisplayed',
+        async function (origFn, ...args) {
+          if (helper.isWeb) return origFn.call(this, ...args)
+          return true
+        },
+        true,
+      )
+    }
+
     this.isRunning = true
     if (this.options.timeouts && this.isWeb) {
       await this.defineTimeout(this.options.timeouts)
@@ -1543,8 +1564,8 @@ class Appium extends Webdriver {
   /**
    * {{> dontSeeElement }}
    */
-  async dontSeeElement(locator) {
-    if (this.isWeb) return super.dontSeeElement(locator)
+  async dontSeeElement(locator, context = null) {
+    if (this.isWeb) return super.dontSeeElement(locator, context)
 
     // For mobile native apps, use safe isDisplayed wrapper
     const parsedLocator = parseLocator.call(this, locator)
@@ -1589,9 +1610,9 @@ class Appium extends Webdriver {
    * {{> fillField }}
    *
    */
-  async fillField(field, value) {
+  async fillField(field, value, context = null) {
     value = value.toString()
-    if (this.isWeb) return super.fillField(field, value)
+    if (this.isWeb) return super.fillField(field, value, context)
     return super.fillField(parseLocator.call(this, field), value)
   }
 
@@ -1706,8 +1727,8 @@ class Appium extends Webdriver {
    * {{> seeElement }}
    *
    */
-  async seeElement(locator) {
-    if (this.isWeb) return super.seeElement(locator)
+  async seeElement(locator, context = null) {
+    if (this.isWeb) return super.seeElement(locator, context)
 
     // For mobile native apps, use safe isDisplayed wrapper
     const parsedLocator = parseLocator.call(this, locator)
@@ -1754,8 +1775,8 @@ class Appium extends Webdriver {
    *
    * Supported only for web testing
    */
-  async selectOption(select, option) {
-    if (this.isWeb) return super.selectOption(select, option)
+  async selectOption(select, option, context = null) {
+    if (this.isWeb) return super.selectOption(select, option, context)
     throw new Error("Should be used only in Web context. In native context use 'click' method instead")
   }
 

package/lib/helper/FileSystem.js

@@ -4,6 +4,7 @@ import fs from 'fs'
 
 import Helper from '@codeceptjs/helper'
 import { fileExists } from '../utils.js'
+import store from '../store.js'
 import { fileIncludes } from '../assert/include.js'
 import { fileEquals } from '../assert/equal.js'
 
@@ -33,7 +34,7 @@ import { fileEquals } from '../assert/equal.js'
 class FileSystem extends Helper {
   constructor() {
     super()
-    this.dir = global.codecept_dir
+    this.dir = store.codeceptDir
     this.file = ''
   }
 
@@ -52,7 +53,7 @@ class FileSystem extends Helper {
    * @param {string} openPath
    */
   amInPath(openPath) {
-    this.dir = path.join(global.codecept_dir, openPath)
+    this.dir = path.join(store.codeceptDir, openPath)
     try {
       this.debugSection('Dir', this.dir)
     } catch (e) {

package/lib/helper/GraphQLDataFactory.js

@@ -2,6 +2,7 @@ import path from 'path'
 
 import HelperModule from '@codeceptjs/helper'
 import GraphQL from './GraphQL.js'
+import store from '../store.js'
 
 /**
  * Helper for managing remote data using GraphQL queries.
@@ -251,7 +252,7 @@ class GraphQLDataFactory extends Helper {
       try {
         require.resolve(modulePath)
       } catch (e) {
-        modulePath = path.join(global.codecept_dir, modulePath)
+        modulePath = path.join(store.codeceptDir, modulePath)
       }
       const builder = require(modulePath)
       return builder.build(data)