codeceptjs 4.0.1-beta.14 → 4.0.1-beta.15

package/lib/command/definitions.js

@@ -239,8 +239,13 @@ function getImportString(testsPath, targetFolderPath, pathsToType, pathsToValue)
   }
 
   for (const name in pathsToValue) {
-    const relativePath = getPath(pathsToValue[name], targetFolderPath, testsPath)
-    importStrings.push(`type ${name} = import('${relativePath}');`)
+    const originalPath = pathsToValue[name]
+    const relativePath = getPath(originalPath, targetFolderPath, testsPath)
+    if (originalPath.endsWith('.js') || originalPath.endsWith('.ts')) {
+      importStrings.push(`type ${name} = InstanceType<typeof import('${relativePath}').default>;`)
+    } else {
+      importStrings.push(`type ${name} = import('${relativePath}');`)
+    }
   }
 
   return importStrings

package/lib/helper/Playwright.js

@@ -1389,7 +1389,6 @@ class Playwright extends Helper {
       }
     }
 
-    // Close browserContext if recordHar is enabled
     if (this.options.recordHar && this.browserContext) {
       try {
         await this.browserContext.close()
@@ -1399,16 +1398,16 @@ class Playwright extends Helper {
     }
     this.browserContext = null
 
-    // Initiate browser close without waiting for it to complete
-    // The browser process will be cleaned up when the Node process exits
     if (this.browser) {
       try {
-        // Fire and forget - don't wait for close to complete
-        this.browser.close().catch(() => {
-          // Silently ignore any errors during async close
-        })
+        // Add timeout to prevent browser.close() from hanging indefinitely
+        await Promise.race([this.browser.close(), new Promise((_, reject) => setTimeout(() => reject(new Error('Browser close timeout')), 5000))])
       } catch (e) {
-        // Ignore any synchronous errors
+        // Ignore errors if browser is already closed or timeout
+        if (!e.message?.includes('Browser close timeout')) {
+          // Non-timeout error, can be ignored as well
+        }
+        // Force cleanup even on error
       }
     }
     this.browser = null

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "codeceptjs",
-  "version": "4.0.1-beta.14",
+  "version": "4.0.1-beta.15",
   "type": "module",
   "description": "Supercharged End 2 End Testing Framework for NodeJS",
   "keywords": [