codecartographer-pi 0.24.1 → 0.26.0

package/dist/extensions/codecarto/index.js

@@ -1,6 +1,6 @@
 import { mkdir, readFile, rename, writeFile } from "node:fs/promises";
 import { basename, dirname, join, resolve } from "node:path";
-import { autoCompletePhase, buildAutoSummary, isPhaseRunning, runAuto, runSinglePhase } from "./auto-runner.js";
+import { autoCompletePhase, buildAutoSummary, describeAutoOutcome, isPhaseRunning, runAuto, runSinglePhase } from "./auto-runner.js";
 import { disposeAgentsWidget } from "./agent-widget.js";
 import { parseDashboardFlags } from "./dashboard-flags.js";
 import { narrateDashboard } from "./dashboard-narrator.js";
@@ -638,7 +638,7 @@ export default function codeCartographerExtension(pi) {
                 });
                 lastFeedbackLines = [`Auto pipeline ${result.outcome}: ${result.reason}`];
                 await refreshWorkspaceUi(ctx, lastFeedbackLines);
-                notifyCtx(ctx, `Auto pipeline ${result.outcome}: ${result.phasesRun.length}/${result.totalPhases} phases.`, result.outcome === "complete" ? "info" : "warning");
+                notifyCtx(ctx, describeAutoOutcome(result), result.outcome === "complete" ? "info" : "warning");
                 return;
             }
             const outcome = resolvePipelineOutcome(state);
@@ -995,7 +995,7 @@ export default function codeCartographerExtension(pi) {
         },
     });
     pi.registerCommand("codecarto-broadside", {
-        description: "Batch reconnaissance (Broad-Side): /codecarto-broadside [submit|collect|status|models|verify] [lenses…] [--model=ID] [--lens-model=LENS:ID] [--top=N] [flags]",
+        description: "Batch reconnaissance (Broad-Side): /codecarto-broadside [submit|collect|status|models|verify] [lenses…] [--model=ID] [--lens-model=LENS:ID] [--top=N] [--regenerate] [flags]",
         // Completes the token under the cursor, so lens names and flags are
         // offered after the action too, and keeps everything typed before it.
         getArgumentCompletions: (prefix) => completeLastToken(prefix, KNOWN_BROADSIDE_TOKENS.map((value) => ({ value }))),
@@ -1220,6 +1220,7 @@ export default function codeCartographerExtension(pi) {
                     retryTruncated,
                     onStatus,
                     ...(flags.runId && { runId: flags.runId }),
+                    ...(flags.regeneratePostPasses && { regeneratePostPasses: true }),
                 });
                 const lines = collectResultText(collect).split("\n");
                 const done = collect.status === "completed";
@@ -1506,10 +1507,15 @@ export default function codeCartographerExtension(pi) {
                     notifyCtx(ctx, `LLM narration skipped (${result.skipReason}); rendering deterministic dashboard.`, "warning");
                 }
             }
-            await writeDashboard(ctx.cwd, PACKAGE_VERSION);
-            lastFeedbackLines = ["Dashboard regenerated: .codecarto/dashboard.html"];
+            // writeDashboard is best-effort and says so with its result: a
+            // swallowed write failure used to be reported as success (#369).
+            const written = await writeDashboard(ctx.cwd, PACKAGE_VERSION);
+            const line = written
+                ? "Dashboard regenerated: .codecarto/dashboard.html"
+                : "Dashboard not regenerated: the write to .codecarto/dashboard.html failed (permissions or disk?); the previous file, if any, stands.";
+            lastFeedbackLines = [line];
             setUiState(ctx, state, lastFeedbackLines);
-            notifyCtx(ctx, "Dashboard regenerated: .codecarto/dashboard.html", "info");
+            notifyCtx(ctx, line, written ? "info" : "error");
         },
     });
     pi.registerCommand("codecarto-refresh-scaffold", {
@@ -1539,7 +1545,7 @@ export default function codeCartographerExtension(pi) {
                 lastFeedbackLines = [
                     `Refreshed ${result.written.length} framework-owned file(s) from the packaged template (${transition}).`,
                     "Project state, user config, findings outputs, scratch, closeouts, and orchestrator files were not touched.",
-                    "THREAD_LOG.md: one scaffold-refresh entry appended.",
+                    result.threadLogEntryAppended ? "THREAD_LOG.md: one scaffold-refresh entry appended." : "THREAD_LOG.md: already carries this refresh; nothing appended.",
                 ];
                 // Re-read state so the widget's staleness line clears with the marker.
                 await refreshWorkspaceUi(ctx, lastFeedbackLines);

package/dist/extensions/codecarto/phase-compaction.js

@@ -66,8 +66,12 @@ export function phaseCompactionExtension(pi) {
         if (event.toolName === "edit" || event.toolName === "write") {
             const inputPath = typeof event.input.path === "string" ? event.input.path : "";
             const strippedPath = inputPath.startsWith("@") ? inputPath.slice(1) : inputPath;
-            // Same containment as the parent extension's hook (#223): follow the
-            // existing prefix through symlinks, then append the unborn tail.
+            // The same symlink-aware containment as the parent extension's hook
+            // (#223) — follow the existing prefix through symlinks, then append
+            // the unborn tail — over a narrower root on purpose: a phase writes
+            // findings, handoffs, and checkpoints under .codecarto/ and never
+            // publishes, so the configured library the orchestrator's hook admits
+            // is not admitted here (#364).
             const targetPath = await resolveExistingPrefix(strippedPath, ctx.cwd);
             const allowedRoot = await canonicalPath(join(ctx.cwd, ".codecarto"));
             if (!isWithinPath(targetPath, allowedRoot)) {

package/dist/mcp-server/server.d.ts

@@ -248,6 +248,7 @@ export declare function handleBroadside(args: {
     model?: string;
     lens_models?: Record<string, string>;
     top?: number;
+    regenerate_post_passes?: boolean;
 }): Promise<{
     content: {
         type: "text";

package/dist/mcp-server/server.js

@@ -17,7 +17,7 @@ import { StdioServerTransport } from "@modelcontextprotocol/sdk/server/stdio.js"
 import { CallToolRequestSchema, ErrorCode, ListToolsRequestSchema, McpError, } from "@modelcontextprotocol/sdk/types.js";
 import { mkdir, readFile, readdir, rename, writeFile } from "node:fs/promises";
 import { basename, isAbsolute, join } from "node:path";
-import { buildPhasePrompt, buildSkillPrompt, buildValidationSummary, BROADSIDE_DIR, broadsideDirFor, BROADSIDE_LENS_IDS, BROADSIDE_SKILL_NAME, BroadsideConfigError, defaultBroadsideConfig, backupWorkspaceState, canonicalPath, copyPackagedWorkspace, collectResultText, completeValidatedPhase, computePerPhaseTotals, computeTotals, createEmptyStatus, DEFAULT_PIPELINE_PATH, deriveSlug, discoverLibrary, describeScaffoldStaleness, detectProvenanceConflicts, estimateSubmitText, getLens, describeDanglingCarryForward, describeMissingCompletedOutputs, describeStuckPipeline, getPipelineLabel, getWorkspaceState, isValidSlug, isWithinPathResolved, listBatchModels, listEntries, listGuideTopics, loadBroadsideConfig, modelsText, readGuide, listMissingCompletedOutputs, listSkillNames, resolvePipelineOutcome, resolveSkillName, loadCodecartoConfig, loadUsage, loadYamlFile, normalizeForComparison, PACKAGE_VERSION, packagedWorkspaceDir, pathExists, PhasePreflightError, previewPublishVersion, publishEntry, reindex as libraryReindex, refreshScaffold, resolvePhase, resolvePipelineChoice, readBroadsideSkill, runBroadsideCollect, runBroadsideStatus, runBroadsideSubmit, runBroadsideVerify, verifyResultText, seedOrchestratorFiles, statusLineWriter, statusText, stringifySimpleYaml, switchPipeline, validatePhaseOutput, writeLibraryConfig, writeDashboard, } from "../core/index.js";
+import { buildPhasePrompt, buildSkillPrompt, buildValidationSummary, BROADSIDE_DIR, broadsideDirFor, BROADSIDE_LENS_IDS, BROADSIDE_SKILL_NAME, BroadsideConfigError, defaultBroadsideConfig, backupWorkspaceState, canonicalPath, copyPackagedWorkspace, collectResultText, completeValidatedPhase, computePerPhaseTotals, computeTotals, createEmptyStatus, DEFAULT_PIPELINE_PATH, deriveSlug, discoverLibrary, describeScaffoldStaleness, detectProvenanceConflicts, estimateSubmitText, getLens, describeDanglingCarryForward, describeMissingCompletedOutputs, describeStuckPipeline, getPipelineLabel, getWorkspaceState, isValidSlug, isWithinPathResolved, listBatchModels, listEntriesWithIndexState, listGuideTopics, loadBroadsideConfig, modelsText, readGuide, listMissingCompletedOutputs, listSkillNames, resolvePipelineOutcome, resolveSkillName, loadCodecartoConfig, loadUsage, loadYamlFile, normalizeForComparison, PACKAGE_VERSION, packagedWorkspaceDir, pathExists, PhasePreflightError, previewPublishVersion, publishEntry, reindex as libraryReindex, refreshScaffold, resolvePhase, resolvePipelineChoice, readBroadsideSkill, runBroadsideCollect, runBroadsideStatus, runBroadsideSubmit, runBroadsideVerify, verifyResultText, seedOrchestratorFiles, statusLineWriter, statusText, stringifySimpleYaml, switchPipeline, validatePhaseOutput, writeLibraryConfig, writeDashboard, } from "../core/index.js";
 import { applyAmendment } from "../core/amendment.js";
 import { appendUsageRun } from "../core/usage.js";
 import { initLibrary } from "../core/library.js";
@@ -545,7 +545,10 @@ export async function readSpecArg(args, allowedRoots) {
         if (!withinAllowed.some((result) => result)) {
             throw new McpError(ErrorCode.InvalidParams, `spec_path must be within the workspace (.codecarto/) or the configured library path. Got: ${args.spec_path}`);
         }
-        return readFile(args.spec_path, "utf8");
+        // The path that was checked is the path that is read: the original
+        // string could be re-pointed through a symlink between the check and
+        // the read; the canonical one cannot (#362).
+        return readFile(resolvedSpecPath, "utf8");
     }
     throw new McpError(ErrorCode.InvalidParams, "Either spec (inline content) or spec_path (absolute file path) is required");
 }
@@ -749,7 +752,7 @@ export async function handleLibraryList(args) {
         filter.slug = args.slug;
     if (typeof args.source_repo === "string" && args.source_repo !== "")
         filter.source_repo = args.source_repo;
-    const entries = await listEntries(libraryPath, filter);
+    const { entries, indexState } = await listEntriesWithIndexState(libraryPath, filter);
     // Computed over the listed entries only, read-only: one readdir per entry
     // plus one small metadata read per older version.
     const conflicts = await detectProvenanceConflicts(libraryPath, entries);
@@ -766,11 +769,17 @@ export async function handleLibraryList(args) {
             }),
             ...provenanceConflictLines(conflicts),
         ].join("\n");
-    return textResult(summary, {
+    // A list never writes the index (#357): say when it answered from the
+    // entry directories instead, so the caller can run a reindex.
+    const indexNote = indexState === "indexed"
+        ? ""
+        : `\nindex.yaml is ${indexState}; this listing was built from the entry directories. Run codecarto_library_reindex to rebuild it.`;
+    return textResult(`${summary}${indexNote}`, {
         libraryPath,
         libraryName: marker.name,
         namespaced: marker.namespaced,
         count: entries.length,
+        indexState,
         entries,
         provenance_conflicts: conflicts,
     });
@@ -996,6 +1005,7 @@ export async function handleRefreshScaffold(args) {
         written: result.written,
         scaffoldVersionBefore: result.scaffoldVersionBefore,
         scaffoldVersionAfter: result.scaffoldVersionAfter,
+        threadLogEntryAppended: result.threadLogEntryAppended,
     });
 }
 export async function handleAmend(args) {
@@ -1208,10 +1218,17 @@ export async function handleBroadside(args) {
             candidates: verified.candidates,
             totalCost: verified.totalCost,
             ...(verified.stoppedByCost && { stoppedByCost: true }),
+            redactedValues: verified.redactedValues,
             findings: verified.findings,
         });
     }
     // action === "collect"
+    if (args.regenerate_post_passes !== undefined && typeof args.regenerate_post_passes !== "boolean") {
+        throw new McpError(ErrorCode.InvalidParams, "regenerate_post_passes must be a boolean.");
+    }
+    if (args.regenerate_post_passes && !includeSynthesis && !includeTriage) {
+        throw new McpError(ErrorCode.InvalidParams, "regenerate_post_passes needs at least one of include_synthesis and include_triage.");
+    }
     const collect = await runBroadsideCollect(cwd, apiKey, {
         waitMs,
         includeSynthesis,
@@ -1219,6 +1236,7 @@ export async function handleBroadside(args) {
         retryTruncated,
         signal: serverLifetime?.signal,
         ...(runId && { runId }),
+        ...(args.regenerate_post_passes && { regeneratePostPasses: true }),
     }).catch((error) => {
         throw new McpError(ErrorCode.InvalidRequest, error instanceof Error ? error.message : String(error));
     });
@@ -1232,6 +1250,7 @@ export async function handleBroadside(args) {
         lensOutcomes: collect.lensOutcomes,
         synthesis: collect.synthesis,
         triage: collect.triage,
+        ...(collect.regenerated && { regenerated: collect.regenerated }),
         topFindings: collect.topFindings,
         topTriageItems: collect.topTriageItems,
     });
@@ -1540,7 +1559,7 @@ const TOOLS = [
                 action: {
                     type: "string",
                     enum: ["submit", "collect", "status", "models", "verify"],
-                    description: "submit fires all lens batches and returns batch ids; collect polls submitted batches, saves results, and optionally runs the synthesis pass; status shows recorded runs; models lists batch-capable models with pricing and capabilities; verify reads a collected run's top defect and security findings against the repository with read-only tools (one sync-priced call each, about a cent on the default model) and writes verified.md/verified.json beside triage.md with a verdict per finding: confirmed (a reachable failure, with the trigger), not-a-defect, discarded, or unclear.",
+                    description: "submit fires all lens batches and returns batch ids; collect polls submitted batches, saves results, and optionally runs the synthesis and triage passes — built from verified.json when a verify pass has already written it, so run verify first or collect again with regenerate_post_passes afterwards; status shows recorded runs; models lists batch-capable models with pricing and capabilities; verify reads a collected run's top defect and security findings against the repository with read-only tools (one sync-priced call each, about a cent on the default model) and writes verified.md/verified.json beside triage.md with a verdict per finding: confirmed (a reachable failure, with the trigger), not-a-defect, discarded, or unclear.",
                 },
                 lenses: {
                     type: "array",
@@ -1575,6 +1594,10 @@ const TOOLS = [
                     type: "boolean",
                     description: "Re-submit lens results that came back truncated at the output token limit, once, with a doubled output cap. Falls back to retry_truncated in .codecarto/broadside/config.yaml (default true).",
                 },
+                regenerate_post_passes: {
+                    type: "boolean",
+                    description: "collect only: reset the run's settled synthesis and triage passes and run them again, so a verify pass's verdicts (verified.json) are built into the executive report and the work order — confirmed findings first, discarded ones dropped, not-a-defect ones listed apart. Costs another post-pass pair (a few cents); a pass still in flight is left to finish; a run whose lens batches are still running is refused.",
+                },
                 max_cost: {
                     type: "number",
                     description: "Approximate run expense limit in USD. The submit action estimates the run cost from slice sizes and the configured model's per-token pricing (live OpenRouter lookup, cached 24h) and refuses to submit when the estimate exceeds the limit unless force is true. For verify it is a running cap: the pass stops before the next finding once the calls so far have reached it. Falls back to max_cost in .codecarto/broadside/config.yaml, whose default is $1.00; pass 0 for no limit.",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "codecartographer-pi",
-  "version": "0.24.1",
+  "version": "0.26.0",
   "mcpName": "io.github.HuginnIndustries/codecartographer",
   "description": "Turn an unfamiliar codebase into a validated reimplementation spec, then synthesize confirmed specs and a product vision into a traceable plan.",
   "type": "module",