codecartographer-pi 0.19.6 → 0.21.0

package/dist/extensions/codecarto/auto-runner.js

@@ -17,8 +17,7 @@ import { clearPhase, finishPhase, getPhaseActivity, startPhase } from "./agent-s
 import { buildSteeringMessage, rewritePhasePrompt } from "./agent-rewriter.js";
 import { buildPhaseSummary } from "./agent-summary.js";
 import { getAgentsWidget } from "./agent-widget.js";
-import { writeDashboard } from "./dashboard-writer.js";
-import { appendUsageRun, buildPhasePrompt, buildValidationSummary, completeValidatedPhase, formatMillis, formatTokenCount, getNextEligiblePhase, getWorkspaceState, loadCodecartoConfig, PACKAGE_VERSION, PhasePreflightError, runPhasePreflight, validatePhaseOutput, } from "../../core/index.js";
+import { appendUsageRun, buildPhasePrompt, buildValidationSummary, completeValidatedPhase, formatMillis, formatTokenCount, describeStuckPipeline, resolvePipelineOutcome, getWorkspaceState, describeConfigProblems, loadCodecartoConfig, PACKAGE_VERSION, PhasePreflightError, runPhasePreflight, validatePhaseOutput, writeDashboard, } from "../../core/index.js";
 /**
  * Run one phase end to end: optional LLM-steered rewrite, spawn the sub-agent,
  * wait for it, then emit the side effects the historical /codecarto-next chain
@@ -60,7 +59,6 @@ export async function runSinglePhase(ctx, pi, state, phase, options) {
         getAgentsWidget().attach(ctx.ui);
     try {
         const result = await runPhase(ctx, prompt, {
-            onSessionCreated: (session) => { activity.session = session; },
             onToolStart: (id, name) => { activity.activeTools.set(id, name); activity.toolUses++; },
             onToolEnd: (id) => { activity.activeTools.delete(id); },
             onTextDelta: (_delta, fullText) => { activity.responseText = fullText; },
@@ -101,7 +99,9 @@ export async function runSinglePhase(ctx, pi, state, phase, options) {
             display: true,
         });
         void recordUsage(state.workspaceDir, phase.id, status, activity, result.sessionFile);
-        void writeDashboard(ctx.cwd, PACKAGE_VERSION);
+        // The phase's sub-agent replaced the session, so reading ctx.cwd here
+        // would throw (#201); the state captured before the run has the root.
+        void writeDashboard(state.cwd, PACKAGE_VERSION);
         return {
             status: result.aborted ? "aborted" : "completed",
             activity,
@@ -128,7 +128,7 @@ export async function runSinglePhase(ctx, pi, state, phase, options) {
             display: true,
         });
         void recordUsage(state.workspaceDir, phase.id, "error", activity);
-        void writeDashboard(ctx.cwd, PACKAGE_VERSION);
+        void writeDashboard(state.cwd, PACKAGE_VERSION);
         return { status: "error", activity, error: message };
     }
     finally {
@@ -190,6 +190,10 @@ export async function runAuto(ctx, pi, initialState, options) {
     const totalTokens = { input: 0, output: 0, cacheWrite: 0 };
     const totalPhases = initialState.pipeline.phase_order.length;
     const config = await loadCodecartoConfig(initialState.workspaceDir);
+    // Once, before the loop: a dropped config file changes what this run does
+    // (the steer toggle lives there) and nothing else in the loop reads it.
+    if (config.problems.length > 0)
+        notifyCtx(ctx, describeConfigProblems(config).join("\n"), "warning");
     const llmSteerEnabled = options.llmSteerOverride ?? config.orchestrator.llm_steer_next_phase;
     let state = initialState;
     while (true) {
@@ -199,13 +203,22 @@ export async function runAuto(ctx, pi, initialState, options) {
                 reason: "User aborted the auto run.",
             });
         }
-        const phase = getNextEligiblePhase(state);
-        if (!phase) {
+        const outcome = resolvePipelineOutcome(state);
+        if (outcome.kind === "stuck") {
+            // Not "complete": the loop ending because nothing can run is the
+            // case that used to read as success (#228).
+            return finish({
+                outcome: "stuck",
+                reason: describeStuckPipeline(outcome.blocked),
+            });
+        }
+        if (outcome.kind === "complete") {
             return finish({
                 outcome: "complete",
                 reason: "Pipeline complete.",
             });
         }
+        const phase = outcome.phase;
         let preflight;
         try {
             preflight = await runPhasePreflight(state, phase);
@@ -241,7 +254,7 @@ export async function runAuto(ctx, pi, initialState, options) {
         if (phaseResult.status === "completed") {
             // State must be refreshed because the sub-agent may have written
             // findings to disk that the validator reads.
-            const stateForValidation = (await getWorkspaceState(ctx.cwd)) ?? state;
+            const stateForValidation = (await getWorkspaceState(autoCwd)) ?? state;
             validation = await validatePhaseOutput(stateForValidation, phase.id);
         }
         const decision = decideAfterPhase(phaseResult.status, phaseResult.error, validation, options.strict);
@@ -304,6 +317,8 @@ export function buildAutoSummary(result, availableSkills = []) {
                 return `**Auto pipeline stopped at \`${result.stoppedAt?.phaseId ?? "?"}\`.**`;
             case "aborted":
                 return `**Auto pipeline aborted${result.stoppedAt?.phaseId ? ` during \`${result.stoppedAt.phaseId}\`` : ""}.**`;
+            case "stuck":
+                return `**Auto pipeline stuck: no phase can run.**`;
         }
     })();
     const statsLine = `_⟳ ${ranOf} · ${tokensStr} tokens · ${wallTime}_`;
@@ -317,6 +332,10 @@ export function buildAutoSummary(result, availableSkills = []) {
         lines.push("", result.reason);
         lines.push("", recoveryHint(result));
     }
+    if (result.outcome === "stuck") {
+        // The reason is the stuck sentence, which already says what to fix.
+        lines.push("", result.reason);
+    }
     if (result.outcome === "complete") {
         lines.push("", "Dashboard: `.codecarto/dashboard.html`");
         if (availableSkills.length > 0) {

package/dist/extensions/codecarto/broadside-flags.d.ts

@@ -16,11 +16,13 @@ export interface BroadsideFlags {
     /** Undefined means "use the repository's config default". */
     maxCost?: number;
     waitSeconds?: number;
+    /** For collect: the run to collect instead of the most recent (#268). */
+    runId?: string;
     benchmarks: boolean;
     unknown: string[];
     /** Set on an invalid combination. The caller surfaces it as an error. */
     error?: string;
 }
 /** Every token the completer offers, in the order it offers them. */
-export declare const KNOWN_BROADSIDE_TOKENS: readonly ["submit", "collect", "status", "models", "architecture", "api", "security", "defect", "conventions", "porting", "--incremental", "--no-incremental", "--max-cost=", "--wait=", "--no-synthesis", "--no-triage", "--no-retry-truncated", "--benchmarks"];
+export declare const KNOWN_BROADSIDE_TOKENS: readonly ["submit", "collect", "status", "models", "architecture", "api", "security", "defect", "conventions", "porting", "--incremental", "--no-incremental", "--max-cost=", "--wait=", "--run=", "--no-synthesis", "--no-triage", "--no-retry-truncated", "--benchmarks"];
 export declare function parseBroadsideFlags(args: string): BroadsideFlags;

package/dist/extensions/codecarto/broadside-flags.js

@@ -13,6 +13,7 @@
 //   --no-incremental       --no-triage
 //   --max-cost=N           --no-retry-truncated
 //   --wait=SECONDS         --benchmarks (models only)
+//   --run=ID (collect only: an older run, as listed by status)
 //
 // --incremental has a spelled-out negative because the value is tri-state:
 // absent defers to config.yaml, so a repository that set `incremental: true`
@@ -34,6 +35,7 @@ export const KNOWN_BROADSIDE_TOKENS = [
     "--no-incremental",
     "--max-cost=",
     "--wait=",
+    "--run=",
     "--no-synthesis",
     "--no-triage",
     "--no-retry-truncated",
@@ -106,6 +108,13 @@ export function parseBroadsideFlags(args) {
             result.waitSeconds = parseNumeric(token, "--wait", result);
             continue;
         }
+        if (token.startsWith("--run=")) {
+            const value = token.slice("--run=".length).trim();
+            if (!value)
+                result.error ??= "--run= needs a run id (see /codecarto-broadside status).";
+            result.runId = value || undefined;
+            continue;
+        }
         result.unknown.push(token);
     }
     // Flags that only mean something for one action are refused rather than
@@ -125,5 +134,8 @@ export function parseBroadsideFlags(args) {
     if (result.action === "status" && result.waitSeconds !== undefined) {
         result.error ??= "--wait is only meaningful for submit and collect; status reads recorded state.";
     }
+    if (result.runId !== undefined && result.action !== "collect") {
+        result.error ??= `--run is only meaningful for collect (got action "${result.action}").`;
+    }
     return result;
 }

package/dist/extensions/codecarto/dashboard-narrator.js

@@ -13,6 +13,7 @@
 import { readFile, readdir } from "node:fs/promises";
 import { join } from "node:path";
 import { createAgentSession, DefaultResourceLoader, getAgentDir, SessionManager, SettingsManager, } from "@earendil-works/pi-coding-agent";
+import { disposeChildSession } from "./agent-runner.js";
 import { atomicWriteFile, computeTotals, NARRATION_CACHE_RELATIVE_PATH, loadUsage, pathExists, stringifySimpleYaml, } from "../../core/index.js";
 import { createChildModelRuntime } from "./child-model-runtime.js";
 // Per-closeout byte budget when stuffing the narrator's input. Three
@@ -158,8 +159,14 @@ async function runNarratorOnce(ctx, prompt) {
         tools: [],
         resourceLoader: loader,
     });
-    await session.prompt(prompt);
-    return getLastAssistantText(session);
+    try {
+        await session.prompt(prompt);
+        return getLastAssistantText(session);
+    }
+    finally {
+        // One prompt, one answer; the child has nothing left to do (#256).
+        disposeChildSession(session);
+    }
 }
 function getLastAssistantText(session) {
     for (let i = session.messages.length - 1; i >= 0; i--) {

package/dist/extensions/codecarto/dashboard-writer.d.ts

@@ -1,8 +1 @@
-/**
- * Render and atomically replace `.codecarto/dashboard.html`.
- * @returns true when a fresh dashboard landed on disk; false when the
- * workspace is missing or any gather/render/write step failed (swallowed —
- * lifecycle callers must never fail on a dashboard problem, but they may
- * report truthfully whether a refresh happened).
- */
-export declare function writeDashboard(cwd: string, packageVersion: string): Promise<boolean>;
+export { writeDashboard } from "../../core/dashboard-writer.ts";

package/dist/extensions/codecarto/dashboard-writer.js

@@ -1,154 +1,5 @@
-// I/O wrapper that gathers all dashboard inputs and writes the rendered
-// HTML to `.codecarto/dashboard.html`. Best-effort — failures are swallowed
-// and never escalate to a phase error the user sees, mirroring the
-// recordUsage discipline at extensions/codecarto/index.ts.
-import { readdir, readFile } from "node:fs/promises";
-import { join } from "node:path";
-import { atomicWriteFile, DASHBOARD_RELATIVE_PATH, getWorkspaceState, loadUsage, NARRATION_CACHE_RELATIVE_PATH, parseSimpleYaml, pathExists, renderDashboard, } from "../../core/index.js";
-const CLOSEOUT_FILENAME_RE = /^(\d{4}-\d{2}-\d{2})-(.+)\.md$/;
-/**
- * Render and atomically replace `.codecarto/dashboard.html`.
- * @returns true when a fresh dashboard landed on disk; false when the
- * workspace is missing or any gather/render/write step failed (swallowed —
- * lifecycle callers must never fail on a dashboard problem, but they may
- * report truthfully whether a refresh happened).
- */
-export async function writeDashboard(cwd, packageVersion) {
-    try {
-        const state = await getWorkspaceState(cwd);
-        if (!state)
-            return false;
-        const workspaceDir = state.workspaceDir;
-        const [usage, closeouts, outputsPresent, narration] = await Promise.all([
-            loadUsage(workspaceDir),
-            listCloseouts(workspaceDir),
-            buildOutputsPresent(state.workspaceDir, state.pipeline),
-            loadNarration(workspaceDir),
-        ]);
-        const inputs = {
-            status: state.status,
-            pipeline: state.pipeline,
-            usage,
-            closeouts,
-            outputsPresent,
-            packageVersion,
-            generatedAt: new Date().toISOString(),
-            narration,
-        };
-        const html = renderDashboard(inputs);
-        await atomicWriteFile(join(workspaceDir, DASHBOARD_RELATIVE_PATH), html);
-        return true;
-    }
-    catch {
-        // Best-effort: a failed dashboard write must not surface as a phase
-        // error. The user's pipeline state is unaffected; the next state
-        // change will trigger another render attempt.
-        return false;
-    }
-}
-async function listCloseouts(workspaceDir) {
-    const dir = join(workspaceDir, "closeouts");
-    if (!(await pathExists(dir)))
-        return [];
-    let entries;
-    try {
-        entries = await readdir(dir);
-    }
-    catch {
-        return [];
-    }
-    const out = [];
-    for (const name of entries) {
-        const m = CLOSEOUT_FILENAME_RE.exec(name);
-        if (!m)
-            continue;
-        out.push({ date: m[1], phaseOrModule: m[2], fileName: name, summary: await readCloseoutSummary(join(dir, name)) });
-    }
-    return out;
-}
-async function readCloseoutSummary(path) {
-    try {
-        const raw = await readFile(path, "utf8");
-        const lines = raw.split(/\r?\n/);
-        const summaryStart = lines.findIndex((line) => /^##\s+Summary\s*$/i.test(line.trim()));
-        if (summaryStart === -1)
-            return undefined;
-        const body = [];
-        for (const line of lines.slice(summaryStart + 1)) {
-            if (/^##\s+/.test(line.trim()))
-                break;
-            const trimmed = line.trim();
-            if (!trimmed || trimmed === "-")
-                continue;
-            body.push(trimmed.replace(/^[-*]\s+/, ""));
-            if (body.join(" ").length > 280)
-                break;
-        }
-        const summary = body.join(" ").trim();
-        return summary ? `${summary.slice(0, 280)}${summary.length > 280 ? "…" : ""}` : undefined;
-    }
-    catch {
-        return undefined;
-    }
-}
-async function buildOutputsPresent(workspaceDir, pipeline) {
-    const out = new Map();
-    for (const phaseId of pipeline.phase_order) {
-        const phaseDef = pipeline.phases.find((p) => p.id === phaseId);
-        if (!phaseDef)
-            continue;
-        const entry = { secondary: [] };
-        if (phaseDef.primary_output) {
-            entry.primary = {
-                path: phaseDef.primary_output,
-                exists: await pathExists(join(workspaceDir, phaseDef.primary_output)),
-            };
-        }
-        for (const sec of phaseDef.secondary_outputs ?? []) {
-            entry.secondary.push({
-                path: sec.path,
-                exists: await pathExists(join(workspaceDir, sec.path)),
-            });
-        }
-        out.set(phaseId, entry);
-    }
-    return out;
-}
-async function loadNarration(workspaceDir) {
-    const path = join(workspaceDir, NARRATION_CACHE_RELATIVE_PATH);
-    if (!(await pathExists(path)))
-        return undefined;
-    try {
-        const raw = await readFile(path, "utf8");
-        const { frontmatter, body } = splitFrontmatter(raw);
-        if (!frontmatter)
-            return undefined;
-        const generatedAt = typeof frontmatter.generatedAt === "string" ? frontmatter.generatedAt : "";
-        const phaseCountAtGeneration = typeof frontmatter.phaseCountAtGeneration === "number" ? frontmatter.phaseCountAtGeneration : 0;
-        if (!generatedAt)
-            return undefined;
-        return { content: body.trim(), generatedAt, phaseCountAtGeneration };
-    }
-    catch {
-        return undefined;
-    }
-}
-function splitFrontmatter(raw) {
-    if (!raw.startsWith("---\n"))
-        return { frontmatter: null, body: raw };
-    const end = raw.indexOf("\n---\n", 4);
-    if (end === -1)
-        return { frontmatter: null, body: raw };
-    const yamlText = raw.slice(4, end);
-    const body = raw.slice(end + 5);
-    try {
-        const parsed = parseSimpleYaml(yamlText);
-        if (parsed && typeof parsed === "object" && !Array.isArray(parsed)) {
-            return { frontmatter: parsed, body };
-        }
-    }
-    catch {
-        // fall through
-    }
-    return { frontmatter: null, body };
-}
+// Moved to core/dashboard-writer.ts (#254): both surfaces render the dashboard
+// at the same lifecycle points, so it is a shared primitive. This re-export
+// keeps the old import path — scripts/build-demo-dashboard.mjs among them —
+// working.
+export { writeDashboard } from "../../core/dashboard-writer.js";