codecartographer-pi 0.19.6 → 0.20.0

package/dist/extensions/codecarto/dashboard-writer.js

@@ -1,154 +1,5 @@
-// I/O wrapper that gathers all dashboard inputs and writes the rendered
-// HTML to `.codecarto/dashboard.html`. Best-effort — failures are swallowed
-// and never escalate to a phase error the user sees, mirroring the
-// recordUsage discipline at extensions/codecarto/index.ts.
-import { readdir, readFile } from "node:fs/promises";
-import { join } from "node:path";
-import { atomicWriteFile, DASHBOARD_RELATIVE_PATH, getWorkspaceState, loadUsage, NARRATION_CACHE_RELATIVE_PATH, parseSimpleYaml, pathExists, renderDashboard, } from "../../core/index.js";
-const CLOSEOUT_FILENAME_RE = /^(\d{4}-\d{2}-\d{2})-(.+)\.md$/;
-/**
- * Render and atomically replace `.codecarto/dashboard.html`.
- * @returns true when a fresh dashboard landed on disk; false when the
- * workspace is missing or any gather/render/write step failed (swallowed —
- * lifecycle callers must never fail on a dashboard problem, but they may
- * report truthfully whether a refresh happened).
- */
-export async function writeDashboard(cwd, packageVersion) {
-    try {
-        const state = await getWorkspaceState(cwd);
-        if (!state)
-            return false;
-        const workspaceDir = state.workspaceDir;
-        const [usage, closeouts, outputsPresent, narration] = await Promise.all([
-            loadUsage(workspaceDir),
-            listCloseouts(workspaceDir),
-            buildOutputsPresent(state.workspaceDir, state.pipeline),
-            loadNarration(workspaceDir),
-        ]);
-        const inputs = {
-            status: state.status,
-            pipeline: state.pipeline,
-            usage,
-            closeouts,
-            outputsPresent,
-            packageVersion,
-            generatedAt: new Date().toISOString(),
-            narration,
-        };
-        const html = renderDashboard(inputs);
-        await atomicWriteFile(join(workspaceDir, DASHBOARD_RELATIVE_PATH), html);
-        return true;
-    }
-    catch {
-        // Best-effort: a failed dashboard write must not surface as a phase
-        // error. The user's pipeline state is unaffected; the next state
-        // change will trigger another render attempt.
-        return false;
-    }
-}
-async function listCloseouts(workspaceDir) {
-    const dir = join(workspaceDir, "closeouts");
-    if (!(await pathExists(dir)))
-        return [];
-    let entries;
-    try {
-        entries = await readdir(dir);
-    }
-    catch {
-        return [];
-    }
-    const out = [];
-    for (const name of entries) {
-        const m = CLOSEOUT_FILENAME_RE.exec(name);
-        if (!m)
-            continue;
-        out.push({ date: m[1], phaseOrModule: m[2], fileName: name, summary: await readCloseoutSummary(join(dir, name)) });
-    }
-    return out;
-}
-async function readCloseoutSummary(path) {
-    try {
-        const raw = await readFile(path, "utf8");
-        const lines = raw.split(/\r?\n/);
-        const summaryStart = lines.findIndex((line) => /^##\s+Summary\s*$/i.test(line.trim()));
-        if (summaryStart === -1)
-            return undefined;
-        const body = [];
-        for (const line of lines.slice(summaryStart + 1)) {
-            if (/^##\s+/.test(line.trim()))
-                break;
-            const trimmed = line.trim();
-            if (!trimmed || trimmed === "-")
-                continue;
-            body.push(trimmed.replace(/^[-*]\s+/, ""));
-            if (body.join(" ").length > 280)
-                break;
-        }
-        const summary = body.join(" ").trim();
-        return summary ? `${summary.slice(0, 280)}${summary.length > 280 ? "…" : ""}` : undefined;
-    }
-    catch {
-        return undefined;
-    }
-}
-async function buildOutputsPresent(workspaceDir, pipeline) {
-    const out = new Map();
-    for (const phaseId of pipeline.phase_order) {
-        const phaseDef = pipeline.phases.find((p) => p.id === phaseId);
-        if (!phaseDef)
-            continue;
-        const entry = { secondary: [] };
-        if (phaseDef.primary_output) {
-            entry.primary = {
-                path: phaseDef.primary_output,
-                exists: await pathExists(join(workspaceDir, phaseDef.primary_output)),
-            };
-        }
-        for (const sec of phaseDef.secondary_outputs ?? []) {
-            entry.secondary.push({
-                path: sec.path,
-                exists: await pathExists(join(workspaceDir, sec.path)),
-            });
-        }
-        out.set(phaseId, entry);
-    }
-    return out;
-}
-async function loadNarration(workspaceDir) {
-    const path = join(workspaceDir, NARRATION_CACHE_RELATIVE_PATH);
-    if (!(await pathExists(path)))
-        return undefined;
-    try {
-        const raw = await readFile(path, "utf8");
-        const { frontmatter, body } = splitFrontmatter(raw);
-        if (!frontmatter)
-            return undefined;
-        const generatedAt = typeof frontmatter.generatedAt === "string" ? frontmatter.generatedAt : "";
-        const phaseCountAtGeneration = typeof frontmatter.phaseCountAtGeneration === "number" ? frontmatter.phaseCountAtGeneration : 0;
-        if (!generatedAt)
-            return undefined;
-        return { content: body.trim(), generatedAt, phaseCountAtGeneration };
-    }
-    catch {
-        return undefined;
-    }
-}
-function splitFrontmatter(raw) {
-    if (!raw.startsWith("---\n"))
-        return { frontmatter: null, body: raw };
-    const end = raw.indexOf("\n---\n", 4);
-    if (end === -1)
-        return { frontmatter: null, body: raw };
-    const yamlText = raw.slice(4, end);
-    const body = raw.slice(end + 5);
-    try {
-        const parsed = parseSimpleYaml(yamlText);
-        if (parsed && typeof parsed === "object" && !Array.isArray(parsed)) {
-            return { frontmatter: parsed, body };
-        }
-    }
-    catch {
-        // fall through
-    }
-    return { frontmatter: null, body };
-}
+// Moved to core/dashboard-writer.ts (#254): both surfaces render the dashboard
+// at the same lifecycle points, so it is a shared primitive. This re-export
+// keeps the old import path — scripts/build-demo-dashboard.mjs among them —
+// working.
+export { writeDashboard } from "../../core/dashboard-writer.js";

package/dist/extensions/codecarto/index.js

@@ -5,13 +5,12 @@ import { autoCompletePhase, buildAutoSummary, isPhaseRunning, runAuto, runSingle
 import { disposeAgentsWidget } from "./agent-widget.js";
 import { parseDashboardFlags } from "./dashboard-flags.js";
 import { narrateDashboard } from "./dashboard-narrator.js";
-import { writeDashboard } from "./dashboard-writer.js";
 import { parseBroadsideFlags, KNOWN_BROADSIDE_TOKENS } from "./broadside-flags.js";
 import { parseNextFlags } from "./next-flags.js";
 import { buildPiGuideMessage } from "./guide-framing.js";
 import { isCtxLive, notifyCtx } from "./notify.js";
 import { phaseCompactionExtension } from "./phase-compaction.js";
-import { applyAmendment, buildPhasePrompt, buildSkillPrompt, buildValidationSummary, canonicalPath, copyPackagedWorkspace, computePerPhaseTotals, computeTotals, ConfidentialityMismatchError, createEmptyStatus, DEFAULT_PIPELINE_PATH, describeScaffoldStaleness, deriveSlug, discoverLibrary, getNextEligiblePhase, getPipelineLabel, getWorkspaceState, isWithinPath, resolveExistingPrefix, BROADSIDE_LENS_IDS, BROADSIDE_SKILL_NAME, BroadsideCancelledError, broadsideDirFor, collectResultText, estimateSubmitText, getLens, listAmendmentNames, listBatchModels, listGuideTopics, listScaffoldRefreshFiles, listSkillNames, loadAmendmentFile, loadBroadsideConfig, modelsText, runBroadsideCollect, runBroadsideStatus, runBroadsideSubmit, statusText, loadCodecartoConfig, loadUsage, loadYamlFile, normalizeForComparison, packagedWorkspaceDir, pathExists, PACKAGE_VERSION, readBroadsideSkill, readGuide, refreshScaffold, PhasePreflightError, PIPELINE_ALIASES, publishEntry, resolvePhase, resolvePipelineChoice, resolvePublishSourceRepo, SourceRepoMismatchError, runPhasePreflight, SCAFFOLD_REFRESH_PROTECTED, seedOrchestratorFiles, stringifySimpleYaml, switchPipeline, validatePhaseOutput, writeLibraryConfig, } from "../../core/index.js";
+import { applyAmendment, buildPhasePrompt, buildSkillPrompt, buildValidationSummary, backupWorkspaceState, canonicalPath, copyPackagedWorkspace, computePerPhaseTotals, computeTotals, ConfidentialityMismatchError, createEmptyStatus, DEFAULT_PIPELINE_PATH, describeScaffoldStaleness, deriveSlug, discoverLibrary, describeDanglingCarryForward, describeMissingCompletedOutputs, getNextEligiblePhase, getPipelineLabel, getWorkspaceState, isWithinPath, resolveExistingPrefix, BROADSIDE_LENS_IDS, BROADSIDE_SKILL_NAME, BroadsideCancelledError, broadsideDirFor, collectResultText, estimateSubmitText, getLens, listAmendmentNames, listBatchModels, listGuideTopics, listScaffoldRefreshFiles, listMissingCompletedOutputs, listSkillNames, resolveSkillName, loadAmendmentFile, loadBroadsideConfig, modelsText, runBroadsideCollect, runBroadsideStatus, runBroadsideSubmit, statusText, describeConfigProblems, loadCodecartoConfig, loadUsage, loadYamlFile, normalizeForComparison, packagedWorkspaceDir, pathExists, PACKAGE_VERSION, readBroadsideSkill, readGuide, refreshScaffold, PhasePreflightError, PIPELINE_ALIASES, publishEntry, resolvePhase, resolvePipelineChoice, resolvePublishSourceRepo, SourceRepoMismatchError, runPhasePreflight, SCAFFOLD_REFRESH_PROTECTED, seedOrchestratorFiles, stringifySimpleYaml, switchPipeline, validatePhaseOutput, writeLibraryConfig, writeDashboard, } from "../../core/index.js";
 import { initLibrary } from "../../core/library.js";
 import { resolveUserConfigPath } from "../../core/orchestrator-config.js";
 const STATUS_WIDGET_ID = "codecarto-widget";
@@ -437,11 +436,21 @@ export default function codeCartographerExtension(pi) {
             const targetExists = await pathExists(targetWorkspaceDir);
             if (targetExists) {
                 const sameWorkspace = normalizeForComparison(await canonicalPath(targetWorkspaceDir)) === normalizeForComparison(await canonicalPath(sourceWorkspaceDir));
-                if (!sameWorkspace) {
-                    const overwrite = await ctx.ui.confirm("CodeCartographer already exists — data will be lost", "A .codecarto/ directory already exists in this repository. Re-initializing will back up the existing workspace to .codecarto-backup-TIMESTAMP/ and create a fresh one. All phase findings, handoffs, usage data, closeouts, and progress will be moved to the backup. Consider /codecarto-open to reattach without resetting. Continue?");
-                    if (!overwrite)
-                        return;
-                    const backupDir = join(ctx.cwd, `.codecarto-backup-${new Date().toISOString().replace(/[:.]/g, "-")}`);
+                // The packaged template itself (a checkout install) is an existing
+                // workspace like any other: ask, and back up. It cannot be renamed
+                // away — it is what init copies from — so its session state is
+                // moved out file by file instead (#245).
+                const overwrite = await ctx.ui.confirm("CodeCartographer already exists — data will be lost", sameWorkspace
+                    ? "This .codecarto/ is CodeCartographer's own packaged template (a checkout install), and it holds workspace state. Re-initializing will move that state — status, findings, handoffs, usage data, closeouts, dashboard — to .codecarto-backup-TIMESTAMP/ and reset; the framework files stay in place. Consider /codecarto-open to reattach without resetting. Continue?"
+                    : "A .codecarto/ directory already exists in this repository. Re-initializing will back up the existing workspace to .codecarto-backup-TIMESTAMP/ and create a fresh one. All phase findings, handoffs, usage data, closeouts, and progress will be moved to the backup. Consider /codecarto-open to reattach without resetting. Continue?");
+                if (!overwrite)
+                    return;
+                const backupDir = join(ctx.cwd, `.codecarto-backup-${new Date().toISOString().replace(/[:.]/g, "-")}`);
+                if (sameWorkspace) {
+                    const moved = await backupWorkspaceState(targetWorkspaceDir, backupDir);
+                    notifyCtx(ctx, `Moved ${moved.length} workspace state file${moved.length === 1 ? "" : "s"} to ${basename(backupDir)}/`, "info");
+                }
+                else {
                     await rename(targetWorkspaceDir, backupDir);
                     notifyCtx(ctx, `Backed up existing workspace to ${basename(backupDir)}/`, "info");
                 }
@@ -490,9 +499,17 @@ export default function codeCartographerExtension(pi) {
             if (!state)
                 return;
             const nextPhase = getNextEligiblePhase(state)?.id ?? "complete";
-            lastFeedbackLines = [`Current phase: ${nextPhase}`, `Pipeline: ${getPipelineLabel(state.status.pipeline)}`];
+            // Same check codecarto_status makes: a phase complete in status.yaml
+            // whose report is not on disk (#259).
+            const missingOutputs = describeMissingCompletedOutputs(await listMissingCompletedOutputs(state));
+            lastFeedbackLines = [`Current phase: ${nextPhase}`, `Pipeline: ${getPipelineLabel(state.status.pipeline)}`, ...missingOutputs];
             setUiState(ctx, state, lastFeedbackLines);
-            notifyCtx(ctx, `CodeCartographer phase: ${nextPhase}`, "info");
+            if (missingOutputs.length > 0) {
+                notifyCtx(ctx, `CodeCartographer phase: ${nextPhase}. ${missingOutputs[0]}`, "warning");
+            }
+            else {
+                notifyCtx(ctx, `CodeCartographer phase: ${nextPhase}`, "info");
+            }
         },
     });
     pi.registerCommand("codecarto-switch-pipeline", {
@@ -533,6 +550,7 @@ export default function codeCartographerExtension(pi) {
                     lines.push(`New phases: ${result.newPhases.join(", ")}`);
                 if (result.dropped.length > 0)
                     lines.push(`Phases not in new pipeline: ${result.dropped.join(", ")} (findings remain on disk)`);
+                lines.push(...describeDanglingCarryForward(result.dangling));
                 lastFeedbackLines = lines;
                 await refreshWorkspaceUi(ctx, lastFeedbackLines);
                 notifyCtx(ctx, `Switched to pipeline: ${getPipelineLabel(pipelineChoice)}`, "info");
@@ -631,6 +649,10 @@ export default function codeCartographerExtension(pi) {
                 return;
             }
             const config = await loadCodecartoConfig(state.workspaceDir);
+            // A bad config file must not block a phase run, but it must not be
+            // silent either: the toggle read here may be the one it dropped.
+            if (config.problems.length > 0)
+                notifyCtx(ctx, describeConfigProblems(config).join("\n"), "warning");
             const llmSteerEnabled = flags.llmSteerOverride ?? config.orchestrator.llm_steer_next_phase;
             lastFeedbackLines = [`Running ${phase.id} phase as sub-agent`];
             setUiState(ctx, state, lastFeedbackLines);
@@ -851,23 +873,27 @@ export default function codeCartographerExtension(pi) {
                 notifyCtx(ctx, `Cannot run skill: pipeline is not complete (next phase: ${nextPhase.id}). Finish the pipeline before running post-pipeline skills.`, "error");
                 return;
             }
-            const skillFile = join(state.workspaceDir, "skills", skillName, "SKILL.md");
-            if (!(await pathExists(skillFile))) {
+            // Resolve against the installed list only: the name is never joined
+            // onto a path, so a traversal like `../findings/architecture` cannot
+            // splice a phase SKILL.md into the post-pipeline prompt. Same rule as
+            // the MCP surface's handleSkill.
+            const resolved = await resolveSkillName(state.workspaceDir, skillName);
+            if (!resolved) {
                 const available = await listSkillNames(state.workspaceDir);
                 const hint = available.length > 0 ? ` (available: ${available.join(", ")})` : " (no skills installed)";
                 notifyCtx(ctx, `Unknown skill: ${skillName}${hint}. The Broad-Side reading guide is served as \`${BROADSIDE_SKILL_NAME}\` and is not pipeline-gated.`, "error");
                 return;
             }
-            const prompt = await buildSkillPrompt(state, skillName);
+            const prompt = await buildSkillPrompt(state, resolved);
             if (ctx.isIdle()) {
                 pi.sendUserMessage(prompt);
             }
             else {
                 pi.sendUserMessage(prompt, { deliverAs: "followUp" });
             }
-            lastFeedbackLines = [`Queued post-pipeline skill: ${skillName}`];
+            lastFeedbackLines = [`Queued post-pipeline skill: ${resolved}`];
             setUiState(ctx, state, lastFeedbackLines);
-            notifyCtx(ctx, `Queued CodeCartographer skill: ${skillName}`, "info");
+            notifyCtx(ctx, `Queued CodeCartographer skill: ${resolved}`, "info");
         },
     });
     pi.registerCommand("codecarto-list-skills", {
@@ -1108,6 +1134,13 @@ export default function codeCartographerExtension(pi) {
             if (!state)
                 return;
             const config = await loadCodecartoConfig(state.workspaceDir);
+            // The library path, namespace, and confirm gate all come from the
+            // config, so a file that could not be used is a refusal, not a silent
+            // fallback to the other layer (#242). Same rule as codecarto_publish.
+            if (config.problems.length > 0) {
+                notifyCtx(ctx, ["Publish refused: the configuration has problems. Fix or remove the offending file, then retry.", ...describeConfigProblems(config)].join("\n"), "error");
+                return;
+            }
             if (!config.library.path) {
                 notifyCtx(ctx, "No library.path is configured. Create a library directory with a .codecarto-library marker, then set library.path in ~/.codecarto/config.yaml or .codecarto/workflow/config.yaml.", "error");
                 return;
@@ -1228,15 +1261,21 @@ export default function codeCartographerExtension(pi) {
                     namespaced: !!namespace,
                     ...(namespace ? {} : {}),
                 });
-                // Write the config to the user-global location
+                // Write library.path (and library.namespace when given) to the
+                // user-global config and nothing else — not publish_confirm, so
+                // initializing a library does not change how publish behaves on
+                // MCP (#244). A config file that cannot be parsed is left alone;
+                // the error lands in the catch below.
                 const configPath = resolveUserConfigPath();
                 await writeLibraryConfig(configPath, libraryPath, namespace);
+                const written = namespace ? "library.path and library.namespace" : "library.path";
                 const msg = result.alreadyExisted
                     ? `Library already exists at ${libraryPath} (marker preserved). Config updated.`
                     : `Created library at ${libraryPath} with marker "${result.marker.name}".`;
-                lastFeedbackLines = [msg, `Config written to ${configPath}`];
+                const configLine = `Wrote ${written} to ${configPath}; other keys untouched`;
+                lastFeedbackLines = [msg, configLine];
                 notifyCtx(ctx, msg, "info");
-                notifyCtx(ctx, `Config written to ${configPath}`, "info");
+                notifyCtx(ctx, configLine, "info");
             }
             catch (error) {
                 const message = error instanceof Error ? error.message : String(error);
@@ -1263,10 +1302,18 @@ export default function codeCartographerExtension(pi) {
                 const marker = await discoverLibrary(config.library.path);
                 lines.push(`  Library marker: ${marker ? `found ("${marker.name}", namespaced: ${marker.namespaced})` : "MISSING — run /codecarto-library-init"}`);
             }
+            // A file that could not be used is the one thing this command exists
+            // to surface; /codecarto-publish refuses while any is listed (#242).
+            lines.push(...describeConfigProblems(config));
             lastFeedbackLines = lines;
             if (state)
                 setUiState(ctx, state, lastFeedbackLines);
-            notifyCtx(ctx, "Configuration shown in status widget.", "info");
+            if (config.problems.length > 0) {
+                notifyCtx(ctx, describeConfigProblems(config).join("\n"), "warning");
+            }
+            else {
+                notifyCtx(ctx, "Configuration shown in status widget.", "info");
+            }
         },
     });
     pi.registerCommand("codecarto-usage", {