codebyplan 1.5.1 → 1.8.0

package/templates/hooks/cbp-mcp-worktree-inject.sh

@@ -0,0 +1,76 @@
+#!/bin/bash
+# @scope: org-shared
+# Hook: PreToolUse mcp__codebyplan__(update_task|complete_task|complete_round|update_checkpoint)
+# Purpose: Auto-inject caller_worktree_id into MCP mutation calls when not already
+#          present. Uses the PreToolUse hookSpecificOutput.updatedInput contract
+#          (Claude Code v2.1 — see hooks.md "PreToolUse decision control"):
+#            - Output JSON with hookSpecificOutput.permissionDecision="allow" and
+#              hookSpecificOutput.updatedInput containing the full modified tool_input.
+#          This hook NEVER exits non-zero — it is a no-op on all failure paths.
+#
+# Fallback chain:
+#   1. caller_worktree_id already present in tool_input → passthrough (no-op)
+#   2. Primary: npx codebyplan resolve-worktree → UUID found → inject
+#   3. Secondary: npx codebyplan resolve-worktree --fallback-from-branch → UUID found → inject
+#   4. Both empty → passthrough (server pre-guard skips when absent)
+#
+# NEVER exit non-zero — backwards-compat passthrough when resolver is broken.
+
+INPUT=$(cat)
+
+TOOL_NAME=$(echo "$INPUT" | jq -r '.tool_name // empty' 2>/dev/null)
+
+# Only intercept matching MCP mutation tools
+case "$TOOL_NAME" in
+  mcp__codebyplan__update_task|\
+  mcp__codebyplan__complete_task|\
+  mcp__codebyplan__complete_round|\
+  mcp__codebyplan__update_checkpoint) ;;
+  *) exit 0 ;;
+esac
+
+# If caller_worktree_id is already present, pass through unchanged
+EXISTING=$(echo "$INPUT" | jq -r '.tool_input.caller_worktree_id // empty' 2>/dev/null)
+if [ -n "$EXISTING" ]; then
+  exit 0
+fi
+
+# Try primary resolver
+UUID=$(npx --yes codebyplan resolve-worktree 2>/dev/null)
+
+# Try fallback if primary returned empty
+if [ -z "$UUID" ]; then
+  UUID=$(npx --yes codebyplan resolve-worktree --fallback-from-branch 2>/dev/null)
+fi
+
+# If no UUID resolved, passthrough unchanged
+if [ -z "$UUID" ]; then
+  exit 0
+fi
+
+# Extract tool_input and guard against null before merging
+TOOL_INPUT=$(echo "$INPUT" | jq -c '.tool_input' 2>/dev/null)
+if [ -z "$TOOL_INPUT" ] || [ "$TOOL_INPUT" = "null" ]; then
+  # No tool_input to mutate — output original input unchanged
+  echo "$INPUT"
+  exit 0
+fi
+
+MERGED_TOOL_INPUT=$(echo "$TOOL_INPUT" | jq -c --arg uuid "$UUID" '. + {caller_worktree_id: $uuid}' 2>/dev/null)
+if [ -z "$MERGED_TOOL_INPUT" ] || [ "$MERGED_TOOL_INPUT" = "null" ]; then
+  echo "$INPUT"
+  exit 0
+fi
+
+# Output PreToolUse hookSpecificOutput with updatedInput
+jq -n \
+  --argjson updated "$MERGED_TOOL_INPUT" \
+  '{
+    hookSpecificOutput: {
+      hookEventName: "PreToolUse",
+      permissionDecision: "allow",
+      updatedInput: $updated
+    }
+  }'
+
+exit 0

package/templates/hooks/cbp-notify.sh

@@ -0,0 +1,68 @@
+#!/bin/bash
+# @hook: Notification
+# Hook: Notification for all matchers
+# Purpose: Send desktop notifications with project context. Cross-platform graceful-degrade —
+#          silent no-op when terminal-notifier is missing (Linux/Windows/macOS without Homebrew);
+#          VS Code click-to-focus action only on macOS hosts with `code` on PATH.
+# Exit 0 = always (notification hooks must never block Claude)
+#
+# Known: notification_type is not sent in JSON input (anthropics/claude-code#11964)
+# Input fields: session_id, cwd, hook_event_name, message
+
+set +e
+
+# Graceful skip on hosts without terminal-notifier (Linux, Windows, macOS w/o Homebrew)
+command -v terminal-notifier >/dev/null 2>&1 || exit 0
+
+# Read JSON input from stdin
+INPUT=$(cat)
+
+# Parse notification fields
+eval "$(echo "$INPUT" | jq -r '
+  @sh "MESSAGE=\(.message // "")",
+  @sh "CWD=\(.cwd // "")"
+' 2>/dev/null)"
+
+# Detect project name
+if [ -n "$CLAUDE_PROJECT_DIR" ]; then
+  PROJECT_DIR="$CLAUDE_PROJECT_DIR"
+elif [ -n "$CWD" ]; then
+  PROJECT_DIR="$CWD"
+else
+  PROJECT_DIR="unknown"
+fi
+PROJECT_NAME=$(basename "$PROJECT_DIR")
+
+TITLE="[$PROJECT_NAME] Claude Code"
+BODY="${MESSAGE:-Claude Code notification}"
+
+# VS Code focus click action — only on macOS with `code` available
+CLICK_ACTION=""
+if [[ "$OSTYPE" == darwin* ]] && command -v code >/dev/null 2>&1; then
+  # Quote path for re-parse by terminal-notifier -execute (POSIX sh)
+  SAFE_DIR=$(printf '%q' "$PROJECT_DIR")
+  CLICK_ACTION="code -r $SAFE_DIR && sleep 0.3 && osascript -e 'tell application \"System Events\" to keystroke \"\`\" using control down'"
+fi
+
+# Send notification via terminal-notifier in background (non-blocking).
+# Omit -execute argument entirely when CLICK_ACTION is empty (avoid passing empty string).
+if [ -n "$CLICK_ACTION" ]; then
+  terminal-notifier \
+    -title "$TITLE" \
+    -message "$BODY" \
+    -sound "Glass" \
+    -group "claude-${PROJECT_NAME}" \
+    -execute "$CLICK_ACTION" \
+    -sender "com.microsoft.VSCode" \
+    > /dev/null 2>&1 &
+else
+  terminal-notifier \
+    -title "$TITLE" \
+    -message "$BODY" \
+    -sound "Glass" \
+    -group "claude-${PROJECT_NAME}" \
+    -sender "com.microsoft.VSCode" \
+    > /dev/null 2>&1 &
+fi
+
+exit 0

package/templates/hooks/cbp-plugin-dispatch.sh

@@ -0,0 +1,29 @@
+#!/bin/bash
+# @scope: org-shared
+# Hook: universal plugin-script dispatcher
+# Purpose: Resolve a plugin-shipped hook/statusLine script path with auto-detect fallback.
+# Workaround: ${CLAUDE_PLUGIN_ROOT} is set in the plugin's own hook context but may not
+# resolve in the consuming repo's settings.json statusLine/hooks command context (Claude
+# Code v1.0 limitation). This shim prefers the env var when set; otherwise auto-detects
+# the latest installed plugin version under ~/.claude/plugins/cache/codebyplan-tools/codebyplan/*.
+# Called from settings.json: `bash .claude/hooks/plugin-dispatch.sh <hook-name>.sh [args...]`
+
+HOOK_NAME="$1"
+shift
+
+if [ -z "$HOOK_NAME" ]; then
+  echo "plugin-dispatch.sh: missing hook script name as \$1" >&2
+  exit 0  # graceful no-op (don't block Claude Code)
+fi
+
+PLUGIN_BASE="$HOME/.claude/plugins/cache/codebyplan-tools/codebyplan"
+
+TARGET=""
+if [ -n "${CLAUDE_PLUGIN_ROOT:-}" ] && [ -f "${CLAUDE_PLUGIN_ROOT}/hooks/$HOOK_NAME" ]; then
+  TARGET="${CLAUDE_PLUGIN_ROOT}/hooks/$HOOK_NAME"
+else
+  TARGET="$(ls -d "$PLUGIN_BASE"/*/hooks/"$HOOK_NAME" 2>/dev/null | sort -V | tail -1)"
+fi
+
+[ -n "$TARGET" ] && [ -f "$TARGET" ] && exec bash "$TARGET" "$@"
+exit 0

package/templates/hooks/cbp-pre-commit-quality-gate.sh

@@ -0,0 +1,204 @@
+#!/bin/bash
+# @hook: PreToolUse Bash
+# Hook: PreToolUse for Bash (git commit commands)
+# Purpose: Block git commits that violate greenfield-lint-zero-warnings,
+#          ship skip-only test files, or have TS compile errors in the
+#          staged files' owning packages.
+#
+# Gates:
+#   3. Greenfield ESLint configs (newly-added eslint.config.{mjs,js,cjs,ts})
+#      must produce zero warnings/errors when run against their package.
+#   4. Newly-added *.{test,spec}.{ts,tsx,js,jsx} files must contain at least
+#      one live (non-.skip / non-.todo) test declaration.
+#   5. (Opt-in via CBP_PRECOMMIT_TYPECHECK=1) Staged TS files typecheck in
+#      their owning package.
+#
+# Exit 0 = allow, Exit 2 = block (stderr sent to Claude)
+
+set -e
+
+echo "[HOOK START] pre-commit-quality-gate"
+
+# Read JSON input from stdin
+INPUT=$(cat)
+
+# Extract command from tool input
+COMMAND=$(echo "$INPUT" | jq -r '.tool_input.command // empty')
+
+if [ -z "$COMMAND" ]; then
+  echo "[HOOK END] pre-commit-quality-gate (no command)"
+  exit 0
+fi
+
+# Only check git commit commands
+if ! echo "$COMMAND" | grep -qE 'git\s+commit'; then
+  echo "[HOOK END] pre-commit-quality-gate (not git commit)"
+  exit 0
+fi
+
+REPO_ROOT=$(git rev-parse --show-toplevel 2>/dev/null || echo "")
+if [ -z "$REPO_ROOT" ]; then
+  echo "[HOOK END] pre-commit-quality-gate (not a git repo)"
+  exit 0
+fi
+
+STAGED_ADDED=$(git diff --cached --name-only --diff-filter=A 2>/dev/null || true)
+STAGED_ALL=$(git diff --cached --name-only --diff-filter=AM 2>/dev/null || true)
+
+BLOCKED=0
+REASONS=""
+
+# ── Helper: walk up from a file to its owning package.json dir ───────────
+find_pkg_dir() {
+  local start_dir="$1"
+  local dir="$start_dir"
+  while [ "$dir" != "$REPO_ROOT" ] && [ "$dir" != "/" ] && [ -n "$dir" ]; do
+    if [ -f "$dir/package.json" ]; then
+      echo "$dir"
+      return 0
+    fi
+    dir="$(dirname "$dir")"
+  done
+  if [ -f "$REPO_ROOT/package.json" ]; then
+    echo "$REPO_ROOT"
+    return 0
+  fi
+  echo ""
+}
+
+# ── Gate 3: Greenfield ESLint configs ship with zero warnings ────────────
+GREENFIELD_CONFIGS=$(echo "$STAGED_ADDED" | grep -E 'eslint\.config\.(mjs|js|cjs|ts)$' || true)
+
+if [ -n "$GREENFIELD_CONFIGS" ]; then
+  while IFS= read -r CFG; do
+    [ -z "$CFG" ] && continue
+    PKG_DIR=$(find_pkg_dir "$REPO_ROOT/$(dirname "$CFG")")
+    [ -z "$PKG_DIR" ] && continue
+
+    ESLINT_BIN=""
+    if [ -x "$PKG_DIR/node_modules/.bin/eslint" ]; then
+      ESLINT_BIN="$PKG_DIR/node_modules/.bin/eslint"
+    elif [ -x "$REPO_ROOT/node_modules/.bin/eslint" ]; then
+      ESLINT_BIN="$REPO_ROOT/node_modules/.bin/eslint"
+    fi
+
+    if [ -z "$ESLINT_BIN" ]; then
+      continue  # eslint binary missing, can't enforce — silent skip
+    fi
+
+    LINT_OUTPUT=$(cd "$PKG_DIR" && "$ESLINT_BIN" --no-error-on-unmatched-pattern . 2>&1) || LINT_FAILED=1
+
+    if [ -n "${LINT_FAILED:-}" ] || echo "$LINT_OUTPUT" | grep -qE '(warning|error)'; then
+      BLOCKED=1
+      REASONS="${REASONS}
+GATE 3 (greenfield-lint-zero-warnings) FAILED for ${CFG}:
+  Package: ${PKG_DIR#$REPO_ROOT/}
+  Reproduce: (cd ${PKG_DIR#$REPO_ROOT/} && ./node_modules/.bin/eslint .)
+  New eslint configs must ship with zero warnings.
+"
+    fi
+    unset LINT_FAILED
+  done <<< "$GREENFIELD_CONFIGS"
+fi
+
+# ── Gate 4: Skip-only test files ─────────────────────────────────────────
+TEST_FILES=$(echo "$STAGED_ADDED" | grep -E '\.(test|spec)\.(ts|tsx|js|jsx)$' || true)
+
+if [ -n "$TEST_FILES" ]; then
+  while IFS= read -r TF; do
+    [ -z "$TF" ] && continue
+    [ ! -f "$REPO_ROOT/$TF" ] && continue
+
+    # Count live test declarations (not .skip, not .todo)
+    # Patterns: describe(, it(, test(  — must NOT be preceded by .skip or .todo
+    # Note: `grep -c` already prints 0 on no match (with exit 1); do NOT add
+    #       `|| echo 0` — that concatenates a second 0 and breaks the -le comparison.
+    LIVE=$(grep -cE '(^|[^.])\b(describe|it|test)\s*\(' "$REPO_ROOT/$TF" 2>/dev/null) || LIVE=0
+    SKIP=$(grep -cE '\b(describe|it|test)\.(skip|todo)\s*\(' "$REPO_ROOT/$TF" 2>/dev/null) || SKIP=0
+
+    # If the file has only skip/todo declarations and no live tests, block
+    if [ "$LIVE" -le "$SKIP" ] && [ "$SKIP" -gt 0 ]; then
+      BLOCKED=1
+      REASONS="${REASONS}
+GATE 4 (skip-only-test-file) FAILED for ${TF}:
+  File contains ${SKIP} skip/todo declarations and no live tests.
+  A new test file that only contains .skip() or .todo() exercises nothing
+  but satisfies test-coverage-gate.sh — remove .skip()/.todo() or remove the file.
+"
+    fi
+  done <<< "$TEST_FILES"
+fi
+
+# ── Gate 5: TS-compile best-effort (opt-in via CBP_PRECOMMIT_TYPECHECK=1) ─
+# Typecheck can take 30–60s on large packages; opt-in keeps the common-case
+# commit path fast. Enable in CI or before shipping via:  export CBP_PRECOMMIT_TYPECHECK=1
+if [ "${CBP_PRECOMMIT_TYPECHECK:-0}" = "1" ]; then
+  TS_FILES=$(echo "$STAGED_ALL" | grep -E '\.(ts|tsx)$' \
+    | grep -vE '(^|/)(node_modules|dist|build|\.next|\.turbo|coverage)/' || true)
+
+  if [ -n "$TS_FILES" ]; then
+    # Group by owning package — uses newline-separated list + sort -u for bash 3.2 (macOS) compatibility
+    PKG_LIST=""
+    while IFS= read -r F; do
+      [ -z "$F" ] && continue
+      PKG_DIR=$(find_pkg_dir "$REPO_ROOT/$(dirname "$F")")
+      [ -z "$PKG_DIR" ] && continue
+      PKG_LIST="${PKG_LIST}${PKG_DIR}
+"
+    done <<< "$TS_FILES"
+
+    UNIQUE_PKGS=$(printf "%s" "$PKG_LIST" | sort -u | grep -v '^$' || true)
+
+    while IFS= read -r PKG_DIR; do
+      [ -z "$PKG_DIR" ] && continue
+      TSC_BIN=""
+      if [ -x "$PKG_DIR/node_modules/.bin/tsc" ]; then
+        TSC_BIN="$PKG_DIR/node_modules/.bin/tsc"
+      elif [ -x "$REPO_ROOT/node_modules/.bin/tsc" ]; then
+        TSC_BIN="$REPO_ROOT/node_modules/.bin/tsc"
+      fi
+      [ -z "$TSC_BIN" ] && continue
+      [ -f "$PKG_DIR/tsconfig.json" ] || continue
+
+      TSC_OUTPUT=$(cd "$PKG_DIR" && "$TSC_BIN" --noEmit -p "$PKG_DIR/tsconfig.json" 2>&1) || TSC_FAILED=1
+
+      if [ -n "${TSC_FAILED:-}" ]; then
+        BLOCKED=1
+        TSC_TRUNC=$(echo "$TSC_OUTPUT" | head -30)
+        REASONS="${REASONS}
+GATE 5 (ts-compile) FAILED for package ${PKG_DIR#$REPO_ROOT/}:
+  Reproduce: (cd ${PKG_DIR#$REPO_ROOT/} && ./node_modules/.bin/tsc --noEmit)
+  First errors:
+${TSC_TRUNC}
+"
+      fi
+      unset TSC_FAILED
+    done <<< "$UNIQUE_PKGS"
+  fi
+fi
+
+# ── Gate 6: .claude/ / templates/ sibling identity ───────────────────────
+SIBLING_CHECK_SCRIPT="$REPO_ROOT/scripts/check-sibling-identity.mjs"
+if [ -f "$SIBLING_CHECK_SCRIPT" ]; then
+  SIBLING_OUTPUT=$(cd "$REPO_ROOT" && node "$SIBLING_CHECK_SCRIPT" 2>&1) || SIBLING_FAILED=1
+  if [ -n "${SIBLING_FAILED:-}" ]; then
+    BLOCKED=1
+    REASONS="${REASONS}
+GATE 6 (sibling-identity) FAILED:
+${SIBLING_OUTPUT}
+"
+  fi
+  unset SIBLING_FAILED
+fi
+
+# ── Report ───────────────────────────────────────────────────────────────
+if [ "$BLOCKED" -eq 1 ]; then
+  echo "" >&2
+  echo "PRE-COMMIT QUALITY GATE: Cannot commit — one or more gates failed:" >&2
+  echo -e "$REASONS" >&2
+  echo "[HOOK END] pre-commit-quality-gate (BLOCKED)" >&2
+  exit 2
+fi
+
+echo "[HOOK END] pre-commit-quality-gate (all gates passed)"
+exit 0