codebuff 1.0.680 → 1.0.682

package/index.js

@@ -74,6 +74,14 @@ function shouldExitAlternateScreen(code, signal) {
   return Boolean(signal) || isWindowsNativeCrashCode(code)
 }
 
+function isIllegalInstructionExit(code, signal) {
+  const unsignedCode = getUnsignedExitCode(code)
+  return (
+    signal === 'SIGILL' ||
+    (process.platform === 'win32' && unsignedCode === 0xC000001D)
+  )
+}
+
 function createConfig(packageName) {
   const homeDir = os.homedir()
   const configDir = path.join(homeDir, '.config', 'manicode')
@@ -164,10 +172,17 @@ function trackUpdateFailed(errorMessage, version, context = {}) {
 
 const PLATFORM_TARGETS = {
   'linux-x64': `${packageName}-linux-x64.tar.gz`,
+  'linux-x64-baseline': `${packageName}-linux-x64-baseline.tar.gz`,
   'linux-arm64': `${packageName}-linux-arm64.tar.gz`,
   'darwin-x64': `${packageName}-darwin-x64.tar.gz`,
   'darwin-arm64': `${packageName}-darwin-arm64.tar.gz`,
   'win32-x64': `${packageName}-win32-x64.tar.gz`,
+  'win32-x64-baseline': `${packageName}-win32-x64-baseline.tar.gz`,
+}
+
+const BASELINE_FALLBACK_TARGETS = {
+  'linux-x64': 'linux-x64-baseline',
+  'win32-x64': 'win32-x64-baseline',
 }
 
 const term = {
@@ -186,6 +201,84 @@ const term = {
   },
 }
 
+function getPlatformKey() {
+  return `${process.platform}-${process.arch}`
+}
+
+function getTargetOverride() {
+  const envNames = [
+    `${packageName.toUpperCase()}_BINARY_TARGET`,
+    'CODEBUFF_BINARY_TARGET',
+    'CLI_BINARY_TARGET',
+  ]
+
+  for (const envName of envNames) {
+    const target = process.env[envName]
+    if (target && PLATFORM_TARGETS[target]) {
+      return target
+    }
+  }
+
+  return null
+}
+
+function linuxCpuHasAvx2() {
+  if (process.platform !== 'linux' || process.arch !== 'x64') {
+    return true
+  }
+
+  try {
+    return /\bavx2\b/i.test(fs.readFileSync('/proc/cpuinfo', 'utf8'))
+  } catch {
+    return true
+  }
+}
+
+function getDefaultTargetKey() {
+  const override = getTargetOverride()
+  if (override) {
+    return override
+  }
+
+  const platformKey = getPlatformKey()
+  if (platformKey === 'linux-x64' && !linuxCpuHasAvx2()) {
+    return 'linux-x64-baseline'
+  }
+
+  return platformKey
+}
+
+function getBaselineFallbackTargetKey() {
+  // Windows has no reliable plain-Node CPU feature check here, so we keep
+  // the fast x64 binary first and fall back after the native SIGILL code.
+  return BASELINE_FALLBACK_TARGETS[getPlatformKey()] || null
+}
+
+function isTargetAllowedForThisMachine(target) {
+  const override = getTargetOverride()
+  if (override) {
+    return target === override
+  }
+  return (
+    target === getDefaultTargetKey() ||
+    target === getBaselineFallbackTargetKey()
+  )
+}
+
+function getDownloadTargetKey() {
+  const override = getTargetOverride()
+  if (override) {
+    return override
+  }
+
+  const metadata = getCurrentMetadata()
+  if (metadata?.target && isTargetAllowedForThisMachine(metadata.target)) {
+    return metadata.target
+  }
+
+  return getDefaultTargetKey()
+}
+
 async function getLatestVersion() {
   try {
     const res = await httpGet(
@@ -214,20 +307,35 @@ function streamToString(stream) {
 
 function getCurrentVersion() {
   try {
-    if (!fs.existsSync(CONFIG.metadataPath)) {
+    const metadata = getCurrentMetadata()
+    if (!metadata) {
       return null
     }
-    const metadata = JSON.parse(fs.readFileSync(CONFIG.metadataPath, 'utf8'))
     // Also verify the binary still exists
     if (!fs.existsSync(CONFIG.binaryPath)) {
       return null
     }
+    const metadataTarget = metadata.target || getPlatformKey()
+    if (!isTargetAllowedForThisMachine(metadataTarget)) {
+      return null
+    }
     return metadata.version || null
   } catch (error) {
     return null
   }
 }
 
+function getCurrentMetadata() {
+  try {
+    if (!fs.existsSync(CONFIG.metadataPath)) {
+      return null
+    }
+    return JSON.parse(fs.readFileSync(CONFIG.metadataPath, 'utf8'))
+  } catch {
+    return null
+  }
+}
+
 function compareVersions(v1, v2) {
   if (!v1 || !v2) return 0
 
@@ -306,13 +414,12 @@ function createProgressBar(percentage, width = 30) {
   return '[' + '█'.repeat(filled) + '░'.repeat(empty) + ']'
 }
 
-async function downloadBinary(version) {
-  const platformKey = `${process.platform}-${process.arch}`
-  const fileName = PLATFORM_TARGETS[platformKey]
+async function downloadBinary(version, targetKey = getDownloadTargetKey()) {
+  const fileName = PLATFORM_TARGETS[targetKey]
 
   if (!fileName) {
     const error = new Error(`Unsupported platform: ${process.platform} ${process.arch}`)
-    trackUpdateFailed(error.message, version, { stage: 'platform_check' })
+    trackUpdateFailed(error.message, version, { stage: 'platform_check', target: targetKey })
     throw error
   }
 
@@ -336,7 +443,7 @@ async function downloadBinary(version) {
   if (res.statusCode !== 200) {
     fs.rmSync(CONFIG.tempDownloadDir, { recursive: true })
     const error = new Error(`Download failed: HTTP ${res.statusCode}`)
-    trackUpdateFailed(error.message, version, { stage: 'http_download', statusCode: res.statusCode })
+    trackUpdateFailed(error.message, version, { stage: 'http_download', statusCode: res.statusCode, target: targetKey })
     throw error
   }
 
@@ -380,7 +487,7 @@ async function downloadBinary(version) {
     const error = new Error(
       `Binary not found after extraction. Expected: ${CONFIG.binaryName}, Available files: ${files.join(', ')}`,
     )
-    trackUpdateFailed(error.message, version, { stage: 'extraction' })
+    trackUpdateFailed(error.message, version, { stage: 'extraction', target: targetKey })
     throw error
   }
 
@@ -434,7 +541,7 @@ async function downloadBinary(version) {
     // Save version metadata for fast version checking
     fs.writeFileSync(
       CONFIG.metadataPath,
-      JSON.stringify({ version }, null, 2),
+      JSON.stringify({ version, target: targetKey }, null, 2),
     )
   } finally {
     // Clean up temp directory even if rename fails
@@ -518,14 +625,7 @@ async function checkForUpdates(runningProcess, exitListener) {
       await downloadBinary(latestVersion)
 
       const newChild = spawnInstalledBinary({ detached: false })
-
-      newChild.on('exit', (code, signal) => {
-        resetTerminal({
-          exitAlternateScreen: shouldExitAlternateScreen(code, signal),
-        })
-        printCrashDiagnostics(code, signal)
-        process.exit(signal ? 1 : (code || 0))
-      })
+      attachExitHandler(newChild)
 
       return new Promise(() => {})
     }
@@ -537,9 +637,7 @@ async function checkForUpdates(runningProcess, exitListener) {
 function printCrashDiagnostics(code, signal) {
   // Windows NTSTATUS codes (unsigned DWORD)
   const unsignedCode = getUnsignedExitCode(code)
-  const isIllegalInstruction =
-    signal === 'SIGILL' ||
-    (process.platform === 'win32' && unsignedCode === 0xC000001D)
+  const isIllegalInstruction = isIllegalInstructionExit(code, signal)
   const isAccessViolation =
     signal === 'SIGSEGV' ||
     (process.platform === 'win32' && unsignedCode === 0xC0000005)
@@ -620,6 +718,11 @@ function printSpawnFailure(err) {
   console.error('')
 }
 
+function exitOnSpawnFailure(err) {
+  printSpawnFailure(err)
+  process.exit(1)
+}
+
 function spawnInstalledBinary(options = {}) {
   if (!fs.existsSync(CONFIG.binaryPath)) {
     try {
@@ -631,29 +734,79 @@ function spawnInstalledBinary(options = {}) {
       `downloaded binary is missing at ${CONFIG.binaryPath}`,
     )
     error.code = 'BINARY_MISSING'
-    printSpawnFailure(error)
-    process.exit(1)
+    exitOnSpawnFailure(error)
   }
 
-  const child = spawn(CONFIG.binaryPath, process.argv.slice(2), {
-    stdio: 'inherit',
-    ...options,
-  })
+  // spawn() only emits 'error' asynchronously for a few errno values
+  // (EACCES, EAGAIN, EMFILE, ENFILE, ENOENT); everything else — notably
+  // UNKNOWN on Windows when antivirus or Smart App Control blocks the
+  // exe or the download is corrupt — is thrown synchronously.
+  let child
+  try {
+    child = spawn(CONFIG.binaryPath, process.argv.slice(2), {
+      stdio: 'inherit',
+      ...options,
+    })
+  } catch (err) {
+    exitOnSpawnFailure(err)
+  }
 
-  child.on('error', (err) => {
-    printSpawnFailure(err)
-    process.exit(1)
-  })
+  child.on('error', exitOnSpawnFailure)
 
   return child
 }
 
-async function main() {
-  await ensureBinaryExists()
+async function tryFallbackToBaseline(code, signal) {
+  if (!isIllegalInstructionExit(code, signal)) {
+    return false
+  }
 
-  const child = spawnInstalledBinary()
+  const fallbackTarget = getBaselineFallbackTargetKey()
+  if (!fallbackTarget) {
+    return false
+  }
+
+  const metadata = getCurrentMetadata()
+  const currentTarget = metadata?.target || getDefaultTargetKey()
+  if (currentTarget === fallbackTarget) {
+    return false
+  }
+
+  const version = metadata?.version || (await getLatestVersion())
+  if (!version) {
+    return false
+  }
+
+  resetTerminal({
+    exitAlternateScreen: shouldExitAlternateScreen(code, signal),
+  })
+  console.error('')
+  console.error(
+    `${packageName} is switching to the older-CPU binary for this machine.`,
+  )
+
+  try {
+    await downloadBinary(version, fallbackTarget)
+  } catch (error) {
+    term.clearLine()
+    console.error(`Failed to download ${fallbackTarget}: ${error.message}`)
+    return false
+  }
+
+  const child = spawnInstalledBinary({ detached: false })
+  attachExitHandler(child, false)
+  return true
+}
+
+function attachExitHandler(child, allowBaselineFallback = true) {
+  const exitListener = async (code, signal) => {
+    if (
+      allowBaselineFallback &&
+      (await tryFallbackToBaseline(code, signal))
+    ) {
+      return
+    }
 
-  const exitListener = (code, signal) => {
     resetTerminal({
       exitAlternateScreen: shouldExitAlternateScreen(code, signal),
     })
@@ -662,6 +815,14 @@ async function main() {
   }
 
   child.on('exit', exitListener)
+  return exitListener
+}
+
+async function main() {
+  await ensureBinaryExists()
+
+  const child = spawnInstalledBinary()
+  const exitListener = attachExitHandler(child)
 
   setTimeout(() => {
     checkForUpdates(child, exitListener)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "codebuff",
-  "version": "1.0.680",
+  "version": "1.0.682",
   "description": "AI coding agent",
   "license": "MIT",
   "bin": {