codebuff-cli 1.0.11 → 1.0.14

package/cli/scripts/download-binary.cjs

@@ -3,33 +3,57 @@ const fs = require('fs');
 const path = require('path');
 const https = require('https');
 const http = require('http');
-const os = require('os');
 
 const REPO = 'Marcus-Mok-GH/codebuff-cli';
 const BINARY_NAME = 'codebuff';
+const MAX_RETRIES = 3;
+const REQUEST_TIMEOUT_MS = 120000;
+const MAX_REDIRECTS = 10;
 
 function getVersion() {
-  const candidates = [
-    path.join(__dirname, '..', '..', 'package.json'),
-    path.join(__dirname, '..', 'package.json'),
-  ];
-  for (const p of candidates) {
-    try {
-      const pkg = JSON.parse(fs.readFileSync(p, 'utf8'));
-      if (pkg.version) return pkg.version;
-    } catch {}
-  }
-  return '1.0.9';
+  const pkgPath = path.join(__dirname, '..', 'package.json');
+  try {
+    const pkg = JSON.parse(fs.readFileSync(pkgPath, 'utf8'));
+    if (pkg.version) return pkg.version;
+  } catch {}
+  throw new Error('Could not determine version from ' + pkgPath);
+}
+
+function getPlatform() {
+  const platform = process.platform;
+  const arch = process.arch;
+  const mappings = {
+    darwin: 'darwin',
+    linux: 'linux',
+    win32: 'win32',
+  };
+  const osName = mappings[platform] || platform;
+  return osName + '-' + arch;
 }
 
 function getBinaryPath() {
-  const binDir = path.join(os.homedir(), '.codebuff', 'bin');
-  const name = process.platform === 'win32' ? `${BINARY_NAME}.exe` : BINARY_NAME;
+  const binDir = path.join(__dirname, '..', 'bin');
+  const name = process.platform === 'win32' ? BINARY_NAME + '.exe' : BINARY_NAME;
   return path.join(binDir, name);
 }
 
-function download(url, dest) {
+function cleanup(dest) {
+  try {
+    if (fs.existsSync(dest)) {
+      fs.unlinkSync(dest);
+    }
+  } catch {
+    // ignore cleanup errors
+  }
+}
+
+function download(url, dest, redirectCount = 0) {
   return new Promise((resolve, reject) => {
+    if (redirectCount > MAX_REDIRECTS) {
+      reject(new Error('Too many redirects (max ' + MAX_REDIRECTS + ') while downloading from ' + url));
+      return;
+    }
+
     const client = url.startsWith('https:') ? https : http;
     const file = fs.createWriteStream(dest);
 
@@ -37,10 +61,10 @@ function download(url, dest) {
       url,
       { headers: { 'User-Agent': 'codebuff-cli-installer' } },
       (res) => {
-        if (res.statusCode === 301 || res.statusCode === 302) {
+        if (res.statusCode === 301 || res.statusCode === 302 || res.statusCode === 307 || res.statusCode === 308) {
           file.close();
-          if (fs.existsSync(dest)) fs.unlinkSync(dest);
-          download(new URL(res.headers.location, url).href, dest)
+          cleanup(dest);
+          download(new URL(res.headers.location, url).href, dest, redirectCount + 1)
             .then(resolve)
             .catch(reject);
           return;
@@ -48,8 +72,8 @@ function download(url, dest) {
 
         if (res.statusCode !== 200) {
           file.close();
-          if (fs.existsSync(dest)) fs.unlinkSync(dest);
-          reject(new Error(`HTTP ${res.statusCode}`));
+          cleanup(dest);
+          reject(new Error('Download failed: HTTP ' + res.statusCode + ' from ' + url));
           return;
         }
 
@@ -63,67 +87,78 @@ function download(url, dest) {
 
     req.on('error', (err) => {
       file.close();
-      if (fs.existsSync(dest)) fs.unlinkSync(dest);
-      reject(err);
+      cleanup(dest);
+      reject(new Error('Network error downloading from ' + url + ': ' + err.message));
     });
 
-    req.setTimeout(30000, () => {
+    req.setTimeout(REQUEST_TIMEOUT_MS, () => {
       req.destroy();
       file.close();
-      if (fs.existsSync(dest)) fs.unlinkSync(dest);
-      reject(new Error('Request timeout'));
+      cleanup(dest);
+      reject(new Error('Download timeout (' + REQUEST_TIMEOUT_MS + 'ms) for ' + url));
     });
   });
 }
 
-async function tryDownload(url, dest) {
-  try {
-    await download(url, dest);
-    return true;
-  } catch {
-    return false;
+async function downloadWithRetry(url, dest) {
+  let lastError;
+  for (let attempt = 1; attempt <= MAX_RETRIES; attempt++) {
+    try {
+      console.log('Downloading binary (attempt ' + attempt + '/' + MAX_RETRIES + ')...');
+      await download(url, dest);
+      return true;
+    } catch (err) {
+      lastError = err;
+      console.error('Attempt ' + attempt + ' failed: ' + err.message);
+      if (attempt < MAX_RETRIES) {
+        const delay = Math.pow(2, attempt) * 1000;
+        console.log('Retrying in ' + delay + 'ms...');
+        await new Promise((resolve) => setTimeout(resolve, delay));
+      }
+    }
   }
+  console.error('Failed to download binary after ' + MAX_RETRIES + ' attempts.');
+  console.error('Last error: ' + lastError.message);
+  return false;
 }
 
 async function main() {
+  const version = getVersion();
+  const platform = getPlatform();
   const binaryPath = getBinaryPath();
 
-  if (fs.existsSync(binaryPath)) {
-    console.log('Binary already exists at', binaryPath);
-    return;
-  }
-
-  const version = getVersion();
-  const baseUrl = `https://github.com/${REPO}/releases/download/v${version}`;
+  const url = 'https://github.com/' + REPO + '/releases/download/v' + version + '/codebuff-' + platform;
 
-  // Try platform-specific binary first
-  const platformName = `${BINARY_NAME}-${process.platform}-${process.arch}${
-    process.platform === 'win32' ? '.exe' : ''
-  }`;
-  const platformUrl = `${baseUrl}/${platformName}`;
-  const genericUrl = `${baseUrl}/${BINARY_NAME}`;
+  console.log('Platform: ' + platform);
+  console.log('Version: ' + version);
+  console.log('Binary path: ' + binaryPath);
+  console.log('Download URL: ' + url);
 
   fs.mkdirSync(path.dirname(binaryPath), { recursive: true });
 
-  if (await tryDownload(platformUrl, binaryPath)) {
-    console.log(`Downloaded platform-specific binary: ${platformName}`);
-  } else if (await tryDownload(genericUrl, binaryPath)) {
-    console.log(`Downloaded generic binary: ${BINARY_NAME}`);
+  if (fs.existsSync(binaryPath)) {
+    console.log('Binary already exists. Skipping download.');
+    process.exit(0);
+  }
+
+  if (await downloadWithRetry(url, binaryPath)) {
+    console.log('Download complete.');
   } else {
-    console.error(
-      `Failed to download binary from:\n  ${platformUrl}\n  ${genericUrl}`
-    );
+    console.error('\nUnable to download the codebuff binary.');
+    console.error('You can try installing manually from:');
+    console.error('  ' + url);
     process.exit(1);
   }
 
   if (process.platform !== 'win32') {
     fs.chmodSync(binaryPath, 0o755);
+    console.log('Made binary executable.');
   }
 
-  console.log(`Binary installed at: ${binaryPath}`);
+  console.log('Binary installed at: ' + binaryPath);
 }
 
 main().catch((err) => {
-  console.error('Error:', err.message);
+  console.error('Fatal error:', err.message);
   process.exit(1);
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "codebuff-cli",
-  "version": "1.0.11",
+  "version": "1.0.14",
   "license": "Apache-2.0",
   "bin": {
     "codebuff": "cli/bin/codebuff.cjs",