code-abyss 1.7.0 → 1.7.2

package/skills/tools/verify-quality/scripts/quality_checker.js

@@ -3,6 +3,7 @@
 
 const fs = require('fs');
 const path = require('path');
+const { parseCliArgs, buildReport, hasFatal } = require(path.join(__dirname, '..', '..', 'lib', 'shared.js'));
 
 // 质量规则配置
 const MAX_LINE_LENGTH = 120;
@@ -15,44 +16,79 @@ const MIN_FUNCTION_NAME_LENGTH = 2;
 const EXCLUDE_DIRS = new Set(['.git', 'node_modules', '__pycache__', '.venv', 'venv', 'dist', 'build', '.tox']);
 const CODE_EXTENSIONS = new Set(['.py', '.js', '.ts', '.go', '.java', '.rs', '.c', '.cpp']);
 
-const COMMENT_PREFIXES = { '.js': '//', '.ts': '//', '.go': '//', '.java': '//', '.c': '//', '.cpp': '//', '.rs': '//' };
+const COMMENT_PREFIXES = {
+  '.js': '//', '.ts': '//', '.go': '//', '.java': '//',
+  '.c': '//', '.cpp': '//', '.rs': '//',
+};
 
 // --- Analysis ---
 
 function analyzeGenericFile(filePath) {
-  const metrics = { path: filePath, lines: 0, code_lines: 0, comment_lines: 0, blank_lines: 0, functions: 0, classes: 0, max_complexity: 0, avg_function_length: 0 };
+  const metrics = {
+    path: filePath, lines: 0, code_lines: 0, comment_lines: 0,
+    blank_lines: 0, functions: 0, classes: 0,
+    max_complexity: 0, avg_function_length: 0,
+  };
   const issues = [];
   let content;
-  try { content = fs.readFileSync(filePath, 'utf-8'); } catch { return { metrics, issues }; }
+  try {
+    content = fs.readFileSync(filePath, 'utf-8');
+  } catch { return { metrics, issues }; }
 
   const lines = content.split('\n');
   metrics.lines = lines.length;
-  const prefix = COMMENT_PREFIXES[path.extname(filePath).toLowerCase()] || '//';
+  const prefix = COMMENT_PREFIXES[
+    path.extname(filePath).toLowerCase()
+  ] || '//';
 
   for (let i = 0; i < lines.length; i++) {
     const stripped = lines[i].trim();
     if (!stripped) metrics.blank_lines++;
-    else if (stripped.startsWith(prefix) || stripped.startsWith('/*') || stripped.startsWith('*')) metrics.comment_lines++;
+    else if (
+      stripped.startsWith(prefix) ||
+      stripped.startsWith('/*') ||
+      stripped.startsWith('*')
+    ) metrics.comment_lines++;
     else metrics.code_lines++;
 
     if (lines[i].length > MAX_LINE_LENGTH) {
-      issues.push({ severity: 'info', category: '格式', message: `行过长 (${lines[i].length} > ${MAX_LINE_LENGTH})`, file_path: filePath, line_number: i + 1, suggestion: null });
+      issues.push({
+        severity: 'info', category: '格式',
+        message: `行过长 (${lines[i].length} > ${MAX_LINE_LENGTH})`,
+        file_path: filePath, line_number: i + 1,
+        suggestion: null,
+      });
     }
   }
 
   if (metrics.code_lines > MAX_FILE_LENGTH) {
-    issues.push({ severity: 'warning', category: '复杂度', message: `文件过长 (${metrics.code_lines} 行代码 > ${MAX_FILE_LENGTH})`, file_path: filePath, suggestion: '考虑拆分为多个模块', line_number: null });
+    issues.push({
+      severity: 'warning', category: '复杂度',
+      message: `文件过长 (${metrics.code_lines} 行代码 > ${MAX_FILE_LENGTH})`,
+      file_path: filePath, suggestion: '考虑拆分为多个模块',
+      line_number: null,
+    });
   }
 
   return { metrics, issues };
 }
 
 function analyzePythonFile(filePath) {
-  const metrics = { path: filePath, lines: 0, code_lines: 0, comment_lines: 0, blank_lines: 0, functions: 0, classes: 0, max_complexity: 0, avg_function_length: 0 };
+  const metrics = {
+    path: filePath, lines: 0, code_lines: 0, comment_lines: 0,
+    blank_lines: 0, functions: 0, classes: 0,
+    max_complexity: 0, avg_function_length: 0,
+  };
   const issues = [];
   let content;
-  try { content = fs.readFileSync(filePath, 'utf-8'); } catch (e) {
-    issues.push({ severity: 'error', category: '文件', message: `无法读取文件: ${e.message}`, file_path: filePath, line_number: null, suggestion: null });
+  try {
+    content = fs.readFileSync(filePath, 'utf-8');
+  } catch (e) {
+    issues.push({
+      severity: 'error', category: '文件',
+      message: `无法读取文件: ${e.message}`,
+      file_path: filePath, line_number: null, suggestion: null,
+    });
     return { metrics, issues };
   }
 
@@ -73,12 +109,22 @@ function analyzePythonFile(filePath) {
     else { metrics.code_lines++; }
 
     if (lines[i].length > MAX_LINE_LENGTH) {
-      issues.push({ severity: 'info', category: '格式', message: `行过长 (${lines[i].length} > ${MAX_LINE_LENGTH})`, file_path: filePath, line_number: i + 1, suggestion: null });
+      issues.push({
+        severity: 'info', category: '格式',
+        message: `行过长 (${lines[i].length} > ${MAX_LINE_LENGTH})`,
+        file_path: filePath, line_number: i + 1,
+        suggestion: null,
+      });
     }
   }
 
   if (metrics.code_lines > MAX_FILE_LENGTH) {
-    issues.push({ severity: 'warning', category: '复杂度', message: `文件过长 (${metrics.code_lines} 行代码 > ${MAX_FILE_LENGTH})`, file_path: filePath, suggestion: '考虑拆分为多个模块', line_number: null });
+    issues.push({
+      severity: 'warning', category: '复杂度',
+      message: `文件过长 (${metrics.code_lines} 行代码 > ${MAX_FILE_LENGTH})`,
+      file_path: filePath, suggestion: '考虑拆分为多个模块',
+      line_number: null,
+    });
   }
 
   // Regex-based Python analysis (no AST available in Node)
@@ -91,7 +137,10 @@ function analyzePythonFile(filePath) {
     const lineNum = content.substring(0, match.index).split('\n').length;
     const name = match[2];
     const indent = match[1].length;
-    const params = match[3].trim() ? match[3].split(',').map(p => p.trim()).filter(p => p && p !== 'self' && p !== 'cls') : [];
+    const params = match[3].trim()
+      ? match[3].split(',').map(p => p.trim())
+        .filter(p => p && p !== 'self' && p !== 'cls')
+      : [];
 
     // Calculate function length by finding next line at same or lesser indent
     const funcLines = lines.slice(lineNum); // lines after def
@@ -120,25 +169,53 @@ function analyzePythonFile(filePath) {
 
     // Check function length
     if (length > MAX_FUNCTION_LENGTH) {
-      issues.push({ severity: 'warning', category: '复杂度', message: `函数 '${name}' 过长 (${length} 行 > ${MAX_FUNCTION_LENGTH})`, file_path: filePath, line_number: lineNum, suggestion: '考虑拆分为多个小函数' });
+      issues.push({
+        severity: 'warning', category: '复杂度',
+        message: `函数 '${name}' 过长 (${length} 行 > ${MAX_FUNCTION_LENGTH})`,
+        file_path: filePath, line_number: lineNum,
+        suggestion: '考虑拆分为多个小函数',
+      });
     }
     // Check complexity
     if (complexity > MAX_COMPLEXITY) {
-      issues.push({ severity: 'warning', category: '复杂度', message: `函数 '${name}' 圈复杂度过高 (${complexity} > ${MAX_COMPLEXITY})`, file_path: filePath, line_number: lineNum, suggestion: '减少嵌套层级，提取子函数' });
+      issues.push({
+        severity: 'warning', category: '复杂度',
+        message: `函数 '${name}' 圈复杂度过高 (${complexity} > ${MAX_COMPLEXITY})`,
+        file_path: filePath, line_number: lineNum,
+        suggestion: '减少嵌套层级，提取子函数',
+      });
     }
     // Check parameter count
     if (params.length > MAX_PARAMETERS) {
-      issues.push({ severity: 'warning', category: '设计', message: `函数 '${name}' 参数过多 (${params.length} > ${MAX_PARAMETERS})`, file_path: filePath, line_number: lineNum, suggestion: '考虑使用配置对象或数据类封装参数' });
+      issues.push({
+        severity: 'warning', category: '设计',
+        message: `函数 '${name}' 参数过多 (${params.length} > ${MAX_PARAMETERS})`,
+        file_path: filePath, line_number: lineNum,
+        suggestion: '考虑使用配置对象或数据类封装参数',
+      });
     }
     // Check naming
-    const SPECIAL = new Set(['setUp', 'tearDown', 'setUpClass', 'tearDownClass', 'setUpModule', 'tearDownModule']);
+    const SPECIAL = new Set([
+      'setUp', 'tearDown', 'setUpClass',
+      'tearDownClass', 'setUpModule', 'tearDownModule',
+    ]);
     if (!name.startsWith('_') && !SPECIAL.has(name) && !name.startsWith('visit_')) {
       if (!/^[a-z][a-z0-9_]*$/.test(name)) {
-        issues.push({ severity: 'info', category: '命名', message: `函数名 '${name}' 不符合 snake_case 规范`, file_path: filePath, line_number: lineNum, suggestion: '函数名应使用 snake_case，如 my_function_name' });
+        issues.push({
+          severity: 'info', category: '命名',
+          message: `函数名 '${name}' 不符合 snake_case 规范`,
+          file_path: filePath, line_number: lineNum,
+          suggestion: '函数名应使用 snake_case',
+        });
       }
     }
     if (name.length < MIN_FUNCTION_NAME_LENGTH) {
-      issues.push({ severity: 'warning', category: '命名', message: `函数名 '${name}' 过短`, file_path: filePath, line_number: lineNum, suggestion: '使用更具描述性的函数名' });
+      issues.push({
+        severity: 'warning', category: '命名',
+        message: `函数名 '${name}' 过短`,
+        file_path: filePath, line_number: lineNum,
+        suggestion: '使用更具描述性的函数名',
+      });
     }
   }
 
@@ -147,7 +224,12 @@ function analyzePythonFile(filePath) {
     const name = match[2];
     metrics.classes++;
     if (!/^[A-Z][a-zA-Z0-9]*$/.test(name)) {
-      issues.push({ severity: 'warning', category: '命名', message: `类名 '${name}' 不符合 PascalCase 规范`, file_path: filePath, line_number: lineNum, suggestion: '类名应使用 PascalCase，如 MyClassName' });
+      issues.push({
+        severity: 'warning', category: '命名',
+        message: `类名 '${name}' 不符合 PascalCase 规范`,
+        file_path: filePath, line_number: lineNum,
+        suggestion: '类名应使用 PascalCase，如 MyClassName',
+      });
     }
   }
 
@@ -164,7 +246,11 @@ function analyzePythonFile(filePath) {
 function scanDirectory(scanPath, excludeDirs) {
   const resolved = path.resolve(scanPath);
   const exclude = excludeDirs || EXCLUDE_DIRS;
-  const result = { scan_path: resolved, files_scanned: 0, total_lines: 0, total_code_lines: 0, issues: [], file_metrics: [] };
+  const result = {
+    scan_path: resolved, files_scanned: 0,
+    total_lines: 0, total_code_lines: 0,
+    issues: [], file_metrics: [],
+  };
 
   function walk(dir) {
     let entries;
@@ -191,83 +277,58 @@ function scanDirectory(scanPath, excludeDirs) {
 
 // --- Reporting ---
 
-function errorCount(result) { return result.issues.filter(i => i.severity === 'error').length; }
-function warningCount(result) { return result.issues.filter(i => i.severity === 'warning').length; }
-function passed(result) { return !result.issues.some(i => i.severity === 'error'); }
+function passed(result) { return !hasFatal(result.issues); }
 
 function formatReport(result, verbose) {
-  const lines = [];
-  const sep = '='.repeat(60);
-  const dash = '-'.repeat(40);
-  lines.push(sep, '代码质量检查报告', sep);
-  lines.push(`\n扫描路径: ${result.scan_path}`);
-  lines.push(`扫描文件: ${result.files_scanned}`);
-  lines.push(`总行数: ${result.total_lines}`);
-  lines.push(`代码行数: ${result.total_code_lines}`);
-  lines.push(`检查结果: ${passed(result) ? '✓ 通过' : '✗ 需要关注'}`);
-  lines.push(`错误: ${errorCount(result)} | 警告: ${warningCount(result)}`);
-
-  if (result.issues.length) {
-    lines.push('\n' + dash, '问题列表:', dash);
-    const byCategory = {};
-    for (const issue of result.issues) {
-      (byCategory[issue.category] || (byCategory[issue.category] = [])).push(issue);
-    }
-    const icons = { error: '✗', warning: '⚠', info: 'ℹ' };
-    for (const cat of Object.keys(byCategory).sort()) {
-      const catIssues = byCategory[cat];
-      lines.push(`\n【${cat}】(${catIssues.length} 个)`);
-      for (const issue of catIssues.slice(0, 10)) {
-        const icon = icons[issue.severity];
-        const loc = issue.line_number ? `:${issue.line_number}` : '';
-        lines.push(`  ${icon} ${issue.file_path}${loc}`);
-        lines.push(`    ${issue.message}`);
-        if (verbose && issue.suggestion) lines.push(`    💡 ${issue.suggestion}`);
-      }
-      if (catIssues.length > 10) lines.push(`  ... 及其他 ${catIssues.length - 10} 个问题`);
-    }
-  }
+  const errs = result.issues.filter(i => i.severity === 'error').length;
+  const warns = result.issues.filter(i => i.severity === 'warning').length;
+  const fields = {
+    '扫描路径': result.scan_path,
+    '扫描文件': result.files_scanned,
+    '总行数': result.total_lines,
+    '代码行数': result.total_code_lines,
+    '检查结果': passed(result) ? '✓ 通过' : '✗ 需要关注',
+    '统计': `错误: ${errs} | 警告: ${warns}`,
+  };
+  let report = buildReport(
+    '代码质量检查报告', fields, result.issues, verbose, 'category'
+  );
 
   if (verbose && result.file_metrics.length) {
-    const complex = result.file_metrics.filter(m => m.max_complexity > 0).sort((a, b) => b.max_complexity - a.max_complexity).slice(0, 5);
+    const complex = result.file_metrics
+      .filter(m => m.max_complexity > 0)
+      .sort((a, b) => b.max_complexity - a.max_complexity)
+      .slice(0, 5);
     if (complex.length) {
-      lines.push('\n' + dash, '复杂度最高的文件:', dash);
+      const lines = ['\n' + '-'.repeat(40), '复杂度最高的文件:', '-'.repeat(40)];
       for (const m of complex) lines.push(`  ${m.path}: 复杂度 ${m.max_complexity}, ${m.functions} 个函数`);
+      report += '\n' + lines.join('\n');
     }
   }
-
-  lines.push('\n' + sep);
-  return lines.join('\n');
+  return report;
 }
 
 // --- CLI ---
 
 function main() {
-  const args = process.argv.slice(2);
-  let scanPath = '.', verbose = false, jsonOutput = false;
-
-  for (let i = 0; i < args.length; i++) {
-    if (args[i] === '-v' || args[i] === '--verbose') verbose = true;
-    else if (args[i] === '--json') jsonOutput = true;
-    else if (!args[i].startsWith('-')) scanPath = args[i];
-  }
+  const opts = parseCliArgs(process.argv);
 
-  const result = scanDirectory(scanPath);
+  const result = scanDirectory(opts.target);
 
-  if (jsonOutput) {
+  if (opts.json) {
     const output = {
       scan_path: result.scan_path,
       files_scanned: result.files_scanned,
       total_lines: result.total_lines,
       total_code_lines: result.total_code_lines,
       passed: passed(result),
-      error_count: errorCount(result),
-      warning_count: warningCount(result),
+      error_count: result.issues.filter(i => i.severity === 'error').length,
+      warning_count: result.issues.filter(i => i.severity === 'warning').length,
       issues: result.issues
     };
     console.log(JSON.stringify(output, null, 2));
   } else {
-    console.log(formatReport(result, verbose));
+    console.log(formatReport(result, opts.verbose));
   }
 
   process.exit(passed(result) ? 0 : 1);