coalesce-transform-mcp 0.3.0 → 0.4.2

package/dist/services/pipelines/node-type-selection.d.ts

@@ -4,6 +4,25 @@ export type PipelineTemplateDefaults = {
 };
 export declare const PIPELINE_NODE_TYPE_FAMILIES: readonly ["stage", "persistent-stage", "view", "work", "dimension", "fact", "hub", "satellite", "link", "unknown"];
 export type PipelineNodeTypeFamily = (typeof PIPELINE_NODE_TYPE_FAMILIES)[number];
+export type InternalPipelineNodeTypeCandidate = {
+    nodeType: string;
+    displayName: string | null;
+    shortName: string | null;
+    family: PipelineNodeTypeFamily;
+    usageCount: number;
+    workspaceUsageCount: number;
+    observedInWorkspace: boolean;
+    autoExecutable: boolean;
+    semanticSignals: string[];
+    missingDefaultFields: string[];
+    templateWarnings: string[];
+    templateDefaults?: PipelineTemplateDefaults;
+    score: number;
+    reasons: string[];
+    source: "repo" | "workspace";
+    resolutionKind?: "direct" | "package";
+    packageAlias?: string;
+};
 export type PipelineNodeTypeSelectionCandidate = {
     nodeType: string;
     displayName: string | null;
@@ -46,7 +65,7 @@ export type PipelineNodeTypeSelectionResult = {
     selection: PipelineNodeTypeSelection;
     warnings: string[];
 };
-type PipelineNodeTypeSelectionContext = {
+export type PipelineNodeTypeSelectionContext = {
     explicitNodeType?: string;
     goal?: string;
     targetName?: string;
@@ -62,7 +81,8 @@ type PipelineNodeTypeSelectionContext = {
     /** Structural hint: are business keys explicitly defined? */
     hasBusinessKeys?: boolean;
 };
+export declare function matchesNodeTypeIdentity(left: string, right: string): boolean;
+export declare function isAutoExecutableFamily(family: PipelineNodeTypeFamily): boolean;
 export declare function inferFamily(signals: string[]): PipelineNodeTypeFamily;
 export declare function selectPipelineNodeType(context: PipelineNodeTypeSelectionContext): PipelineNodeTypeSelectionResult;
-export {};
 //# sourceMappingURL=node-type-selection.d.ts.map

package/dist/services/pipelines/node-type-selection.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"node-type-selection.d.ts","sourceRoot":"","sources":["../../../src/services/pipelines/node-type-selection.ts"],"names":[],"mappings":"AAWA,MAAM,MAAM,wBAAwB,GAAG;IACrC,sBAAsB,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;IAChD,cAAc,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;CACzC,CAAC;AAEF,eAAO,MAAM,2BAA2B,oHAW9B,CAAC;AAEX,MAAM,MAAM,sBAAsB,GAAG,CAAC,OAAO,2BAA2B,CAAC,CAAC,MAAM,CAAC,CAAC;AAsBlF,MAAM,MAAM,kCAAkC,GAAG;IAC/C,QAAQ,EAAE,MAAM,CAAC;IACjB,WAAW,EAAE,MAAM,GAAG,IAAI,CAAC;IAC3B,SAAS,EAAE,MAAM,GAAG,IAAI,CAAC;IACzB,MAAM,EAAE,sBAAsB,CAAC;IAC/B,UAAU,EAAE,MAAM,CAAC;IACnB,mBAAmB,EAAE,MAAM,CAAC;IAC5B,mBAAmB,EAAE,OAAO,CAAC;IAC7B,cAAc,EAAE,OAAO,CAAC;IACxB,KAAK,EAAE,MAAM,CAAC;IACd,OAAO,EAAE,MAAM,EAAE,CAAC;CACnB,CAAC;AAEF,MAAM,MAAM,yBAAyB,GAAG;IACtC,QAAQ,EAAE,UAAU,GAAG,aAAa,GAAG,kBAAkB,GAAG,UAAU,CAAC;IACvE,gBAAgB,EAAE,MAAM,GAAG,IAAI,CAAC;IAChC,mBAAmB,EAAE,MAAM,GAAG,IAAI,CAAC;IACnC,iBAAiB,EAAE,MAAM,GAAG,IAAI,CAAC;IACjC,cAAc,EAAE,sBAAsB,GAAG,IAAI,CAAC;IAC9C,UAAU,EAAE,MAAM,GAAG,QAAQ,GAAG,KAAK,CAAC;IACtC,cAAc,EAAE,OAAO,CAAC;IACxB,kBAAkB,EAAE,MAAM,EAAE,CAAC;IAC7B,QAAQ,EAAE,MAAM,GAAG,IAAI,CAAC;IACxB,gBAAgB,EAAE,MAAM,GAAG,IAAI,CAAC;IAChC,YAAY,EAAE,MAAM,EAAE,CAAC;IACvB,0BAA0B,EAAE,MAAM,EAAE,CAAC;IACrC,mBAAmB,EAAE,kCAAkC,EAAE,CAAC;CAC3D,CAAC;AAEF,MAAM,MAAM,+BAA+B,GAAG;IAC5C,iBAAiB,EAAE;QACjB,QAAQ,EAAE,MAAM,CAAC;QACjB,WAAW,EAAE,MAAM,GAAG,IAAI,CAAC;QAC3B,SAAS,EAAE,MAAM,GAAG,IAAI,CAAC;QACzB,MAAM,EAAE,sBAAsB,CAAC;QAC/B,cAAc,EAAE,OAAO,CAAC;QACxB,eAAe,EAAE,MAAM,EAAE,CAAC;QAC1B,oBAAoB,EAAE,MAAM,EAAE,CAAC;QAC/B,gBAAgB,EAAE,MAAM,EAAE,CAAC;QAC3B,gBAAgB,CAAC,EAAE,wBAAwB,CAAC;KAC7C,GAAG,IAAI,CAAC;IACT,SAAS,EAAE,yBAAyB,CAAC;IACrC,QAAQ,EAAE,MAAM,EAAE,CAAC;CACpB,CAAC;AAEF,KAAK,gCAAgC,GAAG;IACtC,gBAAgB,CAAC,EAAE,MAAM,CAAC;IAC1B,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,GAAG,CAAC,EAAE,MAAM,CAAC;IACb,WAAW,EAAE,MAAM,CAAC;IACpB,kBAAkB,CAAC,EAAE,MAAM,EAAE,CAAC;IAC9B,uBAAuB,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;IACjD,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,6DAA6D;IAC7D,OAAO,CAAC,EAAE,OAAO,CAAC;IAClB,gEAAgE;IAChE,UAAU,CAAC,EAAE,OAAO,CAAC;IACrB,6DAA6D;IAC7D,eAAe,CAAC,EAAE,OAAO,CAAC;CAC3B,CAAC;AAwEF,wBAAgB,WAAW,CAAC,OAAO,EAAE,MAAM,EAAE,GAAG,sBAAsB,CAmCrE;AAgoBD,wBAAgB,sBAAsB,CACpC,OAAO,EAAE,gCAAgC,GACxC,+BAA+B,CAmMjC"}
+{"version":3,"file":"node-type-selection.d.ts","sourceRoot":"","sources":["../../../src/services/pipelines/node-type-selection.ts"],"names":[],"mappings":"AAaA,MAAM,MAAM,wBAAwB,GAAG;IACrC,sBAAsB,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;IAChD,cAAc,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;CACzC,CAAC;AAEF,eAAO,MAAM,2BAA2B,oHAW9B,CAAC;AAEX,MAAM,MAAM,sBAAsB,GAAG,CAAC,OAAO,2BAA2B,CAAC,CAAC,MAAM,CAAC,CAAC;AAElF,MAAM,MAAM,iCAAiC,GAAG;IAC9C,QAAQ,EAAE,MAAM,CAAC;IACjB,WAAW,EAAE,MAAM,GAAG,IAAI,CAAC;IAC3B,SAAS,EAAE,MAAM,GAAG,IAAI,CAAC;IACzB,MAAM,EAAE,sBAAsB,CAAC;IAC/B,UAAU,EAAE,MAAM,CAAC;IACnB,mBAAmB,EAAE,MAAM,CAAC;IAC5B,mBAAmB,EAAE,OAAO,CAAC;IAC7B,cAAc,EAAE,OAAO,CAAC;IACxB,eAAe,EAAE,MAAM,EAAE,CAAC;IAC1B,oBAAoB,EAAE,MAAM,EAAE,CAAC;IAC/B,gBAAgB,EAAE,MAAM,EAAE,CAAC;IAC3B,gBAAgB,CAAC,EAAE,wBAAwB,CAAC;IAC5C,KAAK,EAAE,MAAM,CAAC;IACd,OAAO,EAAE,MAAM,EAAE,CAAC;IAClB,MAAM,EAAE,MAAM,GAAG,WAAW,CAAC;IAC7B,cAAc,CAAC,EAAE,QAAQ,GAAG,SAAS,CAAC;IACtC,YAAY,CAAC,EAAE,MAAM,CAAC;CACvB,CAAC;AAEF,MAAM,MAAM,kCAAkC,GAAG;IAC/C,QAAQ,EAAE,MAAM,CAAC;IACjB,WAAW,EAAE,MAAM,GAAG,IAAI,CAAC;IAC3B,SAAS,EAAE,MAAM,GAAG,IAAI,CAAC;IACzB,MAAM,EAAE,sBAAsB,CAAC;IAC/B,UAAU,EAAE,MAAM,CAAC;IACnB,mBAAmB,EAAE,MAAM,CAAC;IAC5B,mBAAmB,EAAE,OAAO,CAAC;IAC7B,cAAc,EAAE,OAAO,CAAC;IACxB,KAAK,EAAE,MAAM,CAAC;IACd,OAAO,EAAE,MAAM,EAAE,CAAC;CACnB,CAAC;AAEF,MAAM,MAAM,yBAAyB,GAAG;IACtC,QAAQ,EAAE,UAAU,GAAG,aAAa,GAAG,kBAAkB,GAAG,UAAU,CAAC;IACvE,gBAAgB,EAAE,MAAM,GAAG,IAAI,CAAC;IAChC,mBAAmB,EAAE,MAAM,GAAG,IAAI,CAAC;IACnC,iBAAiB,EAAE,MAAM,GAAG,IAAI,CAAC;IACjC,cAAc,EAAE,sBAAsB,GAAG,IAAI,CAAC;IAC9C,UAAU,EAAE,MAAM,GAAG,QAAQ,GAAG,KAAK,CAAC;IACtC,cAAc,EAAE,OAAO,CAAC;IACxB,kBAAkB,EAAE,MAAM,EAAE,CAAC;IAC7B,QAAQ,EAAE,MAAM,GAAG,IAAI,CAAC;IACxB,gBAAgB,EAAE,MAAM,GAAG,IAAI,CAAC;IAChC,YAAY,EAAE,MAAM,EAAE,CAAC;IACvB,0BAA0B,EAAE,MAAM,EAAE,CAAC;IACrC,mBAAmB,EAAE,kCAAkC,EAAE,CAAC;CAC3D,CAAC;AAEF,MAAM,MAAM,+BAA+B,GAAG;IAC5C,iBAAiB,EAAE;QACjB,QAAQ,EAAE,MAAM,CAAC;QACjB,WAAW,EAAE,MAAM,GAAG,IAAI,CAAC;QAC3B,SAAS,EAAE,MAAM,GAAG,IAAI,CAAC;QACzB,MAAM,EAAE,sBAAsB,CAAC;QAC/B,cAAc,EAAE,OAAO,CAAC;QACxB,eAAe,EAAE,MAAM,EAAE,CAAC;QAC1B,oBAAoB,EAAE,MAAM,EAAE,CAAC;QAC/B,gBAAgB,EAAE,MAAM,EAAE,CAAC;QAC3B,gBAAgB,CAAC,EAAE,wBAAwB,CAAC;KAC7C,GAAG,IAAI,CAAC;IACT,SAAS,EAAE,yBAAyB,CAAC;IACrC,QAAQ,EAAE,MAAM,EAAE,CAAC;CACpB,CAAC;AAEF,MAAM,MAAM,gCAAgC,GAAG;IAC7C,gBAAgB,CAAC,EAAE,MAAM,CAAC;IAC1B,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,GAAG,CAAC,EAAE,MAAM,CAAC;IACb,WAAW,EAAE,MAAM,CAAC;IACpB,kBAAkB,CAAC,EAAE,MAAM,EAAE,CAAC;IAC9B,uBAAuB,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;IACjD,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,6DAA6D;IAC7D,OAAO,CAAC,EAAE,OAAO,CAAC;IAClB,gEAAgE;IAChE,UAAU,CAAC,EAAE,OAAO,CAAC;IACrB,6DAA6D;IAC7D,eAAe,CAAC,EAAE,OAAO,CAAC;CAC3B,CAAC;AAiCF,wBAAgB,uBAAuB,CAAC,IAAI,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,GAAG,OAAO,CAE5E;AAED,wBAAgB,sBAAsB,CAAC,MAAM,EAAE,sBAAsB,GAAG,OAAO,CAO9E;AAED,wBAAgB,WAAW,CAAC,OAAO,EAAE,MAAM,EAAE,GAAG,sBAAsB,CAmCrE;AAMD,wBAAgB,sBAAsB,CACpC,OAAO,EAAE,gCAAgC,GACxC,+BAA+B,CA8LjC"}

package/dist/services/pipelines/node-type-selection.js

@@ -1,8 +1,7 @@
-import { parseRepo, resolveRepoNodeType, } from "../repo/parser.js";
+import { parseRepo, } from "../repo/parser.js";
 import { resolveOptionalRepoPathInput } from "../repo/path.js";
-import { buildSetWorkspaceNodeTemplateFromDefinition } from "../templates/nodes.js";
-import { isPlainObject } from "../../utils.js";
-import { NODE_TYPE_INTENT, hasAntiSignal, detectSpecializedPatternPenalty, detectSpecializedPatternMatch } from "./node-type-intent.js";
+import { scoreCandidate, challengeCandidate, rankCandidates } from "./node-type-scoring.js";
+import { collectRepoResolutions, buildRepoCandidate, buildWorkspaceCandidate } from "./node-type-candidates.js";
 export const PIPELINE_NODE_TYPE_FAMILIES = [
     "stage",
     "persistent-stage",
@@ -15,15 +14,9 @@ export const PIPELINE_NODE_TYPE_FAMILIES = [
     "link",
     "unknown",
 ];
-function getString(value) {
-    return typeof value === "string" ? value : null;
-}
-function compareStrings(left, right) {
-    return left.localeCompare(right, undefined, {
-        numeric: true,
-        sensitivity: "case",
-    });
-}
+// ---------------------------------------------------------------------------
+// Shared helpers (used by scoring / candidates / external consumers)
+// ---------------------------------------------------------------------------
 function nodeTypeID(nodeType) {
     const delimiterIndex = nodeType.indexOf(":::");
     return delimiterIndex === -1 ? nodeType : nodeType.slice(delimiterIndex + 3);
@@ -34,7 +27,6 @@ function isExcludedNodeTypeID(nodeType) {
     return EXCLUDED_NODE_TYPE_IDS.has(nodeTypeID(nodeType));
 }
 function isExcludedByInputMode(resolution) {
-    // inputMode can be in outerDefinition (top-level) or nodeDefinition (nodeMetadataSpec)
     if (resolution.nodeTypeRecord.outerDefinition.inputMode === "sql") {
         return true;
     }
@@ -47,27 +39,14 @@ function isExcludedByInputMode(resolution) {
 function isDisabledNodeType(resolution) {
     return resolution.nodeTypeRecord.outerDefinition.isDisabled === true;
 }
-function matchesNodeTypeIdentity(left, right) {
+export function matchesNodeTypeIdentity(left, right) {
     return left === right || nodeTypeID(left) === nodeTypeID(right);
 }
-function collectRepoResolutions(parsedRepo) {
-    const resolutions = [];
-    for (const [id, matches] of parsedRepo.nodeTypesByID.entries()) {
-        if (matches.length !== 1) {
-            continue;
-        }
-        resolutions.push(resolveRepoNodeType(parsedRepo, id));
-    }
-    for (const packageRecord of parsedRepo.packages) {
-        const packageMatches = parsedRepo.packagesByAlias.get(packageRecord.alias) ?? [];
-        if (packageMatches.length !== 1) {
-            continue;
-        }
-        for (const definitionID of packageRecord.resolvedDefinitionIDs) {
-            resolutions.push(resolveRepoNodeType(parsedRepo, `${packageRecord.alias}:::${definitionID}`));
-        }
-    }
-    return resolutions.sort((left, right) => compareStrings(left.resolvedNodeType, right.resolvedNodeType));
+export function isAutoExecutableFamily(family) {
+    return (family === "stage" ||
+        family === "persistent-stage" ||
+        family === "view" ||
+        family === "work");
 }
 export function inferFamily(signals) {
     const combined = signals
@@ -103,506 +82,9 @@ export function inferFamily(signals) {
     }
     return "unknown";
 }
-function getDefinitionConfigItems(nodeDefinition) {
-    const groups = Array.isArray(nodeDefinition.config)
-        ? nodeDefinition.config.filter(isPlainObject)
-        : [];
-    return groups.flatMap((group) => Array.isArray(group.items) ? group.items.filter(isPlainObject) : []);
-}
-function analyzeDefinition(nodeDefinition) {
-    if (!nodeDefinition) {
-        return {
-            semanticSignals: [],
-            missingDefaultFields: [],
-        };
-    }
-    const semanticSignals = new Set();
-    const missingDefaultFields = new Set();
-    for (const item of getDefinitionConfigItems(nodeDefinition)) {
-        const label = getString(item.attributeName) ??
-            getString(item.displayName) ??
-            getString(item.type) ??
-            "unknown";
-        const normalizedLabel = label.toLowerCase();
-        const itemType = getString(item.type) ?? "";
-        const hasDefault = Object.prototype.hasOwnProperty.call(item, "default");
-        if (/(business.?key|surrogate|scd|effective|current.?flag|grain|hash|hub|satellite|link|fact|dimension|merge.?key)/u.test(normalizedLabel)) {
-            semanticSignals.add(label);
-        }
-        if (!hasDefault &&
-            itemType !== "materializationSelector" &&
-            itemType !== "multisourceToggle" &&
-            itemType !== "overrideSQLToggle") {
-            missingDefaultFields.add(label);
-        }
-    }
-    return {
-        semanticSignals: Array.from(semanticSignals).sort(compareStrings),
-        missingDefaultFields: Array.from(missingDefaultFields).sort(compareStrings),
-    };
-}
-function isAutoExecutableFamily(family) {
-    return (family === "stage" ||
-        family === "persistent-stage" ||
-        family === "view" ||
-        family === "work");
-}
-const CATEGORY_FAMILIES = {
-    "general-purpose": ["stage", "work"],
-    "view": ["view"],
-    "persistent": ["persistent-stage"],
-    "dimensional": ["dimension", "fact"],
-    "data-vault": ["hub", "satellite", "link"],
-};
-/**
- * Determine the desired category from context.
- *
- * Decision tree:
- * 1. Explicit dimensional/data-vault/CDC/view intent → that category
- * 2. Strong signal from name (dim_, fct_, hub_, etc.) → that category
- * 3. Otherwise → general-purpose (stage/work, pick by workspace usage)
- *
- * Stage vs Work within general-purpose: prefer whichever the workspace
- * already uses more, or default to stage.
- */
-function buildUseCaseContext(context) {
-    const freeText = [context.goal, context.targetName].filter(Boolean).join(" ").toLowerCase();
-    const multiSource = context.sourceCount > 1;
-    // Dimensional modeling requires explicit intent — not just GROUP BY
-    const dimensionalModeling = /\bdimension(al)?\s+model/u.test(freeText) ||
-        /\bstar\s+schema\b/u.test(freeText) ||
-        /\bsnowflake\s+schema\b/u.test(freeText);
-    // Data Vault requires explicit intent
-    const dataVaultIntent = /\bdata\s*vault\b/u.test(freeText);
-    // CDC / persistent stage requires explicit intent
-    const persistentIntent = /\bpersistent\s*stage\b/u.test(freeText) ||
-        /\bcdc\b/u.test(freeText) ||
-        /\bchange\s*track/u.test(freeText);
-    // View requires explicit intent
-    const viewIntent = /\bview\b/u.test(freeText) ||
-        /\bno\s+materialization/u.test(freeText) ||
-        /\bvirtual\s+table/u.test(freeText);
-    // Check name-based strong signals ONLY for specialized categories
-    // (not for stage/work — those are general-purpose regardless of name)
-    const targetName = (context.targetName ?? "").toLowerCase();
-    const combinedText = `${targetName} ${freeText}`;
-    const specializedSignalChecks = [
-        { category: "persistent", families: ["persistent-stage"] },
-        { category: "dimensional", families: ["dimension", "fact"] },
-        { category: "data-vault", families: ["hub", "satellite", "link"] },
-        { category: "view", families: ["view"] },
-    ];
-    // 1. Explicit intent from goal text
-    if (dataVaultIntent) {
-        return { desiredFamilies: ["hub", "satellite", "link"], category: "data-vault", dimensionalModeling, multiSource };
-    }
-    if (dimensionalModeling) {
-        return { desiredFamilies: ["dimension", "fact"], category: "dimensional", dimensionalModeling, multiSource };
-    }
-    if (persistentIntent) {
-        return { desiredFamilies: ["persistent-stage", "stage"], category: "persistent", dimensionalModeling, multiSource };
-    }
-    if (viewIntent && !context.hasJoin && !context.hasGroupBy) {
-        return { desiredFamilies: ["view", "stage"], category: "view", dimensionalModeling, multiSource };
-    }
-    // 2. Strong signal from name (only for specialized families)
-    for (const { category, families } of specializedSignalChecks) {
-        for (const family of families) {
-            const intent = NODE_TYPE_INTENT[family];
-            if (intent.strongSignals.test(combinedText)) {
-                return { desiredFamilies: families, category, dimensionalModeling, multiSource };
-            }
-        }
-    }
-    // 3. General-purpose — stage and work are interchangeable.
-    // Tiebreaker priority:
-    //   a) Workspace pattern — which does the workspace already use more?
-    //   b) Default to stage (base node type package always has Stage)
-    const counts = context.workspaceNodeTypeCounts ?? {};
-    const stageUsage = Object.entries(counts)
-        .filter(([nodeType]) => inferFamily([nodeType]) === "stage")
-        .reduce((sum, [, count]) => sum + count, 0);
-    const workUsage = Object.entries(counts)
-        .filter(([nodeType]) => inferFamily([nodeType]) === "work")
-        .reduce((sum, [, count]) => sum + count, 0);
-    const desiredFamilies = workUsage > stageUsage
-        ? ["work", "stage", "view"]
-        : ["stage", "work", "view"];
-    return { desiredFamilies, category: "general-purpose", dimensionalModeling, multiSource };
-}
-function familyScore(candidate, useCase) {
-    const { desiredFamilies, category } = useCase;
-    if (desiredFamilies.length === 0) {
-        return { score: 0, reasons: [] };
-    }
-    // For general-purpose category, stage and work get the same top score.
-    // They're interchangeable — the tiebreaker is workspace usage.
-    // Candidates observed in the workspace get a bonus to prefer established patterns.
-    if (category === "general-purpose") {
-        if (candidate.family === "stage" || candidate.family === "work") {
-            const workspaceBonus = candidate.observedInWorkspace ? 20 : 0;
-            const reasons = [`general-purpose ${candidate.family} node — fits standard transforms`];
-            if (workspaceBonus > 0) {
-                reasons.push("preferred — already used in this workspace");
-            }
-            return {
-                score: 120 + workspaceBonus,
-                reasons,
-            };
-        }
-        if (candidate.family === "view") {
-            return {
-                score: 60,
-                reasons: ["view is acceptable for general-purpose transforms"],
-            };
-        }
-        return { score: 0, reasons: [] };
-    }
-    // For specialized categories, rank by position in desired families list
-    if (desiredFamilies.includes(candidate.family)) {
-        const position = desiredFamilies.indexOf(candidate.family);
-        const score = position === 0 ? 120 : 60;
-        return {
-            score,
-            reasons: [`matches the ${category} category (${candidate.family})`],
-        };
-    }
-    // General-purpose families are always a fallback for specialized categories
-    if (candidate.family === "stage" || candidate.family === "work") {
-        return {
-            score: 25,
-            reasons: [`general-purpose fallback for ${category} category`],
-        };
-    }
-    return { score: 0, reasons: [] };
-}
-function scoreCandidate(candidate, context) {
-    const reasons = [...candidate.reasons];
-    let score = candidate.score;
-    const useCase = buildUseCaseContext(context);
-    if (context.explicitNodeType) {
-        if (candidate.nodeType === context.explicitNodeType) {
-            score += 1000;
-            reasons.push("matches the explicit targetNodeType override");
-        }
-        else if (matchesNodeTypeIdentity(candidate.nodeType, context.explicitNodeType)) {
-            score += 900;
-            reasons.push("matches the explicit targetNodeType ID");
-        }
-        else {
-            score -= 200;
-        }
-    }
-    const familyMatch = familyScore(candidate, useCase);
-    score += familyMatch.score;
-    reasons.push(...familyMatch.reasons);
-    if (useCase.multiSource && isAutoExecutableFamily(candidate.family)) {
-        score += 15;
-        reasons.push("fits a multisource projection workflow");
-    }
-    if (useCase.dimensionalModeling && (candidate.family === "dimension" || candidate.family === "fact")) {
-        score += 40;
-        reasons.push(`${candidate.family} is designed for dimensional modeling with business keys`);
-    }
-    if (!useCase.multiSource && (candidate.family === "stage" || candidate.family === "work")) {
-        score += 10;
-        reasons.push("general-purpose node for single-source transforms");
-    }
-    // Anti-signal penalty: if this family's anti-signals match the context, penalize it.
-    // Prevents dimension/fact from being chosen for generic transforms.
-    const contextText = [context.goal, context.targetName].filter(Boolean).join(" ");
-    if (contextText.length > 0 && hasAntiSignal(candidate.family, contextText)) {
-        score -= 30;
-        reasons.push(`context suggests this is not a ${candidate.family} use case`);
-    }
-    // Semantic config penalty: types that require business keys, SCD, etc.
-    // get penalized when there's no dimensional modeling intent
-    const intent = NODE_TYPE_INTENT[candidate.family];
-    if (intent.requiresSemanticConfig && !useCase.dimensionalModeling) {
-        score -= 15;
-        reasons.push(`${candidate.family} requires semantic config (business keys, SCD) — no dimensional modeling intent detected`);
-    }
-    // Specialized materialization patterns: Dynamic Tables, Incremental Loads, etc.
-    // Decision is binary from node-type-intent.ts:
-    //   - If context explicitly requests the pattern (contextRequired matches) → keep it, add bonus
-    //   - If context doesn't request it → mark as not applicable (score = -Infinity)
-    // This is the same logic as validateNodeTypeChoice() at creation time.
-    const candidateSignals = [candidate.nodeType, candidate.displayName ?? "", candidate.shortName ?? ""].join(" ");
-    const specializedResult = detectSpecializedPatternPenalty(candidateSignals, contextText);
-    if (specializedResult) {
-        // Context doesn't match — this specialized type is not appropriate
-        score = -Infinity;
-        reasons.push(`not applicable: ${specializedResult.reason}`);
-    }
-    else {
-        // Check if context positively matches a specialized pattern (context requested it)
-        const positiveMatch = detectSpecializedPatternMatch(candidateSignals, contextText);
-        if (positiveMatch) {
-            score += 50;
-            reasons.push(`context explicitly requests ${positiveMatch} pattern`);
-        }
-    }
-    // Hard exclusion: data-vault package types are NEVER selected unless
-    // the context explicitly requests data vault. These types serve a fundamentally
-    // different modeling paradigm and should not appear in standard pipelines.
-    if (!useCase.dimensionalModeling &&
-        candidate.family !== "hub" && candidate.family !== "satellite" && candidate.family !== "link" &&
-        ((candidate.packageAlias && /data.vault/iu.test(candidate.packageAlias)) ||
-            /data.vault/iu.test(candidate.nodeType))) {
-        const hasDataVaultIntent = /\bdata\s*vault\b/iu.test(contextText);
-        if (!hasDataVaultIntent) {
-            score = -Infinity;
-            reasons.push(`data vault package type excluded — no data vault intent in context`);
-            return { ...candidate, score, reasons: Array.from(new Set(reasons)) };
-        }
-    }
-    // Non-base type exclusion for general-purpose selections.
-    // Priority: workspace pattern > base node type package > 4 defaults.
-    // Types NOT from the base package are EXCLUDED unless observed in workspace.
-    if (useCase.category === "general-purpose" && candidate.source === "repo") {
-        const isBasePackage = candidate.packageAlias && /base.node.type/iu.test(candidate.packageAlias);
-        if (isBasePackage) {
-            score += 15;
-            reasons.push("from base node type package — preferred default");
-        }
-        else if (!candidate.observedInWorkspace) {
-            // Non-base, non-workspace types are excluded for general-purpose transforms.
-            // Only types from the base node type package or already in use in the workspace
-            // are eligible for standard staging/transform/join operations.
-            score = -Infinity;
-            const source = candidate.packageAlias
-                ? `non-base package "${candidate.packageAlias}"`
-                : `custom repo type "${candidate.nodeType}"`;
-            reasons.push(`excluded: ${source} — not observed in workspace. Use base node types or workspace-established types.`);
-            return { ...candidate, score, reasons: Array.from(new Set(reasons)) };
-        }
-    }
-    // Penalize "Copy of" types — these are user-cloned definitions.
-    // The original base type should be preferred unless explicitly requested.
-    if (candidate.displayName &&
-        /\bcopy\s+of\b/iu.test(candidate.displayName) &&
-        !context.explicitNodeType) {
-        score -= 30;
-        reasons.push(`"${candidate.displayName}" is a cloned type — prefer the original`);
-    }
-    // Unknown family types should never beat known general-purpose types.
-    // If inferFamily couldn't classify it, it's likely a custom/specialized type
-    // that shouldn't be auto-selected for standard transforms.
-    if (candidate.family === "unknown" && !context.explicitNodeType) {
-        score -= 50;
-        reasons.push("unknown node type family — cannot verify suitability for this use case");
-    }
-    if (candidate.autoExecutable) {
-        score += 25;
-        reasons.push("supports template-based automatic creation");
-    }
-    else {
-        score -= 25;
-        reasons.push("likely needs extra semantic configuration before automatic creation");
-    }
-    if (candidate.missingDefaultFields.length > 0) {
-        score -= candidate.missingDefaultFields.length * 8;
-        reasons.push(`has config fields without defaults: ${candidate.missingDefaultFields.join(", ")}`);
-    }
-    if (candidate.semanticSignals.length > 0) {
-        score -= candidate.semanticSignals.length * 6;
-        reasons.push(`exposes semantic config signals: ${candidate.semanticSignals.join(", ")}`);
-    }
-    if (candidate.templateWarnings.length > 0) {
-        score -= Math.min(candidate.templateWarnings.length, 3) * 3;
-    }
-    return {
-        ...candidate,
-        score,
-        reasons: Array.from(new Set(reasons)),
-    };
-}
-function buildRepoCandidate(resolution, workspaceNodeTypes, workspaceNodeTypeCounts) {
-    const generated = resolution.nodeTypeRecord.nodeDefinition
-        ? buildSetWorkspaceNodeTemplateFromDefinition(resolution.nodeTypeRecord.nodeDefinition, { nodeType: resolution.resolvedNodeType })
-        : undefined;
-    const displayName = getString(resolution.nodeTypeRecord.outerDefinition.name) ??
-        generated?.definitionSummary.capitalized ??
-        null;
-    const shortName = generated?.definitionSummary.short ?? null;
-    const family = inferFamily([
-        resolution.resolvedNodeType,
-        resolution.nodeTypeRecord.dirName,
-        displayName ?? "",
-        shortName ?? "",
-        generated?.definitionSummary.capitalized ?? "",
-    ].filter((value) => value.length > 0));
-    const insights = analyzeDefinition(resolution.nodeTypeRecord.nodeDefinition);
-    const observedInWorkspace = workspaceNodeTypes.some((nodeType) => matchesNodeTypeIdentity(nodeType, resolution.resolvedNodeType));
-    const workspaceUsageCount = workspaceNodeTypes.reduce((sum, nodeType) => {
-        if (!matchesNodeTypeIdentity(nodeType, resolution.resolvedNodeType)) {
-            return sum;
-        }
-        return sum + (workspaceNodeTypeCounts[nodeType] ?? 0);
-    }, 0);
-    const autoExecutable = (isAutoExecutableFamily(family) ||
-        (family === "unknown" &&
-            insights.semanticSignals.length === 0 &&
-            insights.missingDefaultFields.length === 0 &&
-            !!generated)) &&
-        !generated?.warnings.some((warning) => warning.includes("does not map cleanly"));
-    const reasons = [];
-    if (resolution.usageCount > 0) {
-        reasons.push(`used ${resolution.usageCount} time(s) in committed nodes/`);
-    }
-    if (observedInWorkspace) {
-        reasons.push("already observed in current workspace nodes");
-    }
-    if (displayName) {
-        reasons.push(`definition resolves to ${displayName}`);
-    }
-    return {
-        nodeType: resolution.resolvedNodeType,
-        displayName,
-        shortName,
-        family,
-        usageCount: resolution.usageCount,
-        workspaceUsageCount,
-        observedInWorkspace,
-        autoExecutable,
-        semanticSignals: insights.semanticSignals,
-        missingDefaultFields: insights.missingDefaultFields,
-        templateWarnings: generated?.warnings ?? [],
-        templateDefaults: generated
-            ? {
-                inferredTopLevelFields: generated.inferredTopLevelFields,
-                inferredConfig: generated.inferredConfig,
-            }
-            : undefined,
-        score: resolution.usageCount * 20 + workspaceUsageCount * 10 + (generated ? 5 : 0),
-        reasons,
-        source: "repo",
-        resolutionKind: resolution.resolutionKind,
-        ...(resolution.resolutionKind === "package"
-            ? { packageAlias: resolution.packageAlias }
-            : {}),
-    };
-}
-function buildWorkspaceCandidate(nodeType, workspaceNodeTypeCounts) {
-    const family = inferFamily([nodeType]);
-    return {
-        nodeType,
-        displayName: nodeType,
-        shortName: null,
-        family,
-        usageCount: 0,
-        workspaceUsageCount: workspaceNodeTypeCounts[nodeType] ?? 0,
-        observedInWorkspace: true,
-        autoExecutable: isAutoExecutableFamily(family),
-        semanticSignals: [],
-        missingDefaultFields: [],
-        templateWarnings: [],
-        score: (workspaceNodeTypeCounts[nodeType] ?? 0) * 10,
-        reasons: ["observed in current workspace nodes"],
-        source: "workspace",
-    };
-}
-/**
- * Sort candidates by score descending (highest first).
- */
-function rankCandidates(candidates) {
-    return [...candidates].sort((a, b) => b.score - a.score);
-}
-/**
- * Challenge the top-ranked candidate against the intent corpus.
- * Returns an array of challenge reasons. Empty = candidate passed.
- *
- * Checks:
- * 1. Anti-signals from the intent doc match the context
- * 2. Specialized pattern not requested by context
- * 3. Requires semantic config but no dimensional modeling intent
- * 4. Another family's strong signal matches context but this candidate doesn't belong to it
- * 5. doNotUseWhen entries match the context
- */
-function challengeCandidate(candidate, context, contextText) {
-    const challenges = [];
-    const intent = NODE_TYPE_INTENT[candidate.family];
-    const contextLower = contextText.toLowerCase();
-    // 1. Anti-signals: the intent doc says this family should NOT be used for this context
-    if (intent.antiSignals !== null && intent.antiSignals.test(contextLower)) {
-        challenges.push(`${candidate.family} anti-signal matched — intent says not for this context`);
-    }
-    // 2. Specialized pattern penalty: candidate is a specialized type but context doesn't request it
-    const candidateSignals = [
-        candidate.nodeType,
-        candidate.displayName ?? "",
-        candidate.shortName ?? "",
-    ].join(" ");
-    const specializedPenalty = detectSpecializedPatternPenalty(candidateSignals, contextText);
-    if (specializedPenalty) {
-        challenges.push(specializedPenalty.reason);
-    }
-    // 3. Requires semantic config (business keys, SCD) but context has no dimensional modeling intent
-    if (intent.requiresSemanticConfig) {
-        const hasDimensionalIntent = /\bdimension(al)?\s+model/u.test(contextLower) ||
-            /\bstar\s+schema\b/u.test(contextLower) ||
-            /\bsnowflake\s+schema\b/u.test(contextLower) ||
-            /\bdata\s*vault\b/u.test(contextLower);
-        // Also check if context has a strong signal for THIS family (e.g. name starts with dim_)
-        const hasOwnStrongSignal = intent.strongSignals.test(contextLower);
-        if (!hasDimensionalIntent && !hasOwnStrongSignal) {
-            challenges.push(`${candidate.family} requires semantic config (business keys, SCD) but no dimensional modeling intent detected`);
-        }
-    }
-    // 4. Another family has a strong signal match but this candidate is a different CATEGORY
-    // Stage and work are interchangeable — don't challenge one for the other.
-    const generalPurposeFamilies = new Set(["stage", "work"]);
-    const signalCheckOrder = [
-        "persistent-stage", "dimension", "fact", "hub", "satellite", "link",
-        "view", "work", "stage",
-    ];
-    for (const family of signalCheckOrder) {
-        if (family === candidate.family)
-            continue;
-        // Skip stage↔work challenges — they're the same category
-        if (generalPurposeFamilies.has(family) && generalPurposeFamilies.has(candidate.family))
-            continue;
-        const otherIntent = NODE_TYPE_INTENT[family];
-        if (otherIntent.strongSignals.test(contextLower)) {
-            challenges.push(`context has a strong signal for ${family} but candidate is ${candidate.family}`);
-            break; // One mismatch is enough
-        }
-    }
-    // 5. doNotUseWhen: check if any anti-pattern descriptions match the context
-    for (const antiPattern of intent.doNotUseWhen) {
-        const antiLower = antiPattern.toLowerCase();
-        // Extract key phrases from the doNotUseWhen text and check against context
-        // Only trigger for phrases that are specific enough (> 10 chars, not generic advice)
-        if (antiLower.length > 10) {
-            // Check for CTE decomposition anti-pattern
-            if (/cte\s+decomposition/u.test(antiLower) && /cte\s+decomposition/u.test(contextLower)) {
-                challenges.push(`intent says do not use ${candidate.family} for CTE decomposition`);
-            }
-            // Check for batch ETL anti-pattern
-            if (/batch\s+etl/u.test(antiLower) && /batch\s+etl/u.test(contextLower)) {
-                challenges.push(`intent says do not use ${candidate.family} for batch ETL`);
-            }
-            // Check for general/simple transforms anti-pattern
-            if (/general.purpose|simple\s+stag/u.test(antiLower) && /general|simple|basic/u.test(contextLower)) {
-                challenges.push(`intent says do not use ${candidate.family} for general-purpose transforms`);
-            }
-        }
-    }
-    // 6. Package-level challenge: non-base packages for general-purpose context
-    // Data vault, functional, and other specialized packages should not be selected
-    // for standard staging/transform/join operations — unless already in workspace.
-    if (candidate.packageAlias &&
-        !/base.node.type/iu.test(candidate.packageAlias) &&
-        !candidate.observedInWorkspace &&
-        /batch\s+etl|staging|transform|general/iu.test(contextLower)) {
-        challenges.push(`from specialized package "${candidate.packageAlias}" — not appropriate for general-purpose transforms`);
-    }
-    // 7. "Copy of" types should be challenged in favor of originals
-    if (candidate.displayName && /\bcopy\s+of\b/iu.test(candidate.displayName)) {
-        challenges.push(`"${candidate.displayName}" is a cloned type — original should be preferred`);
-    }
-    return challenges;
-}
+// ---------------------------------------------------------------------------
+// Main selection orchestrator
+// ---------------------------------------------------------------------------
 export function selectPipelineNodeType(context) {
     const warnings = [];
     const workspaceNodeTypes = context.workspaceNodeTypes ?? [];
@@ -647,8 +129,6 @@ export function selectPipelineNodeType(context) {
         candidates.push(scoreCandidate(buildWorkspaceCandidate(nodeType, workspaceNodeTypeCounts), context));
     }
     // === DELIBERATIVE SELECTION: Match → Rank → Challenge → Repeat (twice) ===
-    // Two rounds of scoring + challenge to ensure the best type is selected.
-    // The challenge step uses the intent doc to verify the top candidate is appropriate.
     const contextText = [context.goal, context.targetName].filter(Boolean).join(" ");
     let sorted = rankCandidates(candidates);
     const challengeLog = [];
@@ -659,18 +139,16 @@ export function selectPipelineNodeType(context) {
         const challenges = challengeCandidate(top, context, contextText);
         if (challenges.length > 0) {
             challengeLog.push(`Round ${round}: challenged "${top.nodeType}" (${top.displayName ?? top.family}) — ${challenges.join("; ")}`);
-            // Disqualify the top candidate and re-rank
             top.score = -Infinity;
             top.reasons.push(...challenges.map((c) => `CHALLENGED: ${c}`));
             sorted = rankCandidates(sorted);
         }
         else {
             challengeLog.push(`Round ${round}: "${top.nodeType}" (${top.displayName ?? top.family}) passed challenge`);
-            break; // Candidate passed — no need for another round
+            break;
         }
     }
     let selected = sorted[0] ?? null;
-    // Skip candidates that were disqualified
     if (selected && selected.score === -Infinity) {
         selected = sorted.find((c) => c.score > -Infinity) ?? null;
     }