co-maintainer 0.4.10 → 0.4.12

package/dist/package.json

@@ -1,6 +1,6 @@
 {
     "name": "co-maintainer",
-    "version": "0.4.10",
+    "version": "0.4.12",
     "description": "Analyzes a GitHub repository and writes repository-specific contribution guidance.",
     "license": "MIT",
     "repository": {

package/dist/src/github/collect.d.ts

@@ -1,6 +1,6 @@
 import type { GitHubClient, Options } from "../types.ts";
 import type { PullRequest, Source, State } from "../knowledge/types.ts";
-export declare function collectSource(client: GitHubClient, options: Options, previous?: State, progress?: (items: PullRequest[]) => Promise<void>, codebaseProgress?: (data: {
+export declare function collectSource(client: GitHubClient, options: Options, previous?: State, progress?: (items: PullRequest[], cache: PullRequest[]) => Promise<void>, codebaseProgress?: (data: {
     tree: string[];
     treeSha: Record<string, string>;
     files: Record<string, string>;

package/dist/src/github/collect.js

@@ -248,8 +248,10 @@ async function pullRequests(client, options, previous, phase, progress) {
     if (phase)
         phase.text = "listing pull requests · page 0 · fetched 0";
     const selected = await listPullRequestPages(client, options, phase);
-    const previousByNumber = new Map((previous?.source.pullRequests ?? []).map((pr) => [pr.number, pr]));
+    const keptByNumber = new Map((previous?.source.pullRequests ?? []).map((pr) => [pr.number, pr]));
+    const cacheByNumber = new Map((previous?.source.pullRequestCache ?? []).map((pr) => [pr.number, pr]));
     const result = new Array(selected.length);
+    const cache = new Array(selected.length);
     let completed = 0;
     let save = Promise.resolve();
     if (phase) {
@@ -258,7 +260,8 @@ async function pullRequests(client, options, previous, phase, progress) {
     log("fetch", `${selected.length} pull requests · concurrency=${options.ghConcurrent}`);
     await mapPool(selected, options.ghConcurrent, async (pr, index) => {
         const number = Number(pr.number);
-        const cached = previousByNumber.get(number);
+        const full = keptByNumber.get(number);
+        const cached = full ?? cacheByNumber.get(number);
         const listedAdditions = Number(pr.additions);
         const listedDeletions = Number(pr.deletions);
         const listedStatsAvailable = Number.isFinite(listedAdditions) &&
@@ -308,10 +311,12 @@ async function pullRequests(client, options, previous, phase, progress) {
             current.changesRequested = cached.changesRequested;
         }
         const only = options.onlyRequestChangedPr;
-        const discussionUnchanged = cached?.updatedAt === current.updatedAt;
+        const discussionUnchanged = full?.updatedAt === current.updatedAt;
         const decisionKnown = typeof cached?.changesRequested === "boolean";
-        const diffUnchanged = cached?.headSha === current.headSha && Boolean(cached?.diff);
-        let droppedFromCache = only && discussionUnchanged && cached?.changesRequested === false;
+        const diffUnchanged = full?.headSha === current.headSha && Boolean(full?.diff);
+        let droppedFromCache = only &&
+            cached?.updatedAt === current.updatedAt &&
+            cached.changesRequested === false;
         let dropped = droppedFromCache;
         const loadComments = async () => {
             const comments = await client.pages(`repos/${options.repo}/issues/${number}/comments`);
@@ -383,6 +388,7 @@ async function pullRequests(client, options, previous, phase, progress) {
                 current.diff = "";
             }
         }
+        cache[index] = current;
         if (!dropped)
             result[index] = current;
         completed++;
@@ -391,29 +397,82 @@ async function pullRequests(client, options, previous, phase, progress) {
         }
         log("fetch", `PR ${completed}/${selected.length} · ${percent(completed, selected.length)} #${number} · ${discussionStatus} · ${diffStatus}`);
         if (progress) {
-            save = save.then(() => progress(result.filter((item) => !!item)));
+            save = save.then(() => progress(result.filter((item) => !!item), cache.filter((item) => !!item)));
             await save;
         }
     });
     const kept = result.filter((item) => !!item);
+    const decided = cache.filter((item) => !!item);
     if (options.onlyRequestChangedPr) {
         log("fetch", `only request-changed pr · kept ${kept.length} · dropped ${selected.length - kept.length}`);
     }
-    return kept;
+    return { kept, cache: decided };
 }
-async function commits(client, options, meta, phase) {
+function commitLimit(maxCommits) {
+    return maxCommits && maxCommits > 0 ? maxCommits : undefined;
+}
+function commitsCovered(cached, previousMax, limit) {
+    if (cached.length === 0)
+        return false;
+    const previousAll = commitLimit(previousMax) === undefined;
+    if (limit === undefined)
+        return previousAll;
+    return previousAll || cached.length >= limit;
+}
+async function commits(client, options, meta, previous, phase) {
     const branch = String(meta.default_branch ?? "main");
-    const limit = options.maxCommits && options.maxCommits > 0
-        ? options.maxCommits
-        : undefined;
-    if (phase)
-        phase.text = "commit history · page 0 · fetched 0";
-    return client.pages(`repos/${options.repo}/commits?sha=${encodeURIComponent(branch)}`, limit, (page, fetched) => {
+    const limit = commitLimit(options.maxCommits);
+    const cached = previous?.source.commits ?? [];
+    const cachedTip = String(cached[0]?.sha ?? "");
+    const endpoint = `repos/${options.repo}/commits?sha=${encodeURIComponent(branch)}`;
+    const note = (page, fetched) => {
         const message = `commit history · page ${page} · fetched ${fetched} · total unknown`;
         if (phase)
             phase.text = message;
         log("fetch", message);
-    });
+    };
+    if (phase)
+        phase.text = "commit history · page 0 · fetched 0";
+    if (!cachedTip) {
+        return client.pages(endpoint, limit, note);
+    }
+    const fresh = [];
+    let found = false;
+    for (let page = 1;; page++) {
+        const pageItems = await client.request(`${endpoint}&per_page=100&page=${page}`);
+        const items = Array.isArray(pageItems) ? pageItems : [];
+        for (const commit of items) {
+            if (String(commit.sha ?? "") === cachedTip) {
+                found = true;
+                break;
+            }
+            fresh.push(commit);
+            if (limit !== undefined && fresh.length >= limit)
+                break;
+        }
+        note(page, fresh.length);
+        if (found ||
+            items.length < 100 ||
+            (limit !== undefined && fresh.length >= limit)) {
+            break;
+        }
+    }
+    if (!found || !commitsCovered(cached, previous?.options.maxCommits, limit)) {
+        if (found)
+            return client.pages(endpoint, limit, note);
+        return limit === undefined ? fresh : fresh.slice(0, limit);
+    }
+    const selected = [...fresh];
+    for (const commit of cached) {
+        if (limit !== undefined && selected.length >= limit)
+            break;
+        selected.push(commit);
+    }
+    const reused = selected.length - fresh.length;
+    if (reused > 0) {
+        log("fetch", `commit history · reused ${reused} cached commits · ${selected.length} total`);
+    }
+    return selected;
 }
 export async function collectSource(client, options, previous, progress, codebaseProgress) {
     const phase = { text: "reading repository metadata" };
@@ -426,16 +485,17 @@ export async function collectSource(client, options, previous, progress, codebas
             : { tree: [], treeSha: {}, files: {} };
         const pullRequestData = options.includePullRequests
             ? await pullRequests(client, options, previous, phase, progress)
-            : [];
+            : { kept: [], cache: previous?.source.pullRequestCache ?? [] };
         const commitData = options.includeCommitHistory
-            ? await commits(client, options, repo, phase)
+            ? await commits(client, options, repo, previous, phase)
             : [];
         return {
             repo,
             tree: files.tree,
             treeSha: files.treeSha,
             files: files.files,
-            pullRequests: pullRequestData,
+            pullRequests: pullRequestData.kept,
+            pullRequestCache: pullRequestData.cache,
             commits: commitData,
         };
     }

package/dist/src/knowledge/types.d.ts

@@ -23,7 +23,11 @@ export type Source = {
     tree: string[];
     treeSha: Record<string, string>;
     files: Record<string, string>;
+    /** Pull requests selected for facts and the skill. */
     pullRequests: PullRequest[];
+    /** Every pull request already decided, including ones left out of the skill.
+     * The next fetch reads this so a `changesRequested: false` result is not downloaded again. */
+    pullRequestCache?: PullRequest[];
     commits: Json[];
 };
 export type Fact = {

package/dist/src/knowledge/validate.d.ts

@@ -4,4 +4,4 @@ export type ValidationResult = {
     errors: string[];
     warnings: string[];
 };
-export declare function validateSkill(markdown: string, outputDirectory: string, source?: Source, referenceIssues?: "error" | "warning"): Promise<ValidationResult>;
+export declare function validateSkill(markdown: string, source?: Source, referenceIssues?: "error" | "warning"): Promise<ValidationResult>;

package/dist/src/knowledge/validate.js

@@ -1,5 +1,4 @@
-import { stat } from "../util/runtime.js";
-export async function validateSkill(markdown, outputDirectory, source, referenceIssues = "error") {
+export async function validateSkill(markdown, source, referenceIssues = "error") {
     const errors = [];
     const warnings = [];
     const referenceProblems = referenceIssues === "error" ? errors : warnings;
@@ -33,54 +32,6 @@ export async function validateSkill(markdown, outputDirectory, source, reference
     if (source) {
         const paths = new Set([...source.tree, ...Object.keys(source.files)]);
         const repositoryName = String(source.repo.full_name ?? "");
-        const commands = new Set();
-        for (const [path, content] of Object.entries(source.files)) {
-            if (path.endsWith("package.json")) {
-                try {
-                    const scripts = JSON.parse(content)
-                        .scripts ?? {};
-                    const prefix = source.tree.some((item) => /pnpm-lock\.yaml$/.test(item))
-                        ? "pnpm"
-                        : source.tree.some((item) => /yarn\.lock$/.test(item))
-                            ? "yarn"
-                            : "npm";
-                    for (const name of Object.keys(scripts)) {
-                        commands.add(`${prefix} ${name}`);
-                        commands.add(`${prefix} run ${name}`);
-                        commands.add(String(scripts[name]));
-                    }
-                }
-                catch {
-                    // Ignore malformed manifests; syntax validation is outside this gate.
-                }
-            }
-            if (/deno\.jsonc?$/.test(path)) {
-                try {
-                    const tasks = JSON.parse(content).tasks ??
-                        {};
-                    for (const [name, task] of Object.entries(tasks)) {
-                        commands.add(`deno task ${name}`);
-                        commands.add(String(task));
-                    }
-                }
-                catch {
-                    // Ignore malformed manifests; syntax validation is outside this gate.
-                }
-            }
-            for (const match of content.matchAll(/^\s*run:\s*([^\s#].*?)\s*$/gm)) {
-                commands.add(match[1].replace(/^['"]|['"]$/g, ""));
-            }
-            for (const match of content.matchAll(/`((?:npm|pnpm|yarn|bun|deno|cargo|make|go|python|node|git)\s+[^`\n]+)`/g)) {
-                commands.add(match[1]);
-            }
-            for (const match of content.matchAll(/^\s*((?:npm|pnpm|yarn|bun|deno|cargo|make|go|python|node|git)\s+[^\n`]+)$/gm)) {
-                commands.add(match[1].trim());
-            }
-        }
-        if (source.tree.some((path) => /Cargo\.toml$/.test(path))) {
-            commands.add("cargo test");
-            commands.add("cargo build");
-        }
         const references = [...markdown.matchAll(/`([^`\n]+)`/g)].map((match) => match[1]);
         for (const reference of references) {
             const isQualifier = /^[a-z][a-z\d_-]*:/i.test(reference);
@@ -109,27 +60,14 @@ export async function validateSkill(markdown, outputDirectory, source, reference
                     referenceProblems.push(`referenced path is absent from source: ${reference}`);
                 }
             }
-            if (/^(?:npm|pnpm|yarn|bun|deno|cargo|make|go|python|node|git)\s/.test(reference) &&
-                ![...commands].some((command) => reference === command ||
-                    reference.startsWith(`${command} `) ||
-                    command.startsWith(`${reference} `))) {
-                referenceProblems.push(`referenced command is absent from source: ${reference}`);
-            }
         }
     }
-    const links = [...markdown.matchAll(/\[[^\]]+\]\(([^)]+)\)/g)].map((match) => match[1]);
-    for (const link of links) {
-        if (/^[a-z][a-z\d+.-]*:/i.test(link) ||
-            link.startsWith("/") ||
-            link.includes("..")) {
-            errors.push(`link is not relative: ${link}`);
-            continue;
-        }
-        try {
-            await stat(`${outputDirectory}/${link}`);
-        }
-        catch {
-            errors.push(`linked file does not exist: ${link}`);
+    for (const link of markdown.matchAll(/\[[^\]]+\]\(([^)]+)\)/g)) {
+        const target = link[1];
+        if (/^[a-z][a-z\d+.-]*:/i.test(target) ||
+            target.startsWith("/") ||
+            target.includes("..")) {
+            errors.push(`link is not relative: ${target}`);
         }
     }
     return { valid: errors.length === 0, errors, warnings };

package/dist/src/services/setup.js

@@ -136,8 +136,9 @@ export async function runInitOrRemake(options) {
         log("ai", `${options.ai} providers configured · low=${options.lowModel} · high=${options.highModel}`);
     }
     log("fetch", `${options.repo} via ${options.auth}`);
-    const source = await timed("fetch repository data", options.logTime, () => collectSource(client, options, previous, async (pullRequests) => {
+    const source = await timed("fetch repository data", options.logTime, () => collectSource(client, options, previous, async (pullRequests, cache) => {
         checkpoint.source.pullRequests = pullRequests;
+        checkpoint.source.pullRequestCache = cache;
         checkpoint.scanDone = {
             ...checkpoint.scanDone,
             pullRequests: pullRequests.length,
@@ -204,19 +205,19 @@ export async function runInitOrRemake(options) {
     let result = await timed("assemble skill", options.logTime, () => assembleSkill(options.repo, facts, previousMarkdown, previous?.sectionHashes ?? {}, overrides));
     const reviewDocuments = buildReviewDocuments(facts);
     result.markdown = addReviewLink(result.markdown, reviewDocuments);
-    const validation = await timed("validate skill", options.logTime, () => validateSkill(result.markdown, `${reposDir()}/${options.repo}`, source));
+    const validation = await timed("validate skill", options.logTime, () => validateSkill(result.markdown, source));
     if (!validation.valid && Object.keys(overrides).length) {
         log("validate", `AI output rejected: ${validation.errors.join("; ")}`);
         overrides = {};
         result = await timed("reassemble valid skill", options.logTime, () => assembleSkill(options.repo, facts, previousMarkdown, previous?.sectionHashes ?? {}, overrides));
         result.markdown = addReviewLink(result.markdown, reviewDocuments);
     }
-    const finalValidation = await timed("final skill validation", options.logTime, () => validateSkill(result.markdown, `${reposDir()}/${options.repo}`, source, "warning"));
+    const finalValidation = await timed("final skill validation", options.logTime, () => validateSkill(result.markdown, source, "warning"));
     if (finalValidation.warnings.length) {
         log("validate", `stale references kept: ${finalValidation.warnings.join(", ")}`);
     }
     if (!finalValidation.valid) {
-        throw new Error(`generated skill is invalid: ${finalValidation.errors.join("; ")}`);
+        log("validate", `skill problems kept: ${finalValidation.errors.join("; ")}`);
     }
     await timed("write skill and state", options.logTime, async () => {
         const { withKnowledgeLock } = await import("../review/guides.js");

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "co-maintainer",
-  "version": "0.4.10",
+  "version": "0.4.12",
   "description": "Analyzes a GitHub repository and writes repository-specific contribution guidance.",
   "license": "MIT",
   "repository": {