cm-chessboard 4.1.6 → 4.1.10

package/README.md

@@ -34,7 +34,7 @@ aspects of chess games.
 
 **Option 2:** Download the code from [GitHub](https://github.com/shaack/cm-chessboard).
 
-**Option 3:** Use it via CDN https://cdn.jsdelivr.net/npm/cm-chessboard@4/src/cm-chessboard/Chessboard.js
+**Option 3:** Use it via CDN https://cdn.jsdelivr.net/npm/cm-chessboard@4.1/src/cm-chessboard/Chessboard.js
 
 After installation, copy the sprite in `cm-chessboard/assets/images/` to your projects `assets/images/`
 folder. If you put the sprite somewhere else you have to configure the location

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "cm-chessboard",
-  "version": "4.1.6",
+  "version": "4.1.10",
   "description": "A JavaScript chessboard which is lightweight, ES6 module based, responsive, SVG rendered and without dependencies.",
   "keywords": [
     "chess",

package/src/cm-chessboard/Chessboard.js

@@ -166,23 +166,10 @@ export class Chessboard {
     }
 
     removeMarkers(square = undefined, type = undefined) {
-        const index = square ? this.state.squareToIndex(square) : undefined
-        this.state.removeMarkers(index, type)
+        this.state.removeMarkers(square, type)
         this.view.drawMarkers()
     }
 
-    destroy() {
-        this.positionAnimationsQueue.destroy()
-        this.view.destroy()
-        this.view = undefined
-        this.state = undefined
-        if (this.squareSelectListener) {
-            this.context.removeEventListener("contextmenu", this.squareSelectListener)
-            this.context.removeEventListener("mouseup", this.squareSelectListener)
-            this.context.removeEventListener("touchend", this.squareSelectListener)
-        }
-    }
-
     enableMoveInput(eventHandler, color = undefined) {
         this.view.enableMoveInput(eventHandler, color)
     }
@@ -225,4 +212,17 @@ export class Chessboard {
         this.view.visualizeInputState()
     }
 
+    destroy() {
+        this.positionAnimationsQueue.destroy()
+        this.view.destroy()
+        this.view = undefined
+        this.state = undefined
+        if (this.squareSelectListener) {
+            this.context.removeEventListener("contextmenu", this.squareSelectListener)
+            this.context.removeEventListener("mouseup", this.squareSelectListener)
+            this.context.removeEventListener("touchend", this.squareSelectListener)
+        }
+        this.destroyed = true
+    }
+
 }

package/src/cm-chessboard/model/ChessboardState.js

@@ -49,7 +49,7 @@ export class ChessboardState {
             this.markers = []
         } else {
             this.markers = this.markers.filter((marker) => {
-                if (!marker.type) {
+                if (!type) {
                     if (square === marker.square) {
                         return false
                     }

package/src/cm-chessboard/view/ChessboardViewAccessible.js

@@ -113,12 +113,14 @@ export class ChessboardViewAccessible extends ChessboardView {
     redrawPieces(squares = this.chessboard.state.position.squares) {
         super.redrawPieces(squares)
         setTimeout(() => {
-            this.redrawPositionInAltAttribute()
-            if (this.chessboard.props.accessibility.boardAsTable) {
-                this.redrawBoardAsTable()
-            }
-            if (this.chessboard.props.accessibility.piecesAsList) {
-                this.redrawPiecesLists()
+            if(!this.chessboard.destroyed) {
+                this.redrawPositionInAltAttribute()
+                if (this.chessboard.props.accessibility.boardAsTable) {
+                    this.redrawBoardAsTable()
+                }
+                if (this.chessboard.props.accessibility.piecesAsList) {
+                    this.redrawPiecesLists()
+                }
             }
         })
     }

package/src/cm-chessboard/view/PositionAnimationsQueue.js

@@ -226,22 +226,26 @@ export class PositionAnimationsQueue extends PromiseQueue {
     }
 
     async enqueuePositionChange(positionFrom, positionTo, animated) {
-        return super.enqueue(() => new Promise((resolve) => {
-            let duration = animated ? this.chessboard.props.animationDuration : 0
-            if(this.queue.length > 0) {
-                duration = duration / (1 + Math.pow(this.queue.length / 5, 2))
-            }
-            // console.log("duration", duration, animated, "this.chessboard.props.animationDuration", this.chessboard.props.animationDuration)
-            new PositionsAnimation(this.chessboard.view,
-                positionFrom, positionTo, animated ? duration : 0,
-                () => {
-                    if(this.chessboard.view) { // if destroyed, no view anymore
-                        this.chessboard.view.redrawPieces(positionTo.squares)
-                    }
-                    resolve()
+        if(positionFrom.getFen() === positionTo.getFen()) {
+            return Promise.resolve()
+        } else {
+            return super.enqueue(() => new Promise((resolve) => {
+                let duration = animated ? this.chessboard.props.animationDuration : 0
+                if (this.queue.length > 0) {
+                    duration = duration / (1 + Math.pow(this.queue.length / 5, 2))
                 }
-            )
-        }))
+                // console.log("duration", duration, animated, "this.chessboard.props.animationDuration", this.chessboard.props.animationDuration)
+                new PositionsAnimation(this.chessboard.view,
+                    positionFrom, positionTo, animated ? duration : 0,
+                    () => {
+                        if (this.chessboard.view) { // if destroyed, no view anymore
+                            this.chessboard.view.redrawPieces(positionTo.squares)
+                        }
+                        resolve()
+                    }
+                )
+            }))
+        }
     }
 
     async enqueueTurnBoard(position, color, animated) {

package/test/TestMarkers.js

@@ -26,6 +26,15 @@ describe("TestMarkers", () => {
         assert.equals(chessboard.getMarkers("a4").length, 0)
         assert.equals(chessboard.getMarkers(undefined, MARKER_TYPE.frame).length, 2)
         assert.equals(chessboard.getMarkers("b6", MARKER_TYPE.frame).length, 1)
+        assert.equals(chessboard.getMarkers("h6", MARKER_TYPE.frame).length, 1)
+        chessboard.removeMarkers("h6")
+        assert.equals(chessboard.getMarkers("h6", MARKER_TYPE.frame).length, 0)
+        chessboard.addMarker("h6", MARKER_TYPE.frame)
+        assert.equals(chessboard.getMarkers("h6", MARKER_TYPE.frame).length, 1)
+        chessboard.removeMarkers("h6", MARKER_TYPE.square)
+        assert.equals(chessboard.getMarkers("h6", MARKER_TYPE.frame).length, 1)
+        chessboard.removeMarkers("h6", MARKER_TYPE.frame)
+        assert.equals(chessboard.getMarkers("h6", MARKER_TYPE.frame).length, 0)
         chessboard.destroy()
     })
 

package/docs/PositionsAnimation.md

@@ -1,11 +0,0 @@
-# Positions Queue
-
-- Extra Class
-- Holds the Queue
-- API 
-  - `isRunning(): boolean`
-  - `pushPosition(position, animated)`
-  - `run(): Promise` // starts the animation, callback when finished, if running : Promis
-  - `skip(callback): Promise` // skips all running steps, displays the last position and returns to callback
-- Positions are set immediately in the Model
-  - Then they are pushed into an Animations queue and run (if not running)

package/docs/PreMoves.md

@@ -1,3 +0,0 @@
-# Pre Moves
-
-- TODO