clud-bug 0.6.34 → 0.7.0-rc.11

package/dist/core/render.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"render.d.ts","sourceRoot":"","sources":["../../src/core/render.ts"],"names":[],"mappings":"AAwBA,MAAM,WAAW,cAAc;IAC7B,WAAW,EAAE,MAAM,CAAC;IACpB,gBAAgB,EAAE,MAAM,CAAC;IACzB,aAAa,EAAE,MAAM,CAAC;CACvB;AAWD,eAAO,MAAM,QAAQ,EAAE,cAItB,CAAC;AAOF,MAAM,MAAM,UAAU,GAAG,OAAO,CAAC,cAAc,CAAC,GAAG,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;AAM3E,wBAAgB,MAAM,CAAC,QAAQ,EAAE,MAAM,EAAE,IAAI,EAAE,UAAU,GAAG,MAAM,CAkBjE;AAED,wBAAsB,UAAU,CAAC,IAAI,EAAE,MAAM,EAAE,IAAI,EAAE,UAAU,GAAG,OAAO,CAAC,MAAM,CAAC,CAGhF;AAED,wBAAgB,YAAY,CAAC,SAAS,EAAE,MAAM,EAAE,GAAG,MAAM,CAQxD;AAKD,MAAM,MAAM,gBAAgB,GAAG,IAAI,GAAG,IAAI,GAAG,SAAS,CAAC;AAEvD,wBAAgB,gBAAgB,CAAC,QAAQ,EAAE,MAAM,GAAG,gBAAgB,CAInE"}

package/dist/core/render.js

@@ -0,0 +1,62 @@
+import { readFile } from 'node:fs/promises';
+import { serializedReviewSchema } from './review-schema.js';
+import { PKG_VERSION } from './version.js';
+const PLACEHOLDER_RE = /\{\{([A-Z_]+)\}\}/g;
+// Default values for substitution tokens that every template uses.
+// Callers can override per-render by passing the same key in `vars`.
+//
+// CCA_VERSION pins `anthropics/claude-code-action` to a specific tag in
+// every shipped workflow. Without this, templates resolved `@v1` (the
+// floating major), so upstream changes could silently land in installed
+// workflows mid-cycle. Bumping the pin requires a clud-bug release, which
+// makes the upgrade visible + lets users opt out by pinning a different
+// version in their own forked workflow.
+export const DEFAULTS = {
+    CCA_VERSION: 'v1.0.133',
+    CLUD_BUG_VERSION: PKG_VERSION,
+    REVIEW_SCHEMA: serializedReviewSchema(),
+};
+// Multi-line value substitution preserves YAML/Markdown indentation by
+// applying the placeholder line's leading whitespace to every
+// continuation line. Single-line values pass through unchanged so
+// existing tokens (CCA_VERSION, PROJECT_DESCRIPTION) keep current behavior.
+export function render(template, vars) {
+    const merged = { ...DEFAULTS, ...vars };
+    return template.replace(PLACEHOLDER_RE, (_match, key, offset) => {
+        if (!(key in merged)) {
+            throw new Error(`Missing template variable: ${key}`);
+        }
+        const value = String(merged[key]);
+        if (!value.includes('\n')) {
+            return value;
+        }
+        const lineStart = template.lastIndexOf('\n', offset - 1) + 1;
+        const leadingWhitespaceMatch = template.slice(lineStart, offset).match(/^(\s*)/);
+        const indent = leadingWhitespaceMatch ? (leadingWhitespaceMatch[1] ?? '') : '';
+        return value
+            .split('\n')
+            .map((line, i) => (i === 0 || line === '' ? line : indent + line))
+            .join('\n');
+    });
+}
+export async function renderFile(path, vars) {
+    const tmpl = await readFile(path, 'utf8');
+    return render(tmpl, vars);
+}
+export function pickTemplate(languages) {
+    if (languages.includes('typescript') || languages.includes('javascript')) {
+        return 'workflow-ts.yml.tmpl';
+    }
+    if (languages.includes('python')) {
+        return 'workflow-py.yml.tmpl';
+    }
+    return 'workflow.yml.tmpl';
+}
+export function templateLanguage(tmplName) {
+    if (tmplName === 'workflow-ts.yml.tmpl')
+        return 'ts';
+    if (tmplName === 'workflow-py.yml.tmpl')
+        return 'py';
+    return 'generic';
+}
+//# sourceMappingURL=render.js.map

package/dist/core/render.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"render.js","sourceRoot":"","sources":["../../src/core/render.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,MAAM,kBAAkB,CAAC;AAC5C,OAAO,EAAE,sBAAsB,EAAE,MAAM,oBAAoB,CAAC;AAC5D,OAAO,EAAE,WAAW,EAAE,MAAM,cAAc,CAAC;AAE3C,MAAM,cAAc,GAAG,oBAAoB,CAAC;AA0B5C,mEAAmE;AACnE,qEAAqE;AACrE,EAAE;AACF,wEAAwE;AACxE,sEAAsE;AACtE,wEAAwE;AACxE,0EAA0E;AAC1E,wEAAwE;AACxE,wCAAwC;AACxC,MAAM,CAAC,MAAM,QAAQ,GAAmB;IACtC,WAAW,EAAE,UAAU;IACvB,gBAAgB,EAAE,WAAW;IAC7B,aAAa,EAAE,sBAAsB,EAAE;CACxC,CAAC;AASF,uEAAuE;AACvE,8DAA8D;AAC9D,kEAAkE;AAClE,4EAA4E;AAC5E,MAAM,UAAU,MAAM,CAAC,QAAgB,EAAE,IAAgB;IACvD,MAAM,MAAM,GAA4B,EAAE,GAAG,QAAQ,EAAE,GAAG,IAAI,EAAE,CAAC;IACjE,OAAO,QAAQ,CAAC,OAAO,CAAC,cAAc,EAAE,CAAC,MAAM,EAAE,GAAW,EAAE,MAAc,EAAE,EAAE;QAC9E,IAAI,CAAC,CAAC,GAAG,IAAI,MAAM,CAAC,EAAE,CAAC;YACrB,MAAM,IAAI,KAAK,CAAC,8BAA8B,GAAG,EAAE,CAAC,CAAC;QACvD,CAAC;QACD,MAAM,KAAK,GAAG,MAAM,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC,CAAC;QAClC,IAAI,CAAC,KAAK,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE,CAAC;YAC1B,OAAO,KAAK,CAAC;QACf,CAAC;QACD,MAAM,SAAS,GAAG,QAAQ,CAAC,WAAW,CAAC,IAAI,EAAE,MAAM,GAAG,CAAC,CAAC,GAAG,CAAC,CAAC;QAC7D,MAAM,sBAAsB,GAAG,QAAQ,CAAC,KAAK,CAAC,SAAS,EAAE,MAAM,CAAC,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC;QACjF,MAAM,MAAM,GAAG,sBAAsB,CAAC,CAAC,CAAC,CAAC,sBAAsB,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;QAC/E,OAAO,KAAK;aACT,KAAK,CAAC,IAAI,CAAC;aACX,GAAG,CAAC,CAAC,IAAI,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,KAAK,CAAC,IAAI,IAAI,KAAK,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,MAAM,GAAG,IAAI,CAAC,CAAC;aACjE,IAAI,CAAC,IAAI,CAAC,CAAC;IAChB,CAAC,CAAC,CAAC;AACL,CAAC;AAED,MAAM,CAAC,KAAK,UAAU,UAAU,CAAC,IAAY,EAAE,IAAgB;IAC7D,MAAM,IAAI,GAAG,MAAM,QAAQ,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC;IAC1C,OAAO,MAAM,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;AAC5B,CAAC;AAED,MAAM,UAAU,YAAY,CAAC,SAAmB;IAC9C,IAAI,SAAS,CAAC,QAAQ,CAAC,YAAY,CAAC,IAAI,SAAS,CAAC,QAAQ,CAAC,YAAY,CAAC,EAAE,CAAC;QACzE,OAAO,sBAAsB,CAAC;IAChC,CAAC;IACD,IAAI,SAAS,CAAC,QAAQ,CAAC,QAAQ,CAAC,EAAE,CAAC;QACjC,OAAO,sBAAsB,CAAC;IAChC,CAAC;IACD,OAAO,mBAAmB,CAAC;AAC7B,CAAC;AAOD,MAAM,UAAU,gBAAgB,CAAC,QAAgB;IAC/C,IAAI,QAAQ,KAAK,sBAAsB;QAAE,OAAO,IAAI,CAAC;IACrD,IAAI,QAAQ,KAAK,sBAAsB;QAAE,OAAO,IAAI,CAAC;IACrD,OAAO,SAAS,CAAC;AACnB,CAAC"}

package/dist/core/resolve-verifier.d.ts

@@ -0,0 +1,46 @@
+import type { PriorFinding, VerifyOutcome } from './auto-resolve.js';
+export declare const VERIFIER_SYSTEM: string;
+export interface VerifySingleFindingInput {
+    finding: PriorFinding;
+    /** Code at the finding's anchor BEFORE the fix-push. Empty when deleted. */
+    codeBefore: string;
+    /** Code at the finding's anchor AFTER the fix-push. Empty when deleted. */
+    codeAfter: string;
+    /** Optional: unified-diff hunk at the anchor. */
+    diffAtAnchor?: string;
+}
+/**
+ * Builds the user-facing prompt body.
+ *
+ * Prompt-injection defense:
+ *   - System prompt is module-scope, NOT derived from user content.
+ *   - User content (finding body, code, diff) is wrapped in fence-
+ *     delimited blocks with clear labels. The model knows the
+ *     boundaries.
+ *   - Output is parsed with `parseVerifierResponse` which validates
+ *     the verdict against a fixed enum + caps rationale at 500 chars.
+ *     A model coerced to emit "ADDRESSED!" outside the JSON shape
+ *     gets routed to UNCERTAIN+api-error (fail-closed).
+ */
+export declare function buildVerifierPrompt(input: VerifySingleFindingInput): string;
+/**
+ * Parses the model's text response into a `VerifyOutcome`. Fail-closed:
+ * any malformed input → UNCERTAIN+api-error with the failure mode in
+ * the rationale, so the caller's auto-resolve rules route through
+ * human review (never silently ADDRESSED).
+ *
+ * Tolerates:
+ *   - Leading/trailing whitespace
+ *   - The model wrapping the JSON in ```json fences (strips them)
+ *   - Extra fields (ignored)
+ *
+ * Rejects:
+ *   - Empty / non-string input
+ *   - Non-JSON / malformed JSON
+ *   - Missing or non-string `verdict`
+ *   - `verdict` not in the allowed enum
+ *   - Missing or empty `rationale`
+ *   - `rationale` longer than 500 chars (caps at 500 in the outcome)
+ */
+export declare function parseVerifierResponse(text: unknown): VerifyOutcome;
+//# sourceMappingURL=resolve-verifier.d.ts.map

package/dist/core/resolve-verifier.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"resolve-verifier.d.ts","sourceRoot":"","sources":["../../src/core/resolve-verifier.ts"],"names":[],"mappings":"AAuBA,OAAO,KAAK,EAAE,YAAY,EAAE,aAAa,EAAE,MAAM,mBAAmB,CAAC;AAMrE,eAAO,MAAM,eAAe,QA6BhB,CAAC;AAMb,MAAM,WAAW,wBAAwB;IACvC,OAAO,EAAE,YAAY,CAAC;IACtB,4EAA4E;IAC5E,UAAU,EAAE,MAAM,CAAC;IACnB,2EAA2E;IAC3E,SAAS,EAAE,MAAM,CAAC;IAClB,iDAAiD;IACjD,YAAY,CAAC,EAAE,MAAM,CAAC;CACvB;AAMD;;;;;;;;;;;;GAYG;AACH,wBAAgB,mBAAmB,CAAC,KAAK,EAAE,wBAAwB,GAAG,MAAM,CA4C3E;AAMD;;;;;;;;;;;;;;;;;;GAkBG;AACH,wBAAgB,qBAAqB,CAAC,IAAI,EAAE,OAAO,GAAG,aAAa,CAmElE"}

package/dist/core/resolve-verifier.js

@@ -0,0 +1,187 @@
+// Wave 5b — D.2.6 per-thread fix-verifier prompt + response parser.
+//
+// On every fix-push, the CLI verb asks Claude DIRECTLY for each prior
+// thread: "the prior reviewer said X. Here is the BEFORE / AFTER /
+// DIFF. Did the new commit address the original finding?" Verdicts:
+//
+//   ADDRESSED      — fix unambiguously resolves the original concern
+//   NOT_ADDRESSED  — original concern still applies
+//   UNCERTAIN      — can't tell; routes through human review
+//
+// This module is PURE — prompt builder + response parser. The actual
+// Anthropic Messages API call lives in `src/cli/main.ts::runResolveThreads`
+// (raw `fetch()` — no `@anthropic-ai/sdk` dep so the npm package stays
+// dep-light). Tests inject mocked verifier outcomes via the
+// `runAutoResolve` `verifier` callback in `./auto-resolve`.
+//
+// Ported from `clud-bug-app/lib/resolve-verifier.ts:162-260`. Differences:
+//   - No `@ai-sdk/anthropic` / `zod` dependency. Response parsing is
+//     hand-rolled JSON extraction with manual validation.
+//   - DROP `verifySingleFinding` (App-side IO entry point). The CLI
+//     verb owns the API call directly.
+//   - DROP `aggregateMultiPassVerdicts` — OSS is single-pass.
+// ---------------------------------------------------------------------------
+// System prompt — hard-coded, NOT derived from user content (anti-injection)
+// ---------------------------------------------------------------------------
+export const VERIFIER_SYSTEM = [
+    'You are a code-review fix verifier. Your only job is to decide whether a',
+    'specific code change addressed a specific prior reviewer concern.',
+    '',
+    'You are NOT writing a new code review. You are NOT looking for new issues.',
+    'You are NOT judging style. You are answering one question: did the change',
+    'between BEFORE and AFTER resolve the concern raised in the prior finding?',
+    '',
+    'Your verdict MUST be exactly one of: ADDRESSED, NOT_ADDRESSED, UNCERTAIN.',
+    '',
+    'Rules:',
+    '- ADDRESSED: the AFTER code unambiguously resolves the original concern.',
+    '  Partial fixes that leave the core problem unsolved are NOT ADDRESSED.',
+    '- NOT_ADDRESSED: the AFTER code still has the original problem, OR the',
+    '  change is unrelated to the concern, OR the change made the problem worse.',
+    '- UNCERTAIN: you cannot tell from the BEFORE / AFTER alone. Use this when',
+    '  the context is too narrow, the change is subtle and could go either way,',
+    '  or the concern depends on code you cannot see. Never guess — say',
+    '  UNCERTAIN when you would be guessing.',
+    '',
+    'Treat the prior finding as a black box: it might be wrong, but you are not',
+    'judging the finding. You are judging whether the new code resolves what it',
+    'said. If the finding asked for X and the change does X, mark ADDRESSED even',
+    'if X is unnecessary.',
+    '',
+    'Reply with a JSON object on a single line, no markdown fence, no surrounding',
+    'prose. Shape:',
+    '  {"verdict":"ADDRESSED"|"NOT_ADDRESSED"|"UNCERTAIN","rationale":"<one sentence>"}',
+    'Rationale MUST be one sentence, max 500 characters.',
+].join('\n');
+// ---------------------------------------------------------------------------
+// Prompt builder — pure (no env, no Date.now, no timestamps)
+// ---------------------------------------------------------------------------
+/**
+ * Builds the user-facing prompt body.
+ *
+ * Prompt-injection defense:
+ *   - System prompt is module-scope, NOT derived from user content.
+ *   - User content (finding body, code, diff) is wrapped in fence-
+ *     delimited blocks with clear labels. The model knows the
+ *     boundaries.
+ *   - Output is parsed with `parseVerifierResponse` which validates
+ *     the verdict against a fixed enum + caps rationale at 500 chars.
+ *     A model coerced to emit "ADDRESSED!" outside the JSON shape
+ *     gets routed to UNCERTAIN+api-error (fail-closed).
+ */
+export function buildVerifierPrompt(input) {
+    const f = input.finding;
+    const anchor = f.line !== undefined ? `${f.file}:${f.line}` : f.file;
+    const sev = f.severity === 'critical' ? '🔴 critical' : '🟡 minor';
+    const parts = [];
+    parts.push(`A prior code review (skill: \`${f.skill}\`, severity: ${sev}) flagged \`${anchor}\` with this finding:`);
+    parts.push('');
+    parts.push('```');
+    parts.push('PRIOR FINDING:');
+    parts.push(f.body);
+    parts.push('```');
+    parts.push('');
+    parts.push('The PR author has since pushed a new commit. Here is the code BEFORE and AFTER:');
+    parts.push('');
+    parts.push('```');
+    parts.push('BEFORE:');
+    parts.push(input.codeBefore || '(empty — file did not exist or was empty)');
+    parts.push('```');
+    parts.push('');
+    parts.push('```');
+    parts.push('AFTER:');
+    parts.push(input.codeAfter || '(empty — file was deleted or emptied)');
+    parts.push('```');
+    if (input.diffAtAnchor) {
+        parts.push('');
+        parts.push('```');
+        parts.push('DIFF AT ANCHOR:');
+        parts.push(input.diffAtAnchor);
+        parts.push('```');
+    }
+    parts.push('');
+    parts.push('Did this change ADDRESS the original finding?');
+    parts.push('Reply with the JSON object only — single line, no markdown fence, no prose.');
+    return parts.join('\n');
+}
+// ---------------------------------------------------------------------------
+// Response parser — extracts `{verdict, rationale}` from the model text
+// ---------------------------------------------------------------------------
+/**
+ * Parses the model's text response into a `VerifyOutcome`. Fail-closed:
+ * any malformed input → UNCERTAIN+api-error with the failure mode in
+ * the rationale, so the caller's auto-resolve rules route through
+ * human review (never silently ADDRESSED).
+ *
+ * Tolerates:
+ *   - Leading/trailing whitespace
+ *   - The model wrapping the JSON in ```json fences (strips them)
+ *   - Extra fields (ignored)
+ *
+ * Rejects:
+ *   - Empty / non-string input
+ *   - Non-JSON / malformed JSON
+ *   - Missing or non-string `verdict`
+ *   - `verdict` not in the allowed enum
+ *   - Missing or empty `rationale`
+ *   - `rationale` longer than 500 chars (caps at 500 in the outcome)
+ */
+export function parseVerifierResponse(text) {
+    if (typeof text !== 'string' || !text.trim()) {
+        return {
+            verdict: 'UNCERTAIN',
+            source: 'api-error',
+            rationale: 'verifier returned empty or non-string response',
+        };
+    }
+    // Strip optional ```json … ``` or ``` … ``` fence.
+    let body = text.trim();
+    const fenced = body.match(/^```(?:json)?\s*\n?([\s\S]*?)\n?```$/);
+    if (fenced)
+        body = fenced[1].trim();
+    let parsed;
+    try {
+        parsed = JSON.parse(body);
+    }
+    catch (err) {
+        return {
+            verdict: 'UNCERTAIN',
+            source: 'api-error',
+            rationale: `verifier response was not valid JSON: ${err instanceof Error ? err.message : String(err)}`,
+        };
+    }
+    if (!parsed || typeof parsed !== 'object' || Array.isArray(parsed)) {
+        return {
+            verdict: 'UNCERTAIN',
+            source: 'api-error',
+            rationale: 'verifier response was not a JSON object',
+        };
+    }
+    const obj = parsed;
+    const verdict = obj.verdict;
+    const rationale = obj.rationale;
+    if (verdict !== 'ADDRESSED' &&
+        verdict !== 'NOT_ADDRESSED' &&
+        verdict !== 'UNCERTAIN') {
+        return {
+            verdict: 'UNCERTAIN',
+            source: 'api-error',
+            rationale: `verifier emitted unknown verdict: ${JSON.stringify(verdict)}`,
+        };
+    }
+    if (typeof rationale !== 'string' || !rationale.trim()) {
+        return {
+            verdict: 'UNCERTAIN',
+            source: 'api-error',
+            rationale: 'verifier response missing rationale',
+        };
+    }
+    // Cap rationale at 500 chars per the system prompt's contract.
+    const trimmed = rationale.trim().slice(0, 500);
+    return {
+        verdict,
+        rationale: trimmed,
+        source: 'model',
+    };
+}
+//# sourceMappingURL=resolve-verifier.js.map

package/dist/core/resolve-verifier.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"resolve-verifier.js","sourceRoot":"","sources":["../../src/core/resolve-verifier.ts"],"names":[],"mappings":"AAAA,oEAAoE;AACpE,EAAE;AACF,sEAAsE;AACtE,mEAAmE;AACnE,oEAAoE;AACpE,EAAE;AACF,qEAAqE;AACrE,oDAAoD;AACpD,6DAA6D;AAC7D,EAAE;AACF,qEAAqE;AACrE,4EAA4E;AAC5E,uEAAuE;AACvE,4DAA4D;AAC5D,4DAA4D;AAC5D,EAAE;AACF,2EAA2E;AAC3E,qEAAqE;AACrE,0DAA0D;AAC1D,oEAAoE;AACpE,uCAAuC;AACvC,8DAA8D;AAI9D,8EAA8E;AAC9E,6EAA6E;AAC7E,8EAA8E;AAE9E,MAAM,CAAC,MAAM,eAAe,GAAG;IAC7B,0EAA0E;IAC1E,mEAAmE;IACnE,EAAE;IACF,4EAA4E;IAC5E,2EAA2E;IAC3E,2EAA2E;IAC3E,EAAE;IACF,2EAA2E;IAC3E,EAAE;IACF,QAAQ;IACR,0EAA0E;IAC1E,yEAAyE;IACzE,wEAAwE;IACxE,6EAA6E;IAC7E,2EAA2E;IAC3E,4EAA4E;IAC5E,oEAAoE;IACpE,yCAAyC;IACzC,EAAE;IACF,4EAA4E;IAC5E,4EAA4E;IAC5E,6EAA6E;IAC7E,sBAAsB;IACtB,EAAE;IACF,8EAA8E;IAC9E,eAAe;IACf,oFAAoF;IACpF,qDAAqD;CACtD,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AAgBb,8EAA8E;AAC9E,6DAA6D;AAC7D,8EAA8E;AAE9E;;;;;;;;;;;;GAYG;AACH,MAAM,UAAU,mBAAmB,CAAC,KAA+B;IACjE,MAAM,CAAC,GAAG,KAAK,CAAC,OAAO,CAAC;IACxB,MAAM,MAAM,GAAG,CAAC,CAAC,IAAI,KAAK,SAAS,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,IAAI,IAAI,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;IACrE,MAAM,GAAG,GAAG,CAAC,CAAC,QAAQ,KAAK,UAAU,CAAC,CAAC,CAAC,aAAa,CAAC,CAAC,CAAC,UAAU,CAAC;IAEnE,MAAM,KAAK,GAAa,EAAE,CAAC;IAC3B,KAAK,CAAC,IAAI,CACR,iCAAiC,CAAC,CAAC,KAAK,iBAAiB,GAAG,eAAe,MAAM,uBAAuB,CACzG,CAAC;IACF,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IACf,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IAClB,KAAK,CAAC,IAAI,CAAC,gBAAgB,CAAC,CAAC;IAC7B,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;IACnB,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IAClB,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IACf,KAAK,CAAC,IAAI,CACR,iFAAiF,CAClF,CAAC;IACF,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IACf,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IAClB,KAAK,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;IACtB,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,UAAU,IAAI,2CAA2C,CAAC,CAAC;IAC5E,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IAClB,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IACf,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IAClB,KAAK,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;IACrB,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,SAAS,IAAI,uCAAuC,CAAC,CAAC;IACvE,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IAElB,IAAI,KAAK,CAAC,YAAY,EAAE,CAAC;QACvB,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QACf,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAClB,KAAK,CAAC,IAAI,CAAC,iBAAiB,CAAC,CAAC;QAC9B,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,YAAY,CAAC,CAAC;QAC/B,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IACpB,CAAC;IAED,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IACf,KAAK,CAAC,IAAI,CAAC,+CAA+C,CAAC,CAAC;IAC5D,KAAK,CAAC,IAAI,CACR,6EAA6E,CAC9E,CAAC;IAEF,OAAO,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AAC1B,CAAC;AAED,8EAA8E;AAC9E,wEAAwE;AACxE,8EAA8E;AAE9E;;;;;;;;;;;;;;;;;;GAkBG;AACH,MAAM,UAAU,qBAAqB,CAAC,IAAa;IACjD,IAAI,OAAO,IAAI,KAAK,QAAQ,IAAI,CAAC,IAAI,CAAC,IAAI,EAAE,EAAE,CAAC;QAC7C,OAAO;YACL,OAAO,EAAE,WAAW;YACpB,MAAM,EAAE,WAAW;YACnB,SAAS,EAAE,gDAAgD;SAC5D,CAAC;IACJ,CAAC;IAED,mDAAmD;IACnD,IAAI,IAAI,GAAG,IAAI,CAAC,IAAI,EAAE,CAAC;IACvB,MAAM,MAAM,GAAG,IAAI,CAAC,KAAK,CAAC,sCAAsC,CAAC,CAAC;IAClE,IAAI,MAAM;QAAE,IAAI,GAAG,MAAM,CAAC,CAAC,CAAE,CAAC,IAAI,EAAE,CAAC;IAErC,IAAI,MAAe,CAAC;IACpB,IAAI,CAAC;QACH,MAAM,GAAG,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IAC5B,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,OAAO;YACL,OAAO,EAAE,WAAW;YACpB,MAAM,EAAE,WAAW;YACnB,SAAS,EAAE,yCACT,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,GAAG,CACjD,EAAE;SACH,CAAC;IACJ,CAAC;IAED,IAAI,CAAC,MAAM,IAAI,OAAO,MAAM,KAAK,QAAQ,IAAI,KAAK,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,CAAC;QACnE,OAAO;YACL,OAAO,EAAE,WAAW;YACpB,MAAM,EAAE,WAAW;YACnB,SAAS,EAAE,yCAAyC;SACrD,CAAC;IACJ,CAAC;IAED,MAAM,GAAG,GAAG,MAAiC,CAAC;IAC9C,MAAM,OAAO,GAAG,GAAG,CAAC,OAAO,CAAC;IAC5B,MAAM,SAAS,GAAG,GAAG,CAAC,SAAS,CAAC;IAEhC,IACE,OAAO,KAAK,WAAW;QACvB,OAAO,KAAK,eAAe;QAC3B,OAAO,KAAK,WAAW,EACvB,CAAC;QACD,OAAO;YACL,OAAO,EAAE,WAAW;YACpB,MAAM,EAAE,WAAW;YACnB,SAAS,EAAE,qCAAqC,IAAI,CAAC,SAAS,CAAC,OAAO,CAAC,EAAE;SAC1E,CAAC;IACJ,CAAC;IAED,IAAI,OAAO,SAAS,KAAK,QAAQ,IAAI,CAAC,SAAS,CAAC,IAAI,EAAE,EAAE,CAAC;QACvD,OAAO;YACL,OAAO,EAAE,WAAW;YACpB,MAAM,EAAE,WAAW;YACnB,SAAS,EAAE,qCAAqC;SACjD,CAAC;IACJ,CAAC;IAED,+DAA+D;IAC/D,MAAM,OAAO,GAAG,SAAS,CAAC,IAAI,EAAE,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC,CAAC;IAE/C,OAAO;QACL,OAAO;QACP,SAAS,EAAE,OAAO;QAClB,MAAM,EAAE,OAAO;KAChB,CAAC;AACJ,CAAC"}

package/dist/core/review-schema-zod.d.ts

@@ -0,0 +1,240 @@
+import { z } from 'zod';
+export declare const severityValues: readonly ["critical", "minor", "preexisting"];
+export declare const severitySchema: z.ZodEnum<{
+    critical: "critical";
+    minor: "minor";
+    preexisting: "preexisting";
+}>;
+export type Severity = z.infer<typeof severitySchema>;
+export declare const statusHeaderValues: readonly ["critical findings", "clean", "bare"];
+export declare const statusHeaderSchema: z.ZodEnum<{
+    "critical findings": "critical findings";
+    clean: "clean";
+    bare: "bare";
+}>;
+export type StatusHeader = z.infer<typeof statusHeaderSchema>;
+export declare const summaryCountsSchema: z.ZodObject<{
+    critical: z.ZodNumber;
+    minor: z.ZodNumber;
+    preexisting: z.ZodNumber;
+    resolved_from_prior: z.ZodNumber;
+    still_open: z.ZodNumber;
+}, z.core.$strip>;
+export type SummaryCounts = z.infer<typeof summaryCountsSchema>;
+/**
+ * Wire-shape finding item — NO severity field (mirrors the CLI's
+ * `FINDING_ITEM` JSON Schema in `./review-schema.ts`). Severity is implicit
+ * in which array the item lives in (`critical_findings`/`minor_findings`/
+ * `preexisting_findings`).
+ */
+export declare const findingItemSchema: z.ZodObject<{
+    skill: z.ZodString;
+    file: z.ZodOptional<z.ZodString>;
+    line: z.ZodOptional<z.ZodNumber>;
+    summary: z.ZodString;
+    reasoning: z.ZodOptional<z.ZodString>;
+}, z.core.$strip>;
+export type FindingItem = z.infer<typeof findingItemSchema>;
+/** Per-skill scan report — one entry per loaded skill (even silent ones). */
+export declare const perSkillScanItemSchema: z.ZodObject<{
+    skill: z.ZodString;
+    outcome: z.ZodString;
+}, z.core.$strip>;
+export type PerSkillScanItem = z.infer<typeof perSkillScanItemSchema>;
+/** Dedicated-section block for `review_mode: dedicated` skills. */
+export declare const dedicatedSectionSchema: z.ZodObject<{
+    section_name: z.ZodString;
+    skill: z.ZodString;
+    findings: z.ZodArray<z.ZodObject<{
+        skill: z.ZodString;
+        file: z.ZodOptional<z.ZodString>;
+        line: z.ZodOptional<z.ZodNumber>;
+        summary: z.ZodString;
+        reasoning: z.ZodOptional<z.ZodString>;
+    }, z.core.$strip>>;
+}, z.core.$strip>;
+export type DedicatedSection = z.infer<typeof dedicatedSectionSchema>;
+/**
+ * Full review payload — wire shape. The model produces this; the App
+ * orchestrator immediately flattens to the internal `Finding[]` shape via
+ * `flattenFindings()` for multi-pass + aggregator work, then unflattens
+ * back via `unflattenFindings()` before writeback.
+ */
+export declare const reviewSchema: z.ZodObject<{
+    status_header: z.ZodEnum<{
+        "critical findings": "critical findings";
+        clean: "clean";
+        bare: "bare";
+    }>;
+    summary_counts: z.ZodObject<{
+        critical: z.ZodNumber;
+        minor: z.ZodNumber;
+        preexisting: z.ZodNumber;
+        resolved_from_prior: z.ZodNumber;
+        still_open: z.ZodNumber;
+    }, z.core.$strip>;
+    per_skill_scan: z.ZodArray<z.ZodObject<{
+        skill: z.ZodString;
+        outcome: z.ZodString;
+    }, z.core.$strip>>;
+    critical_findings: z.ZodArray<z.ZodObject<{
+        skill: z.ZodString;
+        file: z.ZodOptional<z.ZodString>;
+        line: z.ZodOptional<z.ZodNumber>;
+        summary: z.ZodString;
+        reasoning: z.ZodOptional<z.ZodString>;
+    }, z.core.$strip>>;
+    minor_findings: z.ZodArray<z.ZodObject<{
+        skill: z.ZodString;
+        file: z.ZodOptional<z.ZodString>;
+        line: z.ZodOptional<z.ZodNumber>;
+        summary: z.ZodString;
+        reasoning: z.ZodOptional<z.ZodString>;
+    }, z.core.$strip>>;
+    preexisting_findings: z.ZodArray<z.ZodObject<{
+        skill: z.ZodString;
+        file: z.ZodOptional<z.ZodString>;
+        line: z.ZodOptional<z.ZodNumber>;
+        summary: z.ZodString;
+        reasoning: z.ZodOptional<z.ZodString>;
+    }, z.core.$strip>>;
+    dedicated_sections: z.ZodOptional<z.ZodArray<z.ZodObject<{
+        section_name: z.ZodString;
+        skill: z.ZodString;
+        findings: z.ZodArray<z.ZodObject<{
+            skill: z.ZodString;
+            file: z.ZodOptional<z.ZodString>;
+            line: z.ZodOptional<z.ZodNumber>;
+            summary: z.ZodString;
+            reasoning: z.ZodOptional<z.ZodString>;
+        }, z.core.$strip>>;
+    }, z.core.$strip>>>;
+    diagnostics: z.ZodOptional<z.ZodArray<z.ZodString>>;
+    skills_referenced: z.ZodArray<z.ZodString>;
+    last_reviewed_sha: z.ZodString;
+}, z.core.$strip>;
+export type Review = z.infer<typeof reviewSchema>;
+/**
+ * Internal flat-finding type used by App orchestrator, multi-pass
+ * aggregator, skill-usage telemetry, etc. Created from a wire-shape
+ * `Review` via `flattenFindings()`. Has explicit `severity` field so
+ * internal code doesn't need to track which array a finding came from.
+ *
+ * Exported from the core barrel as `ZodFinding` to disambiguate from
+ * the CLI-shape `ReviewFinding` (which never carries severity — its
+ * severity comes from the array it lives in).
+ */
+export type Finding = FindingItem & {
+    severity: Severity;
+};
+/**
+ * Zod schema describing the internal Finding shape (for tests + cross-check
+ * Pass 2 independentFindings). The wire equivalent is `findingItemSchema`
+ * which does NOT have severity.
+ */
+export declare const findingSchema: z.ZodObject<{
+    skill: z.ZodString;
+    file: z.ZodOptional<z.ZodString>;
+    line: z.ZodOptional<z.ZodNumber>;
+    summary: z.ZodString;
+    reasoning: z.ZodOptional<z.ZodString>;
+    severity: z.ZodEnum<{
+        critical: "critical";
+        minor: "minor";
+        preexisting: "preexisting";
+    }>;
+}, z.core.$strip>;
+/**
+ * Flatten wire-shape `Review.critical_findings / minor_findings /
+ * preexisting_findings` into a single `Finding[]` with severity tagged.
+ * Preserves ordering: criticals first, then minors, then preexistings.
+ */
+export declare function flattenFindings(review: Review): Finding[];
+/**
+ * Inverse of `flattenFindings`: split a flat `Finding[]` back into the
+ * three wire-shape arrays. Used at writeback time after multi-pass
+ * aggregation has produced the final flat list.
+ */
+export declare function unflattenFindings(findings: Finding[]): {
+    critical_findings: FindingItem[];
+    minor_findings: FindingItem[];
+    preexisting_findings: FindingItem[];
+};
+/**
+ * Derive `summary_counts` from a flat `Finding[]` list. Canonical
+ * source-of-truth used by the orchestrator after flattening, to
+ * overwrite the model's potentially-drifted counts.
+ */
+export declare function deriveSummaryCounts(findings: Finding[]): SummaryCounts;
+/**
+ * Derive `skills_referenced` from a flat `Finding[]` list, preserving
+ * citation order (first appearance wins) and deduplicating.
+ */
+export declare function deriveSkillsReferenced(findings: Finding[]): string[];
+/**
+ * Test helper: build a wire-shape `Review` from a flat `Finding[]` list.
+ * Tests historically built reviews with a flat `findings: [...]` field; the
+ * wire shape (separate severity arrays + per_skill_scan + last_reviewed_sha
+ * required) is more verbose. This helper keeps fixtures short — pass a
+ * flat list, get back a valid wire-shape Review with derived counts and
+ * skills.
+ *
+ * Production code should NOT use this; it constructs reviews from AI output
+ * directly. This is purely for test ergonomics.
+ */
+export declare function buildReviewFromFindings(opts: {
+    findings: Finding[];
+    status_header?: StatusHeader;
+    last_reviewed_sha?: string;
+    per_skill_scan?: PerSkillScanItem[];
+    dedicated_sections?: DedicatedSection[];
+    diagnostics?: string[];
+}): Review;
+/**
+ * Per-finding verdict from a cross-check pass. The pass2 model echoes
+ * back Pass 1's findings by 0-indexed `pass1Index` + `agreed`/`disagreed`
+ * + rationale. The aggregator stitches these into
+ * `MultiPassReview.findings[].attributions`.
+ *
+ * Cross-check Pass 2 operates on a flat finding list (its own
+ * representation), so its independentFindings carry severity — uses the
+ * legacy `findingSchema` shape.
+ */
+export declare const crossCheckVerdictSchema: z.ZodObject<{
+    pass1Index: z.ZodNumber;
+    verdict: z.ZodEnum<{
+        agreed: "agreed";
+        disagreed: "disagreed";
+    }>;
+    rationale: z.ZodOptional<z.ZodString>;
+}, z.core.$strip>;
+export type CrossCheckVerdictSchema = z.infer<typeof crossCheckVerdictSchema>;
+/**
+ * Full cross-check response. Pass 2 outputs verdicts on Pass-1 findings
+ * plus its own independent finds (in the internal `findingSchema` shape
+ * with severity, since cross-check works on already-flattened lists).
+ */
+export declare const crossCheckSchema: z.ZodObject<{
+    verdicts: z.ZodArray<z.ZodObject<{
+        pass1Index: z.ZodNumber;
+        verdict: z.ZodEnum<{
+            agreed: "agreed";
+            disagreed: "disagreed";
+        }>;
+        rationale: z.ZodOptional<z.ZodString>;
+    }, z.core.$strip>>;
+    independentFindings: z.ZodArray<z.ZodObject<{
+        skill: z.ZodString;
+        file: z.ZodOptional<z.ZodString>;
+        line: z.ZodOptional<z.ZodNumber>;
+        summary: z.ZodString;
+        reasoning: z.ZodOptional<z.ZodString>;
+        severity: z.ZodEnum<{
+            critical: "critical";
+            minor: "minor";
+            preexisting: "preexisting";
+        }>;
+    }, z.core.$strip>>;
+}, z.core.$strip>;
+export type CrossCheck = z.infer<typeof crossCheckSchema>;
+//# sourceMappingURL=review-schema-zod.d.ts.map

package/dist/core/review-schema-zod.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"review-schema-zod.d.ts","sourceRoot":"","sources":["../../src/core/review-schema-zod.ts"],"names":[],"mappings":"AAsBA,OAAO,EAAE,CAAC,EAAE,MAAM,KAAK,CAAC;AAIxB,eAAO,MAAM,cAAc,+CAAgD,CAAC;AAC5E,eAAO,MAAM,cAAc;;;;EAAyB,CAAC;AACrD,MAAM,MAAM,QAAQ,GAAG,CAAC,CAAC,KAAK,CAAC,OAAO,cAAc,CAAC,CAAC;AAGtD,eAAO,MAAM,kBAAkB,iDAIrB,CAAC;AACX,eAAO,MAAM,kBAAkB;;;;EAA6B,CAAC;AAC7D,MAAM,MAAM,YAAY,GAAG,CAAC,CAAC,KAAK,CAAC,OAAO,kBAAkB,CAAC,CAAC;AAE9D,eAAO,MAAM,mBAAmB;;;;;;iBAM9B,CAAC;AACH,MAAM,MAAM,aAAa,GAAG,CAAC,CAAC,KAAK,CAAC,OAAO,mBAAmB,CAAC,CAAC;AAEhE;;;;;GAKG;AACH,eAAO,MAAM,iBAAiB;;;;;;iBAM5B,CAAC;AACH,MAAM,MAAM,WAAW,GAAG,CAAC,CAAC,KAAK,CAAC,OAAO,iBAAiB,CAAC,CAAC;AAE5D,6EAA6E;AAC7E,eAAO,MAAM,sBAAsB;;;iBAGjC,CAAC;AACH,MAAM,MAAM,gBAAgB,GAAG,CAAC,CAAC,KAAK,CAAC,OAAO,sBAAsB,CAAC,CAAC;AAEtE,mEAAmE;AACnE,eAAO,MAAM,sBAAsB;;;;;;;;;;iBAIjC,CAAC;AACH,MAAM,MAAM,gBAAgB,GAAG,CAAC,CAAC,KAAK,CAAC,OAAO,sBAAsB,CAAC,CAAC;AAEtE;;;;;GAKG;AACH,eAAO,MAAM,YAAY;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;iBAWvB,CAAC;AACH,MAAM,MAAM,MAAM,GAAG,CAAC,CAAC,KAAK,CAAC,OAAO,YAAY,CAAC,CAAC;AAElD;;;;;;;;;GASG;AACH,MAAM,MAAM,OAAO,GAAG,WAAW,GAAG;IAAE,QAAQ,EAAE,QAAQ,CAAA;CAAE,CAAC;AAE3D;;;;GAIG;AACH,eAAO,MAAM,aAAa;;;;;;;;;;;iBAExB,CAAC;AAEH;;;;GAIG;AACH,wBAAgB,eAAe,CAAC,MAAM,EAAE,MAAM,GAAG,OAAO,EAAE,CAMzD;AAED;;;;GAIG;AACH,wBAAgB,iBAAiB,CAAC,QAAQ,EAAE,OAAO,EAAE,GAAG;IACtD,iBAAiB,EAAE,WAAW,EAAE,CAAC;IACjC,cAAc,EAAE,WAAW,EAAE,CAAC;IAC9B,oBAAoB,EAAE,WAAW,EAAE,CAAC;CACrC,CAUA;AAED;;;;GAIG;AACH,wBAAgB,mBAAmB,CAAC,QAAQ,EAAE,OAAO,EAAE,GAAG,aAAa,CAQtE;AAED;;;GAGG;AACH,wBAAgB,sBAAsB,CAAC,QAAQ,EAAE,OAAO,EAAE,GAAG,MAAM,EAAE,CASpE;AAED;;;;;;;;;;GAUG;AACH,wBAAgB,uBAAuB,CAAC,IAAI,EAAE;IAC5C,QAAQ,EAAE,OAAO,EAAE,CAAC;IACpB,aAAa,CAAC,EAAE,YAAY,CAAC;IAC7B,iBAAiB,CAAC,EAAE,MAAM,CAAC;IAC3B,cAAc,CAAC,EAAE,gBAAgB,EAAE,CAAC;IACpC,kBAAkB,CAAC,EAAE,gBAAgB,EAAE,CAAC;IACxC,WAAW,CAAC,EAAE,MAAM,EAAE,CAAC;CACxB,GAAG,MAAM,CA4BT;AAMD;;;;;;;;;GASG;AACH,eAAO,MAAM,uBAAuB;;;;;;;iBAIlC,CAAC;AACH,MAAM,MAAM,uBAAuB,GAAG,CAAC,CAAC,KAAK,CAAC,OAAO,uBAAuB,CAAC,CAAC;AAE9E;;;;GAIG;AACH,eAAO,MAAM,gBAAgB;;;;;;;;;;;;;;;;;;;;;iBAG3B,CAAC;AACH,MAAM,MAAM,UAAU,GAAG,CAAC,CAAC,KAAK,CAAC,OAAO,gBAAgB,CAAC,CAAC"}