clud-bug 0.5.15 → 0.5.16

package/lib/skills.js

@@ -572,13 +572,47 @@ export function isCriticalReviewHeader(headerLine) {
 export function classifyPerSkillOutcome(outcomeLine) {
   if (outcomeLine == null) return 'failure';
   const text = String(outcomeLine);
-  // 0 findings / 0 finding — anchored: NOT preceded by a digit. So "10 findings"
-  // doesn't match (the `0 findings` substring has `1` before it), and "0
-  // findings" / " 0 findings." both match.
-  if (/(^|[^0-9])0\s+findings?\b/i.test(text)) return 'success';
-  // n/a — anchored on word boundaries either side (so "n/a." at sentence end
-  // matches but "diagnostics" would not contain a matching n/a).
+
+  // HARD-FAILURE OVERRIDE: any positive finding count → failure.
+  // `\b[1-9]\d*\s+(?:\w+\s+){0,3}finding` matches "1 finding",
+  // "2 critical findings", "10 findings", "100 minor findings below".
+  // Up to 3 intermediate words allow modifiers like "critical"/"minor".
+  // The `\b[1-9]` anchor (vs `[0-9]`) excludes `0` — so this never
+  // shadows the "0 findings" success case below. Also: "10 findings"
+  // is correctly classified failure because `\b1` matches at the
+  // word boundary before `1`, then `\d*` consumes `0`.
+  if (/\b[1-9]\d*\s+(?:\w+\s+){0,3}finding/i.test(text)) return 'failure';
+
+  // SUCCESS PATTERNS — broadened in v0.5.16 to handle natural bot
+  // phrasings without enumerating every synonym. The bot's review
+  // prompt encourages canonical "0 findings" wording but variance
+  // is real (e.g. "no findings to anchor", "0 critical findings").
+
+  // (1) Zero-finding count, optionally with up to 3 modifier words.
+  //     Matches: "0 findings", "0 critical findings", "no findings",
+  //     "zero performance findings", "no findings to anchor".
+  //     Does NOT match: "10 findings" (handled above), "all findings",
+  //     "applied to all findings".
+  if (/\b(?:0|no|zero)\s+(?:\S+\s+){0,3}finding/i.test(text)) return 'success';
+
+  // (2) n/a — word-bounded. Matches "n/a.", "n/a — no surface here",
+  //     " n/a " surrounded by anything. Excludes "diagnostics" etc.
   if (/\bn\/a\b/i.test(text)) return 'success';
+
+  // (3) "not applicable" — explicit phrase.
+  if (/\bnot\s+applicable\b/i.test(text)) return 'success';
+
+  // (4) Checkmark (✓) as the bot's universal clean signal. Anchored on
+  //     whitespace/punctuation on both sides so accidental ✓ inside
+  //     other content (e.g. quoting a checkbox list) doesn't trip it.
+  //     Matches "applied to all findings. ✓ all anchored." but not
+  //     "see ✓item-marker in unicode" or similar.
+  if (/(?:^|\s)✓(?:\s|$|[.,;:])/.test(text)) return 'success';
+
+  // Skill-specific vocabulary like "0 pattern fights" (no `finding` word)
+  // falls through to failure here. Skill authors should prefer the
+  // canonical "0 findings" wording in their per-skill scan lines so
+  // this classifier doesn't need per-skill vocabulary knowledge.
   return 'failure';
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "clud-bug",
-  "version": "0.5.15",
+  "version": "0.5.16",
   "description": "Skill-driven Claude PR review. Ship a brand-voice skill, get brand reviews. Each finding cites the skill that motivated it. CLI installs the workflow + a baseline kit; add more from skills.sh.",
   "homepage": "https://cludbug.dev",
   "bugs": "https://github.com/thrillmot/clud-bug/issues",

package/templates/workflow-py.yml.tmpl

@@ -1,4 +1,4 @@
-# clud-bug-template-version: v9
+# clud-bug-template-version: v10
 name: Clud Bug 🐛 Crawls Your Code
 
 on:
@@ -281,6 +281,6 @@ jobs:
       # Strict-mode gate — composite action; see workflow.yml.tmpl for design notes.
       - name: Strict mode — fail check on critical findings
         if: success()
-        uses: thrillmot/clud-bug/.github/actions/strict-mode-gate@v0.5.15
+        uses: thrillmot/clud-bug/.github/actions/strict-mode-gate@v0.5.16
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}

package/templates/workflow-ts.yml.tmpl

@@ -1,4 +1,4 @@
-# clud-bug-template-version: v9
+# clud-bug-template-version: v10
 name: Clud Bug 🐛 Crawls Your Code
 
 on:
@@ -282,6 +282,6 @@ jobs:
       # Strict-mode gate — composite action; see workflow.yml.tmpl for design notes.
       - name: Strict mode — fail check on critical findings
         if: success()
-        uses: thrillmot/clud-bug/.github/actions/strict-mode-gate@v0.5.15
+        uses: thrillmot/clud-bug/.github/actions/strict-mode-gate@v0.5.16
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}

package/templates/workflow.yml.tmpl

@@ -1,4 +1,4 @@
-# clud-bug-template-version: v9
+# clud-bug-template-version: v10
 name: Clud Bug 🐛 Crawls Your Code
 
 on:
@@ -316,6 +316,6 @@ jobs:
       # Letting the action's own failure fail the check is louder and right.
       - name: Strict mode — fail check on critical findings
         if: success()
-        uses: thrillmot/clud-bug/.github/actions/strict-mode-gate@v0.5.15
+        uses: thrillmot/clud-bug/.github/actions/strict-mode-gate@v0.5.16
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}