cloudx-react-native 3.1.2 → 3.2.0

package/README.md

@@ -19,6 +19,7 @@ The CloudX React Native SDK enables monetization of your React Native apps with
 
 | Plugin | iOS (`CloudXCore`) | Android (`io.cloudx:sdk`) |
 |--------|-------------------|---------------------------|
+| 3.2.0  | 3.2.0             | 3.2.0                     |
 | 3.1.2  | 3.1.0             | 3.1.0                     |
 | 2.2.3  | 2.2.3             | 2.2.3                     |
 
@@ -39,12 +40,13 @@ target 'YourApp' do
   # ... existing config ...
 
   # CloudX ad network adapters (add as needed)
-  pod 'CloudXMetaAdapter', '~> 3.1.0'
-  pod 'CloudXVungleAdapter', '~> 3.1.0'
-  pod 'CloudXInMobiAdapter', '~> 3.1.0'
-  pod 'CloudXMintegralAdapter', '~> 3.1.0'
-  pod 'CloudXUnityAdsAdapter', '~> 3.1.0'
-  pod 'CloudXRenderer', '~> 3.1.0'
+  pod 'CloudXMetaAdapter', '~> 3.2.0'
+  pod 'CloudXVungleAdapter', '~> 3.2.0'
+  pod 'CloudXInMobiAdapter', '~> 3.2.0'
+  pod 'CloudXMintegralAdapter', '~> 3.2.0'
+  pod 'CloudXUnityAdsAdapter', '~> 3.2.0'
+  pod 'CloudXMagniteAdapter', '~> 3.2.0'
+  pod 'CloudXRenderer', '~> 3.2.0'
 end
 ```
 
@@ -75,16 +77,17 @@ Add CloudX SDK and adapter dependencies to your `android/app/build.gradle`:
 ```kotlin
 dependencies {
     // CloudX Android SDK
-    implementation "io.cloudx:sdk:3.1.0"
+    implementation "io.cloudx:sdk:3.2.0"
 
     // Adapters for ad networks (add as needed)
-    implementation "io.cloudx:adapter-meta:3.1.0"
-    implementation "io.cloudx:adapter-vungle:3.1.0"
-    implementation "io.cloudx:adapter-inmobi:3.1.0"
-    implementation "io.cloudx:adapter-mintegral:3.1.0"
-    implementation "io.cloudx:adapter-unityads:3.1.0"
-
-    // Required by the native SDK 3.1.0 when using the Meta adapter.
+    implementation "io.cloudx:adapter-meta:3.2.0"
+    implementation "io.cloudx:adapter-vungle:3.2.0"
+    implementation "io.cloudx:adapter-inmobi:3.2.0"
+    implementation "io.cloudx:adapter-mintegral:3.2.0"
+    implementation "io.cloudx:adapter-unityads:3.2.0"
+    implementation "io.cloudx:adapter-magnite:3.2.0"
+
+    // Required by the native SDK 3.2.0 when using the Meta adapter.
     implementation "com.facebook.android:audience-network-sdk:6.21.0"
 }
 ```
@@ -637,12 +640,12 @@ CloudX.setVisualDebuggingEnabled(true);
 - Xcode 14.0+ / CocoaPods (iOS)
 - Gradle 8.0+ / Kotlin 1.8+ (Android)
 
-### Native SDK Versions (3.1.0)
+### Native SDK Versions (3.2.0)
 
 | Platform | Dependency | Version |
 |----------|-----------|---------|
-| iOS | CloudXCore | ~> 3.1.0 |
-| Android | io.cloudx:sdk | 3.1.0 |
+| iOS | CloudXCore | ~> 3.2.0 |
+| Android | io.cloudx:sdk | 3.2.0 |
 
 ## Troubleshooting
 

package/android/build.gradle

@@ -65,7 +65,6 @@ android {
 }
 
 repositories {
-    mavenLocal()
     mavenCentral()
     google()
 }
@@ -73,5 +72,5 @@ repositories {
 dependencies {
     implementation "com.facebook.react:react-native:0.76.2"
 
-    implementation "io.cloudx:sdk:3.1.0"
+    implementation "io.cloudx:sdk:3.2.0"
 }

package/android/src/main/java/com/cloudxreactnative/CloudXModuleImpl.kt

@@ -208,20 +208,24 @@ class CloudXModuleImpl(private val reactApplicationContext: ReactApplicationCont
     }
 
     fun showInterstitial(adUnitId: String, placement: String?, customData: String?) {
-        val interstitial = retrieveInterstitial(adUnitId)
-        val activity = maybeGetCurrentActivity()
-        if (activity == null) {
-            Log.e(TAG, "showInterstitial: no activity available")
-            return
+        reactApplicationContext.runOnUiQueueThread {
+            val interstitial = retrieveInterstitial(adUnitId)
+            val activity = maybeGetCurrentActivity()
+            if (activity == null) {
+                Log.e(TAG, "showInterstitial: no activity available")
+                return@runOnUiQueueThread
+            }
+            interstitial.show(activity, placement, customData)
         }
-        interstitial.show(activity, placement, customData)
     }
 
     fun destroyInterstitial(adUnitId: String) {
-        interstitials.remove(adUnitId)?.let {
-            it.listener = null
-            it.revenueListener = null
-            it.destroy()
+        reactApplicationContext.runOnUiQueueThread {
+            interstitials.remove(adUnitId)?.let {
+                it.listener = null
+                it.revenueListener = null
+                it.destroy()
+            }
         }
     }
 
@@ -238,20 +242,24 @@ class CloudXModuleImpl(private val reactApplicationContext: ReactApplicationCont
     }
 
     fun showRewarded(adUnitId: String, placement: String?, customData: String?) {
-        val rewarded = retrieveRewarded(adUnitId)
-        val activity = maybeGetCurrentActivity()
-        if (activity == null) {
-            Log.e(TAG, "showRewarded: no activity available")
-            return
+        reactApplicationContext.runOnUiQueueThread {
+            val rewarded = retrieveRewarded(adUnitId)
+            val activity = maybeGetCurrentActivity()
+            if (activity == null) {
+                Log.e(TAG, "showRewarded: no activity available")
+                return@runOnUiQueueThread
+            }
+            rewarded.show(activity, placement, customData)
         }
-        rewarded.show(activity, placement, customData)
     }
 
     fun destroyRewarded(adUnitId: String) {
-        rewardedAds.remove(adUnitId)?.let {
-            it.listener = null
-            it.revenueListener = null
-            it.destroy()
+        reactApplicationContext.runOnUiQueueThread {
+            rewardedAds.remove(adUnitId)?.let {
+                it.listener = null
+                it.revenueListener = null
+                it.destroy()
+            }
         }
     }
 
@@ -661,15 +669,17 @@ class CloudXModuleImpl(private val reactApplicationContext: ReactApplicationCont
             destroyAdView(adUnitId, adFormat)
         }
 
-        for (interstitial in interstitials.values) {
-            interstitial.destroy()
-        }
-        interstitials.clear()
+        reactApplicationContext.runOnUiQueueThread {
+            for (interstitial in interstitials.values) {
+                interstitial.destroy()
+            }
+            interstitials.clear()
 
-        for (rewarded in rewardedAds.values) {
-            rewarded.destroy()
+            for (rewarded in rewardedAds.values) {
+                rewarded.destroy()
+            }
+            rewardedAds.clear()
         }
-        rewardedAds.clear()
     }
 
     // =========================================================================

package/android/src/oldarch/com/cloudxreactnative/CloudXModule.kt

@@ -1,5 +1,6 @@
 package com.cloudxreactnative
 
+import com.facebook.react.bridge.Dynamic
 import com.facebook.react.bridge.Promise
 import com.facebook.react.bridge.ReactApplicationContext
 import com.facebook.react.bridge.ReactContextBaseJavaModule
@@ -25,8 +26,23 @@ class CloudXModule(reactContext: ReactApplicationContext) :
     @ReactMethod fun setAppKeyValue(key: String, value: String) = impl.setAppKeyValue(key, value)
     @ReactMethod fun clearAllKeyValues() = impl.clearAllKeyValues()
 
-    @ReactMethod fun setHasUserConsent(hasUserConsent: Boolean?) = impl.setHasUserConsent(hasUserConsent)
-    @ReactMethod fun setDoNotSell(isDoNotSell: Boolean?) = impl.setDoNotSell(isDoNotSell)
+    // Paper's `JavaMethodWrapper` extracts primitive boxed types via
+    // `ReadableNativeArray.getBoolean(int)` which unconditionally calls
+    // `booleanValue()` on the boxed result — null arguments therefore throw
+    // `NativeArgumentsParseException` *before* the method runs, even when the
+    // Kotlin signature is `Boolean?`. Declaring the parameter as `Dynamic`
+    // lets the bridge hand us the raw value and we null-check it ourselves.
+    // TurboModules (NewArch) don't have this limitation, which is why the
+    // newarch counterpart keeps the `Boolean?` signature directly.
+    @ReactMethod fun setHasUserConsent(hasUserConsent: Dynamic) {
+        val value: Boolean? = if (hasUserConsent.isNull) null else hasUserConsent.asBoolean()
+        impl.setHasUserConsent(value)
+    }
+
+    @ReactMethod fun setDoNotSell(isDoNotSell: Dynamic) {
+        val value: Boolean? = if (isDoNotSell.isNull) null else isDoNotSell.asBoolean()
+        impl.setDoNotSell(value)
+    }
 
     @ReactMethod fun createBanner(adUnitId: String, position: String) = impl.createBanner(adUnitId, position)
     @ReactMethod fun createBannerWithOffsets(adUnitId: String, position: String, xOffset: Double, yOffset: Double) = impl.createBannerWithOffsets(adUnitId, position, xOffset, yOffset)

package/cloudx-react-native.podspec

@@ -14,7 +14,7 @@ Pod::Spec.new do |s|
 
   s.requires_arc = true
 
-  s.dependency "CloudXCore", "~> 3.1.0"
+  s.dependency "CloudXCore", "~> 3.2.0"
 
   s.source_files = "ios/**/*.{h,mm}"
 

package/ios/CloudX.mm

@@ -11,6 +11,42 @@
 + (nullable UIColor *)clx_colorWithHexString:(NSString *)hexString;
 @end
 
+// Diagnostic-only observer. Inserted as a zero-size hidden subview of the
+// CLXBannerAdView so we can detect when the banner's window attachment changes.
+// A subview's window follows its superview's, so window transitions on the
+// observer are a reliable proxy for transitions on the banner itself.
+// TODO(CXD-banner-diag): remove once the iOS RN banner visibility issue is
+// root-caused and fixed.
+@interface CLXDiagBannerWindowObserver : UIView
+@property (nonatomic, copy, nullable) NSString *adUnitIdentifier;
+@end
+
+@implementation CLXDiagBannerWindowObserver
+
+- (instancetype)initWithAdUnitIdentifier:(NSString *)adUnitIdentifier
+{
+    self = [super initWithFrame: CGRectZero];
+    if (self) {
+        _adUnitIdentifier = [adUnitIdentifier copy];
+        self.hidden = YES;
+        self.userInteractionEnabled = NO;
+        self.translatesAutoresizingMaskIntoConstraints = YES;
+    }
+    return self;
+}
+
+- (void)didMoveToWindow
+{
+    [super didMoveToWindow];
+    NSLog(@"[CloudXCore] [CloudX] DIAG banner[%@] didMoveToWindow: window=%@ superview=%@ superview.window=%@",
+          self.adUnitIdentifier ?: @"(nil)",
+          self.window,
+          self.superview ? NSStringFromClass([self.superview class]) : @"(nil)",
+          self.superview ? self.superview.window : @"(nil)");
+}
+
+@end
+
 @interface CloudX()
 
 // A simple BOOL tracks initialization state. Concurrent initialize calls are serialized
@@ -840,14 +876,22 @@ RCT_EXPORT_METHOD(destroyRewarded:(NSString *)adUnitIdentifier)
         // on window attachment" path inserts the adapter view immediately.
         if ( !view.superview )
         {
+            // TODO(CXD-banner-diag): remove once the iOS RN banner visibility
+            // issue is root-caused and fixed.
+            [self logBannerAttachDiagnosticsForAdUnit: adUnitIdentifier phase: @"pre-attach" view: view];
+
             UIView *rootView = [self topViewController].view;
             if ( rootView )
             {
                 [rootView addSubview: view];
+                [self attachDiagObserverToBanner: view adUnit: adUnitIdentifier];
+                [self logBannerAttachDiagnosticsForAdUnit: adUnitIdentifier phase: @"post-attach" view: view];
+                [self scheduleBannerAttachFollowupsForAdUnit: adUnitIdentifier view: view];
             }
             else
             {
                 [self log: @"showAdView: no visible root view for ad unit \"%@\"; deferring.", adUnitIdentifier];
+                [self logBannerAttachDiagnosticsForAdUnit: adUnitIdentifier phase: @"no-root-view" view: view];
                 [self.adUnitIdentifiersToShowAfterCreate addObject: adUnitIdentifier];
                 return;
             }
@@ -862,6 +906,68 @@ RCT_EXPORT_METHOD(destroyRewarded:(NSString *)adUnitIdentifier)
     }];
 }
 
+// TODO(CXD-banner-diag): remove once the iOS RN banner visibility issue is
+// root-caused and fixed.
+- (void)logBannerAttachDiagnosticsForAdUnit:(NSString *)adUnitIdentifier
+                                      phase:(NSString *)phase
+                                       view:(CLXBannerAdView *)view
+{
+    UIViewController *topVC = [self topViewController];
+    UIViewController *rootVC = [self keyWindowRootViewController];
+    NSUInteger connectedSceneCount = UIApplication.sharedApplication.connectedScenes.count;
+    NSUInteger foregroundSceneCount = 0;
+    for (UIScene *scene in UIApplication.sharedApplication.connectedScenes) {
+        if (scene.activationState == UISceneActivationStateForegroundActive) foregroundSceneCount++;
+    }
+
+    NSLog(@"[CloudXCore] [CloudX] DIAG banner[%@] %@: "
+          @"view.window=%@ view.superview=%@ view.hidden=%d "
+          @"topVC=%@ topVC.view.window=%@ "
+          @"rootVC=%@ rootVC.view.window=%@ "
+          @"scenes=total:%lu foregroundActive:%lu",
+          adUnitIdentifier,
+          phase,
+          view.window,
+          view.superview ? NSStringFromClass([view.superview class]) : @"(nil)",
+          view.hidden,
+          topVC ? NSStringFromClass([topVC class]) : @"(nil)",
+          topVC.view.window,
+          rootVC ? NSStringFromClass([rootVC class]) : @"(nil)",
+          rootVC.view.window,
+          (unsigned long)connectedSceneCount,
+          (unsigned long)foregroundSceneCount);
+}
+
+// TODO(CXD-banner-diag): remove once root-caused.
+- (void)scheduleBannerAttachFollowupsForAdUnit:(NSString *)adUnitIdentifier
+                                          view:(CLXBannerAdView *)view
+{
+    __weak CloudX *weakSelf = self;
+    __weak CLXBannerAdView *weakView = view;
+    NSArray<NSNumber *> *delaysSeconds = @[ @0.25, @1.0, @3.0, @10.0 ];
+    for (NSNumber *delay in delaysSeconds) {
+        dispatch_after(dispatch_time(DISPATCH_TIME_NOW, (int64_t)(delay.doubleValue * NSEC_PER_SEC)),
+                       dispatch_get_main_queue(), ^{
+            CloudX *strongSelf = weakSelf;
+            CLXBannerAdView *strongView = weakView;
+            if (!strongSelf || !strongView) return;
+            NSString *phase = [NSString stringWithFormat: @"post-attach+%@s", delay];
+            [strongSelf logBannerAttachDiagnosticsForAdUnit: adUnitIdentifier phase: phase view: strongView];
+        });
+    }
+}
+
+// TODO(CXD-banner-diag): remove once root-caused.
+- (void)attachDiagObserverToBanner:(CLXBannerAdView *)view
+                            adUnit:(NSString *)adUnitIdentifier
+{
+    for (UIView *subview in view.subviews) {
+        if ([subview isKindOfClass: [CLXDiagBannerWindowObserver class]]) return;
+    }
+    CLXDiagBannerWindowObserver *observer = [[CLXDiagBannerWindowObserver alloc] initWithAdUnitIdentifier: adUnitIdentifier];
+    [view addSubview: observer];
+}
+
 - (void)hideAdViewWithAdUnitIdentifier:(NSString *)adUnitIdentifier adFormat:(CLXBannerType)adFormat
 {
     [self executeOnMainQueue:^{

package/lib/commonjs/version.js

@@ -6,5 +6,5 @@ Object.defineProperty(exports, "__esModule", {
 exports.PLUGIN_VERSION = void 0;
 // Keep PLUGIN_VERSION in sync with the `version` field in package.json.
 // Phase 1 of RELEASE.md bumps both together.
-const PLUGIN_VERSION = exports.PLUGIN_VERSION = '3.1.2';
+const PLUGIN_VERSION = exports.PLUGIN_VERSION = '3.2.0';
 //# sourceMappingURL=version.js.map

package/lib/module/version.js

@@ -1,4 +1,4 @@
 // Keep PLUGIN_VERSION in sync with the `version` field in package.json.
 // Phase 1 of RELEASE.md bumps both together.
-export const PLUGIN_VERSION = '3.1.2';
+export const PLUGIN_VERSION = '3.2.0';
 //# sourceMappingURL=version.js.map

package/lib/typescript/src/version.d.ts

@@ -1,2 +1,2 @@
-export declare const PLUGIN_VERSION = "3.1.2";
+export declare const PLUGIN_VERSION = "3.2.0";
 //# sourceMappingURL=version.d.ts.map

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "cloudx-react-native",
-  "version": "3.1.2",
+  "version": "3.2.0",
   "description": "React Native wrapper for CloudX SDK (iOS & Android)",
   "main": "lib/commonjs/index",
   "module": "lib/module/index",

package/src/version.ts

@@ -1,3 +1,3 @@
 // Keep PLUGIN_VERSION in sync with the `version` field in package.json.
 // Phase 1 of RELEASE.md bumps both together.
-export const PLUGIN_VERSION = '3.1.2';
+export const PLUGIN_VERSION = '3.2.0';