closure-rs 0.0.1-alpha.3 → 0.0.1-alpha.5

package/LICENSES/headers.tsv

@@ -90,6 +90,7 @@ crates/jscomp/src/check_super.rs	74bf25295c999b5c	Apache-2.0	closure:src/com/goo
 crates/jscomp/src/check_suspicious_code.rs	a3dfb3a369f1d545	Apache-2.0	closure:src/com/google/javascript/jscomp/CheckSuspiciousCode.java; closure:src/com/google/javascript/jscomp/NodeTraversal.java
 crates/jscomp/src/check_type_import_code_references.rs	1c8684b5a972cc2c	Apache-2.0	closure:src/com/google/javascript/jscomp/CheckTypeImportCodeReferences.java; closure:src/com/google/javascript/jscomp/NodeTraversal.java
 crates/jscomp/src/check_unreachable_code.rs	976ba2f8436db648	Apache-2.0	closure:src/com/google/javascript/jscomp/CheckUnreachableCode.java
+crates/jscomp/src/chunked_vec.rs	322fc2ba37b98b96	Apache-2.0	-
 crates/jscomp/src/closure_check_module.rs	78e6e50c5a48566c	Apache-2.0	closure:src/com/google/javascript/jscomp/ClosureCheckModule.java; closure:src/com/google/javascript/jscomp/NodeUtil.java
 crates/jscomp/src/closure_code_removal.rs	0e1ff4fa189b4629	Apache-2.0	closure:src/com/google/javascript/jscomp/ClosureCodeRemoval.java; closure:src/com/google/javascript/jscomp/NodeTraversal.java
 crates/jscomp/src/closure_coding_convention.rs	a2056b96c91fe2c4	Apache-2.0	closure:src/com/google/javascript/jscomp/ClosureCodingConvention.java
@@ -1266,7 +1267,7 @@ crates/testing/src/replay/options_fields.rs	a5e244d5c6849c54	Apache-2.0	own:orac
 crates/testing/src/replay/options_values.rs	e74b73a18838bfd9	Apache-2.0	own:oracle/replay/src/com/google/javascript/jscomp/ReplayValues.java; own:UnitRecorder.java (oracle/patches/0002-recording-hooks.patch)
 crates/testing/src/replay/polyfills.rs	a72b3d1b7ecbb363	Apache-2.0	own:oracle/replay/src/com/google/javascript/jscomp/ReplayDsl.java; closure:src/com/google/javascript/jscomp/PolyfillUsageFinder.java; closure:src/com/google/javascript/jscomp/RewritePolyfills.java; closure:src/com/google/javascript/jscomp/IsolatePolyfills.java; closure:test/com/google/javascript/jscomp/GuardedCallbackTest.java; closure:test/com/google/javascript/jscomp/RewritePolyfillsTest.java
 crates/testing/src/replay/process_closure_provides_and_requires_test_helpers.rs	1daef3870df210df	Apache-2.0	own:oracle/replay/src/com/google/javascript/jscomp/ReplayDsl.java; own:oracle/replay/src/com/google/javascript/jscomp/ReplayValues.java; closure:test/com/google/javascript/jscomp/ProcessClosureProvidesAndRequiresTest.java; own:UnitRecorder.java (oracle/patches/0002-recording-hooks.patch); closure:src/com/google/javascript/jscomp/AbstractCompiler.java
-crates/testing/src/replay/process_defines_test_helpers.rs	d726a0b1cd12626a	Apache-2.0	own:UnitRecorder.java (oracle/patches/0002-recording-hooks.patch); own:oracle/replay/src/com/google/javascript/jscomp/ReplayValues.java; closure:test/com/google/javascript/jscomp/ProcessDefinesTest.java
+crates/testing/src/replay/process_defines_test_helpers.rs	f1c0994e7c3683e1	Apache-2.0	own:UnitRecorder.java (oracle/patches/0002-recording-hooks.patch); own:oracle/replay/src/com/google/javascript/jscomp/ReplayValues.java; closure:test/com/google/javascript/jscomp/ProcessDefinesTest.java; own:oracle/replay/src/com/google/javascript/jscomp/ReplayDsl.java; closure:src/com/google/javascript/jscomp/ProcessDefines.java
 crates/testing/src/replay/proto_values.rs	e74b73a18838bfd9	Apache-2.0	own:UnitRecorder.java (oracle/patches/0002-recording-hooks.patch); own:oracle/replay/src/com/google/javascript/jscomp/ReplayValues.java
 crates/testing/src/replay/pure_function_identifier_helpers.rs	41d4f7c05c0146de	Apache-2.0	closure:test/com/google/javascript/jscomp/PureFunctionIdentifierTest.java; closure:test/com/google/javascript/jscomp/CompilerTestCase.java; closure:src/com/google/javascript/jscomp/NodeTraversal.java; closure:src/com/google/javascript/jscomp/testing/JSCompCorrespondences.java
 crates/testing/src/replay/reference_collector_test_helpers.rs	7d5ff723a72fc8bc	Apache-2.0	own:oracle/replay/src/com/google/javascript/jscomp/ReplayDsl.java; own:oracle/replay/src/com/google/javascript/jscomp/ReplayValues.java; closure:src/com/google/javascript/jscomp/ReferenceCollector.java; own:oracle/replay/helpers/com/google/javascript/jscomp/ReferenceCollectorTest_Helpers.java; closure:src/com/google/javascript/jscomp/AbstractVar.java; closure:src/com/google/javascript/jscomp/ReferenceCollection.java; closure:src/com/google/javascript/jscomp/Reference.java; closure:src/com/google/javascript/jscomp/Scope.java; closure:src/com/google/javascript/jscomp/ReferenceMap.java
@@ -1274,7 +1275,7 @@ crates/testing/src/replay/registry.rs	6c5cf44fa82bab44	Apache-2.0	own:oracle/rep
 crates/testing/src/replay/remove_unused_code_helpers.rs	f9ba8b6cf6b9b31c	Apache-2.0	own:oracle/replay/src/com/google/javascript/jscomp/ReplayDsl.java; closure:src/com/google/javascript/jscomp/RemoveUnusedCode.java; closure:test/com/google/javascript/jscomp/RemoveUnusedCodeTest.java; closure:src/com/google/javascript/jscomp/CompilerPass.java; closure:test/com/google/javascript/jscomp/RemoveUnusedCodeNameAnalyzerTest.java
 crates/testing/src/replay/replace_css_names_test_helpers.rs	9e24a97aba5846db	Apache-2.0	closure:test/com/google/javascript/jscomp/ReplaceCssNamesTest.java; closure:src/com/google/javascript/jscomp/CssRenamingMap.java; own:UnitRecorder.java (oracle/patches/0002-recording-hooks.patch); own:oracle/replay/src/com/google/javascript/jscomp/ReplayValues.java; closure:src/com/google/javascript/jscomp/ReplaceCssNames.java
 crates/testing/src/replay/replace_id_generators_test_helpers.rs	b4a8188ea4524080	Apache-2.0	closure:test/com/google/javascript/jscomp/ReplaceIdGeneratorsTest.java; own:UnitRecorder.java (oracle/patches/0002-recording-hooks.patch); closure:src/com/google/javascript/jscomp/ReplaceIdGenerators.java; own:oracle/replay/src/com/google/javascript/jscomp/ReplayDsl.java
-crates/testing/src/replay/replace_messages_helpers.rs	418b9c47143d44be	Apache-2.0	own:oracle/replay/src/com/google/javascript/jscomp/ReplayValues.java; closure:test/com/google/javascript/jscomp/ReplaceMessagesTest.java; own:oracle/replay/src/com/google/javascript/jscomp/ReplayDsl.java; own:UnitRecorder.java (oracle/patches/0002-recording-hooks.patch); closure:src/com/google/javascript/jscomp/ReplaceMessages.java
+crates/testing/src/replay/replace_messages_helpers.rs	426d6d7b398ea42c	Apache-2.0	own:oracle/replay/src/com/google/javascript/jscomp/ReplayValues.java; closure:test/com/google/javascript/jscomp/ReplaceMessagesTest.java; own:oracle/replay/src/com/google/javascript/jscomp/ReplayDsl.java; own:UnitRecorder.java (oracle/patches/0002-recording-hooks.patch); closure:src/com/google/javascript/jscomp/ReplaceMessages.java; closure:src/com/google/javascript/jscomp/GoogleJsMessageIdGenerator.java
 crates/testing/src/replay/replace_strings_test_helpers.rs	20daf97a04f52270	Apache-2.0	own:oracle/replay/src/com/google/javascript/jscomp/ReplayValues.java; own:UnitRecorder.java (oracle/patches/0002-recording-hooks.patch); closure:src/com/google/javascript/jscomp/ReplaceStrings.java; own:oracle/replay/src/com/google/javascript/jscomp/ReplayDsl.java; closure:src/com/google/javascript/jscomp/NodeTraversal.java; closure:test/com/google/javascript/jscomp/ReplaceStringsTest.java
 crates/testing/src/replay/replay_bridge.rs	51a99d6cd730fad9	Apache-2.0	own:oracle/replay/src/com/google/javascript/jscomp/ReplayBridge.java
 crates/testing/src/replay/replay_compiler_test.rs	3fd5ee14fa767ad8	Apache-2.0	own:oracle/replay/src/com/google/javascript/jscomp/ReplayCompilerTest.java; own:oracle/replay/src/com/google/javascript/jscomp/ReplayDsl.java

package/README.md

@@ -69,7 +69,9 @@ No shell is involved, so values need no quoting. The flags are the Java compiler
 
 `run(callback)` starts the process and returns it. The callback receives `(exitCode, stdout,
 stderr)` once the process has closed; for a non-zero exit code `stderr` starts with the full
-command line. Without `--js` the compiler reads the input from stdin: write it to the returned
+command line. If the process is ended by a signal (for example killed by the out-of-memory
+killer), `exitCode` is 128 + the signal number, as a shell reports it (137 for `SIGKILL`), and
+`stderr` names the signal. The official package passes `null` in that case. Without `--js` the compiler reads the input from stdin: write it to the returned
 process's `stdin` and end it.
 
 ### Types

package/cli.js

@@ -28,7 +28,13 @@ getFirstSupportedPlatform(platforms);
 
 const compiler = new Compiler(args);
 compiler.spawnOptions = {stdio: 'inherit'};
-const child = compiler.run((exitCode) => {
+const child = compiler.run((exitCode, stdout, stderr) => {
+  // stdio is inherited, so the binary's own output is already on the terminal; only the wrapper's
+  // note about a process ended by a signal (exit code 128 + signal number) is printed here.
+  const signal = /closure-rs was terminated by signal .*/.exec(stderr);
+  if (signal) {
+    process.stderr.write(`${signal[0]}\n`);
+  }
   process.exitCode = exitCode;
 });
 child.on('error', (e) => {

package/lib/node/index.js

@@ -7,14 +7,28 @@
 //   - `JAR_PATH` defaults to null, so no JVM arguments are added and `extraCommandArgs` (JVM
 //     arguments in the official package) are ignored unless a caller sets JAR_PATH itself;
 //   - a spawn failure calls the callback once; the official class also calls it a second time
-//     from the 'close' event (Node emits 'error' and then 'close' with a negative code).
+//     from the 'close' event (Node emits 'error' and then 'close' with a negative code);
+//   - a process ended by a signal gives the callback 128 + the signal number (as a shell reports
+//     it) instead of null, and stderr names the signal: the official class passes null on, which
+//     an `if (exitCode)` check takes for success.
 import {spawn} from 'node:child_process';
+import {constants as osConstants} from 'node:os';
 import path from 'node:path';
 import {fileURLToPath} from 'node:url';
-import {getNativeImagePath, platformPackageName} from '../utils.js';
+import {getNativeImagePath} from '../utils.js';
 
 const resolved = getNativeImagePath();
 
+/** The usual cause of a signal, appended to the message for a process ended by one. */
+const SIGNAL_HINTS = {
+  SIGKILL: ' (on Linux usually the out-of-memory killer: check the memory limit of the machine or ' +
+      'container, and how many compiles run at once)',
+  SIGILL: ' (an instruction this CPU does not support)',
+  SIGSEGV: ' (a crash)',
+  SIGBUS: ' (a crash)',
+  SIGABRT: ' (an abort)',
+  SIGSYS: ' (a system call blocked by a seccomp profile, for example in a container)',
+};
 /**
  * The executable `run()` spawns: the closure-rs binary from the platform package (or
  * CLOSURE_RS_BINARY). When neither exists, 'closure-rs' is looked up on PATH, just as the official
@@ -111,13 +125,19 @@ export default class Compiler {
           err += chunk;
         });
       }
-      child.on('close', (code) => {
+      child.on('close', (code, signal) => {
+        if (code === null && signal) {
+          const number = osConstants.signals[signal] || 0;
+          finish(128 + number, this.prependFullCommand(
+              `${err}closure-rs was terminated by signal ${signal}${SIGNAL_HINTS[signal] || ''}.`));
+          return;
+        }
         finish(code, code !== 0 ? this.prependFullCommand(err) : err);
       });
       child.on('error', (e) => {
         finish(1, this.prependFullCommand(
-            'Process spawn error. Is the closure-rs binary installed? It comes from the optional ' +
-            `package ${platformPackageName}; CLOSURE_RS_BINARY can point at a binary instead.\n` +
+            'Process spawn error. Is the closure-rs binary installed? It ships in this package under ' +
+            `bin/${process.platform}-${process.arch}/; CLOSURE_RS_BINARY can point at a binary instead.\n` +
             e.message));
       });
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "closure-rs",
-  "version": "0.0.1-alpha.3",
+  "version": "0.0.1-alpha.5",
   "description": "Rust port of the Closure Compiler CLI. Not affiliated with or published by Google.",
   "repository": {
     "type": "git",