clementine-agent 1.18.76 → 1.18.77

package/dist/cli/dashboard.js

@@ -6368,7 +6368,9 @@ If the tool returns nothing or errors, return an empty array \`[]\`.`,
     // ── CRON CRUD routes (continued) ──────────────────────────────
     app.post('/api/cron', (req, res) => {
         try {
-            const { name, schedule, prompt, tier, enabled, work_dir, mode, max_hours, max_retries, after, agent, context, skills, allowedTools, allowedMcpServers, tags, category, predictable, } = req.body;
+            const { name, schedule, prompt, tier, enabled, work_dir, mode, max_hours, max_retries, after, agent, context, skills, allowedTools, allowedMcpServers, tags, category, predictable, 
+            // PRD Phase 1 fields (camelCase from API; written as snake_case YAML).
+            successCriteriaText, successSchema, addDirs, } = req.body;
             if (!name || !schedule || !prompt) {
                 res.status(400).json({ error: 'name, schedule, and prompt are required' });
                 return;
@@ -6427,6 +6429,16 @@ If the tool returns nothing or errors, return an empty array \`[]\`.`,
             // Predictable mode — default to true (contract execution) for new
             // tricks created via the dashboard. Mirror the MCP tool default.
             job.predictable = (predictable === false) ? false : true;
+            // PRD Phase 1: goal-orientation fields (camelCase from API → snake_case YAML).
+            if (typeof successCriteriaText === 'string' && successCriteriaText.trim()) {
+                job.success_criteria_text = successCriteriaText.trim();
+            }
+            if (successSchema && typeof successSchema === 'object' && !Array.isArray(successSchema) && Object.keys(successSchema).length > 0) {
+                job.success_schema = successSchema;
+            }
+            if (Array.isArray(addDirs) && addDirs.length) {
+                job.add_dirs = addDirs.map(String).map((s) => s.trim()).filter(Boolean);
+            }
             jobs.push(job);
             writeCronFileAt(cronFile, parsed, jobs);
             res.json({ ok: true, message: `Created cron job: ${name}` });
@@ -6568,6 +6580,36 @@ If the tool returns nothing or errors, return an empty array \`[]\`.`,
             if (updates.predictable !== undefined) {
                 jobs[idx].predictable = Boolean(updates.predictable);
             }
+            // PRD Phase 1 goal fields. set-when-non-empty / delete-when-cleared,
+            // matching the existing trick-capability pattern above. The deprecated
+            // success_criteria array is dropped on the first save through this path.
+            if (updates.successCriteriaText !== undefined) {
+                const v = typeof updates.successCriteriaText === 'string' ? updates.successCriteriaText.trim() : '';
+                if (v) {
+                    jobs[idx].success_criteria_text = v;
+                    delete jobs[idx].success_criteria; // sunset the deprecated alias on first save
+                }
+                else {
+                    delete jobs[idx].success_criteria_text;
+                }
+            }
+            if (updates.successSchema !== undefined) {
+                const s = updates.successSchema;
+                if (s && typeof s === 'object' && !Array.isArray(s) && Object.keys(s).length > 0) {
+                    jobs[idx].success_schema = s;
+                }
+                else {
+                    delete jobs[idx].success_schema;
+                }
+            }
+            if (updates.addDirs !== undefined) {
+                if (Array.isArray(updates.addDirs) && updates.addDirs.length) {
+                    jobs[idx].add_dirs = updates.addDirs.map(String).map((s) => s.trim()).filter(Boolean);
+                }
+                else {
+                    delete jobs[idx].add_dirs;
+                }
+            }
             if (updates.name !== undefined && updates.name !== bareJobName) {
                 // Rename — check for duplicates
                 const dup = jobs.find((j, i) => i !== idx && String(j.name ?? '').toLowerCase() === String(updates.name).toLowerCase());
@@ -19998,6 +20040,32 @@ if('serviceWorker' in navigator){navigator.serviceWorker.getRegistrations().then
           </div>
         </div>
 
+        <!-- ── PRD Phase 1: Goal (success_criteria_text + success_schema) ──
+             The single most important new field set. Without one of these, a
+             run "finished"; with one, a run "accomplished what it was meant
+             to". Banner warns (does not block) when neither is set. -->
+        <div class="cron-section-card">
+          <h4>Goal <span style="color:var(--text-muted);font-weight:normal;font-size:12px">— how do you know this task succeeded?</span></h4>
+          <p class="cron-section-desc">Optional but strongly recommended. Use plain English (an evaluator agent grades the run) or a JSON Schema (validated against the agent's structured output).</p>
+          <div id="cron-goal-warning" style="display:none;margin-bottom:12px;padding:10px 12px;border-radius:6px;background:rgba(245,158,11,0.10);border:1px solid rgba(245,158,11,0.30);color:var(--yellow);font-size:12px">
+            ⚠ No goal set — runs will be marked "finished" but not "accomplished". Add a success criterion below or a JSON Schema.
+          </div>
+          <div class="form-group">
+            <label class="form-label">Success criterion <span style="color:var(--text-muted);font-weight:normal">(plain English)</span></label>
+            <textarea id="cron-success-criteria-text" rows="3" placeholder="e.g. 'A daily briefing email was sent to nathan@example.com containing the top 3 overnight items.'" oninput="updateGoalWarning()"></textarea>
+            <div class="form-hint">An evaluator sub-agent reads the run's output and this criterion, then emits pass/fail with reasoning.</div>
+          </div>
+          <div class="form-group" style="margin-bottom:0">
+            <details>
+              <summary style="cursor:pointer;font-size:12px;color:var(--text-secondary);font-weight:500;padding:6px 0">▾ Success schema (JSON Schema, advanced)</summary>
+              <div style="margin-top:8px">
+                <textarea id="cron-success-schema" rows="6" placeholder='{ "type": "object", "required": ["sent"], "properties": { "sent": { "type": "boolean" } } }' style="font-family:'JetBrains Mono',monospace;font-size:11px" oninput="updateGoalWarning()"></textarea>
+                <div class="form-hint">JSON Schema validated against the agent's <code>structured_output</code>. Mechanically successful = parses + validates.</div>
+              </div>
+            </details>
+          </div>
+        </div>
+
         <!-- Skills & tools: pinned skills + MCP + tools + tags -->
         <div class="cron-section-card">
           <h4>Skills &amp; tools</h4>
@@ -20074,6 +20142,14 @@ if('serviceWorker' in navigator){navigator.serviceWorker.getRegistrations().then
                 <div class="form-hint">Run inside a project directory. Agent gets that project's CLAUDE.md.</div>
               </div>
             </div>
+            <!-- PRD Phase 1: read scope beyond cwd. One absolute path per line. -->
+            <div class="form-row">
+              <div class="form-group" style="flex:1">
+                <label class="form-label">Additional read directories <span style="color:var(--text-muted);font-weight:normal">(optional)</span></label>
+                <textarea id="cron-add-dirs" rows="2" placeholder="/Users/me/notes&#10;/Users/me/clients/acme" style="font-family:'JetBrains Mono',monospace;font-size:11px"></textarea>
+                <div class="form-hint">One absolute path per line. The agent gets read access to these in addition to the Project Context cwd.</div>
+              </div>
+            </div>
             <div class="form-row">
               <div class="form-group">
                 <label class="form-label">Mode</label>
@@ -24719,6 +24795,18 @@ function renderCronLegacyBanner(job) {
     + '</div>';
 }
 
+// PRD Phase 1: show a non-blocking warning under the Goal section header
+// when neither success_criteria_text nor success_schema is set. The PRD's
+// "the run accomplished what it was supposed to" promise depends on at
+// least one of the two being present.
+function updateGoalWarning() {
+  var sct = (document.getElementById('cron-success-criteria-text')?.value || '').trim();
+  var ssc = (document.getElementById('cron-success-schema')?.value || '').trim();
+  var warn = document.getElementById('cron-goal-warning');
+  if (!warn) return;
+  warn.style.display = (!sct && !ssc) ? '' : 'none';
+}
+
 // One-click migration: flip predictable=true AND save immediately so the
 // user doesn't have to remember to also click Save Changes.
 async function enablePredictableFromBanner() {
@@ -24760,6 +24848,11 @@ function openCreateCronModal(agentSlug) {
   toggleUnleashedOptions();
   document.getElementById('cron-prompt').value = '';
   document.getElementById('cron-context').value = '';
+  // PRD Phase 1 goal fields — empty by default. Warning banner will show.
+  var sct = document.getElementById('cron-success-criteria-text'); if (sct) sct.value = '';
+  var ssc = document.getElementById('cron-success-schema'); if (ssc) ssc.value = '';
+  var addDirsEl = document.getElementById('cron-add-dirs'); if (addDirsEl) addDirsEl.value = '';
+  if (typeof updateGoalWarning === 'function') updateGoalWarning();
   document.getElementById('cron-training-section').style.display = 'none';
   document.getElementById('cron-train-btn').style.display = '';
   resetCronTrainingChat();
@@ -24806,6 +24899,30 @@ function openEditCronModal(jobName) {
   toggleUnleashedOptions();
   document.getElementById('cron-prompt').value = job.prompt || '';
   document.getElementById('cron-context').value = job.context || '';
+  // PRD Phase 1: load goal fields. Accept either casing — old YAML may have
+  // success_criteria as a list (legacy); the parser already coalesces those
+  // into successCriteriaText on read, but defend here too in case the API
+  // shape differs from what the parser produces.
+  var sctE = document.getElementById('cron-success-criteria-text');
+  if (sctE) {
+    var sctVal = job.successCriteriaText || job.success_criteria_text || '';
+    if (!sctVal && Array.isArray(job.successCriteria || job.success_criteria)) {
+      sctVal = (job.successCriteria || job.success_criteria || []).join('\\n');
+    }
+    sctE.value = sctVal;
+  }
+  var sscE = document.getElementById('cron-success-schema');
+  if (sscE) {
+    var sscObj = job.successSchema || job.success_schema;
+    sscE.value = (sscObj && typeof sscObj === 'object') ? JSON.stringify(sscObj, null, 2) : '';
+  }
+  var addDirsE = document.getElementById('cron-add-dirs');
+  if (addDirsE) {
+    var addDirsArr = Array.isArray(job.addDirs) ? job.addDirs
+      : (Array.isArray(job.add_dirs) ? job.add_dirs : []);
+    addDirsE.value = addDirsArr.join('\\n');
+  }
+  if (typeof updateGoalWarning === 'function') updateGoalWarning();
   document.getElementById('cron-training-section').style.display = 'none';
   document.getElementById('cron-train-btn').style.display = '';
   resetCronTrainingChat();
@@ -25001,6 +25118,11 @@ function captureCronModalSnapshot() {
     v('cron-workdir'),
     v('cron-allowed-tools'),
     v('cron-category'),
+    // PRD Phase 1 goal fields — included in dirty check so leaving the
+    // modal with an unsaved success_schema or success_criteria_text prompts.
+    v('cron-success-criteria-text'),
+    v('cron-success-schema'),
+    v('cron-add-dirs'),
     (document.getElementById('cron-predictable') || {}).checked ? '1' : '0',
     JSON.stringify(_cronSelectedSkills || []),
     JSON.stringify(_cronSelectedMcp || []),
@@ -25025,6 +25147,9 @@ function isCronModalDirty() {
     v('cron-workdir'),
     v('cron-allowed-tools'),
     v('cron-category'),
+    v('cron-success-criteria-text'),
+    v('cron-success-schema'),
+    v('cron-add-dirs'),
     (document.getElementById('cron-predictable') || {}).checked ? '1' : '0',
     JSON.stringify(_cronSelectedSkills || []),
     JSON.stringify(_cronSelectedMcp || []),
@@ -25199,6 +25324,34 @@ async function saveCronJob() {
   }
   if (!prompt) { toast('Prompt is required — tell the agent what to do', 'error'); document.getElementById('cron-prompt').focus(); return; }
 
+  // PRD Phase 1 goal fields. successCriteriaText is freeform; successSchema
+  // is parsed JSON. Validate JSON early so the user gets a clean error before
+  // the round-trip. Empty schema is fine — we just send {} or undefined.
+  var successCriteriaText = (document.getElementById('cron-success-criteria-text')?.value || '').trim();
+  var successSchemaRaw = (document.getElementById('cron-success-schema')?.value || '').trim();
+  var successSchema;
+  if (successSchemaRaw) {
+    try {
+      successSchema = JSON.parse(successSchemaRaw);
+      if (!successSchema || typeof successSchema !== 'object' || Array.isArray(successSchema)) {
+        toast('Success schema must be a JSON object', 'error');
+        document.getElementById('cron-success-schema').focus();
+        return;
+      }
+    } catch (e) {
+      toast('Success schema is not valid JSON: ' + (e.message || String(e)), 'error');
+      document.getElementById('cron-success-schema').focus();
+      return;
+    }
+  }
+  // add_dirs: one absolute path per line. Trim, dedupe, drop blanks.
+  var addDirsRaw = (document.getElementById('cron-add-dirs')?.value || '').split(/\\r?\\n/);
+  var addDirs = addDirsRaw.map(function(s){ return s.trim(); }).filter(Boolean);
+  // Quick sanity — warn but don't block on relative paths.
+  if (addDirs.some(function(p){ return !p.startsWith('/') && !p.startsWith('~'); })) {
+    toast('Heads up: add_dirs entries should be absolute paths.', 'info');
+  }
+
   const body = {
     name, schedule, tier, prompt, enabled: true,
     work_dir: work_dir || undefined, mode, max_hours, max_retries, after, context,
@@ -25216,6 +25369,10 @@ async function saveCronJob() {
     tags: editingCronJob ? _cronTags : (_cronTags.length ? _cronTags : undefined),
     category: editingCronJob ? (category || '') : category,
     predictable,
+    // PRD Phase 1 goal-orientation. PUT delete-on-empty pattern below.
+    successCriteriaText: editingCronJob ? successCriteriaText : (successCriteriaText || undefined),
+    successSchema: editingCronJob ? (successSchema || null) : (successSchema || undefined),
+    addDirs: editingCronJob ? addDirs : (addDirs.length ? addDirs : undefined),
   };
 
   var wasEditing = !!editingCronJob;

package/dist/gateway/cron-scheduler.js

@@ -113,6 +113,24 @@ export function parseCronJobs() {
         const successCriteria = Array.isArray(job.success_criteria)
             ? job.success_criteria.map(c => String(c))
             : undefined;
+        // PRD Phase 1: prefer success_criteria_text (free-form). On read, fall
+        // back to joining the legacy success_criteria string[] so legacy YAML
+        // keeps rendering in the new editor surface. Writes go to the new field.
+        let successCriteriaText = typeof job.success_criteria_text === 'string'
+            ? String(job.success_criteria_text)
+            : (typeof job.successCriteriaText === 'string' ? String(job.successCriteriaText) : undefined);
+        if (!successCriteriaText && Array.isArray(successCriteria) && successCriteria.length > 0) {
+            successCriteriaText = successCriteria.join('\n');
+        }
+        // PRD Phase 1: JSON Schema validated against ResultMessage.structured_output.
+        // Accept either snake_case (success_schema) or camelCase from API. Stored
+        // as a plain object; ajv is loaded lazily at validation time.
+        const successSchemaRaw = job.success_schema ?? job.successSchema;
+        const successSchema = (successSchemaRaw && typeof successSchemaRaw === 'object' && !Array.isArray(successSchemaRaw))
+            ? successSchemaRaw
+            : undefined;
+        // PRD Phase 1: read scope beyond cwd. Accept either casing.
+        const addDirs = normalizeStringArray(job.add_dirs ?? job.addDirs);
         const alwaysDeliver = job.always_deliver === true ? true : undefined;
         const context = job.context != null ? String(job.context) : undefined;
         const preCheck = job.pre_check != null ? String(job.pre_check) : undefined;
@@ -140,7 +158,8 @@ export function parseCronJobs() {
         }
         jobs.push({
             name, schedule, prompt, enabled, tier, maxTurns, model, workDir, mode,
-            maxHours, maxRetries, after, successCriteria, alwaysDeliver, context, preCheck, agentSlug,
+            maxHours, maxRetries, after, successCriteria, successCriteriaText, successSchema, addDirs,
+            alwaysDeliver, context, preCheck, agentSlug,
             skills, allowedTools, allowedMcpServers, tags, category, predictable,
         });
     }
@@ -187,6 +206,18 @@ export function parseAgentCronJobs(agentsDir) {
                 const successCriteria = Array.isArray(job.success_criteria)
                     ? job.success_criteria.map(c => String(c))
                     : undefined;
+                // PRD Phase 1 fields — symmetric with global parser above.
+                let successCriteriaText = typeof job.success_criteria_text === 'string'
+                    ? String(job.success_criteria_text)
+                    : (typeof job.successCriteriaText === 'string' ? String(job.successCriteriaText) : undefined);
+                if (!successCriteriaText && Array.isArray(successCriteria) && successCriteria.length > 0) {
+                    successCriteriaText = successCriteria.join('\n');
+                }
+                const successSchemaRaw = job.success_schema ?? job.successSchema;
+                const successSchema = (successSchemaRaw && typeof successSchemaRaw === 'object' && !Array.isArray(successSchemaRaw))
+                    ? successSchemaRaw
+                    : undefined;
+                const addDirs = normalizeStringArray(job.add_dirs ?? job.addDirs);
                 const context = job.context != null ? String(job.context) : undefined;
                 const preCheck = job.pre_check != null ? String(job.pre_check) : undefined;
                 // ── Trick capabilities — symmetric with global parser ─────────
@@ -210,7 +241,9 @@ export function parseAgentCronJobs(agentsDir) {
                 allJobs.push({
                     name: `${slug}:${name}`,
                     schedule, prompt, enabled, tier, maxTurns, model, workDir,
-                    mode, maxHours, maxRetries, after, successCriteria, context, preCheck,
+                    mode, maxHours, maxRetries, after,
+                    successCriteria, successCriteriaText, successSchema, addDirs,
+                    context, preCheck,
                     agentSlug: slug,
                     skills, allowedTools, allowedMcpServers, tags, category, predictable,
                 });

package/dist/types.d.ts

@@ -328,7 +328,22 @@ export interface CronJobDefinition {
     maxRetries?: number;
     after?: string;
     agentSlug?: string;
+    /** @deprecated Use successCriteriaText (free-text) or successSchema (JSON Schema)
+     *  per PRD Phase 1. successCriteria is kept readable for one release; on read,
+     *  parseCronJobs coalesces it into successCriteriaText. */
     successCriteria?: string[];
+    /** PRD Phase 1: free-text "this task is done when…". An evaluator sub-agent reads
+     *  the run's final state and the criterion and emits a pass/fail with reasoning.
+     *  Stored as RunEvaluation on the Run. Optional but recommended. */
+    successCriteriaText?: string;
+    /** PRD Phase 1: JSON Schema validated against ResultMessage.structured_output.
+     *  If it parses, the run is mechanically successful. The Task editor shows a
+     *  non-blocking "Goal not set" warning when neither this nor successCriteriaText
+     *  is present. */
+    successSchema?: Record<string, unknown>;
+    /** PRD Phase 1: read scope beyond the cwd (workDir). Surfaced as a chip list
+     *  in the editor's Scope tab. The runner passes these to the SDK as add_dirs. */
+    addDirs?: string[];
     alwaysDeliver?: boolean;
     context?: string;
     preCheck?: string;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "clementine-agent",
-  "version": "1.18.76",
+  "version": "1.18.77",
   "description": "Clementine — Personal AI Assistant (TypeScript)",
   "type": "module",
   "main": "dist/index.js",