clementine-agent 1.18.75 → 1.18.76

package/dist/agent/advisor-rules/engine.js

@@ -70,14 +70,18 @@ export function evaluateWhen(c, ctx) {
             const lastRun = ctx.recentRuns[0];
             if (!lastRun)
                 return false;
-            const lastRunTime = new Date(lastRun.finishedAt).getTime();
+            // finishedAt is optional (in-progress runs are 'running' with no
+            // finishedAt). Fall back to startedAt so the rule still has a clock.
+            const lastRunTime = new Date(lastRun.finishedAt ?? lastRun.startedAt).getTime();
             return ctx.nowMs - lastRunTime > c.ms;
         }
         case 'lastRunWithinMs': {
             const lastRun = ctx.recentRuns[0];
             if (!lastRun)
                 return false;
-            const lastRunTime = new Date(lastRun.finishedAt).getTime();
+            // finishedAt is optional (in-progress runs are 'running' with no
+            // finishedAt). Fall back to startedAt so the rule still has a clock.
+            const lastRunTime = new Date(lastRun.finishedAt ?? lastRun.startedAt).getTime();
             return ctx.nowMs - lastRunTime <= c.ms;
         }
         case 'noRecentRuns':
@@ -185,7 +189,7 @@ const TEMPLATE_VARS = {
         const lastRun = ctx.recentRuns[0];
         if (!lastRun)
             return 0;
-        const lastRunTime = new Date(lastRun.finishedAt).getTime();
+        const lastRunTime = new Date(lastRun.finishedAt ?? lastRun.startedAt).getTime();
         const elapsed = ctx.nowMs - lastRunTime;
         const cooldown = 60 * 60 * 1000;
         return Math.max(0, Math.ceil((cooldown - elapsed) / 60_000));

package/dist/agent/execution-advisor.js

@@ -75,7 +75,7 @@ function computeLegacyAdvice(jobName, job) {
                 advice.skipReason = `${consecutiveErrors} consecutive errors — circuit breaker engaged`;
                 return advice;
             }
-            const lastRunTime = new Date(lastRun.finishedAt).getTime();
+            const lastRunTime = new Date(lastRun.finishedAt ?? lastRun.startedAt).getTime();
             const elapsed = Date.now() - lastRunTime;
             if (elapsed < CIRCUIT_BREAKER_COOLDOWN_MS) {
                 advice.shouldSkip = true;

package/dist/channels/discord-agent-bot.js

@@ -366,7 +366,7 @@ export class AgentBotClient {
                 if (recent.length > 0) {
                     const r = recent[0];
                     const icon = r.status === 'ok' ? '\u2705' : r.status === 'error' ? '\u274C' : '\u23ED';
-                    const ago = Math.round((Date.now() - new Date(r.finishedAt).getTime()) / 60000);
+                    const ago = Math.round((Date.now() - new Date(r.finishedAt ?? r.startedAt).getTime()) / 60000);
                     lastRunLines.push(`${icon} ${display} \u2014 ${formatAgentDuration(ago)} ago`);
                 }
                 else {

package/dist/cli/cron.js

@@ -48,7 +48,7 @@ export async function cmdCronList() {
         const status = job.enabled ? 'enabled' : 'disabled';
         const recent = runLog.readRecent(job.name, 1);
         const lastRun = recent.length > 0
-            ? `last run: ${recent[0].finishedAt.slice(0, 16).replace('T', ' ')} (${recent[0].status})`
+            ? `last run: ${(recent[0].finishedAt ?? recent[0].startedAt).slice(0, 16).replace('T', ' ')} (${recent[0].status})`
             : 'never run';
         const errors = runLog.consecutiveErrors(job.name);
         const errorTag = errors > 0 ? ` [${errors} consecutive error(s)]` : '';

package/dist/cli/dashboard.js

@@ -1350,20 +1350,13 @@ function getCronJobs() {
         }
         catch { /* ignore */ }
     }
-    // Attach recent run history
-    const runsDir = path.join(BASE_DIR, 'cron', 'runs');
+    // Attach recent run history. Single source of truth via CronRunLog.readRecent
+    // — same path the new /api/cron/runs cross-job endpoint uses, so per-card
+    // last-run and the Recent History zone never disagree.
+    const log = new CronRunLog();
     const enriched = jobs.map((job) => {
         const name = String(job.name ?? '');
-        const safe = name.replace(/[^a-zA-Z0-9_-]/g, '_');
-        const logPath = path.join(runsDir, `${safe}.jsonl`);
-        let recentRuns = [];
-        if (existsSync(logPath)) {
-            try {
-                const lines = readFileSync(logPath, 'utf-8').trim().split('\n').filter(Boolean);
-                recentRuns = lines.slice(-10).map((l) => JSON.parse(l)).reverse();
-            }
-            catch { /* ignore */ }
-        }
+        const recentRuns = log.readRecent(name, 10);
         return { ...job, recentRuns };
     });
     return { jobs: enriched };
@@ -4597,6 +4590,25 @@ export async function cmdDashboard(opts) {
     app.post('/api/cron/run/:job', (req, res) => {
         const jobName = req.params.job;
         try {
+            // Concurrency lock (1.18.76+): the CronScheduler persists a sidecar
+            // ~/.clementine/cron-running.json with one entry per in-flight job.
+            // If a manual Run Now collides with an already-running job (whether
+            // from another Run Now click or a scheduled tick), reject 409 so the
+            // user gets immediate feedback instead of two parallel runs racing
+            // each other into the same outputs.
+            try {
+                const runningFile = path.join(BASE_DIR, 'cron-running.json');
+                if (existsSync(runningFile)) {
+                    const entries = JSON.parse(readFileSync(runningFile, 'utf-8'));
+                    const collision = Array.isArray(entries) && entries.find(e => String(e.jobName ?? '').toLowerCase() === jobName.toLowerCase());
+                    if (collision) {
+                        const since = collision.startedAt ? ` (running since ${collision.startedAt})` : '';
+                        res.status(409).json({ ok: false, error: `Job "${jobName}" is already running${since}` });
+                        return;
+                    }
+                }
+            }
+            catch { /* if the sidecar is unreadable, fall through and let the runner handle dedup */ }
             const child = spawn('node', [DIST_ENTRY, 'cron', 'run', jobName], {
                 detached: true,
                 stdio: ['ignore', 'pipe', 'pipe'],
@@ -6584,8 +6596,18 @@ If the tool returns nothing or errors, return an empty array \`[]\`.`,
             }
             jobs[idx].enabled = !jobs[idx].enabled;
             writeCronFileAt(cronFile, parsed, jobs);
-            const state = jobs[idx].enabled ? 'enabled' : 'disabled';
-            res.json({ ok: true, message: `${jobName} is now ${state}` });
+            const enabled = jobs[idx].enabled;
+            const state = enabled ? 'enabled' : 'disabled';
+            // Broadcast so other open dashboard tabs flip the toggle without polling.
+            try {
+                broadcastEvent({ type: 'cron_toggled', data: { job: bareJobName, enabled } });
+            }
+            catch { /* non-fatal */ }
+            // The CronScheduler's watchFile polls CRON.md every 2s and reloads
+            // automatically (cron-scheduler.ts:756 watchCronFile), so the toggle
+            // takes effect within 2 seconds without an explicit reload here. We
+            // surface a hint to the user about that latency in the response.
+            res.json({ ok: true, message: `${jobName} is now ${state}`, enabled });
         }
         catch (err) {
             res.status(500).json({ error: String(err) });
@@ -23441,7 +23463,7 @@ async function openTraceViewer(jobName) {
     traceData = d.traces || [];
 
     if (traceData.length === 0) {
-      document.getElementById('trace-content').innerHTML = '<div style="padding:20px;color:var(--text-muted)">No traces recorded yet. Traces are captured on the next run.</div>';
+      document.getElementById('trace-content').innerHTML = '<div style="padding:24px;color:var(--text-muted);line-height:1.6"><div style="font-weight:500;color:var(--text-secondary);margin-bottom:8px">No traces recorded yet</div><div style="font-size:12px">Traces are captured per run and show every tool call the agent made.<br/>If a recent run errored before any tool was invoked, see the <strong>Recent history</strong> zone on the Tasks page for the error message.</div></div>';
       document.getElementById('trace-run-selector').innerHTML = '';
       return;
     }
@@ -23493,7 +23515,7 @@ function renderTrace(idx) {
       + '</div>';
   }
 
-  document.getElementById('trace-content').innerHTML = html || '<div style="padding:20px;color:var(--text-muted)">Empty trace</div>';
+  document.getElementById('trace-content').innerHTML = html || '<div style="padding:24px;color:var(--text-muted);line-height:1.6"><div style="font-weight:500;color:var(--text-secondary);margin-bottom:8px">This run produced no tool calls</div><div style="font-size:12px">The run started but didn\\x27t reach any tool — it likely errored before the agent acted, or was a no-op response.<br/>Check <strong>Recent history</strong> on the Tasks page for the error message or output preview from this run.</div></div>';
 }
 
 // ── Inline Trace (Execution tab) ──

package/dist/gateway/job-health.js

@@ -85,12 +85,20 @@ export function classifyRunHealth(entry) {
             requiresApproval: true,
         };
     }
-    if (entry.status === 'error' || entry.status === 'retried') {
+    // 'timeout' and 'lost' are explicit terminal failure states (1.18.76+).
+    // 'timeout' = the job exceeded max_hours. 'lost' = the daemon-boot sweep
+    // closed an orphaned 'running' entry that never got a finishedAt because
+    // the daemon crashed mid-run.
+    if (entry.status === 'error' || entry.status === 'retried' || entry.status === 'timeout' || entry.status === 'lost') {
         return {
             ...base,
             status: 'failed',
             evidence: compactEvidence(entry.error, entry.outputPreview, terminalReason ? `terminalReason=${terminalReason}` : undefined),
-            recommendedAction: 'Inspect the latest error and current job definition before applying a fix.',
+            recommendedAction: entry.status === 'lost'
+                ? 'The daemon crashed before this run completed. Check the daemon logs around the startedAt timestamp; if this repeats, lower max_hours or investigate the underlying job.'
+                : entry.status === 'timeout'
+                    ? 'The job exceeded its time budget. Lower max_hours, narrow the prompt, or split into smaller steps.'
+                    : 'Inspect the latest error and current job definition before applying a fix.',
             requiresApproval: true,
         };
     }

package/dist/types.d.ts

@@ -392,8 +392,17 @@ export type TerminalReason = 'blocking_limit' | 'rapid_refill_breaker' | 'prompt
 export interface CronRunEntry {
     jobName: string;
     startedAt: string;
-    finishedAt: string;
-    status: 'ok' | 'error' | 'retried' | 'skipped';
+    /** Optional: in-progress runs are appended with status='running' before the
+     *  finishedAt is known. The runner replaces or supersedes the entry on
+     *  completion. The stale-running sweep emits a closing 'lost' entry for
+     *  any 'running' row whose startedAt has aged past the deadline. */
+    finishedAt?: string;
+    /** 'ok' | 'error' | 'retried' | 'skipped' are terminal. 'running' is in-flight.
+     *  'timeout' fires when max_hours is exceeded. 'lost' is appended by the
+     *  daemon-boot stale sweep when a 'running' entry has no companion close
+     *  (daemon likely crashed mid-run). */
+    status: 'ok' | 'error' | 'retried' | 'skipped' | 'running' | 'timeout' | 'lost';
+    /** 0 for in-progress 'running' rows; populated when terminal. */
     durationMs: number;
     error?: string;
     errorType?: 'transient' | 'permanent';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "clementine-agent",
-  "version": "1.18.75",
+  "version": "1.18.76",
   "description": "Clementine — Personal AI Assistant (TypeScript)",
   "type": "module",
   "main": "dist/index.js",