clementine-agent 1.18.171 → 1.18.172

package/dist/agent/chat-skill-resolver.js

@@ -58,10 +58,21 @@ import pino from 'pino';
 import { searchSkills } from './skill-extractor.js';
 const logger = pino({ name: 'clementine.chat-skill-resolver' });
 // ── Tunables ──────────────────────────────────────────────────────────
-/** Default minimum score to consider a skill match real. Mirrors the
- *  legacy `assistant.ts:1492` threshold. Skill auto-match is heuristic;
- *  this filter keeps weak matches from injecting unrelated tooling. */
+/** Default minimum score for user-authored skill matches. Mirrors the
+ *  legacy `assistant.ts:1492` threshold. */
 const DEFAULT_MIN_SCORE = 4;
+/** Higher threshold applied when ALL matches are auto-generated MCP-derived
+ *  skills (no user-authored signal). 1.18.171 hotfix: a vague chat message
+ *  ("did our changes break it?") matched three unrelated auto-skills
+ *  (ElevenLabs + apify) at score 5.5 each because semantic-only matching
+ *  drifted toward whatever embeddings were closest. Bumping the bar for
+ *  auto-only match-sets keeps that noise out of the system prompt. */
+const AUTO_ONLY_MIN_SCORE = 8;
+/** When ALL matches are auto-generated AND they reference this many or
+ *  more distinct servers, the cluster is treated as semantic-noise and
+ *  the injection is skipped entirely. Three different services have no
+ *  business being "all relevant" to a single user message. */
+const AUTO_ONLY_SERVER_NOISE_THRESHOLD = 3;
 /** Default top-K matches to aggregate. Single-tool requests usually
  *  return one strong match; category requests ("salesforce") return
  *  several similarly-scored auto-skills. Top-3 covers both. Raising
@@ -228,9 +239,36 @@ export function resolveSkillsForChat(userMessage, opts = {}) {
         logger.debug({ err }, 'chat-skill-resolver: searchSkills failed (non-fatal)');
         return empty;
     }
-    const matches = candidates
-        .filter((m) => m.score >= minScore)
+    // 1.18.171 hotfix: detect auto-only match-sets and apply the higher
+    // threshold + noise-cluster filter so vague chat messages don't surface
+    // unrelated MCP context. See the comment block on AUTO_ONLY_MIN_SCORE.
+    const isAutoMatch = (m) => m.name.startsWith('auto-');
+    const candidatesAllAuto = candidates.length > 0 && candidates.every(isAutoMatch);
+    const effectiveMinScore = candidatesAllAuto
+        ? Math.max(minScore, AUTO_ONLY_MIN_SCORE)
+        : minScore;
+    let matches = candidates
+        .filter((m) => m.score >= effectiveMinScore)
         .slice(0, limit);
+    // Auto-only noise cluster filter: when every survivor is auto AND they
+    // collectively reference too many distinct servers (no semantic
+    // clustering on a single service), treat as drift and drop.
+    if (matches.length >= 2 && matches.every(isAutoMatch)) {
+        const seenServers = new Set();
+        for (const m of matches) {
+            for (const s of extractMcpServersFromMatch(m))
+                seenServers.add(s);
+        }
+        if (seenServers.size >= AUTO_ONLY_SERVER_NOISE_THRESHOLD) {
+            logger.info({
+                droppedMatches: matches.map(m => ({ name: m.name, score: Number(m.score.toFixed(2)) })),
+                distinctServers: [...seenServers],
+                reason: 'auto_only_server_cluster_too_wide',
+                queryChars,
+            }, 'chat-skill-resolver: dropped match-set (semantic noise)');
+            matches = [];
+        }
+    }
     if (matches.length === 0) {
         return {
             ...empty,

package/dist/cli/dashboard.js

@@ -21638,25 +21638,34 @@ if('serviceWorker' in navigator){navigator.serviceWorker.getRegistrations().then
           </div>
         </div>
         <div style="display:flex;align-items:center;gap:8px;flex-shrink:0">
-          <button class="btn-secondary" onclick="openSkillStudio()" style="font-size:13px;padding:8px 14px;border-radius:6px;border:1px solid var(--border);background:var(--bg-secondary);color:var(--text-primary);font-weight:500;cursor:pointer;display:inline-flex;align-items:center;gap:6px" title="Open the conversational Skill Studio">
+          <button class="btn-secondary" onclick="openSkillStudio()" style="font-size:13px;padding:8px 14px;border-radius:6px;border:1px solid var(--border);background:var(--bg-secondary);color:var(--text-primary);font-weight:500;cursor:pointer;display:inline-flex;align-items:center;gap:6px" title="Open the natural-language Skill Studio">
             Open Studio
           </button>
-          <button class="btn-primary" onclick="openCreateSkillModalFromComposer()" style="font-size:13px;padding:8px 14px;border-radius:6px;border:none;background:var(--accent);color:#fff;font-weight:500;cursor:pointer;display:inline-flex;align-items:center;gap:6px" title="Open a clean blank skill editor">
-            Blank skill
+          <button class="btn-primary" onclick="openCreateSkillModalFromComposer()" style="font-size:13px;padding:8px 14px;border-radius:6px;border:none;background:var(--accent);color:#fff;font-weight:500;cursor:pointer;display:inline-flex;align-items:center;gap:6px" title="Open a blank SKILL.md editor">
+            Manual editor
           </button>
         </div>
       </div>
+      <div id="skill-composer-home">
       <div id="skill-composer" style="margin:0 0 16px;border:1px solid var(--border);border-radius:8px;background:var(--bg-secondary);padding:14px 16px">
-        <div style="display:grid;grid-template-columns:minmax(280px,1.2fr) minmax(260px,0.8fr);gap:14px;align-items:start">
+        <div style="display:flex;align-items:flex-start;justify-content:space-between;gap:14px;margin-bottom:12px">
+          <div style="min-width:0">
+            <div style="font-size:14px;font-weight:600;color:var(--text-primary);margin-bottom:3px">Skill Studio</div>
+            <div style="font-size:12px;color:var(--text-muted);line-height:1.45">Describe reusable work in plain language. Optional starting points only seed the draft; nothing runs until you save or test it.</div>
+          </div>
+          <div style="font-size:10px;color:var(--text-muted);text-transform:uppercase;letter-spacing:0.04em;white-space:nowrap;margin-top:2px">Natural language first</div>
+        </div>
+        <div style="display:grid;grid-template-columns:repeat(auto-fit,minmax(280px,1fr));gap:14px;align-items:start">
           <div>
-            <label for="skill-composer-text" style="display:block;font-size:11px;font-weight:600;color:var(--text-muted);text-transform:uppercase;letter-spacing:0.04em;margin-bottom:6px">Describe the skill</label>
-            <textarea id="skill-composer-text" rows="4" oninput="updateSkillComposerDraftState()" placeholder="Review my Asana tasks, update a Google Sheet, verify four source systems, then report back in Asana." style="width:100%;box-sizing:border-box;padding:10px 12px;border:1px solid var(--border);border-radius:6px;background:var(--bg-primary);color:var(--text-primary);font-size:13px;line-height:1.45;resize:vertical;min-height:92px"></textarea>
+            <label for="skill-composer-text" style="display:block;font-size:11px;font-weight:600;color:var(--text-muted);text-transform:uppercase;letter-spacing:0.04em;margin-bottom:6px">What should Clementine learn?</label>
+            <textarea id="skill-composer-text" rows="5" oninput="updateSkillComposerDraftState()" placeholder="Find Salesforce contacts I have not touched in 15 days, enrich the accounts with DataForSEO signals, draft cold prospecting emails, then report the drafts back for review." style="width:100%;box-sizing:border-box;padding:10px 12px;border:1px solid var(--border);border-radius:6px;background:var(--bg-primary);color:var(--text-primary);font-size:13px;line-height:1.45;resize:vertical;min-height:112px"></textarea>
+            <div style="margin-top:8px;font-size:11px;color:var(--text-muted);line-height:1.45">Good skills name the repeatable outcome, required tools or data, approval boundaries, and what counts as done.</div>
           </div>
           <div>
-            <div style="font-size:11px;font-weight:600;color:var(--text-muted);text-transform:uppercase;letter-spacing:0.04em;margin-bottom:6px">Starting point</div>
+            <div style="font-size:11px;font-weight:600;color:var(--text-muted);text-transform:uppercase;letter-spacing:0.04em;margin-bottom:6px">Optional starting points</div>
             <div id="skill-composer-modes" style="display:grid;grid-template-columns:repeat(5,minmax(0,1fr));gap:4px;margin-bottom:10px">
               <button type="button" class="skill-composer-mode" data-kind="outcome" onclick="setSkillComposerMode('outcome')" style="padding:7px 6px;border:1px solid var(--accent);border-radius:6px;background:rgba(255,141,0,0.10);color:var(--accent);font-size:11px;font-weight:600;cursor:pointer">Outcome</button>
-              <button type="button" class="skill-composer-mode" data-kind="tool" onclick="setSkillComposerMode('tool')" style="padding:7px 6px;border:1px solid var(--border);border-radius:6px;background:var(--bg-primary);color:var(--text-secondary);font-size:11px;font-weight:600;cursor:pointer">Tool/MCP</button>
+              <button type="button" class="skill-composer-mode" data-kind="tool" onclick="setSkillComposerMode('tool')" style="padding:7px 6px;border:1px solid var(--border);border-radius:6px;background:var(--bg-primary);color:var(--text-secondary);font-size:11px;font-weight:600;cursor:pointer">MCP/API</button>
               <button type="button" class="skill-composer-mode" data-kind="cli" onclick="setSkillComposerMode('cli')" style="padding:7px 6px;border:1px solid var(--border);border-radius:6px;background:var(--bg-primary);color:var(--text-secondary);font-size:11px;font-weight:600;cursor:pointer">CLI</button>
               <button type="button" class="skill-composer-mode" data-kind="project" onclick="setSkillComposerMode('project')" style="padding:7px 6px;border:1px solid var(--border);border-radius:6px;background:var(--bg-primary);color:var(--text-secondary);font-size:11px;font-weight:600;cursor:pointer">Project</button>
               <button type="button" class="skill-composer-mode" data-kind="memory" onclick="setSkillComposerMode('memory')" style="padding:7px 6px;border:1px solid var(--border);border-radius:6px;background:var(--bg-primary);color:var(--text-secondary);font-size:11px;font-weight:600;cursor:pointer">Memory</button>
@@ -21670,12 +21679,13 @@ if('serviceWorker' in navigator){navigator.serviceWorker.getRegistrations().then
             <div id="skill-composer-anchor-summary" style="margin-top:8px;min-height:22px;font-size:11px;color:var(--text-muted);line-height:1.45">No starting point selected.</div>
             <div id="skill-composer-preview" style="margin-top:10px;max-height:180px;overflow:auto;border:1px solid var(--border);border-radius:6px;background:var(--bg-primary);padding:10px 12px;font-size:11px;line-height:1.45;color:var(--text-secondary)"></div>
             <div style="display:flex;align-items:center;justify-content:flex-end;gap:8px;margin-top:12px">
-              <button type="button" class="btn-secondary" onclick="openSkillStudio()" style="font-size:12px;padding:7px 12px;border-radius:6px;border:1px solid var(--border);background:transparent;color:var(--text-primary);cursor:pointer">Open Studio</button>
-              <button type="button" class="btn-primary" id="skill-composer-draft-btn" onclick="startSkillComposerDraft()" disabled style="font-size:12px;padding:7px 14px;border-radius:6px;border:none;background:var(--accent);color:#fff;font-weight:600;cursor:pointer;opacity:0.55">Draft skill</button>
+              <button type="button" class="btn-secondary" onclick="startSkillComposerChat()" style="font-size:12px;padding:7px 12px;border-radius:6px;border:1px solid var(--border);background:transparent;color:var(--text-primary);cursor:pointer">Build in chat</button>
+              <button type="button" class="btn-primary" id="skill-composer-draft-btn" onclick="startSkillComposerDraft()" disabled style="font-size:12px;padding:7px 14px;border-radius:6px;border:none;background:var(--accent);color:#fff;font-weight:600;cursor:pointer;opacity:0.55">Review draft</button>
             </div>
           </div>
         </div>
       </div>
+      </div>
       <div style="display:grid;grid-template-columns:380px 1fr;gap:18px;height:calc(100vh - 360px);min-height:440px">
         <div id="skills-list-pane" style="overflow-y:auto;border:1px solid var(--border);border-radius:8px;background:var(--bg-secondary)">
           <div style="padding:14px 16px;border-bottom:1px solid var(--border);display:flex;align-items:center;gap:8px">
@@ -29214,6 +29224,17 @@ function startSkillComposerDraft() {
   openCreateSkillModalFromComposer({ draft: true });
 }
 
+function startSkillComposerChat() {
+  var prompt = buildSkillComposerPrompt();
+  if (typeof askClementineWith !== 'function') {
+    toast('Chat is not ready yet. Try again after the dashboard finishes loading.', 'error');
+    return;
+  }
+  closeSkillStudio({ silent: true });
+  askClementineWith(prompt, { autoSend: false });
+  toast('Skill-creator prompt loaded in chat. Press send when you are ready.', 'info');
+}
+
 function openCreateSkillModalFromComposer(opts) {
   opts = opts || {};
   var text = ((document.getElementById('skill-composer-text') || {}).value || '').trim();
@@ -29223,6 +29244,7 @@ function openCreateSkillModalFromComposer(opts) {
     return;
   }
   var seed = buildSkillComposerDraftSeed();
+  closeSkillStudio({ silent: true });
   _openSkillModal({ mode: 'create', prefill: seed });
   if (seed.note && typeof toast === 'function') toast(seed.note, 'success');
 }
@@ -30003,7 +30025,7 @@ async function _openSkillModal(opts) {
       +       '<strong style="color:var(--text-secondary);font-weight:600">Format:</strong> '
       +       '<code style="font-size:10px;background:var(--bg-secondary);padding:1px 4px;border-radius:3px">[WHAT it does] + [WHEN to use it] + [trigger phrases]</code>'
       +       ' &nbsp;·&nbsp; under 1024 chars · no <code style="font-size:10px">&lt; &gt;</code> · '
-      +       '<a href="javascript:void(0)" onclick="askClementineWith(\\x27Use skill-creator to help me write a great Anthropic-canonical description for the skill I am building.\\x27)" style="color:var(--accent);text-decoration:none">use skill-creator</a>'
+      +       '<a href="javascript:void(0)" onclick="askSkillCreatorForDescription()" style="color:var(--accent);text-decoration:none">use skill-creator</a>'
       +     '</div>'
       +     '<textarea id="skill-modal-desc" rows="2" oninput="updateSkillModalCounters()" placeholder="Example: Analyzes Outlook emails and drafts triage replies. Use when user asks to triage email or mentions inbox cleanup." style="width:100%;padding:8px 10px;font-size:13px;border:1px solid var(--border);border-radius:6px;background:var(--bg-secondary);color:var(--text-primary);margin-bottom:12px;font-family:inherit;resize:vertical"></textarea>'
       +     '<label style="display:block;font-size:12px;color:var(--text-secondary);margin-bottom:4px;font-weight:500">Allowed tools <span style="color:var(--text-muted)">(comma-separated, leave blank for default)</span></label>'
@@ -30023,7 +30045,9 @@ async function _openSkillModal(opts) {
       + '</div>';
     document.body.appendChild(modal);
   }
-  document.getElementById('skill-modal-heading').textContent = opts.mode === 'edit' ? 'Edit skill: ' + nameVal : 'New skill';
+  document.getElementById('skill-modal-heading').textContent = opts.mode === 'edit'
+    ? 'Edit skill: ' + nameVal
+    : (prefill.note ? 'Review skill draft' : 'Manual skill editor');
   document.getElementById('skill-modal-original-name').value = opts.mode === 'edit' ? nameVal : '';
   document.getElementById('skill-modal-name').value = nameVal;
   document.getElementById('skill-modal-name').disabled = opts.mode === 'edit';
@@ -30044,7 +30068,8 @@ async function _openSkillModal(opts) {
   var errEl = document.getElementById('skill-modal-error');
   if (errEl) { errEl.style.display = 'none'; errEl.textContent = ''; }
   modal.style.display = 'flex';
-  document.getElementById('skill-modal-name').focus();
+  var initialFocus = prefill.note ? document.getElementById('skill-modal-desc') : document.getElementById('skill-modal-name');
+  if (initialFocus) initialFocus.focus();
   if (typeof updateSkillModalCounters === 'function') updateSkillModalCounters();
   if (typeof renderSkillModalToolsPreview === 'function') renderSkillModalToolsPreview();
   // 1.18.168 — render the compact optional template seed in create mode only.
@@ -35396,7 +35421,7 @@ document.addEventListener('click', function(e) {
 // Back-compat shim — older call sites still reference loadProfiles().
 function loadProfiles() { return refreshChatAgentPicker(); }
 
-// ── Skill Studio — opens the Skills page composer ──────────
+// ── Skill Studio — opens the natural-language composer as a real modal ──────────
 
 function openSkillStudio() {
   navigateTo('skills');
@@ -35404,15 +35429,56 @@ function openSkillStudio() {
     try { initSkillComposer(); } catch (_) { /* non-fatal */ }
     var composer = document.getElementById('skill-composer');
     var input = document.getElementById('skill-composer-text');
-    if (composer && composer.scrollIntoView) composer.scrollIntoView({ behavior: 'smooth', block: 'start' });
-    if (composer) {
-      composer.style.boxShadow = '0 0 0 2px rgba(255,141,0,0.35)';
-      setTimeout(function() { composer.style.boxShadow = ''; }, 1400);
+    var modal = document.getElementById('skill-studio-modal');
+    if (!modal) {
+      modal = document.createElement('div');
+      modal.id = 'skill-studio-modal';
+      modal.style.cssText = 'position:fixed;inset:0;background:rgba(0,0,0,0.42);z-index:1050;display:none;align-items:center;justify-content:center;padding:20px';
+      modal.innerHTML =
+        '<div style="width:min(1040px,96vw);max-height:92vh;background:var(--bg-primary);border:1px solid var(--border);border-radius:10px;box-shadow:0 18px 56px rgba(0,0,0,0.35);display:flex;flex-direction:column;overflow:hidden">'
+        + '<div style="display:flex;align-items:flex-start;justify-content:space-between;gap:14px;padding:16px 20px;border-bottom:1px solid var(--border);background:var(--bg-secondary)">'
+        +   '<div style="min-width:0">'
+        +     '<div style="font-size:16px;font-weight:600;color:var(--text-primary);margin-bottom:3px">Skill Studio</div>'
+        +     '<div style="font-size:12px;color:var(--text-muted);line-height:1.45">Start with the outcome. Add MCP, CLI, project, or memory anchors only when they are real dependencies. Review the generated SKILL.md before saving.</div>'
+        +   '</div>'
+        +   '<button type="button" onclick="closeSkillStudio()" title="Close Skill Studio" style="background:none;border:none;font-size:20px;color:var(--text-muted);cursor:pointer;padding:0 4px;line-height:1">&times;</button>'
+        + '</div>'
+        + '<div id="skill-studio-modal-body" style="padding:18px 20px;overflow:auto;flex:1;min-height:0"></div>'
+        + '<div style="display:flex;align-items:center;gap:8px;justify-content:flex-end;padding:14px 20px;border-top:1px solid var(--border);background:var(--bg-secondary)">'
+        +   '<button type="button" onclick="closeSkillStudio()" style="font-size:13px;padding:7px 14px;border-radius:6px;border:1px solid var(--border);background:transparent;color:var(--text-primary);cursor:pointer">Keep on page</button>'
+        +   '<button type="button" onclick="startSkillComposerChat()" style="font-size:13px;padding:7px 14px;border-radius:6px;border:1px solid var(--border);background:var(--bg-primary);color:var(--text-primary);cursor:pointer">Build in chat</button>'
+        +   '<button type="button" onclick="startSkillComposerDraft()" class="btn-primary" style="font-size:13px;padding:7px 16px;border-radius:6px;border:none;background:var(--accent);color:#fff;font-weight:600;cursor:pointer">Review draft</button>'
+        + '</div>'
+        + '</div>';
+      document.body.appendChild(modal);
     }
+    var body = document.getElementById('skill-studio-modal-body');
+    if (composer && body && composer.parentElement !== body) {
+      composer.dataset.originalMargin = composer.style.margin || '';
+      body.appendChild(composer);
+      composer.style.margin = '0';
+    }
+    modal.style.display = 'flex';
+    updateSkillComposerDraftState();
     if (input) input.focus();
   }, 80);
 }
 
+function closeSkillStudio(opts) {
+  opts = opts || {};
+  var modal = document.getElementById('skill-studio-modal');
+  var composer = document.getElementById('skill-composer');
+  var home = document.getElementById('skill-composer-home');
+  if (composer && home && composer.parentElement !== home) {
+    home.appendChild(composer);
+    composer.style.margin = composer.dataset.originalMargin || '0 0 16px';
+  }
+  if (modal) modal.style.display = 'none';
+  if (!opts.silent && composer && composer.scrollIntoView) {
+    composer.scrollIntoView({ behavior: 'smooth', block: 'start' });
+  }
+}
+
 function updateBuilderMode() {
   var type = (document.getElementById('builder-type') || {}).value || 'skill';
   var title = document.getElementById('builder-page-title');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "clementine-agent",
-  "version": "1.18.171",
+  "version": "1.18.172",
   "description": "Clementine — Personal AI Assistant (TypeScript)",
   "type": "module",
   "main": "dist/index.js",