clementine-agent 1.0.33 → 1.0.35

package/dist/agent/self-improve.js

@@ -198,6 +198,11 @@ export class SelfImproveLoop {
         const loopStart = Date.now();
         const history = this.loadExperimentLog();
         let consecutiveLow = 0;
+        // Cap accepted proposals per run so the owner's approval queue stays
+        // scannable. The nightly loop should surface 1-3 solid ideas — not a
+        // flood — even if the hypothesizer is inspired.
+        const maxAcceptancesPerRun = 3;
+        let acceptedThisRun = 0;
         try {
             // Step 1: Gather baseline metrics
             const metrics = await this.gatherMetrics();
@@ -379,6 +384,7 @@ export class SelfImproveLoop {
                             }
                         }
                         consecutiveLow = 0;
+                        acceptedThisRun++;
                     }
                     else {
                         consecutiveLow++;
@@ -389,7 +395,13 @@ export class SelfImproveLoop {
                         area: proposal.area,
                         score,
                         accepted,
+                        acceptedThisRun,
                     }, `Iteration ${i} complete`);
+                    // Stop once we've landed enough good ideas for the owner to review.
+                    if (acceptedThisRun >= maxAcceptancesPerRun) {
+                        logger.info({ acceptedThisRun }, 'Reached max-acceptances per run — stopping');
+                        break;
+                    }
                 }
                 catch (err) {
                     const classified = classifyError(err);
@@ -666,6 +678,17 @@ export class SelfImproveLoop {
         const recentTargets = new Map();
         const recentAreas = new Map();
         for (const e of history.slice(-50)) {
+            // Skip error-fallback experiments. They default to `area: 'soul', target:
+            // 'unknown'` (see the error-catch block below) and historically have
+            // poisoned diversity accounting — e.g. a ~2-week stretch of API errors
+            // artificially blacklisted the whole 'soul' area even though no real
+            // attempt was made. A crashed iteration isn't evidence we explored the
+            // space, just that the SDK call failed.
+            if (e.reason?.startsWith('Error:'))
+                continue;
+            // Plateau markers also shouldn't count as attempts.
+            if (e.hypothesis?.startsWith('No new hypothesis'))
+                continue;
             const key = `${e.area}:${e.target}`;
             const ts = Date.parse(e.startedAt);
             const tsMs = Number.isFinite(ts) ? ts : 0;
@@ -717,7 +740,7 @@ export class SelfImproveLoop {
                     (overTargeted.length > 0
                         ? `These specific targets MUST NOT be re-targeted:\n${overTargeted.map(t => `- ${t}`).join('\n')}\n`
                         : '') +
-                    `Choose a DIFFERENT area/target. If no other improvement is needed, output { "area": null }.\n`
+                    `Choose a DIFFERENT area/target. If no other improvement is genuinely needed today, return an empty results array: { "results": [] }.\n`
                 : '');
         const patternAnalysis = this.analyzeExperimentPatterns(history);
         // Format negative feedback
@@ -802,18 +825,17 @@ export class SelfImproveLoop {
             agentFocusText +
             soulCandidatesText +
             `\n## Instructions\n` +
-            `Rank these by expected impact. For each opportunity, specify:\n` +
+            `Propose **1-3 concrete, high-impact improvements** the owner should review today — no fewer (aim for at least one actionable suggestion when data warrants it), no more (the owner reads each proposal manually and you'll overwhelm them). Rank by expected impact; drop anything below "solid idea".\n\n` +
+            `For each opportunity, specify:\n` +
             `- area: ${areas}\n` +
-            `- target: the file/agent slug that should change\n` +
+            `- target: the exact file path / agent slug / cron job name that should change (not "unknown", not "n/a")\n` +
             `- what: a 1-sentence description of what specifically should change\n` +
-            `- why: which metric this should improve\n\n` +
+            `- why: which metric or signal from the data above this should improve\n\n` +
             `Area notes:\n` +
             `- For "goal": target = "{owner}/{goal-slug}" (e.g. "clementine/improve-reply-rates" or "ross-the-sdr/book-demos"). ` +
             `Propose when you observe a pattern in completed tasks or cron runs that suggests a missing or stale goal. ` +
             `The proposedChange must be a JSON goal object with at minimum: title, description, priority, reviewFrequency.\n\n` +
-            `Output ONLY a JSON array of 1-3 objects (no markdown, no explanation):\n` +
-            `[{ "area": "...", "target": "...", "what": "...", "why": "..." }]\n` +
-            `If no improvement is needed, output: []`;
+            `Return your answer as a JSON object matching the schema: { "results": [ ... ] }. Up to 3 items. If absolutely nothing actionable today, return { "results": [] }.`;
         const analysisResult = await this.assistant.runPlanStep('si-analyze', analysisPrompt, {
             tier: 2,
             maxTurns: 3,

package/dist/memory/context-assembler.js

@@ -33,14 +33,15 @@ export async function assembleContext(options) {
             priority: 0,
             maxChars: 500,
             minRemainingBudget: 0,
-            resolve: () => {
+            resolve: (budget) => {
                 if (!fs.existsSync(idPath))
                     return '';
                 try {
                     const content = fs.readFileSync(idPath, 'utf-8').trim();
                     if (!content)
                         return '';
-                    return `## Identity\n\n${content}`;
+                    const block = `## Identity\n\n${content}`;
+                    return block.length > budget ? block.slice(0, budget) : block;
                 }
                 catch {
                     return '';
@@ -56,14 +57,15 @@ export async function assembleContext(options) {
             priority: 1,
             maxChars: isAutonomous ? 1000 : 2000,
             minRemainingBudget: 0,
-            resolve: () => {
+            resolve: (budget) => {
                 if (!fs.existsSync(wmPath))
                     return '';
                 try {
                     const content = fs.readFileSync(wmPath, 'utf-8').trim();
                     if (!content)
                         return '';
-                    return `## Working Memory (scratchpad)\n\n${content}`;
+                    const block = `## Working Memory (scratchpad)\n\n${content}`;
+                    return block.length > budget ? block.slice(0, budget) : block;
                 }
                 catch {
                     return '';
@@ -79,10 +81,15 @@ export async function assembleContext(options) {
             priority: 2,
             maxChars: isAutonomous ? 1000 : 2000,
             minRemainingBudget: 500,
-            resolve: () => skillCtx,
+            resolve: (budget) => skillCtx.length > budget ? skillCtx.slice(0, budget) : skillCtx,
         });
     }
     // Slot 3: Memory search results (core recall)
+    // formatResultsForPrompt respects the effective budget and breaks on
+    // entry boundaries (not mid-string), so we don't need the outer
+    // slice-truncation to kick in here. Previously this slot was double-
+    // truncated: formatter used its own 8000 cap, then the outer loop cut
+    // further by Math.min(maxChars, remaining), chopping entries in half.
     if (options.memoryResults && options.memoryResults.length > 0) {
         const results = options.memoryResults;
         slots.push({
@@ -90,10 +97,7 @@ export async function assembleContext(options) {
             priority: 3,
             maxChars: isAutonomous ? 2000 : 8000,
             minRemainingBudget: 200,
-            resolve: () => {
-                // formatResultsForPrompt already handles truncation within its own budget
-                return formatResultsForPrompt(results, isAutonomous ? 2000 : 8000);
-            },
+            resolve: (budget) => formatResultsForPrompt(results, budget),
         });
     }
     // Slot 4: Graph relationships (supplementary)
@@ -104,7 +108,7 @@ export async function assembleContext(options) {
             priority: 4,
             maxChars: 2000,
             minRemainingBudget: 500,
-            resolve: () => graphCtx,
+            resolve: (budget) => graphCtx.length > budget ? graphCtx.slice(0, budget) : graphCtx,
         });
     }
     // Sort by priority (lower number = higher priority)
@@ -121,18 +125,27 @@ export async function assembleContext(options) {
             continue;
         }
         try {
-            let content = await slot.resolve();
+            // The slot's effective budget is the smaller of its own maxChars and
+            // what's actually remaining across all slots. Passed into resolve so
+            // the slot produces right-sized content up front, not a mid-entry
+            // truncation after the fact.
+            const effectiveBudget = Math.min(slot.maxChars, remaining);
+            const content = await slot.resolve(effectiveBudget);
             if (!content) {
                 skipped.push(slot.name);
                 continue;
             }
-            // Truncate to the smaller of slot max and remaining budget
-            const limit = Math.min(slot.maxChars, remaining);
-            if (content.length > limit) {
-                content = content.slice(0, limit) + '\n...(truncated)';
+            // Safety net: if resolve() ignored the budget and returned too much,
+            // clip at a line boundary rather than a character boundary so we don't
+            // leave a malformed half-block in the prompt.
+            let finalContent = content;
+            if (content.length > effectiveBudget) {
+                const trimmed = content.slice(0, effectiveBudget);
+                const lastNewline = trimmed.lastIndexOf('\n');
+                finalContent = (lastNewline > 0 ? trimmed.slice(0, lastNewline) : trimmed) + '\n...(truncated)';
             }
-            parts.push(content);
-            remaining -= content.length;
+            parts.push(finalContent);
+            remaining -= finalContent.length;
             included.push(slot.name);
         }
         catch {

package/dist/memory/graph-store.d.ts

@@ -61,6 +61,22 @@ export declare class GraphStore {
     syncFromVault(vaultDir: string, agentsDir: string): Promise<GraphSyncStats>;
     extractAndStoreRelationships(triplets: RelationshipTriplet[]): Promise<void>;
     enrichWithGraphContext(entityIds: string[], _maxHops?: number): Promise<string>;
+    /**
+     * Drop Note nodes whose slug isn't in the caller-provided set of valid IDs.
+     * Wikilinks into deleted vault files leave dangling Note nodes with
+     * MENTIONS edges pointing at them — this cleans those up.
+     *
+     * Deliberately NOT auto-scheduled: blast radius is significant, and the
+     * caller (dashboard action, MCP tool, manual script) should supply the
+     * authoritative valid-IDs set. Runs DETACH DELETE so incoming edges go
+     * with the node.
+     *
+     * Returns counts of what was removed.
+     */
+    invalidateOrphanedNotes(validIds: Set<string>): Promise<{
+        scanned: number;
+        deleted: number;
+    }>;
 }
 export declare function getSharedGraphStore(persistenceDir: string): Promise<GraphStore | null>;
 //# sourceMappingURL=graph-store.d.ts.map

package/dist/memory/graph-store.js

@@ -580,6 +580,53 @@ export class GraphStore {
             return '';
         return '\n## Relationship Context\n' + lines.join('\n');
     }
+    /**
+     * Drop Note nodes whose slug isn't in the caller-provided set of valid IDs.
+     * Wikilinks into deleted vault files leave dangling Note nodes with
+     * MENTIONS edges pointing at them — this cleans those up.
+     *
+     * Deliberately NOT auto-scheduled: blast radius is significant, and the
+     * caller (dashboard action, MCP tool, manual script) should supply the
+     * authoritative valid-IDs set. Runs DETACH DELETE so incoming edges go
+     * with the node.
+     *
+     * Returns counts of what was removed.
+     */
+    async invalidateOrphanedNotes(validIds) {
+        if (!this.available)
+            return { scanned: 0, deleted: 0 };
+        if (validIds.size === 0) {
+            // Defense: refuse to run with an empty set — would delete every Note.
+            logger.warn('invalidateOrphanedNotes called with empty validIds — refusing to run');
+            return { scanned: 0, deleted: 0 };
+        }
+        let scanned = 0;
+        let deleted = 0;
+        try {
+            const res = await this.graph.query('MATCH (n:Note) RETURN n.id AS id');
+            const rows = (res.data ?? []);
+            scanned = rows.length;
+            for (const row of rows) {
+                const id = row.id;
+                if (!id || validIds.has(id))
+                    continue;
+                try {
+                    await this.graph.query('MATCH (n:Note {id: $id}) DETACH DELETE n', { params: { id } });
+                    deleted++;
+                }
+                catch (err) {
+                    logger.debug({ err, id }, 'Orphan Note deletion failed');
+                }
+            }
+        }
+        catch (err) {
+            logger.warn({ err }, 'invalidateOrphanedNotes query failed');
+        }
+        if (deleted > 0) {
+            logger.info({ scanned, deleted, validIdsSize: validIds.size }, 'Invalidated orphan Note nodes');
+        }
+        return { scanned, deleted };
+    }
 }
 // ── Shared Client Helper ───────────────────────────────────────────────
 /**

package/dist/memory/store.js

@@ -14,6 +14,7 @@ import { appendFileSync, existsSync, mkdirSync, readFileSync, readdirSync, statS
 import path from 'node:path';
 import Database from 'better-sqlite3';
 import { BASE_DIR } from '../config.js';
+import { temporalDecay } from './search.js';
 import * as embeddingsModule from './embeddings.js';
 import { chunkFile } from './chunker.js';
 import { mmrRerank } from './mmr.js';
@@ -733,20 +734,30 @@ export class MemoryStore {
      * Get the most recently updated chunks.
      */
     getRecentChunks(limit = 5, agentSlug, filters, strict = false) {
-        const mapRow = (row) => ({
-            sourceFile: row.source_file,
-            section: row.section,
-            content: row.content,
-            score: 0,
-            chunkType: row.chunk_type,
-            matchType: 'recency',
-            lastUpdated: row.updated_at ?? '',
-            chunkId: row.id,
-            salience: row.salience ?? 0,
-            agentSlug: row.agent_slug ?? null,
-            category: row.category,
-            topic: row.topic,
-        });
+        const now = Date.now();
+        const mapRow = (row) => {
+            // Score recency by exponential decay (half-life 30 days). Previously
+            // every recent row got score=0, which meant MMR's min-max normalization
+            // ranked them at the floor — a two-day-old chunk and a six-month-old
+            // chunk were indistinguishable. Decay lets recent results actually
+            // compete with FTS and vector matches during rerank.
+            const daysOld = row.updated_at ? (now - Date.parse(row.updated_at)) / 86_400_000 : 0;
+            const decayed = temporalDecay(daysOld);
+            return {
+                sourceFile: row.source_file,
+                section: row.section,
+                content: row.content,
+                score: decayed,
+                chunkType: row.chunk_type,
+                matchType: 'recency',
+                lastUpdated: row.updated_at ?? '',
+                chunkId: row.id,
+                salience: row.salience ?? 0,
+                agentSlug: row.agent_slug ?? null,
+                category: row.category,
+                topic: row.topic,
+            };
+        };
         // Build optional WHERE clauses for category/topic
         let filterSql = '';
         const filterParams = [];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "clementine-agent",
-  "version": "1.0.33",
+  "version": "1.0.35",
   "description": "Clementine — Personal AI Assistant (TypeScript)",
   "type": "module",
   "main": "dist/index.js",