clementine-agent 1.0.23 → 1.0.25

package/dist/agent/insight-engine.js

@@ -11,8 +11,10 @@
 import { existsSync, readFileSync, readdirSync } from 'node:fs';
 import path from 'node:path';
 import pino from 'pino';
-import { GOALS_DIR, BASE_DIR } from '../config.js';
+import { GOALS_DIR, BASE_DIR, MEMORY_DB_PATH, VAULT_DIR } from '../config.js';
 import { listAllGoals } from '../tools/shared.js';
+import { computeBrokenJobs } from '../gateway/failure-monitor.js';
+import { MemoryStore } from '../memory/store.js';
 const logger = pino({ name: 'clementine.insight-engine' });
 const BASE_COOLDOWN_MS = 2 * 60 * 60 * 1000; // 2 hours
 const MAX_DAILY_INSIGHTS = 3;
@@ -172,9 +174,7 @@ export function gatherInsightSignals(gateway) {
     //    with a diagnosis is a real, actionable signal the owner should
     //    see proactively rather than stumble across in the dashboard.
     try {
-        // eslint-disable-next-line @typescript-eslint/no-require-imports
-        const fm = require('../gateway/failure-monitor.js');
-        const broken = fm.computeBrokenJobs();
+        const broken = computeBrokenJobs();
         for (const b of broken.slice(0, 3)) {
             const hint = b.diagnosis?.rootCause
                 ? ` — ${b.diagnosis.rootCause.slice(0, 120)}`
@@ -185,14 +185,13 @@ export function gatherInsightSignals(gateway) {
             }
         }
     }
-    catch { /* failure-monitor may not be loadable; fine */ }
+    catch (err) {
+        logger.debug({ err }, 'Failed to pull broken-jobs signals');
+    }
     // 6. Claim tracker — failed claims in the last N hours erode trust.
     //    Surface them so the owner sees "Clementine said she'd do X; she
     //    didn't" instead of silently swallowing the miss.
     try {
-        // eslint-disable-next-line @typescript-eslint/no-require-imports
-        const { MemoryStore } = require('../memory/store.js');
-        const { MEMORY_DB_PATH, VAULT_DIR } = require('../config.js');
         if (existsSync(MEMORY_DB_PATH)) {
             const store = new MemoryStore(MEMORY_DB_PATH, VAULT_DIR);
             store.initialize();
@@ -209,7 +208,9 @@ export function gatherInsightSignals(gateway) {
             store.close();
         }
     }
-    catch { /* non-fatal */ }
+    catch (err) {
+        logger.debug({ err }, 'Failed to pull failed-claims signals');
+    }
     return signals;
 }
 /**

package/dist/agent/route-classifier.d.ts

@@ -43,7 +43,7 @@ export interface RouteDecision {
  * - `slack:agent:*`, `slack:channel:*:{slug}:*`
  * - `team:*` — inter-agent messages travel via team-bus, never route
  */
-export declare function isRoutable(sessionKey: string, ownerAgentSlugs: Set<string>): boolean;
+export declare function isRoutable(sessionKey: string, _ownerAgentSlugs: Set<string>): boolean;
 /**
  * Classify a user message. Returns null if the call fails — caller
  * should fall back to Clementine handling.

package/dist/agent/route-classifier.js

@@ -38,31 +38,37 @@ const logger = pino({ name: 'clementine.route-classifier' });
  * - `slack:agent:*`, `slack:channel:*:{slug}:*`
  * - `team:*` — inter-agent messages travel via team-bus, never route
  */
-export function isRoutable(sessionKey, ownerAgentSlugs) {
+export function isRoutable(sessionKey, _ownerAgentSlugs) {
     if (!sessionKey)
         return false;
     const parts = sessionKey.split(':');
+    // Structural rule: any 5+ part channel key has an agent slug embedded
+    // (e.g. `discord:channel:{channelId}:{slug}:{userId}`). We reject this
+    // regardless of whether the slug appears in a passed-in roster — the
+    // ownerAgentSlugs list can be stale during agent-hire/rename events,
+    // and the key SHAPE is the safer source of truth.
+    //
+    // `_ownerAgentSlugs` is kept in the signature for future use but the
+    // current implementation is structure-only.
     // Agent-bot DMs and member sessions are always agent-scoped
     if (parts[0] === 'discord') {
         const kind = parts[1];
         if (kind === 'agent' || kind === 'member' || kind === 'member-dm')
             return false;
-        // 5-part discord:channel:{channelId}:{slug}:{userId} means agent in team chat
-        if (kind === 'channel' && parts.length >= 5 && ownerAgentSlugs.has(parts[3] ?? '')) {
+        // Any 5+ part channel key → agent-scoped, never route
+        if (kind === 'channel' && parts.length >= 5)
             return false;
-        }
         // discord:user:* and the 4-part discord:channel:{channelId}:{userId} pass
-        return kind === 'user' || kind === 'channel';
+        return kind === 'user' || (kind === 'channel' && parts.length === 4);
     }
     if (parts[0] === 'slack') {
         const kind = parts[1];
         if (kind === 'agent')
             return false;
-        // slack:channel:{channelId}:{slug}:{userId} — agent-scoped
-        if (kind === 'channel' && parts.length >= 5 && ownerAgentSlugs.has(parts[3] ?? '')) {
+        // Any 5+ part channel key → agent-scoped
+        if (kind === 'channel' && parts.length >= 5)
             return false;
-        }
-        return kind === 'user' || kind === 'dm' || kind === 'channel';
+        return kind === 'user' || kind === 'dm' || (kind === 'channel' && parts.length === 4);
     }
     if (parts[0] === 'telegram')
         return parts[1] === 'user' || /^\d+$/.test(parts[1] ?? '');

package/dist/gateway/claim-tracker.js

@@ -123,13 +123,24 @@ const PATTERNS = [
  * Bounded to prevent memory growth — oldest entries are evicted.
  */
 const MAX_PENDING_LLM = 20;
+const PENDING_LLM_TTL_MS = 6 * 60 * 60 * 1000; // 6h — after that a claim is stale anyway
 const pendingLLMExtraction = [];
+function pruneExpiredPending(now = Date.now()) {
+    while (pendingLLMExtraction.length > 0) {
+        const oldest = pendingLLMExtraction[0];
+        if (now - oldest.queuedAt <= PENDING_LLM_TTL_MS)
+            break;
+        pendingLLMExtraction.shift();
+    }
+}
 function enqueueForLLM(text, sessionKey, agentSlug) {
+    const now = Date.now();
+    pruneExpiredPending(now);
     // De-dup by text hash within the queue — don't re-enqueue the same DM.
     const hash = sha1(text);
-    if (pendingLLMExtraction.some(e => sha1(e.text) === hash))
+    if (pendingLLMExtraction.some(e => e.hash === hash))
         return;
-    pendingLLMExtraction.push({ text, sessionKey, agentSlug, queuedAt: Date.now() });
+    pendingLLMExtraction.push({ text, hash, sessionKey, agentSlug, queuedAt: now });
     while (pendingLLMExtraction.length > MAX_PENDING_LLM)
         pendingLLMExtraction.shift();
 }
@@ -208,11 +219,16 @@ export function extractClaims(text, sessionKey, agentSlug) {
  * the next sweep.
  */
 export async function drainLLMFallback(gateway, maxPerSweep = 3) {
+    pruneExpiredPending();
     let drained = 0;
-    const batch = pendingLLMExtraction.splice(0, Math.min(maxPerSweep, pendingLLMExtraction.length));
+    // Peek — don't remove yet. We only splice on successful processing so a
+    // transient LLM failure doesn't silently drop the candidate.
+    const batch = pendingLLMExtraction.slice(0, Math.min(maxPerSweep, pendingLLMExtraction.length));
+    const toRemove = new Set();
     for (const item of batch) {
         try {
             const claims = await llmExtractClaims(item.text, gateway);
+            toRemove.add(item.hash); // success (or "no claims" — not worth re-trying)
             if (claims.length === 0)
                 continue;
             const toRecord = claims.map(c => ({
@@ -229,9 +245,18 @@ export async function drainLLMFallback(gateway, maxPerSweep = 3) {
             drained += claims.length;
         }
         catch (err) {
+            // Don't add to toRemove — leave in queue for next sweep. TTL eventually
+            // evicts permanently-failing entries.
             logger.debug({ err }, 'LLM fallback extraction failed for one DM');
         }
     }
+    // Remove successfully-processed entries in one pass
+    if (toRemove.size > 0) {
+        for (let i = pendingLLMExtraction.length - 1; i >= 0; i--) {
+            if (toRemove.has(pendingLLMExtraction[i].hash))
+                pendingLLMExtraction.splice(i, 1);
+        }
+    }
     return drained;
 }
 async function llmExtractClaims(text, gateway) {

package/dist/gateway/failure-diagnostics.js

@@ -10,7 +10,7 @@
  * so the response to a silent failure is "here's what's wrong and
  * here's what to change" rather than "go investigate."
  */
-import { existsSync, mkdirSync, readFileSync, writeFileSync, } from 'node:fs';
+import { existsSync, mkdirSync, readFileSync, renameSync, writeFileSync, } from 'node:fs';
 import path from 'node:path';
 import pino from 'pino';
 import { AGENTS_DIR, BASE_DIR, CRON_FILE } from '../config.js';
@@ -52,7 +52,9 @@ function loadCache() {
 function saveCache(cache) {
     try {
         mkdirSync(path.dirname(CACHE_FILE), { recursive: true });
-        writeFileSync(CACHE_FILE, JSON.stringify(cache, null, 2));
+        const tmp = CACHE_FILE + '.tmp';
+        writeFileSync(tmp, JSON.stringify(cache, null, 2));
+        renameSync(tmp, CACHE_FILE);
     }
     catch (err) {
         logger.warn({ err }, 'Failed to persist diagnostic cache');

package/dist/gateway/failure-monitor.js

@@ -15,10 +15,11 @@
  * Read-only with respect to the cron run logs and advisor events; mutates
  * only its own state file (cron/failure-monitor.json).
  */
-import { appendFileSync, existsSync, mkdirSync, readFileSync, readdirSync, writeFileSync, } from 'node:fs';
+import { appendFileSync, existsSync, mkdirSync, readFileSync, readdirSync, renameSync, writeFileSync, } from 'node:fs';
 import path from 'node:path';
+import Database from 'better-sqlite3';
 import pino from 'pino';
-import { BASE_DIR } from '../config.js';
+import { BASE_DIR, MEMORY_DB_PATH } from '../config.js';
 const logger = pino({ name: 'clementine.failure-monitor' });
 const RUNS_DIR = path.join(BASE_DIR, 'cron', 'runs');
 const ADVISOR_EVENTS_FILE = path.join(BASE_DIR, 'cron', 'advisor-events.jsonl');
@@ -50,7 +51,11 @@ function loadState() {
 function saveState(state) {
     try {
         mkdirSync(path.dirname(STATE_FILE), { recursive: true });
-        writeFileSync(STATE_FILE, JSON.stringify(state, null, 2));
+        // Atomic write — write to temp file then rename. Prevents partial
+        // writes from corrupting the state if the process is killed mid-write.
+        const tmp = STATE_FILE + '.tmp';
+        writeFileSync(tmp, JSON.stringify(state, null, 2));
+        renameSync(tmp, STATE_FILE);
     }
     catch (err) {
         logger.warn({ err }, 'Failed to persist failure-monitor state');
@@ -100,11 +105,8 @@ function isFailure(entry, gradeCache) {
 function loadGradeCache() {
     const cache = new Map();
     try {
-        const { MEMORY_DB_PATH } = require('../config.js');
         if (!existsSync(MEMORY_DB_PATH))
             return cache;
-        // eslint-disable-next-line @typescript-eslint/no-require-imports
-        const Database = require('better-sqlite3');
         const db = new Database(MEMORY_DB_PATH, { readonly: true });
         try {
             const rows = db.prepare(`SELECT job_name, started_at, passed FROM graded_runs
@@ -116,7 +118,9 @@ function loadGradeCache() {
         catch { /* graded_runs may not exist on older DBs */ }
         db.close();
     }
-    catch { /* non-fatal */ }
+    catch (err) {
+        logger.warn({ err }, 'Failed to load grade cache');
+    }
     return cache;
 }
 /**

package/dist/gateway/fix-verification.js

@@ -7,7 +7,7 @@
  * owner with the verdict — succeeded or still failing — so a self-reported
  * "fix" can't go untested again.
  */
-import { existsSync, mkdirSync, readFileSync, writeFileSync, } from 'node:fs';
+import { existsSync, mkdirSync, readFileSync, renameSync, writeFileSync, } from 'node:fs';
 import path from 'node:path';
 import crypto from 'node:crypto';
 import pino from 'pino';
@@ -29,7 +29,9 @@ function loadState() {
 function saveState(state) {
     try {
         mkdirSync(path.dirname(STATE_FILE), { recursive: true });
-        writeFileSync(STATE_FILE, JSON.stringify(state, null, 2));
+        const tmp = STATE_FILE + '.tmp';
+        writeFileSync(tmp, JSON.stringify(state, null, 2));
+        renameSync(tmp, STATE_FILE);
     }
     catch (err) {
         logger.warn({ err }, 'Failed to persist fix-verification state');

package/dist/gateway/router.js

@@ -5,7 +5,7 @@
  * Manages per-user/channel sessions for conversation continuity.
  */
 import path from 'node:path';
-import { existsSync, readFileSync, writeFileSync } from 'node:fs';
+import { appendFileSync, existsSync, readFileSync, writeFileSync } from 'node:fs';
 import pino from 'pino';
 import { PersonalAssistant } from '../agent/assistant.js';
 import { SelfImproveLoop } from '../agent/self-improve.js';
@@ -743,7 +743,15 @@ export class Gateway {
                 // specific agent profile, classify whether the message should go
                 // to a specialist. Direct-to-agent-bot sessions bypass this entirely.
                 // Small-talk and meta queries stay with Clementine by default.
-                const routingResult = !isInternalMsg && !sess?.profile && !text.startsWith('!')
+                //
+                // Also bypass structured workflow messages — button clicks, approvals,
+                // and other system-injected interactions are not free-form chat and
+                // shouldn't be reclassified. They already have an intended flow.
+                const isStructuredWorkflowMsg = text.startsWith('[Button clicked:')
+                    || text.startsWith('[Approval:')
+                    || text.startsWith('[Reaction:')
+                    || text.startsWith('[System:');
+                const routingResult = !isInternalMsg && !sess?.profile && !text.startsWith('!') && !isStructuredWorkflowMsg
                     ? await this._maybeRouteToSpecialist(sessionKey, text, onText)
                     : null;
                 if (routingResult?.delegated) {
@@ -1511,8 +1519,6 @@ function logRouteDecision(opts) {
     while (_routeAuditBuffer.length > 200)
         _routeAuditBuffer.shift();
     try {
-        // eslint-disable-next-line @typescript-eslint/no-require-imports
-        const { appendFileSync } = require('node:fs');
         appendFileSync(Gateway.routeAuditLogPath(), JSON.stringify(entry) + '\n');
     }
     catch (err) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "clementine-agent",
-  "version": "1.0.23",
+  "version": "1.0.25",
   "description": "Clementine — Personal AI Assistant (TypeScript)",
   "type": "module",
   "main": "dist/index.js",