clay-server 2.39.0-beta.2 → 2.39.0-beta.4

package/lib/daemon.js

@@ -1248,11 +1248,114 @@ var ipc = createIPCServer(socketPath(), function (msg) {
   }
 });
 
+// --- Cleanup stale SDK warmup CLI session files ---
+//
+// On adapter init the SDK is given a dummy "hi" prompt to discover models,
+// skills, and capabilities. Even though we abort before any response
+// arrives, the SDK creates a real CLI session jsonl on disk. Going forward
+// we delete those inline (see lib/yoke/adapters/claude.js and
+// claude-worker.js), but installs from before that fix can have a long
+// tail of "hi"-only sessions polluting the Resume CLI session dialog.
+//
+// On every daemon startup we scan REAL_HOME/.claude/projects/*/ and unlink
+// files that match a strict warmup signature so legitimate "hi" sessions
+// from real users are never touched. All checks must pass:
+//
+//   1. file size < 64 KB                  (real sessions grow past this fast;
+//      threshold is generous because warmup files include the SDK's
+//      skill_listing / deferred_tools attachments which can run into the
+//      tens of KB on its own)
+//   2. mtime older than 60 seconds        (avoid racing an in-flight warmup)
+//   3. exactly one user message, content text equals literal "hi"
+//   4. zero assistant messages            (real users virtually always get a reply)
+//
+// Multi-user OS-isolated installs have per-user ~/.claude trees that the
+// daemon process can't traverse; the inline cleanup in claude-worker.js
+// covers those.
+function cleanupSdkWarmupSessions() {
+  var projectsRoot = path.join(REAL_HOME, ".claude", "projects");
+  var projectDirs;
+  try { projectDirs = fs.readdirSync(projectsRoot, { withFileTypes: true }); }
+  catch (e) { return; }
+
+  var deleted = 0;
+  var nowMs = Date.now();
+  var MAX_BYTES = 64 * 1024;
+  var MIN_AGE_MS = 60 * 1000;
+
+  for (var di = 0; di < projectDirs.length; di++) {
+    if (!projectDirs[di].isDirectory()) continue;
+    var projDir = path.join(projectsRoot, projectDirs[di].name);
+    var files;
+    try { files = fs.readdirSync(projDir); } catch (e) { continue; }
+
+    for (var fi = 0; fi < files.length; fi++) {
+      var f = files[fi];
+      if (!f.endsWith(".jsonl")) continue;
+      var fp = path.join(projDir, f);
+
+      var st;
+      try { st = fs.statSync(fp); } catch (e) { continue; }
+      if (st.size >= MAX_BYTES) continue;
+      if (nowMs - st.mtimeMs < MIN_AGE_MS) continue;
+
+      var raw;
+      try { raw = fs.readFileSync(fp, "utf8"); } catch (e) { continue; }
+      var lines = raw.split("\n");
+      var userCount = 0;
+      var assistantCount = 0;
+      var userText = null;
+      var parseOk = true;
+      for (var li = 0; li < lines.length; li++) {
+        var line = lines[li];
+        if (!line) continue;
+        var ev;
+        try { ev = JSON.parse(line); } catch (e) { parseOk = false; break; }
+        if (!ev || typeof ev !== "object") continue;
+        if (ev.type === "user") {
+          userCount++;
+          if (userCount > 1) break;
+          var msg = ev.message;
+          var content = msg && msg.content;
+          if (typeof content === "string") {
+            userText = content;
+          } else if (Array.isArray(content)) {
+            var parts = [];
+            for (var ci = 0; ci < content.length; ci++) {
+              if (content[ci] && content[ci].type === "text" && typeof content[ci].text === "string") {
+                parts.push(content[ci].text);
+              }
+            }
+            userText = parts.join("");
+          }
+        } else if (ev.type === "assistant") {
+          assistantCount++;
+          if (assistantCount > 0) break;
+        }
+      }
+      if (!parseOk) continue;
+      if (userCount !== 1) continue;
+      if (assistantCount !== 0) continue;
+      if (userText !== "hi") continue;
+
+      try { fs.unlinkSync(fp); deleted++; } catch (e) {}
+    }
+  }
+
+  if (deleted > 0) {
+    console.log("[daemon] Removed " + deleted + " stale SDK warmup session file(s)");
+  }
+}
+
 // --- Start listening (with retry for port-in-use during update handoff) ---
 var listenRetries = 0;
 var MAX_LISTEN_RETRIES = 15;
 
 function startListening() {
+  // One-shot cleanup of stale SDK warmup CLI session files from previous
+  // daemon runs (best-effort, never fatal).
+  try { cleanupSdkWarmupSessions(); } catch (e) {}
+
   relay.server.listen(config.port, listenHost, function () {
     var protocol = tlsOptions ? "https" : "http";
     console.log("[daemon] Listening on " + protocol + "://" + listenHost + ":" + config.port);

package/lib/project-connection.js

@@ -157,6 +157,21 @@ function attachConnection(ctx) {
       var _comVal = _comUid ? usersModule.getClaudeOpenMode(_comUid) : "tui";
       sendTo(ws, { type: "claude_open_mode_changed", claudeOpenMode: _comVal || "tui" });
     }
+
+    // What's New: push the full entries list (for the home-page feed)
+    // plus the subset of unseen ids (for the auto-pop carousel). Content
+    // lives in lib/whats-new-content.js so adding an entry doesn't touch
+    // this file.
+    try {
+      var _wn = require("./whats-new");
+      var _wnUid = (wsUser && wsUser.id) || null;
+      var _wnState = _wnUid ? _wn.getStateForUser(_wnUid) : { entries: _wn.listEntries(), unseenIds: [] };
+      if (_wnState.entries.length > 0) {
+        sendTo(ws, { type: "whats_new_state", entries: _wnState.entries, unseenIds: _wnState.unseenIds });
+      }
+    } catch (e) {
+      if (debug) console.error("[project] whats_new send failed:", e && e.message);
+    }
     _loop.sendConnectionState(ws);
     if (_mcp) _mcp.sendConnectionState(ws);
     if (_notifications) _notifications.sendConnectionState(ws, sendTo);

package/lib/project-sessions.js

@@ -265,12 +265,21 @@ function attachSessions(ctx) {
     return null;
   }
 
-  // In-place conversion of a TUI session to GUI when the user's preference
-  // is 'gui'. Reads the jsonl transcript through the existing import path
-  // (same code Import CLI uses), populates session.history, flips the mode
-  // to 'gui', and kills the PTY. Subsequent clicks render via the SDK chat.
-  function convertTuiSessionToGui(session) {
+  // Prepare a born-TUI session to be rendered via the SDK GUI chat for the
+  // current click. Reads the CLI jsonl transcript (cli-sessions.js),
+  // populates session.history, and tears
+  // down the PTY. The born-TUI marker (session.mode === 'tui') is kept on
+  // disk so that flipping claudeOpenMode back to 'tui' later restores the
+  // embedded-terminal experience instead of locking the session as GUI.
+  //
+  // Idempotent: if the PTY is already gone and history is populated, this
+  // is a no-op (avoids re-reading jsonl and re-writing the session file on
+  // every click while the user is reading the session in GUI mode).
+  function prepareTuiSessionForGuiView(session) {
     if (!session || session.cliSessionId == null) return;
+    var alreadyHydrated = (typeof session.terminalId !== "number") &&
+                          Array.isArray(session.history) && session.history.length > 0;
+    if (alreadyHydrated) return;
     var cliSess;
     try { cliSess = require("./cli-sessions"); } catch (e) { return; }
     var history = null;
@@ -278,7 +287,6 @@ function attachSessions(ctx) {
     if (Array.isArray(history)) {
       session.history = history;
     }
-    session.mode = "gui";
     if (typeof session.terminalId === "number" && tm) {
       try { tm.close(session.terminalId); } catch (e) {}
     }
@@ -494,101 +502,10 @@ function attachSessions(ctx) {
       return true;
     }
 
-    if (msg.type === "resume_session") {
-      if (!msg.cliSessionId) return true;
-      var cliSess = require("./cli-sessions");
-
-      // If Clay already has a persisted meta file for this cliSessionId, read
-      // its vendor so resumeSession doesn't silently default to the project's
-      // primary vendor (which would break codex sessions after server restart).
-      var persistedVendor = null;
-      try {
-        var _fsResume = require("fs");
-        var _pathResume = require("path");
-        var metaPath = _pathResume.join(sm.sessionsDir, msg.cliSessionId + ".jsonl");
-        if (_fsResume.existsSync(metaPath)) {
-          var firstLine = _fsResume.readFileSync(metaPath, "utf8").split("\n", 1)[0];
-          try {
-            var metaObj = JSON.parse(firstLine);
-            if (metaObj && metaObj.type === "meta" && metaObj.vendor) persistedVendor = metaObj.vendor;
-          } catch (e) {}
-        }
-      } catch (e) {}
-
-      // Try SDK for title first, then fall back to manual parsing
-      var titlePromise = adapter.getSessionInfo(msg.cliSessionId, { dir: cwd }).then(function(info) {
-        return (info && info.summary) ? info.summary.substring(0, 100) : null;
-      }).catch(function() { return null; });
-
-      Promise.all([
-        cliSess.readCliSessionHistory(cwd, msg.cliSessionId),
-        titlePromise
-      ]).then(function(results) {
-        var history = results[0];
-        var sdkTitle = results[1];
-        var title = sdkTitle || "Resumed session";
-        if (!sdkTitle) {
-          for (var i = 0; i < history.length; i++) {
-            if (history[i].type === "user_message" && history[i].text) {
-              title = history[i].text.substring(0, 50);
-              break;
-            }
-          }
-        }
-        var resumed = sm.resumeSession(msg.cliSessionId, { history: history, title: title, vendor: persistedVendor || undefined }, ws);
-        if (resumed) ws._clayActiveSession = resumed.localId;
-      }).catch(function() {
-        var resumed = sm.resumeSession(msg.cliSessionId, persistedVendor ? { vendor: persistedVendor } : undefined, ws);
-        if (resumed) ws._clayActiveSession = resumed.localId;
-      });
-      return true;
-    }
-
-    if (msg.type === "list_cli_sessions") {
-      var _fs = require("fs");
-      // Collect session IDs already in relay (in-memory + persisted on disk)
-      var relayIds = {};
-      sm.sessions.forEach(function (s) {
-        if (s.cliSessionId) relayIds[s.cliSessionId] = true;
-      });
-      try {
-        var sessDir = sm.sessionsDir;
-        var diskFiles = _fs.readdirSync(sessDir);
-        for (var fi = 0; fi < diskFiles.length; fi++) {
-          if (diskFiles[fi].endsWith(".jsonl")) {
-            relayIds[diskFiles[fi].replace(".jsonl", "")] = true;
-          }
-        }
-      } catch (e) {}
-
-      adapter.listSessions({ dir: cwd }).then(function(sdkSessions) {
-        var filtered = sdkSessions.filter(function(s) {
-          return !relayIds[s.sessionId];
-        }).map(function(s) {
-          return {
-            sessionId: s.sessionId,
-            firstPrompt: s.summary || s.firstPrompt || "",
-            model: null,
-            gitBranch: s.gitBranch || null,
-            startTime: s.createdAt ? new Date(s.createdAt).toISOString() : null,
-            lastActivity: s.lastModified ? new Date(s.lastModified).toISOString() : null,
-          };
-        });
-        sendTo(ws, { type: "cli_session_list", sessions: filtered });
-      }).catch(function() {
-        // Fallback to manual parsing if SDK fails
-        var cliSessions = require("./cli-sessions");
-        cliSessions.listCliSessions(cwd).then(function(sessions) {
-          var filtered = sessions.filter(function(s) {
-            return !relayIds[s.sessionId];
-          });
-          sendTo(ws, { type: "cli_session_list", sessions: filtered });
-        }).catch(function() {
-          sendTo(ws, { type: "cli_session_list", sessions: [] });
-        });
-      });
-      return true;
-    }
+    // Note: the old `resume_session` and `list_cli_sessions` WS handlers
+    // were removed when CLI sessions started being auto-adopted into the
+    // unified session list on server start (see sessions.js
+    // adoptOrphanedCliSessions). Click a session in the sidebar instead.
 
     if (msg.type === "switch_session") {
       if (msg.id && sm.sessions.has(msg.id)) {
@@ -598,21 +515,24 @@ function attachSessions(ctx) {
         //  - born-GUI viewed under TUI pref:  spawn a transient PTY running
         //    `claude --resume <cliSessionId>`; the session record stays GUI
         //    so a later pref flip back to GUI just hides the runtime link.
-        //  - born-TUI viewed under GUI pref:  in-place convert via the
-        //    Import CLI code path (jsonl history -> session.history,
-        //    session.mode -> 'gui', kill PTY). This is destructive but
-        //    matches "TUI->GUI is what Import CLI was always for."
+        //  - born-TUI viewed under GUI pref:  hydrate session.history from
+        //    the jsonl transcript and tear down the PTY so the session
+        //    renders via the SDK chat. The born-TUI marker stays on the
+        //    record so a later pref flip back to TUI restores the
+        //    embedded-terminal experience.
         //
         // runtimeMode / runtimeTerminalId are set on the session record so
         // the session_switched and session_list broadcasts surface them to
         // the client without sessions.js needing to know about the pref.
         var xmTarget = sm.sessions.get(msg.id);
         if (xmTarget && (xmTarget.vendor === "claude" || !xmTarget.vendor)) {
+          var xmPref = getClaudeOpenModeForWs(ws);
           // Born-TUI session whose PTY is gone (typically after a daemon
-          // restart). Respawn via `claude --resume <cliSessionId>` before
-          // the cross-mode logic runs - the rest of the pipeline assumes
-          // terminalId points at a live PTY for TUI sessions.
-          if (xmTarget.mode === "tui" && xmTarget.cliSessionId && tm &&
+          // restart) AND the user wants TUI rendering this click. Respawn
+          // via `claude --resume <cliSessionId>` so the rest of the pipeline
+          // has a live PTY to point at. Skipped when the user's pref is GUI
+          // - we'd just tear it back down two lines later.
+          if (xmTarget.mode === "tui" && xmTarget.cliSessionId && tm && xmPref === "tui" &&
               (typeof xmTarget.terminalId !== "number" || !tm.has(xmTarget.terminalId))) {
             var rsSid = xmTarget.cliSessionId;
             var rsLocalId = xmTarget.localId;
@@ -632,11 +552,15 @@ function attachSessions(ctx) {
             if (rsTerm) xmTarget.terminalId = rsTerm.id;
             startTitleWatcher(xmTarget);
           }
-          var xmPref = getClaudeOpenModeForWs(ws);
           var xmRuntime = computeRuntimeMode(xmTarget, xmPref);
           if (xmRuntime === "gui" && xmTarget.mode === "tui") {
-            convertTuiSessionToGui(xmTarget);
-            xmTarget.runtimeMode = null;
+            // Born-TUI session under GUI pref. Hydrate history + drop PTY
+            // without flipping session.mode, so flipping back to TUI later
+            // restores the embedded-terminal rendering. runtimeMode is set
+            // to 'gui' explicitly so the client doesn't fall back to
+            // session.mode (which is still 'tui').
+            prepareTuiSessionForGuiView(xmTarget);
+            xmTarget.runtimeMode = "gui";
             xmTarget.runtimeTerminalId = null;
           } else if (xmRuntime === "tui" && xmTarget.mode === "gui" && xmTarget.cliSessionId) {
             var xmRid = spawnRuntimeTuiPty(xmTarget, ws);
@@ -1754,6 +1678,24 @@ function attachSessions(ctx) {
       return true;
     }
 
+    if (msg.type === "whats_new_seen") {
+      // Persist that the current user dismissed a What's New entry so it
+      // is not shown again on future connects.
+      var wnUserId = ws._clayUser ? ws._clayUser.id : null;
+      if (!wnUserId) {
+        sendTo(ws, { type: "whats_new_seen_result", ok: false, error: "no_user" });
+        return true;
+      }
+      var wnSvc = require("./whats-new");
+      var wnResult = wnSvc.markSeen(wnUserId, msg.id);
+      if (wnResult && wnResult.ok) {
+        sendTo(ws, { type: "whats_new_seen_result", ok: true, id: msg.id });
+      } else {
+        sendTo(ws, { type: "whats_new_seen_result", ok: false, error: (wnResult && wnResult.error) || "unknown" });
+      }
+      return true;
+    }
+
     if (msg.type === "set_claude_open_mode") {
       // Per-user preference: when Clay opens a Claude session, render it as
       // the SDK-driven custom chat ("gui") or as an embedded `claude` TUI

package/lib/public/app.js

@@ -5,7 +5,7 @@ import { renderMarkdown, highlightCodeBlocks, renderMermaidBlocks, closeMermaidM
 import { initSidebar, updatePageTitle, spawnDustParticles } from './modules/sidebar.js';
 import {
   renderSessionList, handleSearchResults, updateSessionPresence,
-  updateSessionBadge, populateCliSessionList
+  updateSessionBadge
 } from './modules/sidebar-sessions.js';
 import {
   renderIconStrip, getEmojiCategories, updateProjectBadge
@@ -63,6 +63,8 @@ import { initDebateUi, showDebateConcludeConfirm as _debShowDebateConcludeConfir
 import { initLoopUi, updateLoopInputVisibility as _loopUpdateLoopInputVisibility, updateLoopButton as _loopUpdateLoopButton, showLoopBanner as _loopShowLoopBanner, updateLoopBanner as _loopUpdateLoopBanner, updateRalphBars as _loopUpdateRalphBars, showRalphCraftingBar as _loopShowRalphCraftingBar, showRalphApprovalBar as _loopShowRalphApprovalBar, updateRalphApprovalStatus as _loopUpdateRalphApprovalStatus, openRalphPreviewModal as _loopOpenRalphPreviewModal, showExecModal as _loopShowExecModal, closeExecModal as _loopCloseExecModal, updateExecModalStatus as _loopUpdateExecModalStatus } from './modules/app-loop-ui.js';
 import { initLoopWizard, openRalphWizard as _loopOpenRalphWizard, closeRalphWizard as _loopCloseRalphWizard, getWizardSource as _loopGetWizardSource } from './modules/app-loop-wizard.js';
 import { initAppNotifications, handleNotificationsState as _notifHandleState, handleNotificationCreated as _notifHandleCreated, handleNotificationDismissed as _notifHandleDismissed, handleNotificationDismissedAll as _notifHandleDismissedAll } from './modules/app-notifications.js';
+import { initWhatsNew, handleWhatsNewState as _wnHandleState, handleWhatsNewSeenResult as _wnHandleSeenResult } from './modules/whats-new.js';
+import { initWhatsNewArticle, openArticle as openWhatsNewArticle } from './modules/whats-new-article.js';
 import { createStore, store } from './modules/store.js';
 import { initPanels, updateConfigChip as _panUpdateConfigChip, getModelEffortLevels as _panGetModelEffortLevels, accumulateUsage as _panAccumulateUsage, updateUsagePanel as _panUpdateUsagePanel, resetUsage as _panResetUsage, toggleUsagePanel as _panToggleUsagePanel, formatTokens as _panFormatTokens, updateStatusPanel as _panUpdateStatusPanel, requestProcessStats as _panRequestProcessStats, toggleStatusPanel as _panToggleStatusPanel, accumulateContext as _panAccumulateContext, updateContextPanel as _panUpdateContextPanel, resetContext as _panResetContext, resetContextData as _panResetContextData, minimizeContext as _panMinimizeContext, expandContext as _panExpandContext, toggleContextPanel as _panToggleContextPanel, getContextView as _panGetContextView, renderCtxPopover as _panRenderCtxPopover, hideCtxPopover as _panHideCtxPopover, formatBytes as _panFormatBytes, formatUptime as _panFormatUptime, getModelSupportsEffort as _panGetModelSupportsEffort, getSessionUsage, setSessionUsage, getContextData, setContextData, setContextView as _panSetContextView, applyContextView as _panApplyContextView } from './modules/app-panels.js';
 import { initProjects, updateProjectList as _projUpdateProjectList, renderProjectList as _projRenderProjectList, renderTopbarPresence as _projRenderTopbarPresence, switchProject as _projSwitchProject, resetClientState as _projResetClientState, confirmRemoveProject as _projConfirmRemoveProject, handleRemoveProjectCheckResult as _projHandleRemoveProjectCheckResult, handleRemoveProjectResult as _projHandleRemoveProjectResult, openAddProjectModal as _projOpenAddProjectModal, closeAddProjectModal as _projCloseAddProjectModal, handleBrowseDirResult as _projHandleBrowseDirResult, handleAddProjectResult as _projHandleAddProjectResult, handleCloneProgress as _projHandleCloneProgress, showUpdateAvailable as _projShowUpdateAvailable, getCachedProjects, setCachedProjects, getCachedProjectCount, getCachedRemovedProjects, setCachedRemovedProjects } from './modules/app-projects.js';
@@ -97,7 +99,6 @@ import { initDebate, handleDebatePreparing, handleDebateStarted, handleDebateRes
   var hamburgerBtn = $("hamburger-btn");
   var sidebarToggleBtn = $("sidebar-toggle-btn");
   var sidebarExpandBtn = $("sidebar-expand-btn");
-  var resumeSessionBtn = $("resume-session-btn");
   var imagePreviewBar = $("image-preview-bar");
   var connectOverlay = $("connect-overlay");
 
@@ -376,7 +377,6 @@ import { initDebate, handleDebatePreparing, handleDebateStarted, handleDebateRes
     sidebarExpandBtn: sidebarExpandBtn,
     hamburgerBtn: hamburgerBtn,
     newSessionBtn: newSessionBtn,
-    resumeSessionBtn: resumeSessionBtn,
     headerTitleEl: headerTitleEl,
     showConfirm: showConfirm,
     onFilesTabOpen: function () { loadRootDirectory(); },
@@ -590,6 +590,17 @@ import { initDebate, handleDebatePreparing, handleDebateStarted, handleDebateRes
   // --- Notifications module ---
   initAppNotifications();
 
+  // --- What's New viewer ---
+  initWhatsNewArticle();
+  initWhatsNew({
+    // "Read more" in the carousel opens the dedicated article viewer
+    // for the chosen entry, jumping straight to the body content
+    // (skipping the home list).
+    onReadMore: function (entryId) {
+      if (entryId) openWhatsNewArticle(entryId);
+    },
+  });
+
   // --- Panels module ---
   initPanels();