clawvault 2.5.2 → 2.5.3

package/bin/command-runtime.test.js

@@ -1,154 +1,154 @@
-import { beforeEach, describe, expect, it, vi } from 'vitest';
-import path from 'path';
-
-const {
-  spawnMock,
-  resolveConfiguredVaultPathMock,
-  clawvaultCtorMock,
-  loadMock
-} = vi.hoisted(() => ({
-  spawnMock: vi.fn(),
-  resolveConfiguredVaultPathMock: vi.fn(),
-  clawvaultCtorMock: vi.fn(),
-  loadMock: vi.fn()
-}));
-
-vi.mock('child_process', () => ({
-  spawn: spawnMock
-}));
-
-vi.mock('../dist/index.js', () => ({
-  ClawVault: clawvaultCtorMock,
-  resolveVaultPath: resolveConfiguredVaultPathMock,
-  QmdUnavailableError: class QmdUnavailableError extends Error {},
-  QMD_INSTALL_COMMAND: 'install-qmd'
-}));
-
-async function loadRuntimeModule() {
-  vi.resetModules();
-  return await import('./command-runtime.js');
-}
-
-beforeEach(() => {
-  vi.clearAllMocks();
-  clawvaultCtorMock.mockImplementation(() => ({
-    load: loadMock
-  }));
-});
-
-describe('command runtime helpers', () => {
-  it('delegates vault path resolution and loads vaults', async () => {
-    resolveConfiguredVaultPathMock.mockReturnValue('/resolved/vault');
-    loadMock.mockResolvedValue(undefined);
-    const { getVault, resolveVaultPath } = await loadRuntimeModule();
-
-    const resolved = resolveVaultPath('/explicit');
-    expect(resolveConfiguredVaultPathMock).toHaveBeenCalledWith({ explicitPath: '/explicit' });
-    expect(resolved).toBe('/resolved/vault');
-
-    await getVault('/explicit');
-    expect(clawvaultCtorMock).toHaveBeenCalledWith('/resolved/vault');
-    expect(loadMock).toHaveBeenCalled();
-  });
-
-  it('maps qmd ENOENT failures to QmdUnavailableError', async () => {
-    const { runQmd, QmdUnavailableError } = await loadRuntimeModule();
-    spawnMock.mockImplementation(() => {
-      const handlers = {};
-      const proc = {
-        on: (event, handler) => {
-          handlers[event] = handler;
-        }
-      };
-      queueMicrotask(() => {
-        handlers.error?.({ code: 'ENOENT' });
-      });
-      return proc;
-    });
-
-    await expect(runQmd(['update'])).rejects.toBeInstanceOf(QmdUnavailableError);
-  });
-
-  it('injects qmd index from environment when configured', async () => {
-    const previous = process.env.CLAWVAULT_QMD_INDEX;
-    process.env.CLAWVAULT_QMD_INDEX = 'clawvault-test';
-
-    try {
-      const { runQmd } = await loadRuntimeModule();
-      spawnMock.mockImplementation((_command, _args) => {
-        const handlers = {};
-        const proc = {
-          on: (event, handler) => {
-            handlers[event] = handler;
-          }
-        };
-        queueMicrotask(() => {
-          handlers.close?.(0);
-        });
-        return proc;
-      });
-
-      await runQmd(['update']);
-      expect(spawnMock).toHaveBeenCalledWith(
-        'qmd',
-        ['--index', 'clawvault-test', 'update'],
-        { stdio: 'inherit' }
-      );
-    } finally {
-      if (previous === undefined) {
-        delete process.env.CLAWVAULT_QMD_INDEX;
-      } else {
-        process.env.CLAWVAULT_QMD_INDEX = previous;
-      }
-    }
-  });
-
-  it('surfaces qmd non-zero exit codes as errors', async () => {
-    const { runQmd } = await loadRuntimeModule();
-    spawnMock.mockImplementation(() => {
-      const handlers = {};
-      const proc = {
-        on: (event, handler) => {
-          handlers[event] = handler;
-        }
-      };
-      queueMicrotask(() => {
-        handlers.close?.(2);
-      });
-      return proc;
-    });
-
-    await expect(runQmd(['update'])).rejects.toThrow('qmd exited with code 2');
-  });
-
-  it('exports and enforces argument/path sanitization helpers', async () => {
-    const { sanitizeQmdArg, validatePathWithinBase } = await loadRuntimeModule();
-    expect(sanitizeQmdArg('update')).toBe('update');
-    expect(sanitizeQmdArg(42)).toBe('42');
-    expect(() => sanitizeQmdArg('bad\0arg')).toThrow('contains null byte');
-
-    const safePath = validatePathWithinBase('notes/today.md', '/tmp/vault');
-    expect(safePath).toBe(path.resolve('/tmp/vault', 'notes/today.md'));
-    expect(() => validatePathWithinBase('../etc/passwd', '/tmp/vault')).toThrow('Path traversal detected');
-  });
-
-  it('rejects qmd args with null-byte injection attempts', async () => {
-    const { runQmd } = await loadRuntimeModule();
-    await expect(runQmd(['up\0date'])).rejects.toThrow('contains null byte');
-    expect(spawnMock).not.toHaveBeenCalled();
-  });
-
-  it('prints consistent qmd missing guidance', async () => {
-    const errorSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
-    const logSpy = vi.spyOn(console, 'log').mockImplementation(() => {});
-    try {
-      const { printQmdMissing } = await loadRuntimeModule();
-      printQmdMissing();
-      expect(errorSpy).toHaveBeenCalledWith(expect.stringContaining('ClawVault requires qmd.'));
-      expect(logSpy).toHaveBeenCalledWith(expect.stringContaining('install-qmd'));
-    } finally {
-      errorSpy.mockRestore();
-      logSpy.mockRestore();
-    }
-  });
-});
+import { beforeEach, describe, expect, it, vi } from 'vitest';
+import path from 'path';
+
+const {
+  spawnMock,
+  resolveConfiguredVaultPathMock,
+  clawvaultCtorMock,
+  loadMock
+} = vi.hoisted(() => ({
+  spawnMock: vi.fn(),
+  resolveConfiguredVaultPathMock: vi.fn(),
+  clawvaultCtorMock: vi.fn(),
+  loadMock: vi.fn()
+}));
+
+vi.mock('child_process', () => ({
+  spawn: spawnMock
+}));
+
+vi.mock('../dist/index.js', () => ({
+  ClawVault: clawvaultCtorMock,
+  resolveVaultPath: resolveConfiguredVaultPathMock,
+  QmdUnavailableError: class QmdUnavailableError extends Error {},
+  QMD_INSTALL_COMMAND: 'install-qmd'
+}));
+
+async function loadRuntimeModule() {
+  vi.resetModules();
+  return await import('./command-runtime.js');
+}
+
+beforeEach(() => {
+  vi.clearAllMocks();
+  clawvaultCtorMock.mockImplementation(() => ({
+    load: loadMock
+  }));
+});
+
+describe('command runtime helpers', () => {
+  it('delegates vault path resolution and loads vaults', async () => {
+    resolveConfiguredVaultPathMock.mockReturnValue('/resolved/vault');
+    loadMock.mockResolvedValue(undefined);
+    const { getVault, resolveVaultPath } = await loadRuntimeModule();
+
+    const resolved = resolveVaultPath('/explicit');
+    expect(resolveConfiguredVaultPathMock).toHaveBeenCalledWith({ explicitPath: '/explicit' });
+    expect(resolved).toBe('/resolved/vault');
+
+    await getVault('/explicit');
+    expect(clawvaultCtorMock).toHaveBeenCalledWith('/resolved/vault');
+    expect(loadMock).toHaveBeenCalled();
+  });
+
+  it('maps qmd ENOENT failures to QmdUnavailableError', async () => {
+    const { runQmd, QmdUnavailableError } = await loadRuntimeModule();
+    spawnMock.mockImplementation(() => {
+      const handlers = {};
+      const proc = {
+        on: (event, handler) => {
+          handlers[event] = handler;
+        }
+      };
+      queueMicrotask(() => {
+        handlers.error?.({ code: 'ENOENT' });
+      });
+      return proc;
+    });
+
+    await expect(runQmd(['update'])).rejects.toBeInstanceOf(QmdUnavailableError);
+  });
+
+  it('injects qmd index from environment when configured', async () => {
+    const previous = process.env.CLAWVAULT_QMD_INDEX;
+    process.env.CLAWVAULT_QMD_INDEX = 'clawvault-test';
+
+    try {
+      const { runQmd } = await loadRuntimeModule();
+      spawnMock.mockImplementation((_command, _args) => {
+        const handlers = {};
+        const proc = {
+          on: (event, handler) => {
+            handlers[event] = handler;
+          }
+        };
+        queueMicrotask(() => {
+          handlers.close?.(0);
+        });
+        return proc;
+      });
+
+      await runQmd(['update']);
+      expect(spawnMock).toHaveBeenCalledWith(
+        'qmd',
+        ['--index', 'clawvault-test', 'update'],
+        { stdio: 'inherit' }
+      );
+    } finally {
+      if (previous === undefined) {
+        delete process.env.CLAWVAULT_QMD_INDEX;
+      } else {
+        process.env.CLAWVAULT_QMD_INDEX = previous;
+      }
+    }
+  });
+
+  it('surfaces qmd non-zero exit codes as errors', async () => {
+    const { runQmd } = await loadRuntimeModule();
+    spawnMock.mockImplementation(() => {
+      const handlers = {};
+      const proc = {
+        on: (event, handler) => {
+          handlers[event] = handler;
+        }
+      };
+      queueMicrotask(() => {
+        handlers.close?.(2);
+      });
+      return proc;
+    });
+
+    await expect(runQmd(['update'])).rejects.toThrow('qmd exited with code 2');
+  });
+
+  it('exports and enforces argument/path sanitization helpers', async () => {
+    const { sanitizeQmdArg, validatePathWithinBase } = await loadRuntimeModule();
+    expect(sanitizeQmdArg('update')).toBe('update');
+    expect(sanitizeQmdArg(42)).toBe('42');
+    expect(() => sanitizeQmdArg('bad\0arg')).toThrow('contains null byte');
+
+    const safePath = validatePathWithinBase('notes/today.md', '/tmp/vault');
+    expect(safePath).toBe(path.resolve('/tmp/vault', 'notes/today.md'));
+    expect(() => validatePathWithinBase('../etc/passwd', '/tmp/vault')).toThrow('Path traversal detected');
+  });
+
+  it('rejects qmd args with null-byte injection attempts', async () => {
+    const { runQmd } = await loadRuntimeModule();
+    await expect(runQmd(['up\0date'])).rejects.toThrow('contains null byte');
+    expect(spawnMock).not.toHaveBeenCalled();
+  });
+
+  it('prints consistent qmd missing guidance', async () => {
+    const errorSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
+    const logSpy = vi.spyOn(console, 'log').mockImplementation(() => {});
+    try {
+      const { printQmdMissing } = await loadRuntimeModule();
+      printQmdMissing();
+      expect(errorSpy).toHaveBeenCalledWith(expect.stringContaining('ClawVault requires qmd.'));
+      expect(logSpy).toHaveBeenCalledWith(expect.stringContaining('install-qmd'));
+    } finally {
+      errorSpy.mockRestore();
+      logSpy.mockRestore();
+    }
+  });
+});

package/bin/help-contract.test.js

@@ -1,39 +1,39 @@
-import { describe, expect, it } from 'vitest';
-import { registerAllCommandModules } from './test-helpers/cli-command-fixtures.js';
-
-describe('CLI help contract', () => {
-  it('includes expected high-level command surface', () => {
-    const help = registerAllCommandModules().helpInformation();
-    expect(help).toContain('init');
-    expect(help).toContain('context');
-    expect(help).toContain('inject');
-    expect(help).toContain('doctor');
-    expect(help).toContain('embed');
-    expect(help).toContain('compat');
-    expect(help).toContain('graph');
-    expect(help).toContain('reflect');
-    expect(help).toContain('replay');
-    expect(help).toContain('repair-session');
-    expect(help).toContain('project');
-    expect(help).toContain('template');
-    expect(help).toContain('config');
-    expect(help).toContain('route');
-  });
-
-  it('documents context/compat/inject/project help details', () => {
-    const program = registerAllCommandModules();
-    const contextHelp = program.commands.find((command) => command.name() === 'context')?.helpInformation() ?? '';
-    const compatHelp = program.commands.find((command) => command.name() === 'compat')?.helpInformation() ?? '';
-    const injectHelp = program.commands.find((command) => command.name() === 'inject')?.helpInformation() ?? '';
-    const projectCommand = program.commands.find((command) => command.name() === 'project');
-    const projectListHelp = projectCommand?.commands.find((command) => command.name() === 'list')?.helpInformation() ?? '';
-    const projectBoardHelp = projectCommand?.commands.find((command) => command.name() === 'board')?.helpInformation() ?? '';
-    expect(contextHelp).toContain('--profile <profile>');
-    expect(contextHelp).toContain('auto');
-    expect(compatHelp).toContain('--strict');
-    expect(injectHelp).toContain('inject.maxResults');
-    expect(injectHelp).toContain('inject.scope');
-    expect(projectListHelp).toContain('archived projects are hidden');
-    expect(projectBoardHelp).toContain('default: status');
-  });
-});
+import { describe, expect, it } from 'vitest';
+import { registerAllCommandModules } from './test-helpers/cli-command-fixtures.js';
+
+describe('CLI help contract', () => {
+  it('includes expected high-level command surface', () => {
+    const help = registerAllCommandModules().helpInformation();
+    expect(help).toContain('init');
+    expect(help).toContain('context');
+    expect(help).toContain('inject');
+    expect(help).toContain('doctor');
+    expect(help).toContain('embed');
+    expect(help).toContain('compat');
+    expect(help).toContain('graph');
+    expect(help).toContain('reflect');
+    expect(help).toContain('replay');
+    expect(help).toContain('repair-session');
+    expect(help).toContain('project');
+    expect(help).toContain('template');
+    expect(help).toContain('config');
+    expect(help).toContain('route');
+  });
+
+  it('documents context/compat/inject/project help details', () => {
+    const program = registerAllCommandModules();
+    const contextHelp = program.commands.find((command) => command.name() === 'context')?.helpInformation() ?? '';
+    const compatHelp = program.commands.find((command) => command.name() === 'compat')?.helpInformation() ?? '';
+    const injectHelp = program.commands.find((command) => command.name() === 'inject')?.helpInformation() ?? '';
+    const projectCommand = program.commands.find((command) => command.name() === 'project');
+    const projectListHelp = projectCommand?.commands.find((command) => command.name() === 'list')?.helpInformation() ?? '';
+    const projectBoardHelp = projectCommand?.commands.find((command) => command.name() === 'board')?.helpInformation() ?? '';
+    expect(contextHelp).toContain('--profile <profile>');
+    expect(contextHelp).toContain('auto');
+    expect(compatHelp).toContain('--strict');
+    expect(injectHelp).toContain('inject.maxResults');
+    expect(injectHelp).toContain('inject.scope');
+    expect(projectListHelp).toContain('archived projects are hidden');
+    expect(projectBoardHelp).toContain('default: status');
+  });
+});