clawvault 2.4.7 → 2.5.1

package/bin/command-runtime.js

@@ -1,5 +1,6 @@
 import { spawn } from 'child_process';
 import chalk from 'chalk';
+import path from 'path';
 import {
   ClawVault,
   QmdUnavailableError,
@@ -7,6 +8,38 @@ import {
   resolveVaultPath as resolveConfiguredVaultPath
 } from '../dist/index.js';
 
+/**
+ * Validates that a path is within an allowed base directory.
+ * Prevents path traversal attacks.
+ * @param {string} inputPath - The path to validate
+ * @param {string} basePath - The allowed base directory
+ * @returns {string} The resolved, validated path
+ * @throws {Error} If the path escapes the base directory
+ */
+export function validatePathWithinBase(inputPath, basePath) {
+  const resolvedBase = path.resolve(basePath);
+  const resolvedPath = path.resolve(basePath, inputPath);
+
+  if (!resolvedPath.startsWith(resolvedBase + path.sep) && resolvedPath !== resolvedBase) {
+    throw new Error(`Path traversal detected: ${inputPath} escapes ${basePath}`);
+  }
+
+  return resolvedPath;
+}
+
+/**
+ * Sanitizes an argument that may contain a path to prevent injection.
+ * @param {string} arg - The argument to sanitize
+ * @returns {string} The sanitized argument
+ */
+function sanitizeQmdArg(arg) {
+  // Reject arguments with null bytes (injection attempt)
+  if (arg.includes('\0')) {
+    throw new Error('Invalid argument: contains null byte');
+  }
+  return arg;
+}
+
 export function resolveVaultPath(vaultPath) {
   return resolveConfiguredVaultPath({ explicitPath: vaultPath });
 }
@@ -19,7 +52,9 @@ export async function getVault(vaultPath) {
 
 export async function runQmd(args) {
   return new Promise((resolve, reject) => {
-    const proc = spawn('qmd', args, { stdio: 'inherit' });
+    // Sanitize all arguments before passing to spawn
+    const sanitizedArgs = args.map(sanitizeQmdArg);
+    const proc = spawn('qmd', sanitizedArgs, { stdio: 'inherit' });
     proc.on('close', (code) => {
       if (code === 0) resolve();
       else reject(new Error(`qmd exited with code ${code}`));

package/bin/register-core-commands.js

@@ -2,6 +2,8 @@
  * Core vault lifecycle and write command registrations.
  */
 
+import { validatePathWithinBase } from './command-runtime.js';
+
 export function registerCoreCommands(
   program,
   { chalk, path, fs, createVault, getVault, runQmd }
@@ -179,7 +181,10 @@ export function registerCoreCommands(
         let content = options.content || '';
 
         if (options.file) {
-          content = fs.readFileSync(options.file, 'utf-8');
+          // Validate file path is within current working directory to prevent path traversal
+          const cwd = process.cwd();
+          const resolvedFilePath = validatePathWithinBase(options.file, cwd);
+          content = fs.readFileSync(resolvedFilePath, 'utf-8');
         } else if (options.stdin) {
           content = fs.readFileSync(0, 'utf-8');
         }

package/bin/register-vault-operations-commands.js

@@ -2,6 +2,8 @@
  * Vault operation command registrations (browse/sync/reindex/remember/shell-init/dashboard).
  */
 
+import { validatePathWithinBase } from './command-runtime.js';
+
 export function registerVaultOperationsCommands(
   program,
   {
@@ -232,7 +234,10 @@ export function registerVaultOperationsCommands(
         const vault = await getVault(options.vault);
         let content = options.content || '';
         if (options.file) {
-          content = fs.readFileSync(options.file, 'utf-8');
+          // Validate file path is within current working directory to prevent path traversal
+          const cwd = process.cwd();
+          const resolvedFilePath = validatePathWithinBase(options.file, cwd);
+          content = fs.readFileSync(resolvedFilePath, 'utf-8');
         } else if (options.stdin) {
           content = fs.readFileSync(0, 'utf-8');
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "clawvault",
-  "version": "2.4.7",
+  "version": "2.5.1",
   "description": "Structured memory system for AI agents — typed storage, knowledge graph, context profiles, canvas dashboards, neural graph themes, and Obsidian-native task views. An elephant never forgets. 🐘",
   "type": "module",
   "main": "dist/index.cjs",