clawspec 1.0.16 → 1.0.20

package/test/queue-planning.test.ts

@@ -1,322 +0,0 @@
-import test from "node:test";
-import assert from "node:assert/strict";
-import { pathExists, readJsonFile, writeUtf8 } from "../src/utils/fs.ts";
-import { PlanningJournalStore } from "../src/planning/journal.ts";
-import { getRepoStatePaths } from "../src/utils/paths.ts";
-import { createServiceHarness, seedPlanningProject } from "./helpers/harness.ts";
-
-test("apply prepares visible planning", async () => {
-  const harness = await createServiceHarness("clawspec-apply-queue-");
-  const { service, stateStore, watcherManager, repoPath, workspacePath, changeDir } = harness;
-  const channelKey = "discord:apply-queue:default:main";
-
-  await seedPlanningProject(stateStore, channelKey, {
-    workspacePath,
-    repoPath,
-    projectName: "demo-app",
-    changeName: "weather-plan",
-    changeDir,
-    phase: "proposal",
-    status: "ready",
-    planningDirty: true,
-  });
-
-  const repoStatePaths = getRepoStatePaths(repoPath, "archives");
-  await writeUtf8(repoStatePaths.executionControlFile, "{\"state\":\"running\"}\n");
-  await writeUtf8(repoStatePaths.executionResultFile, "{\"status\":\"running\"}\n");
-  await writeUtf8(repoStatePaths.workerProgressFile, "{\"kind\":\"task_start\"}\n");
-
-  const result = await service.queuePlanningProject(channelKey, "apply");
-  const project = await stateStore.getActiveProject(channelKey);
-
-  assert.match(result.text ?? "", /Planning Ready/);
-  assert.equal(project?.status, "ready");
-  assert.equal(project?.execution, undefined);
-  assert.deepEqual(watcherManager.wakeCalls, []);
-  assert.equal(await pathExists(repoStatePaths.executionControlFile), false);
-  assert.equal(await pathExists(repoStatePaths.executionResultFile), false);
-  assert.equal(await pathExists(repoStatePaths.workerProgressFile), false);
-});
-
-test("continue routes back to planning when dirty", async () => {
-  const harness = await createServiceHarness("clawspec-continue-planning-");
-  const { service, stateStore, watcherManager, repoPath, workspacePath, changeDir } = harness;
-  const channelKey = "discord:continue-planning:default:main";
-
-  await seedPlanningProject(stateStore, channelKey, {
-    workspacePath,
-    repoPath,
-    projectName: "demo-app",
-    changeName: "dirty-plan",
-    changeDir,
-    phase: "tasks",
-    status: "paused",
-    planningDirty: true,
-  });
-
-  const result = await service.continueProject(channelKey);
-  const project = await stateStore.getActiveProject(channelKey);
-
-  assert.match(result.text ?? "", /Planning Ready/);
-  assert.equal(project?.status, "ready");
-  assert.equal(project?.execution, undefined);
-  assert.deepEqual(watcherManager.wakeCalls, []);
-});
-
-test("apply still prepares visible planning review when attached and journal matches the last snapshot", async () => {
-  const harness = await createServiceHarness("clawspec-apply-no-new-plan-");
-  const { service, stateStore, watcherManager, repoPath, workspacePath, changeDir } = harness;
-  const channelKey = "discord:apply-no-new-plan:default:main";
-
-  await seedPlanningProject(stateStore, channelKey, {
-    workspacePath,
-    repoPath,
-    projectName: "demo-app",
-    changeName: "weather-plan",
-    changeDir,
-    phase: "tasks",
-    status: "ready",
-    planningDirty: true,
-  });
-
-  const repoStatePaths = getRepoStatePaths(repoPath, "archives");
-  const journalStore = new PlanningJournalStore(repoStatePaths.planningJournalFile);
-  await journalStore.append({
-    timestamp: new Date(Date.now() - 60_000).toISOString(),
-    changeName: "weather-plan",
-    role: "user",
-    text: "keep the same two API endpoints",
-  });
-  await journalStore.writeSnapshot(repoStatePaths.planningJournalSnapshotFile, "weather-plan");
-
-  const result = await service.queuePlanningProject(channelKey, "apply");
-  const project = await stateStore.getActiveProject(channelKey);
-
-  assert.match(result.text ?? "", /Planning Ready/);
-  assert.equal(project?.status, "ready");
-  assert.match(project?.latestSummary ?? "", /Waiting for cs-plan in chat/);
-  assert.deepEqual(watcherManager.wakeCalls, []);
-});
-
-test("apply reports no new planning notes when the chat context is detached", async () => {
-  const harness = await createServiceHarness("clawspec-apply-detached-no-new-plan-");
-  const { service, stateStore, watcherManager, repoPath, workspacePath, changeDir } = harness;
-  const channelKey = "discord:apply-detached-no-new-plan:default:main";
-
-  await seedPlanningProject(stateStore, channelKey, {
-    workspacePath,
-    repoPath,
-    projectName: "demo-app",
-    changeName: "weather-plan",
-    changeDir,
-    phase: "tasks",
-    status: "ready",
-    planningDirty: true,
-  });
-
-  await stateStore.updateProject(channelKey, (current) => ({
-    ...current,
-    contextMode: "detached",
-  }));
-
-  const repoStatePaths = getRepoStatePaths(repoPath, "archives");
-  const journalStore = new PlanningJournalStore(repoStatePaths.planningJournalFile);
-  await journalStore.writeSnapshot(repoStatePaths.planningJournalSnapshotFile, "weather-plan");
-
-  const result = await service.queuePlanningProject(channelKey, "apply");
-  const project = await stateStore.getActiveProject(channelKey);
-
-  assert.match(result.text ?? "", /No New Planning Notes/);
-  assert.equal(project?.planningJournal?.dirty, false);
-  assert.deepEqual(watcherManager.wakeCalls, []);
-});
-
-test("cs-plan runs visible planning sync and writes a fresh snapshot", async () => {
-  const harness = await createServiceHarness("clawspec-visible-plan-");
-  const { service, stateStore, repoPath, openSpec, sentMessages } = harness;
-  const channelKey = "discord:visible-plan:default:main";
-  const promptContext = {
-    trigger: "user",
-    channel: "discord",
-    channelId: "visible-plan",
-    accountId: "default",
-    conversationId: "main",
-    sessionKey: "agent:main:discord:channel:visible-plan",
-  };
-
-  await service.startProject(channelKey);
-  await service.useProject(channelKey, "demo-app");
-  await service.proposalProject(channelKey, "demo-change Demo change");
-  await service.recordPlanningMessageFromContext(promptContext, "add another API endpoint");
-
-  const instructionCalls: string[] = [];
-  const originalInstructionsArtifact = openSpec.instructionsArtifact;
-  openSpec.instructionsArtifact = async (...args: unknown[]) => {
-    instructionCalls.push(String(args[1]));
-    return await originalInstructionsArtifact(...args);
-  };
-
-  const injected = await service.handleBeforePromptBuild(
-    { prompt: "cs-plan", messages: [] },
-    promptContext,
-  );
-  const runningProject = await stateStore.getActiveProject(channelKey);
-
-  assert.match(injected?.prependContext ?? "", /ClawSpec planning sync is active for this turn/);
-  assert.match(injected?.prependContext ?? "", /Prefetched OpenSpec instructions for this turn/);
-  assert.match(injected?.prependContext ?? "", /OpenSpec commands already executed by the plugin before this turn/);
-  assert.match(injected?.prependContext ?? "", /openspec instructions proposal --change demo-change --json/);
-  assert.match(injected?.prependContext ?? "", /planning-instructions[\\/]+proposal\.json/);
-  assert.deepEqual(instructionCalls, ["proposal", "specs", "design", "tasks"]);
-  assert.match(injected?.prependContext ?? "", /allowed planning scope is limited/i);
-  assert.match(injected?.prependContext ?? "", /Do not invent endpoints, features, constraints, files, acceptance criteria, test scenarios, or architecture details/i);
-  assert.match(injected?.prependContext ?? "", /mandatory final line exactly in this shape/i);
-  assert.equal(runningProject?.status, "planning");
-  assert.equal(runningProject?.phase, "planning_sync");
-  assert.deepEqual(
-    sentMessages.map((entry) => entry.to),
-    [
-      "channel:visible-plan",
-      "channel:visible-plan",
-      "channel:visible-plan",
-      "channel:visible-plan",
-    ],
-  );
-  assert.match(sentMessages[0]?.text ?? "", /openspec instructions proposal --change demo-change --json/);
-  assert.match(sentMessages[0]?.text ?? "", /planning-instructions\/proposal\.json/);
-  assert.match(sentMessages[1]?.text ?? "", /openspec instructions specs --change demo-change --json/);
-  assert.match(sentMessages[1]?.text ?? "", /planning-instructions\/specs\.json/);
-  assert.match(sentMessages[2]?.text ?? "", /openspec instructions design --change demo-change --json/);
-  assert.match(sentMessages[2]?.text ?? "", /planning-instructions\/design\.json/);
-  assert.match(sentMessages[3]?.text ?? "", /openspec instructions tasks --change demo-change --json/);
-  assert.match(sentMessages[3]?.text ?? "", /planning-instructions\/tasks\.json/);
-
-  await service.handleAgentEnd(
-    { messages: [], success: true, durationMs: 10 },
-    promptContext,
-  );
-
-  const finalized = await stateStore.getActiveProject(channelKey);
-  const repoStatePaths = getRepoStatePaths(repoPath, "archives");
-  const snapshotExists = await pathExists(repoStatePaths.planningJournalSnapshotFile);
-  const snapshot = await readJsonFile<any>(repoStatePaths.planningJournalSnapshotFile, null);
-
-  assert.equal(finalized?.status, "ready");
-  assert.equal(finalized?.phase, "tasks");
-  assert.equal(finalized?.planningJournal?.dirty, false);
-  assert.match(finalized?.latestSummary ?? "", /Say `cs-work` to start implementation/);
-  assert.equal(snapshotExists, true);
-  assert.equal(snapshot?.changeName, "demo-change");
-});
-
-test("cs-plan finalizes and writes a fresh snapshot even if agent_end sessionKey changes", async () => {
-  const harness = await createServiceHarness("clawspec-visible-plan-fallback-");
-  const { service, stateStore, repoPath } = harness;
-  const channelKey = "discord:visible-plan-fallback:default:main";
-  const promptContext = {
-    trigger: "user",
-    channel: "discord",
-    channelId: "visible-plan-fallback",
-    accountId: "default",
-    conversationId: "main",
-    sessionKey: "agent:main:discord:channel:visible-plan-fallback",
-  };
-
-  await service.startProject(channelKey);
-  await service.useProject(channelKey, "demo-app");
-  await service.proposalProject(channelKey, "demo-change Demo change");
-  await service.recordPlanningMessageFromContext(promptContext, "add another API endpoint");
-
-  await service.handleBeforePromptBuild(
-    { prompt: "cs-plan", messages: [] },
-    promptContext,
-  );
-
-  await service.handleAgentEnd(
-    { messages: [], success: true, durationMs: 10 },
-    {
-      ...promptContext,
-      sessionKey: "agent:main:discord:channel:visible-plan-fallback:other",
-    },
-  );
-
-  const finalized = await stateStore.getActiveProject(channelKey);
-  const repoStatePaths = getRepoStatePaths(repoPath, "archives");
-  const snapshot = await readJsonFile<any>(repoStatePaths.planningJournalSnapshotFile, null);
-
-  assert.equal(finalized?.status, "ready");
-  assert.equal(finalized?.phase, "tasks");
-  assert.equal(finalized?.planningJournal?.dirty, false);
-  assert.equal(snapshot?.changeName, "demo-change");
-  assert.equal(snapshot?.entryCount, 1);
-});
-
-test("cs-plan clears stale execution control artifacts from earlier worker runs", async () => {
-  const harness = await createServiceHarness("clawspec-visible-plan-cleanup-");
-  const { service, stateStore, repoPath } = harness;
-  const channelKey = "discord:visible-plan-cleanup:default:main";
-  const promptContext = {
-    trigger: "user",
-    channel: "discord",
-    channelId: "visible-plan-cleanup",
-    accountId: "default",
-    conversationId: "main",
-    sessionKey: "agent:main:discord:channel:visible-plan-cleanup",
-  };
-
-  await service.startProject(channelKey);
-  await service.useProject(channelKey, "demo-app");
-  await service.proposalProject(channelKey, "demo-change Demo change");
-  await service.recordPlanningMessageFromContext(promptContext, "add another API endpoint");
-
-  const repoStatePaths = getRepoStatePaths(repoPath, "archives");
-  await writeUtf8(repoStatePaths.executionControlFile, "{\"state\":\"running\"}\n");
-  await writeUtf8(repoStatePaths.executionResultFile, "{\"status\":\"running\"}\n");
-  await writeUtf8(repoStatePaths.workerProgressFile, "{\"kind\":\"task_start\"}\n");
-
-  await service.handleBeforePromptBuild(
-    { prompt: "cs-plan", messages: [] },
-    promptContext,
-  );
-
-  await service.handleAgentEnd(
-    { messages: [], success: true, durationMs: 10 },
-    promptContext,
-  );
-
-  assert.equal(await pathExists(repoStatePaths.executionControlFile), false);
-  assert.equal(await pathExists(repoStatePaths.executionResultFile), false);
-  assert.equal(await pathExists(repoStatePaths.workerProgressFile), false);
-});
-
-test("ordinary planning discussion does not preload planning artifacts or propose skill", async () => {
-  const harness = await createServiceHarness("clawspec-discussion-guard-");
-  const { service } = harness;
-  const channelKey = "discord:discussion-guard:default:main";
-  const promptContext = {
-    trigger: "user",
-    channel: "discord",
-    channelId: "discussion-guard",
-    accountId: "default",
-    conversationId: "main",
-    sessionKey: "agent:main:discord:channel:discussion-guard",
-  };
-
-  await service.startProject(channelKey);
-  await service.useProject(channelKey, "demo-app");
-  await service.proposalProject(channelKey, "demo-change Demo change");
-
-  const injected = await service.handleBeforePromptBuild(
-    { prompt: "再增加一个接口", messages: [] },
-    promptContext,
-  );
-
-  assert.match(injected?.prependContext ?? "", /ClawSpec planning discussion mode is active/);
-  assert.doesNotMatch(injected?.prependContext ?? "", /openspec[\\/].*proposal\.md/);
-  assert.doesNotMatch(injected?.prependContext ?? "", /openspec[\\/].*design\.md/);
-  assert.doesNotMatch(injected?.prependContext ?? "", /openspec[\\/].*tasks\.md/);
-  assert.match(injected?.prependContext ?? "", /Do not say planning has started, queued, refreshed, synced, or completed/);
-  assert.match(injected?.prependContext ?? "", /explicitly tell the user that `cs-plan` is the next step before any further implementation/);
-  assert.match(injected?.prependContext ?? "", /do not say the next step is `cs-work`/);
-  assert.doesNotMatch(injected?.prependSystemContext ?? "", /openspec-propose/i);
-});

package/test/queue-work.test.ts

@@ -1,220 +0,0 @@
-import test from "node:test";
-import assert from "node:assert/strict";
-import path from "node:path";
-import { buildWorkerSessionKey, createWorkerSessionKey } from "../src/execution/session.ts";
-import { writeUtf8 } from "../src/utils/fs.ts";
-import { createServiceHarness, seedPlanningProject } from "./helpers/harness.ts";
-
-test("work queues background implementation", async () => {
-  const harness = await createServiceHarness("clawspec-work-queue-");
-  const { service, stateStore, watcherManager, repoPath, workspacePath, changeDir } = harness;
-  const channelKey = "discord:work-queue:default:main";
-  const tasksPath = path.join(changeDir, "tasks.md");
-  await writeUtf8(tasksPath, "- [ ] 1.1 Build the demo endpoint\n");
-
-  harness.openSpec.instructionsApply = async (cwd: string, changeName: string) => ({
-    command: `openspec instructions apply --change ${changeName} --json`,
-    cwd,
-    stdout: "{}",
-    stderr: "",
-    durationMs: 1,
-    parsed: {
-      changeName,
-      changeDir,
-      schemaName: "spec-driven",
-      contextFiles: { tasks: tasksPath },
-      progress: { total: 1, complete: 0, remaining: 1 },
-      tasks: [{ id: "1.1", description: "Build the demo endpoint", done: false }],
-      state: "ready",
-      instruction: "Implement the remaining task.",
-    },
-  });
-
-  await seedPlanningProject(stateStore, channelKey, {
-    workspacePath,
-    repoPath,
-    projectName: "demo-app",
-    changeName: "queue-work",
-    changeDir,
-    phase: "tasks",
-    status: "ready",
-    planningDirty: false,
-  });
-  await stateStore.updateProject(channelKey, (current) => ({
-    ...current,
-    boundSessionKey: "agent:main:discord:channel:work-queue",
-  }));
-
-  const result = await service.queueWorkProject(channelKey, "apply");
-  const project = await stateStore.getActiveProject(channelKey);
-
-  assert.match(result.text ?? "", /Execution Queued/);
-  assert.equal(project?.status, "armed");
-  assert.equal(project?.execution?.action, "work");
-  assert.equal(project?.currentTask, "1.1 Build the demo endpoint");
-  assert.equal(
-    project?.execution?.sessionKey,
-    createWorkerSessionKey(project!, {
-      workerSlot: "primary",
-      workerAgentId: "codex",
-      attemptKey: project?.execution?.armedAt,
-    }),
-  );
-  assert.match(project?.execution?.sessionKey ?? "", new RegExp(`^${buildWorkerSessionKey(project!, "primary", "codex")}:`));
-  assert.notEqual(project?.execution?.sessionKey, project?.boundSessionKey);
-  assert.deepEqual(watcherManager.wakeCalls, [channelKey]);
-});
-
-test("before_dispatch intercepts cs-work and queues background implementation directly", async () => {
-  const harness = await createServiceHarness("clawspec-work-dispatch-");
-  const { service, stateStore, watcherManager, repoPath, workspacePath, changeDir } = harness;
-  const channelKey = "discord:work-dispatch:default:main";
-  const tasksPath = path.join(changeDir, "tasks.md");
-  await writeUtf8(tasksPath, "- [ ] 1.1 Build the demo endpoint\n");
-
-  harness.openSpec.instructionsApply = async (cwd: string, changeName: string) => ({
-    command: `openspec instructions apply --change ${changeName} --json`,
-    cwd,
-    stdout: "{}",
-    stderr: "",
-    durationMs: 1,
-    parsed: {
-      changeName,
-      changeDir,
-      schemaName: "spec-driven",
-      contextFiles: { tasks: tasksPath },
-      progress: { total: 1, complete: 0, remaining: 1 },
-      tasks: [{ id: "1.1", description: "Build the demo endpoint", done: false }],
-      state: "ready",
-      instruction: "Implement the remaining task.",
-    },
-  });
-
-  await seedPlanningProject(stateStore, channelKey, {
-    workspacePath,
-    repoPath,
-    projectName: "demo-app",
-    changeName: "queue-work",
-    changeDir,
-    phase: "tasks",
-    status: "ready",
-    planningDirty: false,
-  });
-  await stateStore.updateProject(channelKey, (current) => ({
-    ...current,
-    boundSessionKey: "agent:main:discord:channel:work-dispatch",
-  }));
-
-  const result = await service.handleBeforeDispatch(
-    { content: "cs-work", channel: "discord" },
-    {
-      channelId: "work-dispatch",
-      accountId: "default",
-      conversationId: "main",
-      sessionKey: "agent:main:discord:channel:work-dispatch",
-    },
-  );
-  const project = await stateStore.getActiveProject(channelKey);
-
-  assert.equal(result?.handled, true);
-  assert.match(result?.text ?? "", /Execution Queued/);
-  assert.equal(project?.status, "armed");
-  assert.equal(project?.execution?.action, "work");
-  assert.deepEqual(watcherManager.wakeCalls, [channelKey]);
-});
-
-test("main chat agent end does not clear a background worker run", async () => {
-  const harness = await createServiceHarness("clawspec-work-session-");
-  const { service, stateStore, repoPath, workspacePath, changeDir } = harness;
-  const channelKey = "discord:work-session:default:main";
-  const workerSessionKey = "clawspec:worker-session";
-  const boundSessionKey = "agent:main:discord:channel:work-session";
-
-  await seedPlanningProject(stateStore, channelKey, {
-    workspacePath,
-    repoPath,
-    projectName: "demo-app",
-    changeName: "queue-work",
-    changeDir,
-    phase: "implementing",
-    status: "running",
-    planningDirty: false,
-    execution: { action: "work", state: "running", mode: "apply" },
-  });
-  await stateStore.updateProject(channelKey, (current) => ({
-    ...current,
-    boundSessionKey,
-    latestSummary: "Worker is running in the background.",
-    execution: current.execution
-      ? {
-          ...current.execution,
-          sessionKey: workerSessionKey,
-          workerAgentId: "codex",
-          workerSlot: "primary",
-        }
-      : current.execution,
-  }));
-
-  await service.handleAgentEnd(
-    { messages: [], success: true },
-    { sessionKey: boundSessionKey, trigger: "user" },
-  );
-
-  const project = await stateStore.getActiveProject(channelKey);
-  assert.equal(project?.status, "running");
-  assert.equal(project?.execution?.state, "running");
-  assert.equal(project?.execution?.sessionKey, workerSessionKey);
-  assert.equal(project?.latestSummary, "Worker is running in the background.");
-});
-
-test("work requires OpenClaw ACP default agent when no project override is set", async () => {
-  const harness = await createServiceHarness("clawspec-work-missing-acp-");
-  const { service, stateStore, watcherManager, repoPath, workspacePath, changeDir } = harness;
-  const channelKey = "discord:work-missing-acp:default:main";
-  const tasksPath = path.join(changeDir, "tasks.md");
-  await writeUtf8(tasksPath, "- [ ] 1.1 Build the demo endpoint\n");
-
-  (service as any).config = {
-    acp: {
-      backend: "acpx",
-    },
-  };
-
-  harness.openSpec.instructionsApply = async (cwd: string, changeName: string) => ({
-    command: `openspec instructions apply --change ${changeName} --json`,
-    cwd,
-    stdout: "{}",
-    stderr: "",
-    durationMs: 1,
-    parsed: {
-      changeName,
-      changeDir,
-      schemaName: "spec-driven",
-      contextFiles: { tasks: tasksPath },
-      progress: { total: 1, complete: 0, remaining: 1 },
-      tasks: [{ id: "1.1", description: "Build the demo endpoint", done: false }],
-      state: "ready",
-      instruction: "Implement the remaining task.",
-    },
-  });
-
-  await seedPlanningProject(stateStore, channelKey, {
-    workspacePath,
-    repoPath,
-    projectName: "demo-app",
-    changeName: "queue-work",
-    changeDir,
-    phase: "tasks",
-    status: "ready",
-    planningDirty: false,
-  });
-
-  const result = await service.queueWorkProject(channelKey, "apply");
-  const project = await stateStore.getActiveProject(channelKey);
-
-  assert.match(result.text ?? "", /Worker Setup Required/);
-  assert.match(result.text ?? "", /openclaw config set acp\.backend acpx/);
-  assert.match(result.text ?? "", /openclaw config set acp\.defaultAgent codex/);
-  assert.equal(project?.status, "ready");
-  assert.deepEqual(watcherManager.wakeCalls, []);
-});