claudeup 6.5.1 → 6.6.0

package/src/services/plugin-version-check.ts

@@ -1,360 +0,0 @@
-/**
- * Plugin version mismatch detection and fix.
- *
- * HISTORICAL (pre-2.1.209): Claude Code's plugin loader took the FIRST entry
- * from installed_plugins.json for each plugin ID:
- *
- *   const installEntry = installedPluginsData.plugins[pluginId]?.[0]
- *
- * so the first project to install a plugin determined the version loaded for
- * ALL projects (bug #45997).
- *
- * FIXED in Claude Code 2.1.209: the loader is now project-aware — it filters
- * entries to the current project/scope (same git root or user/managed scope)
- * BEFORE selecting, so cross-project [0] contention no longer applies. This
- * detection therefore mostly warns on older Claude Code; it is retained for
- * those versions but should not be treated as a current-version defect.
- *
- * Bug report: https://github.com/anthropics/claude-code/issues/45997
- */
-
-import type { InstalledPluginEntry } from "../types/index.js";
-import {
-	getEnabledPlugins,
-	getGlobalEnabledPlugins,
-	getLocalEnabledPlugins,
-	readInstalledPluginsRegistry,
-	writeInstalledPluginsRegistry,
-} from "./claude-settings.js";
-
-const BUG_REPORT_URL = "https://github.com/anthropics/claude-code/issues/45997";
-
-// ── Types ────────────────────────────────────────────────────────────────────
-
-export interface VersionMismatchInfo {
-	/** Plugin ID, e.g. "terminal@magus" */
-	pluginId: string;
-	/** Version at entries[0] — the one Claude Code actually loads */
-	firstEntryVersion: string;
-	/** Project path of the entries[0] entry */
-	firstEntryProject: string | undefined;
-	/** Version this project has installed */
-	currentProjectVersion: string;
-	/** All entries for this plugin */
-	allEntries: InstalledPluginEntry[];
-}
-
-export interface FixResult {
-	/** Number of entries updated */
-	updated: number;
-	/** Project paths that were updated */
-	projects: string[];
-}
-
-// ── Detection ────────────────────────────────────────────────────────────────
-
-/**
- * Check for plugin version mismatches caused by the [0] index bug.
- *
- * For each enabled plugin in the current project:
- * 1. Reads the plugin's entry array from installed_plugins.json
- * 2. Finds the entry matching the current project
- * 3. Checks if entries[0] has a DIFFERENT version than the current project's entry
- * 4. If yes: this project will load the wrong version
- *
- * @param projectPath - The current project path to check
- * @returns Array of mismatch info for each affected plugin
- */
-export async function checkPluginVersionMismatches(
-	projectPath: string,
-): Promise<VersionMismatchInfo[]> {
-	const registry = await readInstalledPluginsRegistry();
-	const enabledPluginIds = await collectEnabledPluginIds(projectPath);
-	const mismatches: VersionMismatchInfo[] = [];
-
-	for (const pluginId of enabledPluginIds) {
-		const entries = registry.plugins[pluginId];
-		if (!entries || entries.length < 2) continue;
-
-		// Find the entry for the current project
-		const currentEntry = entries.find(
-			(e) =>
-				e.scope === "project" &&
-				normalizePath(e.projectPath) === normalizePath(projectPath),
-		);
-		if (!currentEntry) continue;
-
-		const firstEntry = entries[0];
-
-		// Compare the version at [0] with the current project's version
-		if (firstEntry.version !== currentEntry.version) {
-			mismatches.push({
-				pluginId,
-				firstEntryVersion: firstEntry.version,
-				firstEntryProject: firstEntry.projectPath,
-				currentProjectVersion: currentEntry.version,
-				allEntries: entries,
-			});
-		}
-	}
-
-	return mismatches;
-}
-
-/**
- * Check a single plugin for version mismatch (used after plugin update).
- *
- * @param pluginId - The plugin ID to check
- * @param projectPath - The current project path
- * @returns Mismatch info or null if no mismatch
- */
-export async function checkSinglePluginMismatch(
-	pluginId: string,
-	projectPath: string,
-): Promise<VersionMismatchInfo | null> {
-	const registry = await readInstalledPluginsRegistry();
-	const entries = registry.plugins[pluginId];
-	if (!entries || entries.length < 2) return null;
-
-	const currentEntry = entries.find(
-		(e) =>
-			e.scope === "project" &&
-			normalizePath(e.projectPath) === normalizePath(projectPath),
-	);
-	if (!currentEntry) return null;
-
-	const firstEntry = entries[0];
-	if (firstEntry.version === currentEntry.version) return null;
-
-	return {
-		pluginId,
-		firstEntryVersion: firstEntry.version,
-		firstEntryProject: firstEntry.projectPath,
-		currentProjectVersion: currentEntry.version,
-		allEntries: entries,
-	};
-}
-
-// ── Fix ──────────────────────────────────────────────────────────────────────
-
-/**
- * Fix a version mismatch by updating ALL entries for a plugin to use
- * the target version. This is a JSON-only operation that rewrites
- * installPath and version in each entry.
- *
- * IMPORTANT: This modifies installed_plugins.json which is Claude Code-owned.
- * Only call after explicit user consent.
- *
- * @param pluginId - The plugin ID to fix
- * @param targetVersion - The version to normalize all entries to
- * @returns Number of updated entries and which projects were affected
- */
-export async function fixPluginVersionMismatch(
-	pluginId: string,
-	targetVersion: string,
-): Promise<FixResult> {
-	const registry = await readInstalledPluginsRegistry();
-	const entries = registry.plugins[pluginId];
-	if (!entries || entries.length === 0) {
-		return { updated: 0, projects: [] };
-	}
-
-	// Find an existing entry with the target version to get the correct installPath
-	const templateEntry = entries.find((e) => e.version === targetVersion);
-	if (!templateEntry) {
-		return { updated: 0, projects: [] };
-	}
-
-	const targetInstallPath = templateEntry.installPath;
-	const updated: string[] = [];
-
-	for (const entry of entries) {
-		if (entry.version !== targetVersion) {
-			entry.version = targetVersion;
-			entry.installPath = targetInstallPath;
-			entry.lastUpdated = new Date().toISOString();
-			updated.push(entry.projectPath || "(global)");
-		}
-	}
-
-	if (updated.length > 0) {
-		await writeInstalledPluginsRegistry(registry);
-	}
-
-	return { updated: updated.length, projects: updated };
-}
-
-/**
- * Fix all version mismatches by normalizing each plugin to its latest version.
- *
- * @param mismatches - Array of mismatches from checkPluginVersionMismatches
- * @returns Map of pluginId to FixResult
- */
-export async function fixAllPluginVersionMismatches(
-	mismatches: VersionMismatchInfo[],
-): Promise<Map<string, FixResult>> {
-	const results = new Map<string, FixResult>();
-
-	// Read registry once, apply all fixes, write once
-	const registry = await readInstalledPluginsRegistry();
-
-	for (const mismatch of mismatches) {
-		const entries = registry.plugins[mismatch.pluginId];
-		if (!entries || entries.length === 0) {
-			results.set(mismatch.pluginId, { updated: 0, projects: [] });
-			continue;
-		}
-
-		// Use the current project's version as the target (the version the user expects)
-		const targetVersion = mismatch.currentProjectVersion;
-		const templateEntry = entries.find((e) => e.version === targetVersion);
-		if (!templateEntry) {
-			results.set(mismatch.pluginId, { updated: 0, projects: [] });
-			continue;
-		}
-
-		const targetInstallPath = templateEntry.installPath;
-		const updated: string[] = [];
-
-		for (const entry of entries) {
-			if (entry.version !== targetVersion) {
-				entry.version = targetVersion;
-				entry.installPath = targetInstallPath;
-				entry.lastUpdated = new Date().toISOString();
-				updated.push(entry.projectPath || "(global)");
-			}
-		}
-
-		results.set(mismatch.pluginId, {
-			updated: updated.length,
-			projects: updated,
-		});
-	}
-
-	await writeInstalledPluginsRegistry(registry);
-	return results;
-}
-
-// ── Formatting ───────────────────────────────────────────────────────────────
-
-/**
- * Format mismatch info for console output (prerunner).
- */
-export function formatMismatchWarning(
-	mismatches: VersionMismatchInfo[],
-): string {
-	const lines: string[] = [];
-	lines.push(
-		"WARNING: Plugin version mismatch detected (Claude Code bug #45997)",
-	);
-	lines.push(
-		"Claude Code loads the first entry from installed_plugins.json for ALL projects.",
-	);
-	lines.push(
-		"The following plugins will load a different version than what this project has installed:\n",
-	);
-
-	for (const m of mismatches) {
-		const firstProject = m.firstEntryProject
-			? shortenPath(m.firstEntryProject)
-			: "(global)";
-		lines.push(`  ${m.pluginId}:`);
-		lines.push(`    Loading v${m.firstEntryVersion} (from ${firstProject})`);
-		lines.push(`    Expected v${m.currentProjectVersion} (this project)`);
-	}
-
-	lines.push("");
-	lines.push(`Bug report: ${BUG_REPORT_URL}`);
-	lines.push(
-		"Run claudeup to fix — it can align all projects to the same version.",
-	);
-
-	return lines.join("\n");
-}
-
-/**
- * Format mismatch info for TUI modal display.
- * Returns a multi-line string suitable for a modal message.
- */
-export function formatMismatchModal(mismatches: VersionMismatchInfo[]): string {
-	const lines: string[] = [];
-
-	lines.push("Your plugins will not work correctly in this project.");
-	lines.push("");
-	lines.push("Due to a Claude Code bug, the plugin loader ignores");
-	lines.push("per-project versions and loads an older version instead.");
-	lines.push("Commands, MCP tools, and skills will be outdated.");
-	lines.push("");
-
-	for (const m of mismatches) {
-		const name = m.pluginId.split("@")[0];
-		lines.push(
-			`  ${name}: v${m.firstEntryVersion} loaded, expected v${m.currentProjectVersion}`,
-		);
-	}
-
-	lines.push("");
-	lines.push("Fix: align all projects to the same version.");
-	lines.push("Details: github.com/anthropics/claude-code/issues/45997");
-
-	return lines.join("\n");
-}
-
-// ── Helpers ──────────────────────────────────────────────────────────────────
-
-/**
- * Collect all enabled plugin IDs across all scopes for a project.
- */
-async function collectEnabledPluginIds(
-	projectPath: string,
-): Promise<Set<string>> {
-	const pluginIds = new Set<string>();
-
-	try {
-		const global = await getGlobalEnabledPlugins();
-		for (const [id, enabled] of Object.entries(global)) {
-			if (enabled) pluginIds.add(id);
-		}
-	} catch {
-		/* skip unreadable */
-	}
-
-	try {
-		const project = await getEnabledPlugins(projectPath);
-		for (const [id, enabled] of Object.entries(project)) {
-			if (enabled) pluginIds.add(id);
-		}
-	} catch {
-		/* skip unreadable */
-	}
-
-	try {
-		const local = await getLocalEnabledPlugins(projectPath);
-		for (const [id, enabled] of Object.entries(local)) {
-			if (enabled) pluginIds.add(id);
-		}
-	} catch {
-		/* skip unreadable */
-	}
-
-	return pluginIds;
-}
-
-/**
- * Normalize a path for comparison (resolve and trailing-slash normalize).
- */
-function normalizePath(p: string | undefined): string {
-	if (!p) return "";
-	return p.replace(/\/+$/, "");
-}
-
-/**
- * Shorten a path for display by replacing homedir with ~.
- */
-function shortenPath(p: string): string {
-	const home = process.env.HOME || process.env.USERPROFILE || "";
-	if (home && p.startsWith(home)) {
-		return `~${p.slice(home.length)}`;
-	}
-	return p;
-}

package/src/services/update-cache.ts

@@ -1,78 +0,0 @@
-import { promises as fs } from "node:fs";
-import os from "node:os";
-import path from "node:path";
-
-const CACHE_TTL_MS = 60 * 60 * 1000; // 1 hour
-
-export interface UpdateCacheData {
-	lastUpdateCheck: string; // ISO timestamp
-	lastUpdateResult: {
-		updated: string[]; // ["frontend@magus v3.13.0", ...]
-		failed: string[]; // Marketplaces that failed
-		autoUpdated?: Array<{
-			pluginId: string;
-			oldVersion: string;
-			newVersion: string;
-		}>; // Plugins that were auto-updated
-	};
-}
-
-export class UpdateCache {
-	private cachePath: string;
-
-	constructor() {
-		// Cache at ~/.claude/claudeup-cache.json
-		this.cachePath = path.join(os.homedir(), ".claude", "claudeup-cache.json");
-	}
-
-	async shouldCheckForUpdates(): Promise<boolean> {
-		const data = await this.getLastCheck();
-		if (!data) return true; // No cache
-
-		const lastCheck = new Date(data.lastUpdateCheck);
-		const now = new Date();
-		const elapsed = now.getTime() - lastCheck.getTime();
-
-		return elapsed >= CACHE_TTL_MS;
-	}
-
-	async getLastCheck(): Promise<UpdateCacheData | null> {
-		try {
-			const content = await fs.readFile(this.cachePath, "utf-8");
-			const data = JSON.parse(content) as UpdateCacheData;
-			return data;
-		} catch (error) {
-			// Cache doesn't exist or is corrupted
-			return null;
-		}
-	}
-
-	async saveCheck(result: UpdateCacheData): Promise<void> {
-		try {
-			// Ensure .claude directory exists
-			const cacheDir = path.dirname(this.cachePath);
-			await fs.mkdir(cacheDir, { recursive: true });
-
-			// Write cache file
-			await fs.writeFile(
-				this.cachePath,
-				JSON.stringify(result, null, 2),
-				"utf-8",
-			);
-		} catch (error) {
-			// Non-fatal - just log and continue
-			console.warn(
-				"Warning: Failed to save update cache:",
-				error instanceof Error ? error.message : "Unknown error",
-			);
-		}
-	}
-
-	async clear(): Promise<void> {
-		try {
-			await fs.unlink(this.cachePath);
-		} catch (error) {
-			// Ignore errors (file might not exist)
-		}
-	}
-}

package/src/ui/components/modals/VersionMismatchModal.tsx

@@ -1,138 +0,0 @@
-import React from "react";
-import type { VersionMismatchInfo } from "../../../services/plugin-version-check.js";
-import { theme } from "../../theme.js";
-
-interface VersionMismatchModalProps {
-	/** List of version mismatches detected */
-	mismatches: VersionMismatchInfo[];
-	/** Currently selected option index (0 = Fix, 1 = Dismiss) */
-	defaultIndex?: number;
-}
-
-const COLOR_BG = theme.surface.bg;
-const COLOR_BORDER = theme.colors.dim;
-const COLOR_TITLE = theme.colors.text;
-const COLOR_MUTED = theme.colors.muted;
-const COLOR_DIM = theme.colors.muted;
-const COLOR_WARN = theme.colors.warning;
-const COLOR_BAD = theme.colors.danger;
-const COLOR_GOOD = theme.colors.success;
-const COLOR_ACCENT = theme.colors.text;
-
-/** Truncate a plugin name to fit the column width */
-function shortName(pluginId: string, max: number): string {
-	const name = pluginId.split("@")[0];
-	if (name.length <= max) return name;
-	return `${name.slice(0, max - 1)}…`;
-}
-
-/** Truncate a version string to fit the column width */
-function shortVersion(v: string, max: number): string {
-	if (v.length <= max) return v;
-	return `${v.slice(0, max - 1)}…`;
-}
-
-export function VersionMismatchModal({
-	mismatches,
-	defaultIndex,
-}: VersionMismatchModalProps) {
-	const selectedIndex = defaultIndex ?? 0;
-
-	// Column widths chosen to fit a 64-wide modal with padding
-	const NAME_W = 22;
-	const VER_W = 12;
-
-	return (
-		<box
-			flexDirection="column"
-			border
-			borderStyle="rounded"
-			borderColor={COLOR_BORDER}
-			backgroundColor={COLOR_BG}
-			paddingLeft={3}
-			paddingRight={3}
-			paddingTop={1}
-			paddingBottom={1}
-			width={64}
-		>
-			{/* Title */}
-			<box marginBottom={1}>
-				<text fg={COLOR_TITLE}>
-					<span fg={COLOR_WARN}>⚠ </span>
-					<strong>Plugin Version Mismatch</strong>
-				</text>
-			</box>
-
-			{/* Description */}
-			<box flexDirection="column" marginBottom={1}>
-				<text fg={COLOR_MUTED}>
-					Plugins in this project will load <strong>wrong versions</strong>
-				</text>
-				<text fg={COLOR_MUTED}>due to a Claude Code bug (#45997).</text>
-			</box>
-
-			{/* Table header */}
-			<box flexDirection="column" marginBottom={1}>
-				<text fg={COLOR_DIM}>
-					<strong>
-						{"Plugin".padEnd(NAME_W)}
-						{"Loaded".padEnd(VER_W)}
-						{"Expected".padEnd(VER_W)}
-					</strong>
-				</text>
-				<text fg={COLOR_BORDER}>
-					{"─".repeat(NAME_W - 1)} {"─".repeat(VER_W - 1)}{" "}
-					{"─".repeat(VER_W - 1)}
-				</text>
-
-				{/* Table rows */}
-				{mismatches.map((m) => {
-					const name = shortName(m.pluginId, NAME_W - 1);
-					const loaded = `v${shortVersion(m.firstEntryVersion, VER_W - 2)}`;
-					const expected = `v${shortVersion(m.currentProjectVersion, VER_W - 2)}`;
-					return (
-						<text key={m.pluginId} fg={COLOR_MUTED}>
-							<span fg={COLOR_ACCENT}>{name.padEnd(NAME_W)}</span>
-							<span fg={COLOR_BAD}>{loaded.padEnd(VER_W)}</span>
-							<span fg={COLOR_GOOD}>{expected.padEnd(VER_W)}</span>
-						</text>
-					);
-				})}
-			</box>
-
-			{/* Footer note */}
-			<box marginBottom={1}>
-				<text fg={COLOR_DIM}>
-					Details: github.com/anthropics/claude-code/issues/45997
-				</text>
-			</box>
-
-			{/* Options */}
-			<box flexDirection="column" paddingLeft={1}>
-				<text fg={selectedIndex === 0 ? COLOR_ACCENT : COLOR_MUTED}>
-					<span fg={selectedIndex === 0 ? COLOR_ACCENT : COLOR_DIM}>
-						{selectedIndex === 0 ? "❯ " : "  "}
-					</span>
-					{selectedIndex === 0 ? (
-						<strong>Fix all projects</strong>
-					) : (
-						"Fix all projects"
-					)}
-				</text>
-				<text fg={selectedIndex === 1 ? COLOR_ACCENT : COLOR_MUTED}>
-					<span fg={selectedIndex === 1 ? COLOR_ACCENT : COLOR_DIM}>
-						{selectedIndex === 1 ? "❯ " : "  "}
-					</span>
-					{selectedIndex === 1 ? <strong>Dismiss</strong> : "Dismiss"}
-				</text>
-			</box>
-
-			{/* Keybind hints */}
-			<box marginTop={1}>
-				<text fg={COLOR_DIM}>↑↓ Select • ↵ Confirm • Esc Cancel</text>
-			</box>
-		</box>
-	);
-}
-
-export default VersionMismatchModal;

package/src/ui/hooks/useMismatchModal.ts

@@ -1,89 +0,0 @@
-import { useCallback } from "react";
-import {
-	type VersionMismatchInfo,
-	fixAllPluginVersionMismatches,
-} from "../../services/plugin-version-check.js";
-import { useApp } from "../state/AppContext.js";
-
-/**
- * Shared hook for showing the plugin version mismatch modal.
- *
- * Used in two places:
- * 1. App.tsx — startup check shows mismatches found across all enabled plugins
- * 2. PluginsScreen.tsx — post-install/update check shows a single plugin mismatch
- *
- * Both flows now share the same interactive modal with a "Fix all projects"
- * button, so users never have to restart claudeup to access the fix.
- *
- * The fix uses fixAllPluginVersionMismatches() which rewrites
- * installed_plugins.json in-place to align all entries to the current
- * project's expected versions. After success, shows a hint to restart
- * Claude Code so the new versions actually load (the running session
- * has the old plugin code in memory).
- */
-export function useMismatchModal() {
-	const { dispatch } = useApp();
-
-	const show = useCallback(
-		(mismatches: VersionMismatchInfo[]) => {
-			if (mismatches.length === 0) return;
-
-			const dismiss = () => dispatch({ type: "HIDE_MODAL" });
-
-			const fix = async () => {
-				dispatch({ type: "HIDE_MODAL" });
-				dispatch({
-					type: "SHOW_PROGRESS",
-					state: { message: "Aligning plugin versions across projects..." },
-				});
-
-				try {
-					const results = await fixAllPluginVersionMismatches(mismatches);
-					dispatch({ type: "HIDE_PROGRESS" });
-
-					// Count how many projects were updated across all plugins
-					const totalUpdated = Array.from(results.values()).reduce(
-						(sum, r) => sum + r.updated,
-						0,
-					);
-
-					dispatch({
-						type: "SHOW_MODAL",
-						modal: {
-							type: "message",
-							title: "Plugin Versions Aligned",
-							message: `Updated ${totalUpdated} project entr${totalUpdated === 1 ? "y" : "ies"} in installed_plugins.json.\n\nRestart Claude Code for the new versions to load. The running session still has the old plugin code in memory.`,
-							variant: "success",
-							onDismiss: dismiss,
-						},
-					});
-				} catch (error) {
-					dispatch({ type: "HIDE_PROGRESS" });
-					dispatch({
-						type: "SHOW_MODAL",
-						modal: {
-							type: "message",
-							title: "Fix Failed",
-							message: `Could not align plugin versions: ${error instanceof Error ? error.message : String(error)}\n\nTry running claudeup again, or manually update the plugin in each project.`,
-							variant: "error",
-							onDismiss: dismiss,
-						},
-					});
-				}
-			};
-
-			dispatch({
-				type: "SHOW_MODAL",
-				modal: {
-					type: "version-mismatch",
-					mismatches,
-					onFix: fix,
-					onDismiss: dismiss,
-				},
-			});
-		},
-		[dispatch],
-	);
-
-	return { show };
-}