claudeup 6.2.1 → 6.3.2

package/src/services/update-plan.ts

@@ -56,17 +56,15 @@ function scopeVersions(
 	info: PluginInfo | undefined,
 ): Array<[PluginScope, string]> {
 	if (!info) return [];
-	return (
-		[
-			["user", info.userScope],
-			["project", info.projectScope],
-			["local", info.localScope],
-		] as const
-	)
-		.filter(([, status]) => !!status?.version)
-		.map(
-			([scope, status]) => [scope, status!.version!] as [PluginScope, string],
-		);
+	const out: Array<[PluginScope, string]> = [];
+	for (const [scope, status] of [
+		["user", info.userScope],
+		["project", info.projectScope],
+		["local", info.localScope],
+	] as const) {
+		if (status?.version) out.push([scope, status.version]);
+	}
+	return out;
 }
 
 /** The highest version installed across scopes, or null. */

package/src/services/version-snapshot.ts

@@ -15,8 +15,8 @@
  */
 
 import { promises as fs } from "node:fs";
-import path from "node:path";
 import os from "node:os";
+import path from "node:path";
 
 /**
  * Sentinel recorded by Claude Code for a plugin that is installed but whose
@@ -27,41 +27,41 @@ export const UNKNOWN_VERSION = "0.0.0";
 
 /** True when a version string carries no usable information. */
 export function isKnownVersion(v: string | undefined): v is string {
-  return !!v && v !== UNKNOWN_VERSION;
+	return !!v && v !== UNKNOWN_VERSION;
 }
 
 export type PluginChangeKind = "installed" | "updated";
 
 export interface PluginChange {
-  pluginId: string;
-  kind: PluginChangeKind;
-  /** Previous version. Only set for "updated", and always a known version. */
-  from?: string;
-  /** Current version. May be UNKNOWN_VERSION — callers must not render it raw. */
-  to: string;
+	pluginId: string;
+	kind: PluginChangeKind;
+	/** Previous version. Only set for "updated", and always a known version. */
+	from?: string;
+	/** Current version. May be UNKNOWN_VERSION — callers must not render it raw. */
+	to: string;
 }
 
 interface SnapshotFile {
-  /**
-   * Legacy flat baseline: pluginId -> version, with no record of which project
-   * it was observed from. Kept only so an existing file can be migrated.
-   */
-  seen?: Record<string, string>;
-  /**
-   * projectPath -> (pluginId -> installedVersion) as of the last time claudeup
-   * rendered that project.
-   *
-   * Versions are per-project (installed_plugins.json keys installs by
-   * projectPath), but this file is global. A single flat map therefore let two
-   * projects legitimately on different versions overwrite each other's
-   * baseline, and every differing plugin was badged "updated" on the next
-   * render — a change that never happened. Keying by project removes the
-   * cross-talk entirely.
-   */
-  byProject?: Record<string, Record<string, string>>;
-  /** Set on the run that first created the baseline. */
-  seededAt: string;
-  updatedAt: string;
+	/**
+	 * Legacy flat baseline: pluginId -> version, with no record of which project
+	 * it was observed from. Kept only so an existing file can be migrated.
+	 */
+	seen?: Record<string, string>;
+	/**
+	 * projectPath -> (pluginId -> installedVersion) as of the last time claudeup
+	 * rendered that project.
+	 *
+	 * Versions are per-project (installed_plugins.json keys installs by
+	 * projectPath), but this file is global. A single flat map therefore let two
+	 * projects legitimately on different versions overwrite each other's
+	 * baseline, and every differing plugin was badged "updated" on the next
+	 * render — a change that never happened. Keying by project removes the
+	 * cross-talk entirely.
+	 */
+	byProject?: Record<string, Record<string, string>>;
+	/** Set on the run that first created the baseline. */
+	seededAt: string;
+	updatedAt: string;
 }
 
 /**
@@ -72,24 +72,24 @@ interface SnapshotFile {
  * That is not hypothetical: it happened while building the tests for this fix.
  */
 function snapshotPath(): string {
-  const configDir =
-    process.env.CLAUDE_CONFIG_DIR || path.join(os.homedir(), ".claude");
-  return path.join(configDir, "claudeup-version-snapshot.json");
+	const configDir =
+		process.env.CLAUDE_CONFIG_DIR || path.join(os.homedir(), ".claude");
+	return path.join(configDir, "claudeup-version-snapshot.json");
 }
 
 async function read(): Promise<SnapshotFile | null> {
-  try {
-    const raw = await fs.readFile(snapshotPath(), "utf-8");
-    const data = JSON.parse(raw) as SnapshotFile;
-    if (!data) return null;
-    const hasFlat = typeof data.seen === "object" && data.seen !== null;
-    const hasByProject =
-      typeof data.byProject === "object" && data.byProject !== null;
-    if (!hasFlat && !hasByProject) return null;
-    return data;
-  } catch {
-    return null; // absent or corrupt — treated as "no baseline yet"
-  }
+	try {
+		const raw = await fs.readFile(snapshotPath(), "utf-8");
+		const data = JSON.parse(raw) as SnapshotFile;
+		if (!data) return null;
+		const hasFlat = typeof data.seen === "object" && data.seen !== null;
+		const hasByProject =
+			typeof data.byProject === "object" && data.byProject !== null;
+		if (!hasFlat && !hasByProject) return null;
+		return data;
+	} catch {
+		return null; // absent or corrupt — treated as "no baseline yet"
+	}
 }
 
 /**
@@ -111,30 +111,30 @@ async function read(): Promise<SnapshotFile | null> {
  * A downgrade IS reported: rolling back is a real change worth surfacing.
  */
 export function diffVersions(
-  previous: Record<string, string> | null,
-  current: Record<string, string>,
+	previous: Record<string, string> | null,
+	current: Record<string, string>,
 ): PluginChange[] {
-  if (!previous) return [];
+	if (!previous) return [];
 
-  const changes: PluginChange[] = [];
-  for (const [pluginId, to] of Object.entries(current)) {
-    const from = previous[pluginId];
+	const changes: PluginChange[] = [];
+	for (const [pluginId, to] of Object.entries(current)) {
+		const from = previous[pluginId];
 
-    // Never seen before → newly installed, not an update. There is no
-    // meaningful "from", and `to` may legitimately be UNKNOWN_VERSION.
-    if (from === undefined) {
-      changes.push({ pluginId, kind: "installed", to });
-      continue;
-    }
+		// Never seen before → newly installed, not an update. There is no
+		// meaningful "from", and `to` may legitimately be UNKNOWN_VERSION.
+		if (from === undefined) {
+			changes.push({ pluginId, kind: "installed", to });
+			continue;
+		}
 
-    if (from === to) continue;
+		if (from === to) continue;
 
-    // One side carries no real version: we learned or lost it, nothing moved.
-    if (!isKnownVersion(from) || !isKnownVersion(to)) continue;
+		// One side carries no real version: we learned or lost it, nothing moved.
+		if (!isKnownVersion(from) || !isKnownVersion(to)) continue;
 
-    changes.push({ pluginId, kind: "updated", from, to });
-  }
-  return changes;
+		changes.push({ pluginId, kind: "updated", from, to });
+	}
+	return changes;
 }
 
 /**
@@ -149,16 +149,16 @@ export function diffVersions(
  * asks first, which is the closest thing to the truth it contains.
  */
 export async function loadSeenVersions(
-  projectPath: string,
+	projectPath: string,
 ): Promise<Record<string, string> | null> {
-  const data = await read();
-  if (!data) return null;
-  const scoped = data.byProject?.[projectPath];
-  if (scoped) return scoped;
-  // Legacy flat baseline, project unknown — use it once, then it is replaced
-  // by per-project entries on save.
-  if (data.seen && !data.byProject) return data.seen;
-  return null;
+	const data = await read();
+	if (!data) return null;
+	const scoped = data.byProject?.[projectPath];
+	if (scoped) return scoped;
+	// Legacy flat baseline, project unknown — use it once, then it is replaced
+	// by per-project entries on save.
+	if (data.seen && !data.byProject) return data.seen;
+	return null;
 }
 
 /**
@@ -167,23 +167,23 @@ export async function loadSeenVersions(
  * shows again next launch.
  */
 export async function saveSeenVersions(
-  projectPath: string,
-  current: Record<string, string>,
+	projectPath: string,
+	current: Record<string, string>,
 ): Promise<void> {
-  try {
-    const file = snapshotPath();
-    await fs.mkdir(path.dirname(file), { recursive: true });
-    const existing = await read();
-    const now = new Date().toISOString();
-    const payload: SnapshotFile = {
-      // Other projects' baselines are preserved — writing only this project's
-      // slot is the entire point of the fix.
-      byProject: { ...(existing?.byProject ?? {}), [projectPath]: current },
-      seededAt: existing?.seededAt ?? now,
-      updatedAt: now,
-    };
-    await fs.writeFile(file, JSON.stringify(payload, null, 2), "utf-8");
-  } catch {
-    // ignore
-  }
+	try {
+		const file = snapshotPath();
+		await fs.mkdir(path.dirname(file), { recursive: true });
+		const existing = await read();
+		const now = new Date().toISOString();
+		const payload: SnapshotFile = {
+			// Other projects' baselines are preserved — writing only this project's
+			// slot is the entire point of the fix.
+			byProject: { ...(existing?.byProject ?? {}), [projectPath]: current },
+			seededAt: existing?.seededAt ?? now,
+			updatedAt: now,
+		};
+		await fs.writeFile(file, JSON.stringify(payload, null, 2), "utf-8");
+	} catch {
+		// ignore
+	}
 }

package/src/types/gitignore.ts

@@ -10,31 +10,31 @@ export type Tier = "builtin" | "global" | "project" | "profile";
 
 /** A user-authored manifest, deserialized from JSON. */
 export interface GitignoreManifest {
-  /** Paths or globs that must be excluded from git. */
-  ignore: string[];
-  /** Paths that must remain tracked even if a parent is in ignore. */
-  track: string[];
-  /** Optional template names to merge in (e.g. "common-dev"). */
-  extends?: string[];
+	/** Paths or globs that must be excluded from git. */
+	ignore: string[];
+	/** Paths that must remain tracked even if a parent is in ignore. */
+	track: string[];
+	/** Optional template names to merge in (e.g. "common-dev"). */
+	extends?: string[];
 }
 
 /** A single rule after tier resolution. */
 export interface ResolvedRule {
-  pattern: string;
-  action: RuleAction;
-  source: Tier;
+	pattern: string;
+	action: RuleAction;
+	source: Tier;
 }
 
 /** When two tiers disagree on a pattern, the higher-precedence tier wins. */
 export interface ResolvedConflict {
-  pattern: string;
-  winner: Tier;
-  losers: Array<{ tier: Tier; action: RuleAction }>;
+	pattern: string;
+	winner: Tier;
+	losers: Array<{ tier: Tier; action: RuleAction }>;
 }
 
 export interface ResolvedManifest {
-  rules: ResolvedRule[];
-  conflicts: ResolvedConflict[];
+	rules: ResolvedRule[];
+	conflicts: ResolvedConflict[];
 }
 
 /**
@@ -49,20 +49,20 @@ export interface ResolvedManifest {
  *                                covers it (and the path isn't currently tracked)
  */
 export type ViolationKind =
-  | "tracked-but-should-ignore"
-  | "ignored-but-should-track"
-  | "untracked-and-should-track"
-  | "missing-from-gitignore";
+	| "tracked-but-should-ignore"
+	| "ignored-but-should-track"
+	| "untracked-and-should-track"
+	| "missing-from-gitignore";
 
 export interface Violation {
-  kind: ViolationKind;
-  path: string;
-  /** Which tier asserted the rule that's being violated. */
-  source: Tier;
-  /**
-   * "safe"        — fix is purely additive (append a .gitignore line)
-   * "destructive" — fix mutates git index (`git rm --cached`, `git add`,
-   *                  removing existing .gitignore lines)
-   */
-  severity: "safe" | "destructive";
+	kind: ViolationKind;
+	path: string;
+	/** Which tier asserted the rule that's being violated. */
+	source: Tier;
+	/**
+	 * "safe"        — fix is purely additive (append a .gitignore line)
+	 * "destructive" — fix mutates git index (`git rm --cached`, `git add`,
+	 *                  removing existing .gitignore lines)
+	 */
+	severity: "safe" | "destructive";
 }

package/src/ui/App.tsx

@@ -1,55 +1,55 @@
-import React, { useEffect, useState } from "react";
-import { useRenderer } from "@opentui/react";
 import fs from "node:fs";
+import { useRenderer } from "@opentui/react";
+import React, { useEffect, useState } from "react";
+import { isClaudeAvailable } from "../services/claude-cli.js";
 import {
-	AppProvider,
-	useApp,
-	useNavigation,
-	useModal,
-} from "./state/AppContext.js";
-import {
-	DimensionsProvider,
-	useDimensions,
-} from "./state/DimensionsContext.js";
-import { ModalContainer } from "./components/modals/index.js";
-import {
-	PluginsScreen,
-	McpScreen,
-	McpRegistryScreen,
-	SettingsScreen,
-	CliToolsScreen,
-	ProfilesScreen,
-	SkillsScreen,
-	StylesScreen,
-	GitignoreScreen,
-	AliasScreen,
-} from "./screens/index.js";
-import type { Screen } from "./state/types.js";
+	migrateMarketplaceRename,
+	recoverMarketplaceSettings,
+} from "../services/claude-settings.js";
 import { checkGitignore } from "../services/gitignore-prerun.js";
 import {
-	loadGitignoreState,
 	applyAllSafeFixes,
+	loadGitignoreState,
 } from "../services/gitignore-service.js";
-import { useGitignoreModal } from "./hooks/useGitignoreModal.js";
 import { repairAllMarketplaces } from "../services/local-marketplace.js";
-import {
-	migrateMarketplaceRename,
-	recoverMarketplaceSettings,
-} from "../services/claude-settings.js";
 import { autoAddMissingMarketplaces } from "../services/marketplace-sync.js";
-import { isClaudeAvailable } from "../services/claude-cli.js";
 import {
-	checkPluginVersionMismatches,
 	type VersionMismatchInfo,
+	checkPluginVersionMismatches,
 } from "../services/plugin-version-check.js";
-import { useMismatchModal } from "./hooks/useMismatchModal.js";
 import {
+	type VersionCheckResult,
 	checkForUpdates,
 	getCurrentVersion,
-	type VersionCheckResult,
 } from "../services/version-check.js";
-import { useKeyboardHandler } from "./hooks/useKeyboardHandler.js";
 import { ProgressBar } from "./components/layout/ProgressBar.js";
+import { ModalContainer } from "./components/modals/index.js";
+import { useGitignoreModal } from "./hooks/useGitignoreModal.js";
+import { useKeyboardHandler } from "./hooks/useKeyboardHandler.js";
+import { useMismatchModal } from "./hooks/useMismatchModal.js";
+import {
+	AliasScreen,
+	CliToolsScreen,
+	GitignoreScreen,
+	McpRegistryScreen,
+	McpScreen,
+	PluginsScreen,
+	ProfilesScreen,
+	SettingsScreen,
+	SkillsScreen,
+	StylesScreen,
+} from "./screens/index.js";
+import {
+	AppProvider,
+	useApp,
+	useModal,
+	useNavigation,
+} from "./state/AppContext.js";
+import {
+	DimensionsProvider,
+	useDimensions,
+} from "./state/DimensionsContext.js";
+import type { Screen } from "./state/types.js";
 import { theme } from "./theme.js";
 
 export const VERSION = getCurrentVersion();

package/src/ui/adapters/settingsAdapter.ts

@@ -4,7 +4,7 @@ import {
 	type SettingDefinition,
 } from "../../data/settings-catalog.js";
 import type { ScopedSettingValues } from "../../services/settings-manager.js";
-import { theme, type UiColor } from "../theme.js";
+import { type UiColor, theme } from "../theme.js";
 
 // ─── Item types ────────────────────────────────────────────────────────────────
 
@@ -117,7 +117,7 @@ export function formatValue(
 	}
 
 	if (value.length > 12) {
-		return value.slice(0, 12) + "…";
+		return `${value.slice(0, 12)}…`;
 	}
 	return value;
 }

package/src/ui/components/CategoryHeader.tsx

@@ -1,5 +1,5 @@
 import React from "react";
-import { theme, type UiColor } from "../theme.js";
+import { type UiColor, theme } from "../theme.js";
 
 interface CategoryHeaderProps {
 	/** Category title */

package/src/ui/components/ScopeIndicator.tsx

@@ -1,5 +1,5 @@
 import React from "react";
-import { theme, type UiColor } from "../theme.js";
+import { type UiColor, theme } from "../theme.js";
 
 /**
  * Scope indicator for list items.
@@ -49,10 +49,12 @@ export function ScopeIndicator({ user, project, local }: ScopeIndicatorProps) {
 		<text fg={theme.colors.text}>
 			{segments.map((s, i) =>
 				s.bg ? (
+					// biome-ignore lint/suspicious/noArrayIndexKey: segments are fixed-position scope squares (user/project/local); the slot is the identity and the list never reorders
 					<span key={i} bg={s.bg} fg={s.fg}>
 						{s.char}
 					</span>
 				) : (
+					// biome-ignore lint/suspicious/noArrayIndexKey: same fixed-slot list as above
 					<span key={i}> </span>
 				),
 			)}

package/src/ui/components/ScrollableList.tsx

@@ -1,4 +1,5 @@
-import React, { useState, useEffect, useMemo } from "react";
+import type React from "react";
+import { useEffect, useMemo, useState } from "react";
 import { theme } from "../theme.js";
 
 interface ScrollableListProps<T> {

package/src/ui/components/StyledText.tsx

@@ -1,4 +1,4 @@
-import React from "react";
+import type React from "react";
 import { theme } from "../theme.js";
 
 interface StyledTextProps {

package/src/ui/components/layout/FooterHints.tsx

@@ -30,20 +30,22 @@ export function FooterHints({
 }: { hints: FooterHint[] }): React.ReactNode {
 	const nodes: React.ReactNode[] = [];
 	hints.forEach((hint, i) => {
+		// A hint is identified by its key chord plus label, not its position.
+		const id = `${hint.keys.join("")}:${hint.label}`;
 		if (i > 0) {
 			nodes.push(
-				<span key={`gap-${i}`} fg={LABEL_FG}>
+				<span key={`gap-${id}`} fg={LABEL_FG}>
 					{GAP}
 				</span>,
 			);
 		}
 		nodes.push(
-			<span key={`k-${i}`} bg={KEY_BG} fg={KEY_FG}>
+			<span key={`k-${id}`} bg={KEY_BG} fg={KEY_FG}>
 				{` ${hint.keys.join("")} `}
 			</span>,
 		);
 		nodes.push(
-			<span key={`l-${i}`} fg={LABEL_FG}>
+			<span key={`l-${id}`} fg={LABEL_FG}>
 				{` ${hint.label}`}
 			</span>,
 		);

package/src/ui/components/layout/Panel.tsx

@@ -1,5 +1,5 @@
-import React from "react";
-import { theme, type UiColor } from "../../theme.js";
+import type React from "react";
+import { type UiColor, theme } from "../../theme.js";
 
 interface PanelProps {
 	/** Panel title */

package/src/ui/components/layout/ScreenLayout.tsx

@@ -1,12 +1,13 @@
-import React, { useEffect, useRef } from "react";
 import type { ScrollBoxRenderable } from "@opentui/core";
-import { useDimensions } from "../../state/DimensionsContext.js";
+import type React from "react";
+import { useEffect, useRef } from "react";
 import { useKeyboard } from "../../hooks/useKeyboard.js";
 import { useApp } from "../../state/AppContext.js";
-import { TabBar } from "../TabBar.js";
+import { useDimensions } from "../../state/DimensionsContext.js";
 import type { Screen } from "../../state/types.js";
-import { FooterHints, type FooterHint } from "./FooterHints.js";
 import { theme } from "../../theme.js";
+import { TabBar } from "../TabBar.js";
+import { type FooterHint, FooterHints } from "./FooterHints.js";
 
 interface ScreenLayoutProps {
 	/** Screen title (e.g., "claudeup Plugins") */

package/src/ui/components/modals/InputModal.tsx

@@ -1,3 +1,4 @@
+import type { SubmitEvent } from "@opentui/core";
 import React from "react";
 import { theme } from "../../theme.js";
 
@@ -53,7 +54,12 @@ export function InputModal({
 			>
 				<input
 					value={defaultValue}
-					onSubmit={onSubmit as any}
+					onSubmit={(value: string | SubmitEvent) => {
+						// @opentui/react types the prop as an intersection of the core
+						// `(event: SubmitEvent) => void` and its own `(value: string) => void`;
+						// at runtime the input hands over the string.
+						if (typeof value === "string") onSubmit(value);
+					}}
 					focused
 					width={50}
 				/>

package/src/ui/components/modals/ModalContainer.tsx

@@ -1,11 +1,11 @@
 import React, { useState } from "react";
-import { useApp } from "../../state/AppContext.js";
 import { useKeyboard } from "../../hooks/useKeyboard.js";
+import { useApp } from "../../state/AppContext.js";
 import { ConfirmModal } from "./ConfirmModal.js";
 import { InputModal } from "./InputModal.js";
-import { SelectModal } from "./SelectModal.js";
-import { MessageModal } from "./MessageModal.js";
 import { LoadingModal } from "./LoadingModal.js";
+import { MessageModal } from "./MessageModal.js";
+import { SelectModal } from "./SelectModal.js";
 import { VersionMismatchModal } from "./VersionMismatchModal.js";
 
 /**

package/src/ui/components/modals/SelectModal.tsx

@@ -1,6 +1,6 @@
 import React from "react";
-import type { SelectOption } from "../../state/types.js";
 import { useDimensions } from "../../state/DimensionsContext.js";
+import type { SelectOption } from "../../state/types.js";
 import { theme } from "../../theme.js";
 
 interface SelectModalProps {

package/src/ui/components/primitives/DetailSection.tsx

@@ -1,4 +1,4 @@
-import React from "react";
+import type React from "react";
 import { theme } from "../../theme.js";
 
 interface DetailSectionProps {

package/src/ui/components/primitives/KeyValueLine.tsx

@@ -1,4 +1,4 @@
-import React from "react";
+import type React from "react";
 import { theme } from "../../theme.js";
 
 interface KeyValueLineProps {

package/src/ui/components/primitives/ScopeSquares.tsx

@@ -23,8 +23,8 @@ const SEGMENT = "■";
  * grey as de-emphasised body text. Against a light page that reads as a *dark*
  * block, giving an unlit segment the same visual weight as a lit one — "non
  * installed state is dark as well - confusing". The unlit fill now comes from
- * `scopeOffFill()`, which steps toward whichever page the terminal actually has;
- * see theme-mode.ts for why that one value cannot be fixed.
+ * `scopeOffFill()`, which steps toward the page the resolved mode names; see
+ * theme-mode.ts for why that one value cannot be fixed.
  */
 export function ScopeSquares({
 	user,

package/src/ui/hooks/index.ts

@@ -1,4 +1,3 @@
-export { useAsyncData, useDebouncedAsyncData } from "./useAsyncData.js";
 export { useKeyboardHandler } from "./useKeyboardHandler.js";
 export { useKeyboard } from "./useKeyboard.js";
 export { useMismatchModal } from "./useMismatchModal.js";

package/src/ui/hooks/useGitignoreModal.ts

@@ -40,11 +40,7 @@ export function buildGitignoreModal(args: BuildModalArgs): ModalState {
 	return {
 		type: "select",
 		title: "Gitignore violations detected",
-		message:
-			`Found ${violationCount} managed gitignore item(s) that do not match ` +
-			`the current repo state.\n\n` +
-			`Missing .gitignore entries can be added now. Items that change git ` +
-			`tracking are reviewed and fixed from the Gitignore tab.`,
+		message: `Found ${violationCount} managed gitignore item(s) that do not match the current repo state.\n\nMissing .gitignore entries can be added now. Items that change git tracking are reviewed and fixed from the Gitignore tab.`,
 		options,
 		onSelect: (value: string) => {
 			if (value === "fix-safe") onFixSafe();